[ovs-dev] null deref in build_ipam?

2017-05-26 Thread Ben Pfaff
Coverity points out the following code in build_ipam() in ovn-northd.c: if (is_dynamic_lsp_address(nbsp->addresses[j]) && !nbsp->dynamic_addresses) { if (!ipam_allocate_addresses(od, op, nbsp->addresses[j]) || !extract

Re: [ovs-dev] null deref in build_ipam?

2017-05-30 Thread Guru Shetty
On 26 May 2017 at 22:46, Ben Pfaff wrote: > Coverity points out the following code in build_ipam() in ovn-northd.c: > > if (is_dynamic_lsp_address(nbsp->addresses[j]) > && !nbsp->dynamic_addresses) { > if (!ipam_allocate_addresses(od, op, >

Re: [ovs-dev] null deref in build_ipam?

2017-05-30 Thread Ben Pfaff
On Tue, May 30, 2017 at 09:59:25AM -0700, Guru Shetty wrote: > On 26 May 2017 at 22:46, Ben Pfaff wrote: > > > Coverity points out the following code in build_ipam() in ovn-northd.c: > > > > if (is_dynamic_lsp_address(nbsp->addresses[j]) > > && !nbsp->dynamic_a