Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Ilya Maximets
On 6/12/23 22:58, Robin Jarry wrote: > Ilya Maximets, Jun 12, 2023 at 21:53: >> The build-aux/initial-tab-allowed-files seems to list most of the >> non-conventionally styled files. > > I'll have a look there. Thanks. > >> Some files with different styles are in the same subtree, so describing >>

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Robin Jarry
Ilya Maximets, Jun 12, 2023 at 21:53: > The build-aux/initial-tab-allowed-files seems to list most of the > non-conventionally styled files. I'll have a look there. Thanks. > Some files with different styles are in the same subtree, so describing > at the root sounds better. Ack. > Well, AFAIU,

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Ilya Maximets
On 6/12/23 20:29, Robin Jarry wrote: > Hi Ilya, > > Ilya Maximets, Jun 12, 2023 at 17:47: >> I'm a bit concerned that this patch is applying the same config >> to all the .c|.h files in the repo while not all of them have >> the same coding style. The most obvious is that linux headers >> are usi

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Robin Jarry
Hi Ilya, Ilya Maximets, Jun 12, 2023 at 17:47: > I'm a bit concerned that this patch is applying the same config > to all the .c|.h files in the repo while not all of them have > the same coding style. The most obvious is that linux headers > are using tabs, not spaces. Not so obvious - sFlow im

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Ilya Maximets
On 6/12/23 17:15, Eelco Chaudron wrote: > > > On 12 Jun 2023, at 17:07, Mike Pattrick wrote: > >> On Mon, Jun 12, 2023 at 10:54 AM Eelco Chaudron wrote: >>> >>> >>> >>> On 12 Jun 2023, at 15:11, Mike Pattrick wrote: >>> On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: > > Edito

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Eelco Chaudron
On 12 Jun 2023, at 17:07, Mike Pattrick wrote: > On Mon, Jun 12, 2023 at 10:54 AM Eelco Chaudron wrote: >> >> >> >> On 12 Jun 2023, at 15:11, Mike Pattrick wrote: >> >>> On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: EditorConfig is a file format and collection of text editor pl

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Mike Pattrick
On Mon, Jun 12, 2023 at 10:54 AM Eelco Chaudron wrote: > > > > On 12 Jun 2023, at 15:11, Mike Pattrick wrote: > > > On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: > >> > >> EditorConfig is a file format and collection of text editor plugins for > >> maintaining consistent coding styles betwe

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Robin Jarry
Hi Mike, Eelco, Eelco Chaudron, Jun 12, 2023 at 16:54: > I also like the idea, but the editoconfig does not seem to bring much > to the table for C. And it looks like there is not much activity on > the project. It might be better to look at clang-format, however, this > is c/c++ specific. > > Jus

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Eelco Chaudron
On 12 Jun 2023, at 15:11, Mike Pattrick wrote: > On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: >> >> EditorConfig is a file format and collection of text editor plugins for >> maintaining consistent coding styles between different editors and IDEs. >> >> Initialize the file following the

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Mike Pattrick
On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: > > EditorConfig is a file format and collection of text editor plugins for > maintaining consistent coding styles between different editors and IDEs. > > Initialize the file following the coding rules in > Documentation/internals/contributing/co