Re: [ovs-dev] [PATCH v15 0/7] Add offload support for sFlow

2021-09-21 Thread Chris Mi via dev
Hi Eelco, That's ok. Please review it according to your plan.  Thanks, Chris On 9/21/2021 4:12 PM, Eelco Chaudron wrote: Hi Chris, Just a quick update, I did see your responses to v14 and I also noticed you send out a v15. I planned to review it this week, but due to some other unforeseen

Re: [ovs-dev] [PATCH ovn] northd: Fix multicast relay when DGP are configured.

2021-09-21 Thread Numan Siddique
On Tue, Sep 21, 2021 at 1:50 PM Han Zhou wrote: > > On Tue, Sep 21, 2021 at 6:50 AM Dumitru Ceara wrote: > > > > IP multicast relay didn't work properly if traffic had to be forwarded > > across a distributed gateway port in the router pipeline. That is > > because the multicast_group used as

Re: [ovs-dev] [PATCH ovn v2] northd: Update the probe interval in main loop.

2021-09-21 Thread Han Zhou
On Tue, Sep 21, 2021 at 11:08 AM Zhen Wang wrote: > > From: zhen wang > > When ovn-northd work in HA mode, ovn-northd will not update the > probe interval in standby mode. If SB/NB raft leader and active > ovn-northd instance got killed by system power outage, standby > ovn-northd instance would

[ovs-dev] [PATCH ovn] Enforce datapath and port key constraints in vxlan mode

2021-09-21 Thread Ihar Hrachyshka
With vxlan enabled for in-cluster communication, the ranges available for port and datapath keys are limited to 12 bits (including multigroup keys). (The default range is 16 bit long.) This means that OVN should avoid allocating, or allowing to request, tunnel keys for datapaths and ports that

[ovs-dev] [PATCH ovn] Fix basic multicast flows for vxlan (non-vtep) tunnels

2021-09-21 Thread Ihar Hrachyshka
The 15-bit port key range used for multicast groups can't be covered by 12-bit key space available for port keys in VXLAN. To make multicast keys work, we have to transform 16-bit multicast port keys to 12-bit keys before fanning out packets through VXLAN tunnels. Otherwise significant bits are

Re: [ovs-dev] [PATCH 2/2] openvswitch: Fix condition check in output_userspace() by using nla_ok()

2021-09-21 Thread Pravin Shelar
On Fri, Sep 17, 2021 at 1:25 AM Jiasheng Jiang wrote: > > Just using 'rem > 0' might be unsafe, so it's better > to use the nla_ok() instead. > Because we can see from the nla_next() that > '*remaining' might be smaller than 'totlen'. And nla_ok() > will avoid it happening. > For example,

Re: [ovs-dev] [PATCH ovn] ovn-controller: Allow specifying tos option for tunnel interface

2021-09-21 Thread Han Zhou
On Tue, Sep 21, 2021 at 9:24 AM wrote: > > From: Venugopal Iyer > > Currently, OVN tunnel interface supports the csum option along > with remote_ip and key. There are applications (e.g. RoCE) that rely > on setting the DSCP bits and expect it to be moved to the outer/ > tunnel header as well. >

[ovs-dev] [PATCH ovn v2] northd: Update the probe interval in main loop.

2021-09-21 Thread Zhen Wang via dev
From: zhen wang When ovn-northd work in HA mode, ovn-northd will not update the probe interval in standby mode. If SB/NB raft leader and active ovn-northd instance got killed by system power outage, standby ovn-northd instance would never detect the failure. This patch address the problem by

Re: [ovs-dev] [PATCH ovn] northd: Fix multicast relay when DGP are configured.

2021-09-21 Thread Han Zhou
On Tue, Sep 21, 2021 at 6:50 AM Dumitru Ceara wrote: > > IP multicast relay didn't work properly if traffic had to be forwarded > across a distributed gateway port in the router pipeline. That is > because the multicast_group used as output logical port is expanded in > the egress pipeline, way

Re: [ovs-dev] [PATCH net-next v5] net: openvswitch: IPv6: Add IPv6 extension header support

2021-09-21 Thread Jakub Kicinski
On Mon, 20 Sep 2021 11:20:38 -0700 Toms Atteka wrote: > This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and > packets can be filtered using ipv6_ext flag. > > Signed-off-by: Toms Atteka Please make sure to check the files you touch with ./scripts/kernel-doc -none You're adding

Re: [ovs-dev] [PATCH ovn branch-21.06] northd: support HW VTEP with stateful datapath

2021-09-21 Thread Numan Siddique
On Sat, Sep 18, 2021 at 8:51 AM Vladislav Odintsov wrote: > > A packet going from HW VTEP device to VIF port when arrives to > hypervisor chassis should go through LS ingress pipeline to l2_lkp > stage without any match. In l2_lkp stage an output port is > determined and then packet passed to LS

[ovs-dev] [PATCH ovn] ovn-controller: Allow specifying tos option for tunnel interface

2021-09-21 Thread venugopali--- via dev
From: Venugopal Iyer Currently, OVN tunnel interface supports the csum option along with remote_ip and key. There are applications (e.g. RoCE) that rely on setting the DSCP bits and expect it to be moved to the outer/ tunnel header as well. This commit adds an "ovn-encap-tos" external-id that

[ovs-dev] [PATCH v2 ovn 2/2] controller: add memory accounting for if_status_mgr module

2021-09-21 Thread Lorenzo Bianconi
Introduce memory accounting for data structures in ovn-controller if_status_mgr module. Signed-off-by: Lorenzo Bianconi --- controller/if-status.c | 33 + controller/if-status.h | 3 +++ controller/ovn-controller.c | 1 + 3 files changed, 37

[ovs-dev] [PATCH v2 ovn 1/2] controller: do not allocate iface name twice in if_status_mgr module

2021-09-21 Thread Lorenzo Bianconi
Rely on shash_add_nocopy instead of shash_add in ovs_iface_create in order to avoid allocating iface_id twice. Signed-off-by: Lorenzo Bianconi --- controller/if-status.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/controller/if-status.c b/controller/if-status.c

[ovs-dev] [PATCH v2 ovn 0/2] add memory accounting for if_status_mgr module

2021-09-21 Thread Lorenzo Bianconi
Changes since v1: - add ovs_iface_account_mem utility routine - rely on shash_add_nocopy in ovs_iface_create Lorenzo Bianconi (2): controller: do not allocate iface name twice in if_status_mgr module controller: add memory accounting for if_status_mgr module controller/if-status.c | 40

Re: [ovs-dev] [PATCH v2] ovsdb-server: Log database transactions for user requested tables.

2021-09-21 Thread Michael Santana
On 9/16/21 11:37 AM, Dumitru Ceara wrote: Add a new command, 'ovsdb-server/log-db-ops DB TABLE on|off', which allows the user to enable/disable transaction logging for specific databases and tables. By default, logging is disabled. Once enabled, logs are generated with level INFO and are

[ovs-dev] [OVN Patch v4 1/2] Make changes to the parallel processing API to allow pool sizing

2021-09-21 Thread anton . ivanov
From: Anton Ivanov 1. Make pool size user defineable. 2. Expose pool destruction. 3. Make pools resizeable at runtime. 4. Split pool start and completion to allow background execution. 5. Add a simplified API for SAFE walking single hash. Signed-off-by: Anton Ivanov ---

[ovs-dev] [OVN Patch v4 2/2] Add support for configuring parallelization via unixctl

2021-09-21 Thread anton . ivanov
From: Anton Ivanov libs: add configuration support to parallel-hmap.[c,h] northd: add support for configuring parallelization to northd Signed-off-by: Anton Ivanov --- lib/ovn-parallel-hmap.c | 185 ++-- lib/ovn-parallel-hmap.h | 63 +-

Re: [ovs-dev] [PATCH ovn] ovn-northd: Virtual port add ND/ARP responder flows for IPv6 VIPs.

2021-09-21 Thread Dumitru Ceara
On 9/20/21 3:20 PM, mh...@redhat.com wrote: > From: Mohammad Heib > > currently ovn-northd only handle virtual ports with VIP IPv4 and ignores > virtual ports with VIP IPv6. > > This patch adds support for virtual ports with VIP IPv6 by adding > lflows to the lsp_in_arp_rsp logical switch

Re: [ovs-dev] [PATCH] dpdk: Use DPDK 20.11.3 release

2021-09-21 Thread Kalahasthi, Suneetha
Hi Kevin, Thanks for the details. I will make the setup, test and update the results. Regards, Suneetha -Original Message- From: Kevin Traynor Sent: 21 September 2021 17:52 To: Kalahasthi, Suneetha ; d...@openvswitch.org Cc: David Marchand Subject: Re: [ovs-dev] [PATCH] dpdk: Use

[ovs-dev] [PATCH ovn] northd: Fix multicast relay when DGP are configured.

2021-09-21 Thread Dumitru Ceara
IP multicast relay didn't work properly if traffic had to be forwarded across a distributed gateway port in the router pipeline. That is because the multicast_group used as output logical port is expanded in the egress pipeline, way after 'lr_in_gw_redirect' where unicast traffic would normally

Re: [ovs-dev] Unit Test Failure Report to OVS ML

2021-09-21 Thread Ilya Maximets
On 9/21/21 14:51, Amber, Kumar wrote: > Hi Ilya, > > The Test-case failure is not related to AVX512 or any patches we are directly > failing on "master" latest of OVS with no patches on top of it. > I am still trying to figure out or root cause the issue, we tested the master > on 4 different

[ovs-dev] [PATCH] ovs-ctl: add log level option to utilities/ovs-ctl.in

2021-09-21 Thread remijouannet
From: Remi Jouannet Add three new options to configure log level at runtime with ovs-ctl --vconsole, --vsyslog-level and --vfile-level Signed-off-by: Remi Jouannet --- utilities/ovs-ctl.in | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] Unit Test Failure Report to OVS ML

2021-09-21 Thread Amber, Kumar
Hi Ilya, The Test-case failure is not related to AVX512 or any patches we are directly failing on "master" latest of OVS with no patches on top of it. I am still trying to figure out or root cause the issue, we tested the master on 4 different servers, and all fails on the same test-case.

Re: [ovs-dev] [PATCH v3 0/6] MFEX Optimizations IPv6 + Hashing

2021-09-21 Thread Ilya Maximets
On 9/21/21 12:23, Kumar Amber wrote: > --- > v3: > - rebase to master. > v2: > - fix the CI build. > - fix check-patch for co-author. > --- > > The patch-set introduces AVX512 optimizations of IPv6 > traffic profiles and hashing improvements for all AVX512 > supported traffic profiles for IPv4

Re: [ovs-dev] [PATCH] dpdk: Use DPDK 20.11.3 release

2021-09-21 Thread Kevin Traynor
On 21/09/2021 13:16, Kalahasthi, Suneetha wrote: HI Kevin, The setup is: 1. Add one virtio_user port to OVS with 3 queues ovs-vsctl add-port br0 virtio_user0 -- set Interface virtio_user0 type=dpdk options:dpdk-devargs=net_virtio_user0,iface=tap0,path=/dev/vhost-net,queues=3 Just need to add

Re: [ovs-dev] [PATCH] dpdk: Use DPDK 20.11.3 release

2021-09-21 Thread Kalahasthi, Suneetha
HI Kevin, The setup is: 1. Add one virtio_user port to OVS with 3 queues ovs-vsctl add-port br0 virtio_user0 -- set Interface virtio_user0 type=dpdk options:dpdk-devargs=net_virtio_user0,iface=tap0,path=/dev/vhost-net,queues=3 2. Inject traffic 3. traffic should eb received at virtio_user port ?

Re: [ovs-dev] [PATCH] dpdk: Use DPDK 20.11.3 release

2021-09-21 Thread Kevin Traynor
On 21/09/2021 11:42, Kevin Traynor wrote: On 21/09/2021 08:08, Suneetha Kalahasthi wrote: Modify ci linux build script to use the latest DPDK stable release 20.11.3. Modify Documentation to use the latest DPDK stable release 20.11.3. Update NEWS file to reflect the latest DPDK stable release

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-21 Thread Dumitru Ceara
On 9/21/21 1:33 PM, Vladislav Odintsov wrote: > Hi Dumitru, Hi Vladislav, > > are you talking about any specific _mising_ patch? No, sorry for the confusion. I just meant there's a bug in the OOT module that was probably already fixed in the in-tree one so, likely, one would have to figure

Re: [ovs-dev] [PATCH net-next] openvswitch: allow linking a VRF to an OVS bridge

2021-09-21 Thread Antoine Tenart
Hello, Quoting Luis Tomas Bolivar (2021-09-21 13:20:08) > > Follow up on this. I found the mistake I was making on the veth-pair > addition configuration (ovs flow was setting the wrong mac address > before sending the traffic through the veth device to the vrf). And it > indeed works connecting

[ovs-dev] [PATCH] ovs-ctl: add log level option to utilities/ovs-ctl.in

2021-09-21 Thread remijouannet
From: Remi Jouannet Add three new options to configure log level at runtime with ovs-ctl --vconsole, --vsyslog-level and --vfile-level Signed-off-by: Remi Jouannet --- utilities/ovs-ctl.in | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH net-next] openvswitch: allow linking a VRF to an OVS bridge

2021-09-21 Thread Antoine Tenart
VRF devices are prevented from being added to upper devices since commit 1017e0987117 ("vrf: prevent adding upper devices") as they set the IFF_NO_RX_HANDLER flag. However attaching a VRF to an OVS bridge is a valid use case[1]. Allow a VRF device to be attached to an OVS bridge by having an OVS

Re: [ovs-dev] [PATCH] ovs: Only clear tstamp when changing namespaces

2021-09-21 Thread Tyler Stachecki
On Sun, Sep 19, 2021 at 7:33 PM Cong Wang wrote: > > On Sun, Sep 19, 2021 at 10:59 AM Tyler J. Stachecki > wrote: > > > > As of "ovs: clear skb->tstamp in forwarding path", the > > tstamp is now being cleared unconditionally to fix fq qdisc > > operation with ovs vports. > > > > While this is

Re: [ovs-dev] [PATCH] ovs: Only clear tstamp when changing namespaces

2021-09-21 Thread Cong Wang
On Sun, Sep 19, 2021 at 10:44 PM Tyler Stachecki wrote: > Sorry if this is a no-op -- I'm admittedly not familiar with this part > of the tree. I had added this check based on this discussion on the > OVS mailing list: >

Re: [ovs-dev] [PATCH net-next] openvswitch: allow linking a VRF to an OVS bridge

2021-09-21 Thread David Ahern
On 9/20/21 9:34 AM, Antoine Tenart wrote: > There might be questions about the setup in which a VRF is linked to an > OVS bridge; I cc'ed Luis Tomás who wrote the article. My head just exploded. You want to make an L3 device a port of an L2 device. Can someone explain how this is supposed to

Re: [ovs-dev] [PATCH] ovs: Only clear tstamp when changing namespaces

2021-09-21 Thread Cong Wang
On Sun, Sep 19, 2021 at 10:59 AM Tyler J. Stachecki wrote: > > As of "ovs: clear skb->tstamp in forwarding path", the > tstamp is now being cleared unconditionally to fix fq qdisc > operation with ovs vports. > > While this is mostly correct and fixes forwarding for that > use case, a slight

[ovs-dev] [PATCH] ovs: Only clear tstamp when changing namespaces

2021-09-21 Thread Tyler J. Stachecki
As of "ovs: clear skb->tstamp in forwarding path", the tstamp is now being cleared unconditionally to fix fq qdisc operation with ovs vports. While this is mostly correct and fixes forwarding for that use case, a slight adjustment is necessary to ensure that the tstamp is cleared *only when the

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-21 Thread Vladislav Odintsov
Hi Dumitru, are you talking about any specific _mising_ patch? Regards, Vladislav Odintsov > On 16 Sep 2021, at 19:09, Dumitru Ceara wrote: > > On 9/16/21 4:18 PM, Vladislav Odintsov wrote: >> Sorry, by OOT I meant non-inbox kmod. >> I’ve tried to use inbox kernel module (from kernel package)

Re: [ovs-dev] [PATCH net-next] openvswitch: allow linking a VRF to an OVS bridge

2021-09-21 Thread Luis Tomas Bolivar
On Tue, Sep 21, 2021 at 10:12 AM Luis Tomas Bolivar wrote: > > On Mon, Sep 20, 2021 at 5:45 PM David Ahern wrote: > > > > On 9/20/21 9:34 AM, Antoine Tenart wrote: > > > There might be questions about the setup in which a VRF is linked to an > > > OVS bridge; I cc'ed Luis Tomás who wrote the

Re: [ovs-dev] [PATCH] dpdk: Use DPDK 20.11.3 release

2021-09-21 Thread Kevin Traynor
On 21/09/2021 08:08, Suneetha Kalahasthi wrote: Modify ci linux build script to use the latest DPDK stable release 20.11.3. Modify Documentation to use the latest DPDK stable release 20.11.3. Update NEWS file to reflect the latest DPDK stable release 20.11.3. FAQ is updated to reflect the latest

[ovs-dev] [PATCH v3 6/6] dpif-netdev/mfex: Avoid hashing when opt mfex called

2021-09-21 Thread Kumar Amber
This patch avoids calculating the software hash of the packet again if the optimized miniflow-extract hit and has already calculated the packet hash. In cases of scalar miniflow extract, the normal hashing calculation is performed. Signed-off-by: Kumar Amber --- lib/dpif-netdev-avx512.c | 6

[ovs-dev] [PATCH v3 5/6] dpif-netdev/mfex: Add ipv6 profile based hashing

2021-09-21 Thread Kumar Amber
This commit adds IPv6 profile specific hashing which uses fixed offsets into the packet to improve hashing perforamnce. Hash value is autovalidated by MFEX autovalidator. Signed-off-by: Kumar Amber Signed-off-by: Harry van Haaren Co-authored-by: Harry van Haaren --- v2: - Fix check-patch

[ovs-dev] [PATCH v3 4/6] dpif-netdev/mfex: Add ipv4 profile based hashing

2021-09-21 Thread Kumar Amber
This commit adds IPv4 profile specific hashing which uses fixed offsets into the packet to improve hashing perforamnce. Signed-off-by: Kumar Amber Signed-off-by: Harry van Haaren Co-authored-by: Harry van Haaren --- v3: - Fix check-patch sign-offs --- NEWS | 1 +

[ovs-dev] [PATCH v3 3/6] dpif-netdev/mfex: Add packet hash check to autovalidator

2021-09-21 Thread Kumar Amber
This patch adds the per profile AVX512 opt hashing to autovalidator for validating the hash values against the scalar hash. Signed-off-by: Kumar Amber --- lib/dpif-netdev-private-extract.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/dpif-netdev-private-extract.c

[ovs-dev] [PATCH v3 2/6] dpif-netdev/mfex: Add AVX512 vlan ipv6 traffic profiles

2021-09-21 Thread Kumar Amber
Add AVX512 Ipv6 optimized profile for vlan/IPv6/UDP and vlan/IPv6/TCP. MFEX autovalidaton test-case already has the IPv6 support for validating against the scalar mfex. Signed-off-by: Kumar Amber Signed-off-by: Harry van Haaren Co-authored-by: Harry van Haaren --- v2: - Fix check-patch

[ovs-dev] [PATCH v3 1/6] dpif-netdev/mfex: Add AVX512 basic ipv6 traffic profiles

2021-09-21 Thread Kumar Amber
Add AVX512 IPv6 optimized profile for IPv6/UDP and IPv6/TCP. MFEX autovalidaton test-case already has the IPv6 support for validating against the scalar mfex. Signed-off-by: Kumar Amber Signed-off-by: Harry van Haaren Co-authored-by: Harry van Haaren --- v2: - Fix CI build error - Fix

[ovs-dev] [PATCH v3 0/6] MFEX Optimizations IPv6 + Hashing

2021-09-21 Thread Kumar Amber
--- v3: - rebase to master. v2: - fix the CI build. - fix check-patch for co-author. --- The patch-set introduces AVX512 optimizations of IPv6 traffic profiles and hashing improvements for all AVX512 supported traffic profiles for IPv4 and IPv6. Kumar Amber (6): dpif-netdev/mfex: Add AVX512

Re: [ovs-dev] [PATCH v2 1/2] ovsdb-data: Optimize union of sets.

2021-09-21 Thread Mark Gray
On 17/09/2021 18:17, Ilya Maximets wrote: > Current algorithm of ovsdb_datum_union looks like this: > > for-each atom in b: > if not bin_search(a, atom): > push(a, clone(atom)) > quicksort(a) > > So, the complexity looks like this: > >Nb * log2(Na) +Nb + (Na

Re: [ovs-dev] [PATCH v2 2/2] ovsdb-data: Optimize subtraction of sets.

2021-09-21 Thread Mark Gray
On 17/09/2021 18:17, Ilya Maximets wrote: > Current algorithm for ovsdb_datum_subtract looks like this: > > for-each atom in a: > if atom in b: > swap(atom, ) > destroy(atom) > quicksort(a) > > Complexity: > > Na * log2(Nb) + (Na - Nb) * log2(Na - Nb) >

Re: [ovs-dev] [PATCH v1] configure: Allow opt-in to CPU ISA opts at compile time

2021-09-21 Thread Eelco Chaudron
On 13 Sep 2021, at 16:36, Van Haaren, Harry wrote: >> -Original Message- >> From: Eelco Chaudron >> Sent: Friday, September 10, 2021 3:41 PM >> To: Van Haaren, Harry ; i.maxim...@ovn.org; >> Stokes, Ian ; f...@sysclose.org >> Cc: Amber, Kumar ; ovs-dev@openvswitch.org; >>

Re: [ovs-dev] [PATCH v15 0/7] Add offload support for sFlow

2021-09-21 Thread Eelco Chaudron
Hi Chris, Just a quick update, I did see your responses to v14 and I also noticed you send out a v15. I planned to review it this week, but due to some other unforeseen stuff, I have to move it to next week (if nothing more is going to mess up my plan ;) Cheers, Eelco On 15 Sep 2021, at

Re: [ovs-dev] [PATCH net-next] openvswitch: allow linking a VRF to an OVS bridge

2021-09-21 Thread Luis Tomas Bolivar
On Mon, Sep 20, 2021 at 5:45 PM David Ahern wrote: > On 9/20/21 9:34 AM, Antoine Tenart wrote: > > There might be questions about the setup in which a VRF is linked to an > > OVS bridge; I cc'ed Luis Tomás who wrote the article. > > My head just exploded. You want to make an L3 device a port of

Re: [ovs-dev] [PATCH ovn v4 9/9] plug_providers: Introduce representor plugin.

2021-09-21 Thread Han Zhou
On Fri, Sep 3, 2021 at 12:27 PM Frode Nordahl wrote: > > Add the first in-tree plug provider plugin and its dependencies. > The representor plugin can be used with multiple NIC vendors > supporting Open vSwitch hardware offload and the devlink-port > infrastructure[0]. > > It is particularly

[ovs-dev] [PATCH] dpdk: Use DPDK 20.11.3 release

2021-09-21 Thread Suneetha Kalahasthi
Modify ci linux build script to use the latest DPDK stable release 20.11.3. Modify Documentation to use the latest DPDK stable release 20.11.3. Update NEWS file to reflect the latest DPDK stable release 20.11.3. FAQ is updated to reflect the latest DPDK for each OVS branch. Signed-off-by:

[ovs-dev] [PATCH branch-2.16] dpdk: Use DPDK 20.11.3 release

2021-09-21 Thread Suneetha Kalahasthi
Modify ci linux build script to use the latest DPDK stable release 20.11.3. Modify Documentation to use the latest DPDK stable release 20.11.3. Update NEWS file to reflect the latest DPDK stable release 20.11.3. FAQ is updated to reflect the latest DPDK for each OVS branch. Signed-off-by: