Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix ukey installation failure logs and counters.

On 4/5/24 15:46, Eelco Chaudron wrote: > > > On 5 Apr 2024, at 15:04, Ilya Maximets wrote: > >> On 4/5/24 14:33, Eelco Chaudron wrote: >>> >>> >>> On 4 Apr 2024, at 14:09, Ilya Maximets wrote: >>> ukey_install() returns boolean signaling if the ukey was installed or not. Installation

Re: [ovs-dev] [PATCH] Use listen backlog = 64 for all connections.

On 4/5/24 11:15, Eelco Chaudron wrote: > > > On 4 Apr 2024, at 21:17, Ihar Hrachyshka wrote: > >> On Thu, Apr 4, 2024 at 2:36 AM Eelco Chaudron wrote: >> >>> >>> >>> On 3 Apr 2024, at 23:18, Ihar Hrachyshka wrote: >>> Before the patch, the size of the backlog depended on the type of

[ovs-dev] [PATCH] vlog: Log stack trace on vlog_abort.

Currently, calls like ovs_assert() just print out a condition that caused assertion to fail. But it may be not enough to understand what exactly has happened, especially if assertion failed in some generic function like dp_packet_resize() or similar. Print the stack trace along with the abort

Re: [ovs-dev] [PATCH v14 0/6] dpif: probe support for OVS_ACTION_ATTR_DROP

On 4/3/24 16:35, Eric Garver wrote: > v14: > - remove atomic_init() > - add bogus dl_type to feature probe > - ovs_assert() that check_drop_action() returns false when expected > - add and use missing enum ovs_dec_ttl_attr > v13: > - use macros strip_ptype and strip_eth in test > v12: >

Re: [ovs-dev] [PATCH v7 2/2] netlink-conntrack: Optimize flushing ct zone.

On 4/4/24 15:27, Aaron Conole wrote: > Felix Huettner via dev writes: > >> Previously the kernel did not provide a netlink interface to flush/list >> only conntrack entries matching a specific zone. With [1] and [2] it is now >> possible to flush and list conntrack entries filtered by zone.

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Use paused controller action for packet buffering.

On Tue, Apr 2, 2024 at 2:28 AM Ales Musil wrote: > The current packet injection loses ct_state in the process. When > the ct_state is lost we might commit to DNAT zone and perform > zero SNAT after the packet injection. This causes the first session > to be wrong as the reply packets are not

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Use the current user for default file permissions.

On Thu, Apr 4, 2024 at 4:01 PM Mark Michelson wrote: > Thanks Ales, > > Acked-by: Mark Michelson > Thanks. I applied this patch to the main branch. Does this require a backport ? Numan > On 3/25/24 06:40, Ales Musil wrote: > > The ovn-ctl utility was assuming that the user/group is always

[ovs-dev] [PATCH ovn v4] Make tunnel ids exhaustion test trigger the problem.

The original version of the scenario passed with or without the fix. This is because all LSs were processed in one go, so the allocate function was never entered with *hint==0. Also, added another scenario that will check behavior when *hint is out of [min;max] bounds but > max (this happens in

Re: [ovs-dev] [PATCH ovn v3] Make tunnel ids exhaustion test trigger the problem.

Sorry for forgetting to include changelogs in these submissions. v1: initial version. v2: cover both cases of hint = 0 and hint > max. v3: reduce the number of ports to create in the hint > max scenario needed to trigger the problem. On Fri, Apr 5, 2024 at 12:10 PM Ihar Hrachyshka wrote: > The

[ovs-dev] [PATCH ovn v3] Make tunnel ids exhaustion test trigger the problem.

The original version of the scenario passed with or without the fix. This is because all LSs were processed in one go, so the allocate function was never entered with *hint==0. Also, added another scenario that will check behavior when *hint is out of [min;max] bounds but > max (this happens in

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

On Thu, Apr 4, 2024 at 4:02 PM Vladislav Odintsov wrote: > > > > On 4 Apr 2024, at 22:51, Mark Michelson wrote: > > > > On 4/4/24 12:46, Dumitru Ceara wrote: > >> On 4/4/24 17:52, Vladislav Odintsov wrote: > >>> Thanks Dumitru! > >>> I’m totally fine with your change. > >>> Should I send

Re: [ovs-dev] [PATCH ovn] Make tunnel ids exhaustion test case trigger the problem.

On Fri, Apr 5, 2024 at 11:38 AM Vladislav Odintsov wrote: > > > On 5 Apr 2024, at 18:35, Ihar Hrachyshka wrote: > > On Thu, Apr 4, 2024 at 3:56 PM Vladislav Odintsov > wrote: > >> Thanks Ihar for the patch. >> >> It definitely triggers the bug mentioned in Fixes commit, but how do you >> like

[ovs-dev] [PATCH ovn v2] Make tunnel ids exhaustion test trigger the problem.

The original version of the scenario passed with or without the fix. This is because all LSs were processed in one go, so the allocate function was never entered with *hint==0. Also, added another scenario that will check behavior when *hint is out of [min;max] bounds but > max (this happens in

Re: [ovs-dev] [PATCH ovn v2] controller: Change dns resolution to async.

On Fri, Apr 5, 2024 at 1:38 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > Currently DNS resolution is a blocking call in OVN controller. > If DNS server is not reachable for any reason then, ovn-controller > thread blocks for longer time and other events are not processed. > >

Re: [ovs-dev] [PATCH OVN v5 0/4] DHCP Relay Agent support for overlay subnets.

On Wed, Mar 20, 2024 at 10:40 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > > This patch contains changes to enable DHCP Relay Agent support for overlay subnets. > > USE CASE: > -- > - Enable IP address assignment for overlay subnets from the centralized

Re: [ovs-dev] [PATCH ovn] Make tunnel ids exhaustion test case trigger the problem.

> On 5 Apr 2024, at 18:35, Ihar Hrachyshka wrote: > > On Thu, Apr 4, 2024 at 3:56 PM Vladislav Odintsov > wrote: >> Thanks Ihar for the patch. >> >> It definitely triggers the bug mentioned in Fixes commit, but how do you >> like next diff as an alternative? >> It

Re: [ovs-dev] [PATCH ovn] Make tunnel ids exhaustion test case trigger the problem.

On Thu, Apr 4, 2024 at 3:56 PM Vladislav Odintsov wrote: > Thanks Ihar for the patch. > > It definitely triggers the bug mentioned in Fixes commit, but how do you > like next diff as an alternative? > It seems a little easier to me, because it shows the real limit and the > situation where the

Re: [ovs-dev] [PATCH v3] Documentation: Updates for rename of primary development branch as main.

On 5 Apr 2024, at 15:57, Simon Horman wrote: > Recently OVS adopted a policy of using the inclusive naming word list v1 > [1, 2]. > > In keeping with this policy rename the primary development branch from > 'master' to 'main'. This patch does not actually make that change, but > rather updates

Re: [ovs-dev] [PATCH v3] Documentation: Updates for rename of primary development branch as main.

Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject, ': ', is over 70 characters, i.e., 72. Subject: Documentation: Updates

[ovs-dev] [PATCH v3] Documentation: Updates for rename of primary development branch as main.

Recently OVS adopted a policy of using the inclusive naming word list v1 [1, 2]. In keeping with this policy rename the primary development branch from 'master' to 'main'. This patch does not actually make that change, but rather updates references to the branch in documentation in the source

Re: [ovs-dev] [PATCH v14 4/6] dpif: Probe support for OVS_ACTION_ATTR_DROP.

On 5 Apr 2024, at 15:43, Ilya Maximets wrote: > On 4/5/24 15:08, Ilya Maximets wrote: >> On 4/5/24 15:01, Eric Garver wrote: >>> On Fri, Apr 05, 2024 at 11:39:58AM +0200, Eelco Chaudron wrote: On 3 Apr 2024, at 16:35, Eric Garver wrote: > Kernel support has been added

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix ukey installation failure logs and counters.

On 5 Apr 2024, at 15:04, Ilya Maximets wrote: > On 4/5/24 14:33, Eelco Chaudron wrote: >> >> >> On 4 Apr 2024, at 14:09, Ilya Maximets wrote: >> >>> ukey_install() returns boolean signaling if the ukey was installed >>> or not. Installation may fail for a few reasons: >>> >>> 1. Conflicting

Re: [ovs-dev] [PATCH v14 4/6] dpif: Probe support for OVS_ACTION_ATTR_DROP.

On 4/5/24 15:08, Ilya Maximets wrote: > On 4/5/24 15:01, Eric Garver wrote: >> On Fri, Apr 05, 2024 at 11:39:58AM +0200, Eelco Chaudron wrote: >>> >>> >>> On 3 Apr 2024, at 16:35, Eric Garver wrote: >>> Kernel support has been added for this action. As such, we need to probe the datapath

Re: [ovs-dev] [PATCH v14 4/6] dpif: Probe support for OVS_ACTION_ATTR_DROP.

On 4/5/24 15:01, Eric Garver wrote: > On Fri, Apr 05, 2024 at 11:39:58AM +0200, Eelco Chaudron wrote: >> >> >> On 3 Apr 2024, at 16:35, Eric Garver wrote: >> >>> Kernel support has been added for this action. As such, we need to probe >>> the datapath for support. >>> >>> Signed-off-by: Eric

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix ukey installation failure logs and counters.

On 4/5/24 14:33, Eelco Chaudron wrote: > > > On 4 Apr 2024, at 14:09, Ilya Maximets wrote: > >> ukey_install() returns boolean signaling if the ukey was installed >> or not. Installation may fail for a few reasons: >> >> 1. Conflicting ukey. >> 2. Mutex contention while trying to replace

Re: [ovs-dev] [PATCH v14 4/6] dpif: Probe support for OVS_ACTION_ATTR_DROP.

On Fri, Apr 05, 2024 at 11:39:58AM +0200, Eelco Chaudron wrote: > > > On 3 Apr 2024, at 16:35, Eric Garver wrote: > > > Kernel support has been added for this action. As such, we need to probe > > the datapath for support. > > > > Signed-off-by: Eric Garver > > --- > >

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Fallback to non tunnel offloading API.

On 4/4/24 14:46, David Marchand wrote: > On Wed, Apr 3, 2024 at 8:13 PM Ilya Maximets wrote: >>> - This patch fixes some misusage of the DPDK API. >> >> Hmm, I understand that the driver does something funny when it gets >> outer flags set without any inner flags, but how is that a misuse >> of

Re: [ovs-dev] [PATCH v2] Rename primary development branch as main.

On Fri, Apr 05, 2024 at 11:57:17AM +0200, Ilya Maximets wrote: > On 4/2/24 16:44, Simon Horman wrote: > > Recently OVS adopted a policy of using the inclusive naming word list v1 > > [1, 2]. > > > > In keeping with this policy rename the primary development branch from > > 'master' to 'main'.

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix ukey installation failure logs and counters.

On 4 Apr 2024, at 14:09, Ilya Maximets wrote: > ukey_install() returns boolean signaling if the ukey was installed > or not. Installation may fail for a few reasons: > > 1. Conflicting ukey. > 2. Mutex contention while trying to replace existing ukey. > 3. The same ukey already exists and

Re: [ovs-dev] [PATCH v5] ci: Add clang-analyze to GitHub actions.

On 1/11/24 00:08, Eelco Chaudron wrote: > This patch identifies new static analysis issues during a GitHub action > run and reports them. The process involves analyzing the changes introduced > in the current commit and comparing them to those in the preceding commit. > > However, there are two

Re: [ovs-dev] [PATCH v2] Rename primary development branch as main.

On 2 Apr 2024, at 16:44, Simon Horman wrote: > Recently OVS adopted a policy of using the inclusive naming word list v1 > [1, 2]. > > In keeping with this policy rename the primary development branch from > 'master' to 'main'. This patch does not actually make that change, > but rather updates

[ovs-dev] [PATCH ovn] utilities: Add missing bfd option in ovn-nbctl manpage.

Add missing bfd option to lr-route-add and lr-policy-add commands in ovn-nbctl manpage. Reported-at: https://issues.redhat.com/browse/FDP-550 Signed-off-by: Lorenzo Bianconi --- utilities/ovn-nbctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/utilities/ovn-nbctl.c

Re: [ovs-dev] [PATCH v2] Rename primary development branch as main.

On 4/2/24 16:44, Simon Horman wrote: > Recently OVS adopted a policy of using the inclusive naming word list v1 > [1, 2]. > > In keeping with this policy rename the primary development branch from > 'master' to 'main'. This patch does not actually make that change, > but rather updates references

Re: [ovs-dev] [PATCH ovn] tests: Add macro for checking flows after recompute.

Hi Mark Thanks for the review. On Thu, Apr 4, 2024 at 10:25 PM Mark Michelson wrote: > Hi Xavier, the patch looks good, but I have one question down below. > > On 3/26/24 07:56, Xavier Simonart wrote: > > The macro CHECK_FLOWS_AFTER_RECOMPUTE dumps the Openflows, then > > recomputes, then

Re: [ovs-dev] [PATCH v14 4/6] dpif: Probe support for OVS_ACTION_ATTR_DROP.

On 3 Apr 2024, at 16:35, Eric Garver wrote: > Kernel support has been added for this action. As such, we need to probe > the datapath for support. > > Signed-off-by: Eric Garver > --- > include/linux/openvswitch.h | 2 +- > lib/dpif.c | 6 ++- > lib/dpif.h

Re: [ovs-dev] [PATCH v14 1/6] dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.

On 3 Apr 2024, at 16:35, Eric Garver wrote: > This is prep for adding a different OVS_ACTION_ATTR_ enum value. This > action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However, > to make -Werror happy we must add a case to all existing switches. > > Signed-off-by: Eric Garver

Re: [ovs-dev] [PATCH] Use listen backlog = 64 for all connections.

On 4 Apr 2024, at 21:17, Ihar Hrachyshka wrote: > On Thu, Apr 4, 2024 at 2:36 AM Eelco Chaudron wrote: > >> >> >> On 3 Apr 2024, at 23:18, Ihar Hrachyshka wrote: >> >>> Before the patch, the size of the backlog depended on the type of socket >>> (UNIX vs INET) as well as on the language (C vs

Re: [ovs-dev] [PATCH ovn] Make tunnel ids exhaustion test case trigger the problem.

Yes, this diff is from main. To trigger an initial bug it is enough to create a new ls/lr while all available tunnel ids are used for datapaths (4095). This is because we need to enter ovn_allocate_tnlid() with *hint=0 to trigger infinite loop. That is why I suggest just to create 4095 LSs and