Clang's static analyzer will complain about a null pointer dereference
because dumps can be set to null and then there is a loop where it could
have been written to.
Instead, return early from the netdev_ports_flow_dump_create function if
dumps is NULL.
Signed-off-by: Mike Pattrick
---
lib
Previously the mirror_set() and mirror_get() functions took a large
number of parameters, which was inefficient and difficult to read and
extend. This patch moves most of the parameters into a struct.
Signed-off-by: Mike Pattrick
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off
packets are mirrored based on flow metadata. This
significantly improves overall vswitchd performance during mirroring if
only a subset of traffic is required.
Signed-off-by: Mike Pattrick
---
v8:
- Corrected code from v7 related to sequence and in_port. Mirrors
reject filters with an in_port set
ed-By: Luca Czesla
> Signed-off-by: Luca Czesla
> Co-Authored-By: Max Lamprecht
> Signed-off-by: Max Lamprecht
> Signed-off-by: Felix Huettner
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
, returning immediately. One notable change in
functionality is not performing the RBAC check in this condition, as no
mutation actually takes place.
Reported-by: Terry Wilson
Reported-at: https://issues.redhat.com/browse/FDP-359
Signed-off-by: Mike Pattrick
---
v2: Added additional non-rbac tests
On Mon, Mar 4, 2024 at 3:22 AM Felix Huettner via dev
wrote:
>
> Extract checking for a given kernel version to a separate function.
> It will be used also in the next patch.
>
> Signed-off-by: Felix Huettner
> ---
Acked-by: Mike Pattrick
_
084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/321
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
; Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
"userspace: Add Generic Segmentation Offloading.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
unexpected
> tunnel types in case something goes wrong.
>
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
://bugzilla.redhat.com/show_bug.cgi?id=1975039
Reported-by: Qijun Ding
Fixes: d6afbc00d5b3 ("ipsec: Allow custom file locations.")
Signed-off-by: Mike Pattrick
---
v2: Don't extract variables from ipsec script
v3: Removed use of packaging
---
ipsec/ovs-monitor-ipsec.in | 20 ++--
1 file c
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
v2: Changed documentation, and added a NEWS item
v3: NEWS file merge conflict
v4: Better comments, new test
---
NEWS | 4
lib/netdev-native-tnl.c | 2 +-
lib/netdev-vport.c| 17
On Tue, Mar 19, 2024 at 5:35 PM Ilya Maximets wrote:
>
> On 3/13/24 22:54, Mike Pattrick wrote:
> > In v4.0, LibreSwan changed a default paths that had been hardcoded in
> > ovs-monitor-ipsec, breaking some uses of this script. This patch adds
> > support for both old an
://bugzilla.redhat.com/show_bug.cgi?id=1975039
Reported-by: Qijun Ding
Fixes: d6afbc00d5b3 ("ipsec: Allow custom file locations.")
Signed-off-by: Mike Pattrick
---
v2: Don't extract variables from ipsec script
---
ipsec/ovs-monitor-ipsec.in | 16 ++--
1 file changed, 14 insertions(+), 2
On Wed, Mar 20, 2024 at 2:05 PM Mike Pattrick wrote:
>
> In v4.0, LibreSwan changed a default paths that had been hardcoded in
> ovs-monitor-ipsec, breaking some uses of this script. This patch adds
> support for both old and newer versions by auto detecting the version
&g
resetting the mirror context.
Fixes: feed7f677505 ("ofproto-dpif-upcall: Mirror packets that are modified.")
Reported-by: Zhangweiwei
Signed-off-by: Mike Pattrick
---
include/openvswitch/meta-flow.h | 1 +
lib/meta-flow.c | 109
ofproto/of
://bugzilla.redhat.com/show_bug.cgi?id=1975039
Reported-by: Qijun Ding
Fixes: d6afbc00d5b3 ("ipsec: Allow custom file locations.")
Signed-off-by: Mike Pattrick
---
ipsec/ovs-monitor-ipsec.in | 31 +++
1 file changed, 27 insertions(+), 4 deletions(-)
diff --g
ic test.
>
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2024-March/053014.html
> Signed-off-by: Ilya Maximets
> ---
I have tested this, and it does fix the segfault here.
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
address is different then
this would be the expected behavior, the collection of the packet as
it enters, and then as it exists modified.
Thank you,
Mike
>
> -邮件原件-
> 发件人: Mike Pattrick [mailto:m...@redhat.com]
> 发送时间: 2024年3月13日 1:37
> 收件人: d...@openvswitch.org
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
v2: Changed documentation, and added a NEWS item
v3: NEWS file merge conflict
v4: Better comments, new test
v5: Addressed identified nit's
---
NEWS | 4
lib/netdev-native-tnl.c | 2 +-
lib
On Wed, Mar 27, 2024 at 1:39 PM Simon Horman wrote:
>
> On Tue, Feb 20, 2024 at 11:08:55PM -0500, Mike Pattrick wrote:
> > When sending packets that are flagged as requiring segmentation to an
> > interface that doens't support this feature, send the packet to the TSO
>
09:36:53.862230 68:05:ca:21:d6:e5 > 52:54:00:67:d5:61, ethertype IPv4
> (0x0800), length 98: (tos 0x0, ttl 63, id 22176, offset 0, flags [none],
> proto ICMP (1), length 84)
> 1.1.70.2 > 11.11.70.1: ICMP echo reply, id 15498, seq 18, length 64
>
> -邮件原件-
> 发件人
, returning immediately. One notable change in
functionality is not performing the RBAC check in this condition, as no
mutation actually takes place.
Reported-by: Terry Wilson
Reported-at: https://issues.redhat.com/browse/FDP-359
Signed-off-by: Mike Pattrick
---
v2: Added additional non-rbac tests
Previously the mirror_set() and mirror_get() functions took a large
number of parameters, which was inefficient and difficult to read and
extend. This patch moves most of the parameters into a struct.
Signed-off-by: Mike Pattrick
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
---
ofproto
packets are mirrored based on flow metadata. This
significantly improves overall vswitchd performance during mirroring if
only a subset of traffic is required.
Signed-off-by: Mike Pattrick
---
v7:
- Make sure filter mask is added to masks of non-matching flows.
- Added additional tests
On Tue, Feb 27, 2024 at 10:37 AM Simon Horman wrote:
>
> Correct spelling errors in .rst files flagged by codespell.
>
> Signed-off-by: Simon Horman
> ---
These look correct to me.
Acked-by: Mike Pattrick
___
dev mailing list
d...@
tead.
>
> 1., 2. & 3. Found by inspection
> 4. Flagged by check-docs
>
> Signed-off-by: Simon Horman
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
rf/en/latest/release/release-notes/release-notes.html
>
> Signed-off-by: Simon Horman
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote:
>
> Update link to OCF Resource Agents documentation as the existing link
> is broken. Also, use HTTPS.
>
> Broken link flagged by make check-docs
>
> Signed-off-by: Simon Horman
Ac
On Mon, Feb 26, 2024 at 4:22 AM Felix Huettner via dev
wrote:
>
> Extract checking for a given kernel version to a separate function.
> It will be used also in the next patch.
>
> Signed-off-by: Felix Huettner
> ---
> v4->v5:
> - fix wrong ifdef that broke on macos
> - fix
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote:
>
> IANAL, but I think we can extend the copyright attached
> to documentation to cover the current year: we are still
> actively working on the documentation.
>
> Signed-off-by: Simon Horman
Acked-by: Mike Pattrick
I wo
On Wed, Feb 28, 2024 at 8:41 AM Ilya Maximets wrote:
>
> On 2/22/24 17:37, Mike Pattrick wrote:
> > Previously when an empty mutation was used to count the number of rows
> > in a table, OVSDB would iterate over all rows twice. First to perform an
> > RBAC ch
On Mon, Feb 26, 2024 at 5:50 AM Xavier Simonart wrote:
>
> On netdev datapath, when a ct element was cleaned, the cmap
> could be shrinked, potentially causing some elements to be skipped
> in the flush iteration.
>
> Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
> Signed-off-by: Xavier
offload inner either.
Reported-at: https://issues.redhat.com/browse/FDP-363
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mike Pattrick
---
nb: I also tested a more complex patch that only resolved the inner
checksum and offloaded the UDP layer. This didn't
ot;)
> Signed-off-by: Xavier Simonart
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
the netdev_ports_flow_dump_create function if
dumps is NULL.
Signed-off-by: Mike Pattrick
---
lib/netdev-offload.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-offload.c b/lib/netdev-offload.c
index 931d634e1..8a9d36555 100644
--- a/lib/netdev-offload.c
+++ b
Clang's static analyzer will complain about uninitialized value 'hlen'
because we weren't properly checking the error code from a function that
would have initialized the value.
Instead, add a check for that return code.
Signed-off-by: Mike Pattrick
Fixes: 03fc1ad78521 ("userspace: Add
flow deletion via ovs-dpctl due to
missing ufid.")
Signed-off-by: Mike Pattrick
---
lib/dpctl.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 3c555a559..a70df5342 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -1359,19 +1359,17
Clang's static analyzer noted that the output from
netdev_linux_get_speed_locked can be checked even if this function
doesn't set any values.
Now we always set those values to a sane default in all cases.
Fixes: 6240c0b4c80e ("netdev: Add netdev_get_speed() to netdev API.")
Signed-of
read the database with DNS
host names.")
Fixes: 5f219af8b3c7 ("ovsdb-server: Fix handling of DNS name for listener
configuration.")
Signed-off-by: Mike Pattrick
---
lib/socket-util.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/socket-util.c b/lib/socket-ut
("netdev-linux: Use ethtool to detect offload support.")
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 25349c605..8b855bdc4 100644
--- a/lib/netdev-linux.c
+++ b/
On Mon, May 20, 2024 at 2:56 AM laixiangwu <15310488...@163.com> wrote:
>
> Description:
>
> when 1) The fragment timeout is between 15 seconds and 25 seconds; 2) The
> ipf_list currently has received more than 32 fragments, and there are other
> fragments of same big packet that have not been
read the database with DNS
host names.")
Fixes: 5f219af8b3c7 ("ovsdb-server: Fix handling of DNS name for listener
configuration.")
Signed-off-by: Mike Pattrick
---
lib/socket-util.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/socket-util.c b/lib/socket-ut
Signed-off-by: Mike Pattrick
---
lib/netdev-native-tnl.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
index b21176037..d6f46ac4a 100644
--- a/lib/netdev-native-tnl.c
+++ b/lib/netdev-native-tnl.c
@@ -1067,
flow deletion via ovs-dpctl due to
missing ufid.")
Signed-off-by: Mike Pattrick
---
lib/dpctl.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 3c555a559..a70df5342 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -1359,19 +1359,17
-by: Mike Pattrick
Mike Pattrick (6):
netdev-offload: Fix null pointer dereference warning on dump creation.
netdev-native-tnl: Fix use of uninitialized offset on SRv6 header pop.
dpctl: Fix uninitialized value when deleting flows.
socket: Fix uninitialized values in inet_parse_ functions
the netdev_ports_flow_dump_create function if
dumps is NULL.
Signed-off-by: Mike Pattrick
---
lib/netdev-offload.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-offload.c b/lib/netdev-offload.c
index 931d634e1..8a9d36555 100644
--- a/lib/netdev-offload.c
+++ b
("netdev-linux: Use ethtool to detect offload support.")
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 25349c605..c89a85a38 100644
--- a/lib/netdev-linux.c
+++ b/
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index c89a85a38..ff5e94856 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -2727,6 +2727,7 @@ netdev_linux_get_speed_locked(struct netdev_lin
message")
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ness.
>
> Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
38 problem when storing uint32_t values in time_t. This patch
> updates the internal data structures to use uint32_t variables.
>
> Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
> Signed-off-by: Eelco Cha
igned-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, May 28, 2024 at 4:26 PM Ilya Maximets wrote:
>
> On 5/27/24 21:08, Mike Pattrick wrote:
> > Clang's static analyzer noted that the output from
> > netdev_linux_get_speed_locked can be checked even if this function
> > doesn't set any values.
> >
>
On Thu, May 23, 2024 at 6:47 AM Roi Dayan via dev
wrote:
>
> It is observed in some environments that there are much more ukeys than
> actual DP flows. For example:
>
> $ ovs-appctl upcall/show
> system@ovs-system:
> flows : (current 7) (avg 6) (max 117) (limit 2125)
> offloaded flows : 525
>
Hello laixaingwu,
I happen to have a patch on the list right now for a similar sounding issue:
https://patchwork.ozlabs.org/project/openvswitch/patch/20240516153832.153496-1-...@redhat.com/
Do you happen to have a stack trace available for this crash? That
could help determine if the crash is
ture added to be able to handle and print out the
> 'indexed' table from the idltest schema.
>
> Fixes: 13973bc41524 ("Add multi-column index support for the Python IDL")
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2024-May/053159.html
> Repor
a separate file is to make management of this
list simpler by decoupling the code from the keywords.
Signed-off-by: Mike Pattrick
---
utilities/checkpatch.py | 67 +---
utilities/extra_keywords | 747 +++
2 files changed, 750 insertions(+), 64 deletions
a separate file is to make management of this
list simpler by decoupling the code from the keywords.
Signed-off-by: Mike Pattrick
---
v2: Included new file in distfiles
---
utilities/automake.mk| 1 +
utilities/checkpatch.py | 67 +---
utilities/extra_keywords | 747
On Mon, Jun 3, 2024 at 9:56 AM Simon Horman wrote:
>
> On Mon, Jun 03, 2024 at 12:20:36AM -0400, Mike Pattrick wrote:
> > Currently all OVSDB database queries except for UUID lookups all result
> > in linear lookups over the entire table, even if an index is present.
> >
On Fri, Jun 7, 2024 at 2:35 AM Eelco Chaudron wrote:
>
>
>
> On 6 Jun 2024, at 3:07, Mike Pattrick wrote:
>
> > This patch extends the extra_keywords list from 324 to 747 keywords and
> > moves this list to a separate file. The methodology used to create this
>
on to add/delete static fdb
> entry.")
> Signed-off-by: Eelco Chaudron
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Jun 13, 2024 at 5:59 AM David Marchand
wrote:
>
> Querying link status may get delayed for an undeterministic (long) time
> with mlx5 ports. This is a consequence of the mlx5 driver calling ethtool
> kernel API and getting stuck on the kernel RTNL lock while some other
> operation is in
On Wed, Jun 12, 2024 at 6:45 AM Emma Finn wrote:
>
> The AVX implementation for IPv4 action did not check whether
> the IPv4 checksum offload flag has been set and was incorrectly
> calculating checksums in software. Adding a check to skip AVX
> checksum claculation when offload flags are set.
On Wed, Jun 12, 2024 at 6:44 AM Emma Finn wrote:
>
> The AVX implementation for the IPv6 action did not set
> traffic class field. Adding support for this field to
> the AVX implementation.
>
> Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
> ---
> lib/odp-execute-avx512.c | 8
On Tue, Jun 4, 2024 at 7:29 AM Dumitru Ceara wrote:
>
> It improves the debugging experience if we can easily get a list of
> OpenFlow rules and groups that contribute to the creation of a datapath
> flow.
>
> The suggested workflow is:
> a. dump datapath flows (along with UUIDs), this also
tch/ovs.git
> - DPDK:
> * OVS validated with DPDK 23.11.1.
> + * Link status changes are now handled via interrupt mode if the DPDK
> + driver supports it. It is possible to revert to polling mode by
> setting
> + per interface 'dpdk-lsc-interrupt' other_c
On Mon, Jun 17, 2024 at 12:54 PM Mike Pattrick wrote:
>
> Currently all OVSDB database queries except for UUID lookups all result
> in linear lookups over the entire table, even if an index is present.
>
> This patch modifies ovsdb_query() to attempt an index lookup first
On Mon, Jun 3, 2024 at 2:01 PM Ilya Maximets wrote:
>
> On 6/3/24 06:20, Mike Pattrick wrote:
> > Currently all OVSDB database queries except for UUID lookups all result
> > in linear lookups over the entire table, even if an index is present.
> >
> > This patch mod
://issues.redhat.com/browse/FDP-590
Signed-off-by: Mike Pattrick
---
v2:
- Included txn in index code
- Added benchmarks
- Refactored code
- Added more tests
- Now a mock row is created to perform the search with standard
functions
Signed-off-by: Mike Pattrick
---
ovsdb/execution.c| 20
On Fri, Jun 14, 2024 at 6:45 AM Dumitru Ceara wrote:
>
> It improves the debugging experience if we can easily get a list of
> OpenFlow rules and groups that contribute to the creation of a datapath
> flow.
>
> The suggested workflow is:
> a. dump datapath flows (along with UUIDs), this also
.
Reported-at: https://issues.redhat.com/browse/FDP-590
Signed-off-by: Mike Pattrick
---
NEWS | 3 ++
ovsdb/query.c| 102 +++
ovsdb/row.h | 28 +++
ovsdb/transaction.c | 27 ---
tests/ovsdb
.
Reported-at: https://issues.redhat.com/browse/FDP-590
Signed-off-by: Mike Pattrick
---
NEWS | 3 ++
ovsdb/query.c| 102 +++
ovsdb/row.h | 28 +++
ovsdb/transaction.c | 27 ---
tests/ovsdb
On Wed, Jun 12, 2024 at 9:50 AM Ales Musil wrote:
>
>
> On Wed, Jun 12, 2024 at 3:32 PM Mike Pattrick wrote:
>
>> When compiling with '-fsanitize=address,undefined', the "ovs-ofctl
>> ct-flush" test will yield the following undefined behavior flagged
>>
On Tue, Jun 4, 2024 at 10:29 AM David Marchand
wrote:
>
> On Wed, Feb 21, 2024 at 5:09 AM Mike Pattrick wrote:
> > @@ -105,20 +115,35 @@ dp_packet_gso(struct dp_packet *p, struct
> > dp_packet_batch **batches)
> > return false;
> > }
> &g
Signed-off-by: Mike Pattrick
---
lib/ofp-prop.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/ofp-prop.c b/lib/ofp-prop.c
index 0a685750c..ed6365414 100644
--- a/lib/ofp-prop.c
+++ b/lib/ofp-prop.c
@@ -271,10 +271,12 @@ enum ofperr
ofpprop_parse_u128(const struct ofpbuf
When sending packets that are flagged as requiring segmentation to an
interface that doens't support this feature, send the packet to the TSO
software fallback instead of dropping it.
Signed-off-by: Mike Pattrick
---
v2:
- Fixed udp tunnel length
- Added test that UDP headers are correct
On Fri, Jun 14, 2024 at 8:55 AM Ilya Maximets wrote:
>
> On 6/12/24 20:12, Mike Pattrick wrote:
> > On Wed, Jun 12, 2024 at 9:50 AM Ales Musil wrote:
> >
> >>
> >>
> >> On Wed, Jun 12, 2024 at 3:32 PM Mike Pattrick wrote:
> >>
> >>
On Tue, Jun 25, 2024 at 4:30 AM echken wrote:
>
> The OVS internal port does not support UDP fragmentation offloading,
> resulting in large packets sent through the OVS internal port to OVS
> being prematurely fragmented. This increases the total number of packets
> processed in the path from the
d flags are set.
>
> Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
This brings things inline with the scalar odp-execute.
Fixes: 5d11c47d3ebe ("userspace: Enable IP checksum offloading by default.")
Acked-by: Mike Pattrick
Cheers,
M
://issues.redhat.com/browse/FDP-689
Reported-by: Ihar Hrachyshka
Signed-off-by: Mike Pattrick
---
tests/ovsdb-server.at | 50 +++
utilities/ovs-lib.in | 23
2 files changed, 69 insertions(+), 4 deletions(-)
diff --git a/tests/ovsdb-server.at b
On Fri, Jun 21, 2024 at 11:08 AM David Marchand
wrote:
>
> Hi Mike,
>
> On Thu, Jun 13, 2024 at 4:54 AM Mike Pattrick wrote:
> >
> > When sending packets that are flagged as requiring segmentation to an
> > interface that doens't support this feature, send the
to set csum=false on IPv6 tunnels.
Acked-by: Simon Horman
Signed-off-by: Mike Pattrick
---
NEWS | 11 +++
lib/netdev-native-tnl.c | 2 +-
lib/netdev-vport.c| 17 +++--
lib/netdev.h | 18 +-
ofproto
When prepending a tunnel header to a packet marked for segmentation, we
need to adjust the segment size. Failure to do so can result in packets
that are larger than the intended MTU post segmentation.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mik
When sending packets that are flagged as requiring segmentation to an
interface that does not support this feature, send the packet to the TSO
software fallback instead of dropping it.
Signed-off-by: Mike Pattrick
---
v2:
- Fixed udp tunnel length
- Added test that UDP headers are correct
flags.
The modification to outer UDP offload is still required pending a future
DPDK release.
Suggested-by: David Marchand
Signed-off-by: Mike Pattrick
---
lib/netdev-dpdk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 02cef6e45..95a78241d
On Tue, Jul 9, 2024 at 5:57 PM Ilya Maximets wrote:
>
> On 7/5/24 22:44, Mike Pattrick wrote:
> > When sending packets that are flagged as requiring segmentation to an
> > interface that does not support this feature, send the packet to the TSO
> > software fall
On Tue, Jul 9, 2024 at 1:49 AM 赖香武 <15310488...@163.com> wrote:
>
> hi, llya and Michael
>
> Can you take the time to take a look at my patch? Thank you.
Hello,
I wasn't able to reproduce the crash using your method and
unfortunately the stack trace appears to be missing debug symbols.
Looking
When sending packets that are flagged as requiring segmentation to an
interface that does not support this feature, send the packet to the TSO
software fallback instead of dropping it.
Signed-off-by: Mike Pattrick
---
v2:
- Fixed udp tunnel length
- Added test that UDP headers are correct
flags.
The modification to outer UDP offload is still required pending a future
DPDK release.
Suggested-by: David Marchand
Signed-off-by: Mike Pattrick
---
lib/netdev-dpdk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 02cef6e45..95a78241d
When prepending a tunnel header to a packet marked for segmentation, we
need to adjust the segment size. Failure to do so can result in packets
that are larger than the intended MTU post segmentation.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mik
a package.
Fixes: 3ddb31f60487 ("ovs-monitor-ipsec: LibreSwan autodetect paths.")
Signed-off-by: Mike Pattrick
---
ipsec/ovs-monitor-ipsec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ipsec/ovs-monitor-ipsec.in b/ipsec/ovs-monitor-ipsec.in
index bc7ac55
he version proved simpler than
removing use of auto.
There was also a change to ipsec status command that effected the tests.
However, this change was backwards compatible.
Reported-at: https://issues.redhat.com/browse/FDP-645
Reported-by: Ilya Maximets
Signed-off-by: Mike Pattrick
---
ipsec/o
On Thu, Jun 27, 2024 at 4:13 PM Ilya Maximets wrote:
>
> On 6/18/24 21:41, Dumitru Ceara wrote:
> > It improves the debugging experience if we can easily get a list of
> > OpenFlow rules and groups that contribute to the creation of a datapath
> > flow.
> >
> > The suggested workflow is:
> > a.
On Fri, Jun 28, 2024 at 4:50 AM David Marchand
wrote:
>
> On Thu, Jun 27, 2024 at 4:04 PM David Marchand
> wrote:
> > @@ -926,6 +926,17 @@ netdev_send(struct netdev *netdev, int qid,
> > struct dp_packet_batch *batch,
> > return netdev_send_tso(netdev, qid, batch,
> >
packets are mirrored based on flow metadata. This
significantly improves overall vswitchd performance during mirroring if
only a subset of traffic is required.
Signed-off-by: Mike Pattrick
---
v8:
- Corrected code from v7 related to sequence and in_port. Mirrors
reject filters with an in_port set
Previously the mirror_set() and mirror_get() functions took a large
number of parameters, which was inefficient and difficult to read and
extend. This patch moves most of the parameters into a struct.
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off-by: Mike Pattrick
---
ofproto
On Wed, Jun 19, 2024 at 8:32 AM Simon Horman wrote:
>
> On Mon, Jun 17, 2024 at 01:11:28PM -0400, Mike Pattrick wrote:
> > On Mon, Jun 3, 2024 at 2:01 PM Ilya Maximets wrote:
> > >
> > > On 6/3/24 06:20, Mike Pattrick wrote:
> > > > Currently all OVSD
ofp_print lib/ofp-print.c:1308
6: in ofctl_ofp_print utilities/ovs-ofctl.c:4899
7: in ovs_cmdl_run_command__ lib/command-line.c:247
8: in ovs_cmdl_run_command lib/command-line.c:278
9: in main utilities/ovs-ofctl.c:186
Signed-off-by: Mike Pattrick
---
v2: removed memcpy
---
lib/
://issues.redhat.com/browse/FDP-590
Signed-off-by: Mike Pattrick
---
v3:
- Included txn in index code
- Added benchmarks
- Refactored code
- Added more tests
- Now a mock row is created to perform the search with standard
functions
Signed-off-by: Mike Pattrick
---
ovsdb/execution.c| 20
601 - 700 of 724 matches
Mail list logo