Re: [ovs-dev] [PATCH ovn 2/3] Introduce icmp6.frag_mtu action

2020-07-07 Thread Numan Siddique
On Fri, Jul 3, 2020 at 7:55 PM Lorenzo Bianconi wrote: > Similar to what have been already done for IPv4, introduce > icmp6.frag_mtu action in order to set correct mtu in ICMPv6 "packet too > big" error message > > Signed-off-by: Lorenzo Bianconi > Hi Lorenzo, This patch has a compilation

Re: [ovs-dev] [PATCH ovn 2/3] Introduce icmp6.frag_mtu action

2020-07-07 Thread Numan Siddique
On Tue, Jul 7, 2020 at 2:33 PM Numan Siddique wrote: > > > On Fri, Jul 3, 2020 at 7:55 PM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > >> Similar to what have been already done for IPv4, introduce >> icmp6.frag_mtu action in order to set correct

Re: [ovs-dev] [PATCH v3 ovn] Throttle the OVS-OVN Global config logs

2020-07-07 Thread Numan Siddique
On Sun, Jul 5, 2020 at 11:08 AM Ankur Sharma wrote: > From: Ankur Sharma > > ISSUE: > We observed that if ovn-controller is running, while ovn-encap-ip/ > ovn-encap-type is not set, then following error gets logged > continously: > "chassis|INFO|Need to specify an encap type and ip" > > Above

Re: [ovs-dev] [PATCH v4 ovn 5/5] ovn-northd: Minimize number of ARP/NS responder flows for DNAT.

2020-07-06 Thread Numan Siddique
Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2020-June/050186.html > Signed-off-by: Dumitru Ceara > Acked-by: Numan Siddique Thanks Numan > --- > northd/ovn-northd.8.xml | 16 ++ > northd/ovn-northd.c | 342 > +

Re: [ovs-dev] [PATCH v4 ovn 4/5] ovn-northd: Refactor NAT address parsing.

2020-07-06 Thread Numan Siddique
On Sat, Jul 4, 2020 at 12:05 AM Dumitru Ceara wrote: > Store NAT entries pointers in ovn_datapath and pre-parse the external IP > addresses. This simplifies the code and makes it easier to reuse the parsed > external IP and solicited-node address without reparsing. > > Acked-by: Han Zhou >

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix the missing lflow issue in LS_OUT_PRE_LB.

2020-07-07 Thread Numan Siddique
On Tue, Jul 7, 2020 at 8:03 PM Dumitru Ceara wrote: > On 7/7/20 3:16 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > When load balancer(s) configured with VIPs are associated to a logical > switch, > > then ovn-northd adds the below logical flow so th

Re: [ovs-dev] [PATCH ovn v3] ovn-northd: Fix logical flows to limit ARP/NS broadcast domain.

2020-07-10 Thread Numan Siddique
s configured on the router port). > > Reported-by: Girish Moodalbail > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2020-June/050287.html > Fixes: 32f5ebb06226 ("ovn-northd: Limit ARP/ND broadcast domain whenever > possible.") > Signed-off-by: Dumitru

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-10 Thread Numan Siddique
k). [1] - https://github.com/numansiddique/ovn-fake-multinode/blob/vlan_chassis_mac_issue/ovn_cluster.sh#L501 Thanks Numan Regards, > Ankur > > From: num...@ovn.org > Sent: Thursday, July 9, 2020 2:11 AM > To: d...@openvswitch.org > Cc: Numan

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-13 Thread Numan Siddique
of a gateway port configuration. > Absence of guard, leads to multiple ARP responses and duplicate ICMP reply > packets.I will submit a fix for this. > > > Please let me know your thoughts on the same and please feel free to call > out, if i missed something. > > Thanks > > Reg

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-10 Thread Numan Siddique
On Fri, Jul 10, 2020 at 4:41 PM Numan Siddique wrote: > > > On Fri, Jul 10, 2020 at 12:45 AM Ankur Sharma > wrote: > >> Hi Numan, Daniel, >> >> I have not looked at the patch yet. But replacing arp.sha with chassis >> mac is not the correct approach from

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Configure hwaddr for the integration bridge

2020-07-03 Thread Numan Siddique
On Fri, Jul 3, 2020 at 12:11 AM Mark Michelson wrote: > Excellent! Thanks, Numan! > > Acked-by: Mark Michelson > > Thanks for the review. I applied this patch to master. Numan > On 7/1/20 11:34 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > >

Re: [ovs-dev] [PATCH v1 ovn] Fix seg fault while encoding DHCP domain search option.

2020-07-01 Thread Numan Siddique
On Wed, Jul 1, 2020 at 6:08 AM Ankur Sharma wrote: > Hi Dhathri, > > Please Add "Fixes" header to commit message. > Acked-by: Ankur Sharma > Thanks. I applied this patch to master. Numan > > Regards, > Ankur > > From: dev on behalf of >

Re: [ovs-dev] [PATCH v5 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-17 Thread Numan Siddique
On Fri, Jun 12, 2020 at 2:14 AM Ankur Sharma wrote: > From: Dhathri Purohith > > From: Dhathri Purohith > > Currently, DHCP option is of type ipv4. But, according to RFC 2132, > option 66 can be a hostname i.e, we should also accept string type. > In order to be backward compatible, a new type

Re: [ovs-dev] [PATCH ovn v12 0/7] Incremental processing improvements.

2020-06-17 Thread Numan Siddique
On Wed, Jun 17, 2020 at 12:32 PM Han Zhou wrote: > On Thu, Jun 11, 2020 at 5:43 AM wrote: > > > > From: Numan Siddique > > > > This patch series handles port binding, datapath binding, ovs interface > changes, > > runtime data changes, sb chassis changes i

Re: [ovs-dev] [PATCH ovs v3] ovsdb idl: Try committing the pending txn in ovsdb_idl_loop_run.

2020-06-16 Thread Numan Siddique
On Wed, Jun 17, 2020 at 2:49 AM Ben Pfaff wrote: > On Fri, Jun 05, 2020 at 02:00:29PM +0530, num...@ovn.org wrote: > > From: Numan Siddique > > > > The function ovsdb_idl_loop_run(), after calling ovsdb_idl_run(), > > returns a transaction object (of

Re: [ovs-dev] [PATCH ovn] Fix ovn-controller generated packets from getting dropped for reject ACL action.

2020-06-17 Thread Numan Siddique
On Tue, Jun 16, 2020 at 6:34 PM Mark Michelson wrote: > Looks good to me. > > Acked-by: Mark Michelson > Thanks for the review. I applied this patch to master, branch-20.06 and branch-20.03. Thanks Numan > > On 6/15/20 5:47 AM, num...@ovn.org wrote: > > From: Num

Re: [ovs-dev] [PATCH ovn] test: add more tests to IP-buffering unit-test

2020-06-17 Thread Numan Siddique
On Wed, Jun 3, 2020 at 2:18 PM Lorenzo Bianconi wrote: > On Jun 03, Ankur Sharma wrote: > > Hi Lorenzo, > > > > Please find my comments inline. > > > > Regards, > > Ankur > > > > > > From: dev on behalf of Ankur Sharma < > ankur.sha...@nutanix.com> > > Sent:

Re: [ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-17 Thread Numan Siddique
On Wed, Jun 17, 2020 at 3:26 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Set packet length in lr_in_chk_pkt_len router pipeline instead of > gw interface MTU since ovs kernel datapath usually works on L2 frames > > Fixes: 7d42c146be ("ovn: Generate ICMPv4 packet in router pipeline

Re: [ovs-dev] [PATCH v5 2/2 ovn] Add support for DHCP domain search option (119)

2020-06-17 Thread Numan Siddique
Hi Dhathri, Please see a few comments inline. On Fri, Jun 12, 2020 at 2:14 AM Ankur Sharma wrote: > From: Dhathri Purohith > This From is causing the author to have the email - svc.eng.git-pa...@nutanix.com. Is this intentional ? It would be great if you could fix this and remove this

Re: [ovs-dev] [PATCH ovn] Fix the test case "80. ovn -- 4 HV, 1 LS, 1 LR, packet test with HA distributed router gateway port"

2020-06-18 Thread Numan Siddique
me a bit faster in handling the updates. I applied this patch to master. Thanks Numan On 6/17/20 4:38 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This test case is failing intermittently in my local setup. > > > > *** > > rcv_

Re: [ovs-dev] [PATCH ovn v2] Support packet metadata marking for logical router policies.

2020-06-18 Thread Numan Siddique
r > > On Thu, Jun 18, 2020 at 11:17 AM wrote: > > > From: Numan Siddique > > > > This patch adds a new column 'options' of type smap in the > > Logical_Router_Policy table in the NB DB and supports the key 'pkt_mark'. > > CMS can set a desired value for this key in

Re: [ovs-dev] [PATCH ovn v13 3/7] ovn-controller: Handle runtime data changes in flow output engine

2020-06-19 Thread Numan Siddique
On Fri, Jun 19, 2020 at 5:22 PM Dumitru Ceara wrote: > On 6/19/20 1:10 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > In order to handle runtime data changes incrementally, the flow outut > > runtime data handle should know the changed runtime data.

Re: [ovs-dev] [PATCH ovn v13 5/7] tests: Enhance ovn-performance testing by adding gw router port.

2020-06-19 Thread Numan Siddique
On Fri, Jun 19, 2020 at 5:57 PM Dumitru Ceara wrote: > On Fri, Jun 19, 2020 at 1:11 PM wrote: > > > > From: Numan Siddique > > > > This covers the scenario of setting up/deleting of BFD tunnels > > for HA. > > > > Acked-by: Han Zhou > > Si

Re: [ovs-dev] [PATCH ovn v12 5/7] tests: Enhance ovn-performance testing by adding gw router port.

2020-06-19 Thread Numan Siddique
On Fri, Jun 19, 2020 at 2:08 PM Dumitru Ceara wrote: > On 6/11/20 2:44 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This covers the scenario of setting up/deleting of BFD tunnels > > for HA. > > > > Tested-by: Dumitru Ceara > >

Re: [ovs-dev] [PATCH ovn v13 0/7] Incremental processing improvements.

2020-06-19 Thread Numan Siddique
On Fri, Jun 19, 2020 at 6:09 PM Dumitru Ceara wrote: > On 6/19/20 1:09 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This patch series handles port binding, datapath binding, ovs interface > changes, > > runtime data changes, sb chassis changes increme

Re: [ovs-dev] [PATCH ovn v5] Support packet metadata marking for logical router policies.

2020-06-23 Thread Numan Siddique
On Mon, Jun 22, 2020 at 9:17 PM Dumitru Ceara wrote: > On 6/22/20 1:11 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This patch adds a new column 'options' of type smap in the > > Logical_Router_Policy table in the NB DB and supports the key 'pkt_mark'

Re: [ovs-dev] [PATCH v7 ovn] Add support for DHCP domain search option (119)

2020-06-23 Thread Numan Siddique
On Mon, Jun 22, 2020 at 12:09 PM Numan Siddique wrote: > > > On Fri, Jun 19, 2020 at 11:12 PM Ankur Sharma > wrote: > >> From: Dhathri Purohith >> >> Domain search list is encoded according to the specifications in RFC 1035, >> section 4.1.4. >>

Re: [ovs-dev] [PATCH v7 ovn] Add support for DHCP domain search option (119)

2020-06-23 Thread Numan Siddique
On Tue, Jun 23, 2020 at 7:36 PM Mark Michelson wrote: > On 6/23/20 5:13 AM, Numan Siddique wrote: > > On Mon, Jun 22, 2020 at 12:09 PM Numan Siddique wrote: > > > >> > >> > >> On Fri, Jun 19, 2020 at 11:12 PM Ankur Sharma > > >> wrote:

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Enhance lr-policy-add to set the options.

2020-06-23 Thread Numan Siddique
On Tue, Jun 23, 2020 at 7:09 PM Mark Michelson wrote: > Hi Numan, > > I have a few comments in-line down below. > > On 6/23/20 7:43 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit [1] added a new column - 'options' to Logical_Router_Pol

Re: [ovs-dev] [PATCH ovn v2] ovn-nbctl: Enhance lr-policy-add to set the options.

2020-06-23 Thread Numan Siddique
On Tue, Jun 23, 2020 at 8:07 PM Mark Michelson wrote: > Acked-by: Mark Michelson > Thanks for the review. I applied this patch to master. Thanks Numan > > On 6/23/20 10:29 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit [1]

Re: [ovs-dev] [PATCH ovn v2] pinctrl: Support DHCPRELEASE and DHCPINFORM in native OVN dhcp responder.

2020-06-23 Thread Numan Siddique
On Tue, Jun 23, 2020 at 6:19 PM Mark Michelson wrote: > Acked-by: Mark Michelson > > Thank you Lorenzo and Mark for the reviews. I applied this patch to master. Thanks Numan > On 6/22/20 11:31 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > Right no

Re: [ovs-dev] [PATCH ovn] lex: Allow unmasked bits in value/mask tokens.

2020-06-24 Thread Numan Siddique
On Tue, Jun 23, 2020 at 10:04 PM Mark Michelson wrote: > On 6/23/20 11:08 AM, Dumitru Ceara wrote: > > On 6/23/20 4:56 PM, Mark Michelson wrote: > >> Acked-by: Mark Michelson > Thanks Dumitru and Mark (for the reviews). I applied this patch to master with the below changes in the

Re: [ovs-dev] [PATCH v4 ovn 1/6] Avoid case-sensitive MAC address comparisons.

2020-06-26 Thread Numan Siddique
same address. > > This commit fixes the issue by converting the string representation to > the binary representation and comparing that instead. > > Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1829059 > Signed-off-by: Mark Michelson > Acked-by: Numan Siddique for a

Re: [ovs-dev] [PATCH ovn 0/4] Reduce number of flows in IN_IP_INPUT table for DNAT.

2020-06-26 Thread Numan Siddique
On Wed, Jun 24, 2020 at 9:21 PM Dumitru Ceara wrote: > The first three patches refactor the ARP/NS responder code for logical > routers in order to make it easier for patch #4 to configure the flows > with different priorities depending on logical port type. > > Suggested-by: Han Zhou >

Re: [ovs-dev] [PATCH] jsonrpc: Don't assert for 0 remotes in jsonrpc_session_open_multiple().

2020-06-29 Thread Numan Siddique
mote instead. > > Signed-off-by: Ben Pfaff > Acked-by: Numan Siddique Thanks Numan > --- > lib/jsonrpc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c > index 060b6669d893..10c0c09962da 100644 > --- a/lib/jsonrpc.c

Re: [ovs-dev] [PATCH ovn] chassis.c: Add comment to SB DB transaction only when needed.

2020-06-29 Thread Numan Siddique
On Thu, Jun 25, 2020 at 1:28 PM Dumitru Ceara wrote: > The chassis_run() function incorrectly adds a "ovn-controller: > registering chassis" comment to every SB transaction. This should be done > only when the chassis record is created or updated. If nothing changes in > the chassis record we

Re: [ovs-dev] [PATCH ovn] ovn-northd: Make it harder to specify a bad database remote.

2020-06-29 Thread Numan Siddique
Pfaff > Acked-by: Numan Siddique Thanks Numan > --- > northd/ovn-northd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > index 784f33b6861c..d586c12eabb0 100644 > --- a/northd/ovn-northd.c > +++ b/no

Re: [ovs-dev] [PATCH ovn] Split SB Port_Group per datapath.

2020-06-29 Thread Numan Siddique
500 > new ports attached to 100 switches, 5 per switch) on a test setup > we observe an improvement of 50% in time it takes to install all > openflow rules when port_groups are split in the SB database. > > Suggested-by: Numan Siddique > Reported-by: Venkata Anil > Reported-at: https:

Re: [ovs-dev] [PATCH ovn] Fix selection fields for UDP and SCTP load balancers.

2020-06-29 Thread Numan Siddique
On Mon, Jun 29, 2020 at 8:48 PM Mark Michelson wrote: > On 6/22/20 1:41 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit 5af304e7478a ("Support selection fields in load balancer.") > > didn't handle the selection fields for UDP

Re: [ovs-dev] [PATCH ovn] northd: By pass IPv6 Router Adv and Router Solicitation packets from ACL stages.

2020-06-15 Thread Numan Siddique
On Fri, Jun 12, 2020 at 12:41 AM Mark Michelson wrote: > On 6/11/20 12:12 PM, Numan Siddique wrote: > > > > > > On Thu, Jun 11, 2020 at 8:59 PM Numan Siddique > <mailto:num...@ovn.org>> wrote: > > > > > > > > On Thu, Jun 11, 2020 at

Re: [ovs-dev] [PATCH ovn v3] Support packet metadata marking for logical router policies.

2020-06-22 Thread Numan Siddique
On Mon, Jun 22, 2020 at 3:18 PM Dumitru Ceara wrote: > On 6/19/20 8:30 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This patch adds a new column 'options' of type smap in the > > Logical_Router_Policy table in the NB DB and supports the key 'pkt_mark'

Re: [ovs-dev] [PATCH v7 ovn] Add support for DHCP domain search option (119)

2020-06-22 Thread Numan Siddique
On Fri, Jun 19, 2020 at 11:12 PM Ankur Sharma wrote: > From: Dhathri Purohith > > Domain search list is encoded according to the specifications in RFC 1035, > section 4.1.4. > > Signed-off-by: Dhathri Purohith > Signed-off-by: Ankur Sharma > I have asked a question in v5 of this patch about

Re: [ovs-dev] [PATCH ovn 1/3] TODO.rst: Remove "Finish up ARP/ND support".

2020-06-22 Thread Numan Siddique
On Mon, Jun 22, 2020 at 11:09 AM Han Zhou wrote: > This is redundant with the section "Dynamic IP to MAC binding > enhancements". > > Signed-off-by: Han Zhou > Acked-by: Numan Siddique for all the 3 patches of this series. Thanks Numan > --- > TODO.

Re: [ovs-dev] [PATCH ovn] ovn-nb.xml: Fix the description about LB usage on logical routers.

2020-06-22 Thread Numan Siddique
On Mon, Jun 22, 2020 at 11:46 AM Han Zhou wrote: > LB is supported not only on Gateway routers but also on distributed > routers as long as they have distributed gateway ports. It is tested > by case "ovn -- Load balancer health checks". > > Signed-off-by: Han Zhou &g

Re: [ovs-dev] [PATCH v2 ovn] northd: set packet length in check_pkt_larger()

2020-06-22 Thread Numan Siddique
On Thu, Jun 18, 2020 at 10:21 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Set packet length in lr_in_chk_pkt_len router pipeline instead of > gw interface MTU since ovs kernel datapath usually works on L2 frames > > Fixes: 7d42c146be ("ovn: Generate ICMPv4 packet in router

Re: [ovs-dev] [PATCH ovn v12 2/7] ovn-controller: I-P for ct zone and OVS interface changes in flow output stage.

2020-06-19 Thread Numan Siddique
On Fri, Jun 19, 2020 at 1:11 PM Dumitru Ceara wrote: > On 6/11/20 2:43 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This patch handles ct zone changes and OVS interface changes > incrementally > > in the flow output stage. > > > > Any ch

Re: [ovs-dev] [PATCH ovn v12 2/7] ovn-controller: I-P for ct zone and OVS interface changes in flow output stage.

2020-06-19 Thread Numan Siddique
On Fri, Jun 19, 2020 at 1:39 PM Numan Siddique wrote: > > > On Fri, Jun 19, 2020 at 1:11 PM Dumitru Ceara wrote: > >> On 6/11/20 2:43 PM, num...@ovn.org wrote: >> > From: Numan Siddique >> > >> > This patch handles ct zone changes and OVS interf

Re: [ovs-dev] [PATCH] acinclude: Remove libmnl for MLX5 PMD

2020-06-25 Thread Numan Siddique
On Tue, Jun 23, 2020 at 10:19 PM Timothy Redaelli wrote: > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. > > Signed-off-by: Timothy Redaelli > Acked-by: Numan Siddique This patch is needed to build OVS on Fedora rawhide successfully and the commit [1] is required in

Re: [ovs-dev] [PATCH ovn 0/4] Reduce number of flows in IN_IP_INPUT table for DNAT.

2020-06-26 Thread Numan Siddique
On Fri, Jun 26, 2020 at 7:02 PM Dumitru Ceara wrote: > On 6/26/20 3:05 PM, Numan Siddique wrote: > > > > > > On Wed, Jun 24, 2020 at 9:21 PM Dumitru Ceara > <mailto:dce...@redhat.com>> wrote: > > > > The first three patches refactor the ARP/NS

Re: [ovs-dev] [PATCH ovn v13 0/7] Incremental processing improvements.

2020-06-25 Thread Numan Siddique
On Fri, Jun 19, 2020 at 6:29 PM Numan Siddique wrote: > > > On Fri, Jun 19, 2020 at 6:09 PM Dumitru Ceara wrote: > >> On 6/19/20 1:09 PM, num...@ovn.org wrote: >> > From: Numan Siddique >> > >> > This patch series handles port binding, datapath bi

Re: [ovs-dev] [PATCH v10 ovn] Add support for DHCP domain search option (119)

2020-06-25 Thread Numan Siddique
On Thu, Jun 25, 2020 at 7:46 AM Ankur Sharma wrote: > From: Dhathri Purohith > > Domain search list is encoded according to the specifications in RFC 1035, > section 4.1.4. > > Signed-off-by: Dhathri Purohith > Signed-off-by: Ankur Sharma > Thanks. I applied this patch to master with the

Re: [ovs-dev] [PATCH v5 2/2 ovn] Add support for DHCP domain search option (119)

2020-06-22 Thread Numan Siddique
apture what changed from the previous version for your future patches :) This makes it a bit easier for the reviewers to figure out what changed between versions. One example here - https://patchwork.ozlabs.org/project/openvswitch/patch/2020062200.838586-1-num...@ovn.org/ Thanks Numan > Thanks

Re: [ovs-dev] [PATCH ovn v4] Honour router_preference for solicited RA

2020-06-18 Thread Numan Siddique
On Sat, Jun 13, 2020 at 2:50 PM Gabriele Cerami wrote: > Replies to router solicitation follow a different flow than periodic RA. > This flow currently does not honour the router_preference configuration. > > This patch modifies the flow to honour the flag, and send > router-preference

Re: [ovs-dev] [PATCH ovn v2] Honour router_preference for solicited RA

2020-06-18 Thread Numan Siddique
On Sat, Jun 13, 2020 at 2:53 PM Gabriele Cerami wrote: > On 12 Jun, Gabriele Cerami wrote: > > +/* RFC4191 section 2.2 */ > > +if (ntohs(ra->router_lifetime) == 0) { > > +ra->mo_flags &= IPV6_ND_RA_OPT_PRF_RESET_MASK; > > +} > > Sorry for the spamming, not having test

Re: [ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-18 Thread Numan Siddique
On Thu, Jun 18, 2020 at 2:00 PM Gabriele Cerami wrote: > On 17 Jun, Numan Siddique wrote: > > On Wed, Jun 17, 2020 at 3:26 PM Lorenzo Bianconi < > > lorenzo.bianc...@redhat.com> wrote: > > > > > Set packet length in lr_in_chk_pkt_len router pipeline instead

Re: [ovs-dev] [PATCH ovn] Support packet metadata marking for logical router policies.

2020-06-18 Thread Numan Siddique
Hi, Thanks for the review comments. Please see below for some comments. Thanks Numan On Thu, Jun 18, 2020 at 3:22 AM Gabriele Cerami wrote: > Hi, > > I added some note for my better understanding, but I have some questions > at the end on the testing part. > Sorry if they seem irrelevant or

Re: [ovs-dev] [PATCH ovn 2/2] Prepare for 20.03.2

2020-06-10 Thread Numan Siddique
On Wed, Jun 10, 2020 at 12:53 AM Mark Michelson wrote: > Signed-off-by: Mark Michelson > Acked-by: Numan Siddique for both the patches of the series. Numan --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 1

Re: [ovs-dev] [PATCH ovn] northd: Fix IPAM IPv4 start address calculation.

2020-06-10 Thread Numan Siddique
On Tue, Jun 9, 2020 at 12:51 PM Numan Siddique wrote: > > > On Wed, Jun 3, 2020 at 12:31 AM Mark Michelson > wrote: > >> IPAM assumes the other_config:subnet of the logical switch is a network >> address, which can result in unusual address assignments. &g

Re: [ovs-dev] [PATCH ovn] Honour router_preference for solicited RA

2020-06-10 Thread Numan Siddique
On Tue, Jun 9, 2020 at 5:29 PM Gabriele Cerami wrote: > On 09 Jun, Gabriele Cerami wrote: > > Problem is, the rest of the options assume mo_flags contains only > addr_mode, > > so there's a bit more to rework to make everything pass again. > > I got it to work reusing a single ra pointer, but

Re: [ovs-dev] [PATCH ovn v10 3/8] ovn-controller: I-P for datapath binding

2020-06-10 Thread Numan Siddique
On Wed, Jun 10, 2020 at 3:14 PM Dumitru Ceara wrote: > On 6/9/20 7:10 PM, Numan Siddique wrote: > > > > > > On Mon, Jun 8, 2020 at 9:39 PM Dumitru Ceara > <mailto:dce...@redhat.com>> wrote: > > > > On 6/8/20 3:50 PM, num...@ovn.org <mai

Re: [ovs-dev] [PATCH ovn v10 3/8] ovn-controller: I-P for datapath binding

2020-06-10 Thread Numan Siddique
On Wed, Jun 10, 2020 at 3:31 PM Numan Siddique wrote: > > > On Wed, Jun 10, 2020 at 3:14 PM Dumitru Ceara wrote: > >> On 6/9/20 7:10 PM, Numan Siddique wrote: >> > >> > >> > On Mon, Jun 8, 2020 at 9:39 PM Dumitru Ceara > > <mailto:dce...@re

Re: [ovs-dev] [PATCH ovn] Honour router_preference for solicited RA

2020-06-10 Thread Numan Siddique
On Wed, Jun 10, 2020 at 3:01 PM Gabriele Cerami wrote: > Thanks for the review! > > On 10 Jun, Numan Siddique wrote: > > > I think test cases are fine. The action parsing test case makes sure that > > the > > action is encoded properly. > > > I'm pret

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix I-P for SB Port_Binding and OVS Interface.

2020-06-10 Thread Numan Siddique
s. I'll rebase my I-P patch series and submit v12. Thanks Numan > The commit also adds two test cases to cover the above scenarios and > changes the way unit tests attach hypervisors in such way that a unit > test can first configure br-int interfaces, even if ovn-controller > hasn't sta

Re: [ovs-dev] [PATCH ovn v9 2/8] ovn-controller: I-P for SB port binding and OVS interface in runtime_data.

2020-06-03 Thread Numan Siddique
On Wed, Jun 3, 2020 at 10:49 AM Han Zhou wrote: > On Thu, May 28, 2020 at 4:05 AM wrote: > > > > From: Numan Siddique > > > > This patch handles SB port binding changes and OVS interface changes > > incrementally in the runtime_data stage which otherwise

Re: [ovs-dev] [PATCH ovn v9 8/8] ovn-controller: Handle sbrec_chassis changes incrementally.

2020-06-03 Thread Numan Siddique
On Wed, Jun 3, 2020 at 11:43 AM Han Zhou wrote: > On Thu, May 28, 2020 at 4:06 AM wrote: > > > > From: Numan Siddique > > > > When ovn-controller updates the nb_cfg column of its chassis, > > this results in full recomputation on all the nodes. This res

Re: [ovs-dev] [PATCH ovn 1/2] Set the release date for 20.03.0

2020-06-08 Thread Numan Siddique
On Mon, Jun 8, 2020 at 6:25 PM Mark Michelson wrote: > Apologies. The subject line should be "20.06.0". I'll correct it in the > merged version. > No worries. Thanks for the patches. Acked-by: Numan Siddique for both the patches in the series. Numan > > On 6/8/2

Re: [ovs-dev] [PATCH ovn] Documentation: add a quick start for prospective contributors

2020-06-08 Thread Numan Siddique
On Fri, May 22, 2020 at 8:54 PM Gabriele Cerami wrote: > This change adds a small guide that may be useful to prospective > contributors that start from scratch. > > Signed-off-by: Gabriele Cerami > Thanks for the patch and improving the OVN documentation. I see a few "WIP". Do you plan to

Re: [ovs-dev] [PATCH v4 2/2 ovn] Add support for DHCP domain search option (119)

2020-06-08 Thread Numan Siddique
On Mon, Jun 1, 2020 at 11:45 PM Ankur Sharma wrote: > From: Dhathri Purohith > > Domain search list is encoded according to the specifications in RFC 1035, > section 4.1.4. > > Signed-off-by: Dhathri Purohith > Signed-off-by: Ankur Sharma > Hi Dhathri, Thanks for the patch. Please see below

Re: [ovs-dev] [PATCH v4 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-08 Thread Numan Siddique
On Fri, Jun 5, 2020 at 4:35 AM Dhathri Purohith < dhathri.puroh...@nutanix.com> wrote: > Hi Numan, > > We have fixed the schema checksum error and split the patch into two. > Please take a look and let us know if you have any further comments. > > Thanks, > Dhathri > > On 6/1/20, 11:14 AM,

Re: [ovs-dev] [PATCH ovn v10 6/8] ovn-controller: Handle runtime data changes in flow output engine

2020-06-09 Thread Numan Siddique
On Tue, Jun 9, 2020 at 3:11 PM Dumitru Ceara wrote: > On 6/8/20 3:50 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > In order to handle runtime data changes incrementally, the flow outut > > runtime data handle should know the changed runtime data.

Re: [ovs-dev] [PATCH ovn v10 6/8] ovn-controller: Handle runtime data changes in flow output engine

2020-06-09 Thread Numan Siddique
On Tue, Jun 9, 2020 at 6:33 PM Dumitru Ceara wrote: > On 6/9/20 1:00 PM, Numan Siddique wrote: > > > > > > On Tue, Jun 9, 2020 at 3:11 PM Dumitru Ceara > <mailto:dce...@redhat.com>> wrote: > > > > On 6/8/20 3:50 PM, num...@ovn.org <mai

Re: [ovs-dev] [PATCH ovn v10 8/8] tests: Enhance ovn-performance testing by adding gw router port.

2020-06-09 Thread Numan Siddique
On Tue, Jun 9, 2020 at 4:21 PM Dumitru Ceara wrote: > On 6/8/20 3:50 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This covers the scenario of setting up/deleting of BFD tunnels > > for HA. > > > > Signed-off-by: Numan Siddique > >

Re: [ovs-dev] [PATCH ovn v10 4/8] I-P engine: Provide the option for an engine to clear tracked engine data in every run.

2020-06-08 Thread Numan Siddique
On Mon, Jun 8, 2020 at 9:42 PM Dumitru Ceara wrote: > On 6/8/20 3:50 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > A new function is added in the engine node called - clear_tracked_data() > to > > clear any engine data which was tracked during the e

Re: [ovs-dev] [PATCH ovn v10 7/8] ovn-controller: Use the tracked runtime data changes for flow calculation.

2020-06-09 Thread Numan Siddique
anges, reference of logical flows to port bindings is maintained. > > > > Co-Authored-by: Numan Siddique > > Signed-off-by: Venkata Anil > > Signed-off-by: Numan Siddique > > --- > > controller/lflow.c | 88 ++- > > co

Re: [ovs-dev] [PATCH ovn v10 3/8] ovn-controller: I-P for datapath binding

2020-06-09 Thread Numan Siddique
On Mon, Jun 8, 2020 at 9:39 PM Dumitru Ceara wrote: > On 6/8/20 3:50 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This patch adds partial support of incremental processing of datapath > binding. > > If a datapath is deleted, then a full recompute is

Re: [ovs-dev] [PATCH ovn v10 5/8] ovn-controller: I-P for ct zone and OVS interface changes in flow output stage.

2020-06-09 Thread Numan Siddique
On Tue, Jun 9, 2020 at 2:31 PM Dumitru Ceara wrote: > On 6/9/20 10:51 AM, Numan Siddique wrote: > > > > > > On Mon, Jun 8, 2020 at 11:29 PM Dumitru Ceara > <mailto:dce...@redhat.com>> wrote: > > > > On 6/8/20 3:50 PM, num...@ovn.org <mai

Re: [ovs-dev] [PATCH ovs] ovsdb idl: Try committing the pending txn in ovsdb_idl_loop_run.

2020-06-04 Thread Numan Siddique
On Thu, Jun 4, 2020 at 4:43 AM Han Zhou wrote: > On Wed, Jun 3, 2020 at 9:51 AM wrote: > > > > From: Numan Siddique > > > > The function ovsdb_idl_loop_run(), after calling ovsdb_idl_run(), > > returns a transaction object (of type 'struct ovsdb_idl_txn'). &g

Re: [ovs-dev] [PATCH ovs v2] ovsdb idl: Try committing the pending txn in ovsdb_idl_loop_run.

2020-06-05 Thread Numan Siddique
On Fri, Jun 5, 2020 at 12:39 AM Han Zhou wrote: > On Thu, Jun 4, 2020 at 11:47 AM wrote: > > > > From: Numan Siddique > > > > The function ovsdb_idl_loop_run(), after calling ovsdb_idl_run(), > > returns a transaction object (of type 'struct ovsdb_idl_txn'). &g

Re: [ovs-dev] [PATCH ovn v2] Make the notify() calls work with IPv6 in the OCF resource-agent

2020-06-05 Thread Numan Siddique
On Wed, Jun 3, 2020 at 6:14 PM Michele Baldessari wrote: > When the VIP is an IPv6 address we get the following error in the > resource agent: > ovndb_servers_notify_0:355:stderr [ + ovn-sbctl -- --id=@conn_uuid create > Connection 'target=ptcp\:6642\:[fd00:fd00:fd00:2000::a2]' >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix I-P for SB Port_Binding and OVS Interface.

2020-06-11 Thread Numan Siddique
On Thu, Jun 11, 2020 at 2:01 PM Dumitru Ceara wrote: > On 6/10/20 7:58 PM, Numan Siddique wrote: > > > > > > On Wed, Jun 10, 2020 at 10:16 PM Dumitru Ceara > <mailto:dce...@redhat.com>> wrote: > > > > The commit that introduced incremental

Re: [ovs-dev] [PATCH ovn] Fix compilation error when configured with --enable-sparse.

2020-06-11 Thread Numan Siddique
On Thu, Jun 11, 2020 at 1:44 PM Dumitru Ceara wrote: > On 6/11/20 9:23 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The below error is seen. > > > > ../controller/ovn-controller.c:2305:70: error: Using plain integer as > NULL pointer > > m

Re: [ovs-dev] [PATCH ovn] northd: By pass IPv6 Router Adv and Router Solicitation packets from ACL stages.

2020-06-11 Thread Numan Siddique
nd 134? > The document in ovn-sb.xml says: · nd expands to icmp6.type == {135, 136} && icmp6.code == 0 && ip.ttl == 255 So I think it was intended to be used for IPv6 Neighbor discovery packets and not for Router Adv/Router solicitation packets. Thanks Numan > O

Re: [ovs-dev] [PATCH ovn] northd: By pass IPv6 Router Adv and Router Solicitation packets from ACL stages.

2020-06-11 Thread Numan Siddique
On Thu, Jun 11, 2020 at 8:59 PM Numan Siddique wrote: > > > On Thu, Jun 11, 2020 at 8:13 PM Mark Michelson > wrote: > >> Hi Numan, >> >> I was a bit surprised to find that "nd" did not cover "nd_rs" and >> "nd_ra" packets a

Re: [ovs-dev] [RFC ovn 2/6] tests: Fix get_arp/get_nd tests mac-binding table id.

2020-06-11 Thread Numan Siddique
On Thu, Jun 11, 2020 at 12:30 AM Han Zhou wrote: > The table id used in test is not the same as the one used in > real implementation. Although it doesn't affect correctness, it > may cause confusion when people are studying test cases. > > Signed-off-by: Han Zhou > --- > tests/ovn.at | 8

Re: [ovs-dev] [RFC ovn 4/6] actions: Implement new actions lookup_arp_ip and lookup_nd_ip.

2020-06-11 Thread Numan Siddique
On Thu, Jun 11, 2020 at 12:31 AM Han Zhou wrote: > lookup_arp_ip and lookup_nd_ip are added to lookup if an entry exists > in MAC bindings for a given IP address, for IPv4 and IPv6 respectively. > > Signed-off-by: Han Zhou > Hi Han, I know this is RFC. I was just going through it and noticed

Re: [ovs-dev] [PATCH ovn v9 7/8] ovn-controller: Use the tracked runtime data changes for flow calculation.

2020-06-02 Thread Numan Siddique
Mark Michelson > Co-Authored-by: Numan Siddique > Signed-off-by: Venkata Anil > Signed-off-by: Numan Siddique > --- > controller/lflow.c | 69 - > controller/lflow.h | 13 +++- > controller/ovn-controller.c | 117 +++

Re: [ovs-dev] [PATCH ovn v10 4/8] I-P engine: Provide the option for an engine to clear tracked engine data in every run.

2020-06-09 Thread Numan Siddique
On Tue, Jun 9, 2020 at 1:30 PM Dumitru Ceara wrote: > On 6/8/20 7:34 PM, Numan Siddique wrote: > > > > > > On Mon, Jun 8, 2020 at 9:42 PM Dumitru Ceara > <mailto:dce...@redhat.com>> wrote: > > > > On 6/8/20 3:50 PM, num...@ovn.org <mai

Re: [ovs-dev] [PATCH ovn v10 5/8] ovn-controller: I-P for ct zone and OVS interface changes in flow output stage.

2020-06-09 Thread Numan Siddique
On Mon, Jun 8, 2020 at 11:29 PM Dumitru Ceara wrote: > On 6/8/20 3:50 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This patch handles ct zone changes and OVS interface changes > incrementally > > in the flow output stage. > > > > Any ch

Re: [ovs-dev] [PATCH ovn v10 4/8] I-P engine: Provide the option for an engine to clear tracked engine data in every run.

2020-06-09 Thread Numan Siddique
On Tue, Jun 9, 2020 at 2:35 PM Dumitru Ceara wrote: > On 6/9/20 10:46 AM, Numan Siddique wrote: > > > > > > On Tue, Jun 9, 2020 at 1:30 PM Dumitru Ceara > <mailto:dce...@redhat.com>> wrote: > > > > On 6/8/20 7:34 PM, Numan Siddique wrote: >

Re: [ovs-dev] [PATCH ovn] northd: Fix IPAM IPv4 start address calculation.

2020-06-09 Thread Numan Siddique
le, the provided 172.16.1.254/29 would be converted > internally to 172.16.1.248/29 . Therefore, the first IP address > allocated to a switch port would be 172.16.1.250. Further allocations would > continue up until 172.16.1.254. > > Reported at: https://bugzilla.redhat.com/show_bug.cg

Re: [ovs-dev] [PATCH ovn] Honour router_preference for solicited RA

2020-06-09 Thread Numan Siddique
On Sat, Jun 6, 2020 at 4:54 PM Gabriele Cerami wrote: > Replies to router solicitation follow a different flow than periodic RA. > This flow currently does not honour the router_preference configuration. > > This patch modifies the flow to honour the flag, and send > router preference

Re: [ovs-dev] [PATCH ovn v2 2/3] Use nested actions in ct_commit.

2020-07-24 Thread Numan Siddique
On Fri, Jul 24, 2020 at 1:07 AM Mark Michelson wrote: > ct_commit allow for ct_label and ct_mark to be set within. However, > there are some restrictions with the current implementation: > > * It is not possible to address the indiviual bits within the ct_mark or > ct_label. > * It is not

Re: [ovs-dev] [PATCH ovn v2 3/3] Add ECMP symmetric replies.

2020-07-24 Thread Numan Siddique
On Fri, Jul 24, 2020 at 1:07 AM Mark Michelson wrote: > When traffic arrives over an ECMP route, there is no guarantee that the > reply traffic will egress over the same route. Sometimes, the nature of > the traffic (or the intervening equipment) means that it is important > for reply traffic to

Re: [ovs-dev] [ovs-discuss] OVN nb-db and sb-db out of sync

2020-07-23 Thread Numan Siddique
On Thu, Jul 23, 2020 at 8:22 AM Tony Liu wrote: > Hi, > > I see why sb-db broke at 1568th port-binding. > The 1568th datapath-binding in sb-db references the same > > _uuid : 108cf745-db82-43c0-a9d3-afe27a41e4aa > external_ids: >

Re: [ovs-dev] [PATCH ovn 0/2] Improve ovn-detrace usability with clustered DBs.

2020-07-23 Thread Numan Siddique
On Tue, Jul 7, 2020 at 9:23 PM Dumitru Ceara wrote: > Patch 1 of the series adds support for multiple remotes when connecting > to OVSDBs. This is useful when the NB/SB DBs are clustered. > > Patch 2 of the series adds support for connecting to DB remotes via SSL. > > Signed-off-by: Dumitru

Re: [ovs-dev] [PATCH ovn v3] ovn-northd: Fix logical flows to limit ARP/NS broadcast domain.

2020-07-23 Thread Numan Siddique
On Fri, Jul 10, 2020 at 5:07 PM Numan Siddique wrote: > > > On Fri, Jul 10, 2020 at 1:27 AM Dumitru Ceara wrote: > >> Logical flows that limit the ARP/NS broadcast domain on a logical switch >> should only match on ARP requests/NS for IPs that can actually be >&g

Re: [ovs-dev] [PATCH ovn v2 2/3] Use nested actions in ct_commit.

2020-07-24 Thread Numan Siddique
On Sat, Jul 25, 2020 at 12:25 AM Mark Michelson wrote: > On 7/24/20 9:46 AM, Mark Michelson wrote: > > On 7/24/20 4:56 AM, Numan Siddique wrote: > >> > >> > >> On Fri, Jul 24, 2020 at 1:07 AM Mark Michelson >> <mailto:mmich...@redhat.com>>

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix the missing ct zone entries for container ports.

2020-07-17 Thread Numan Siddique
On Fri, Jul 17, 2020 at 6:55 PM Mark Michelson wrote: > > On 7/17/20 5:51 AM, Dumitru Ceara wrote: > > On 7/17/20 11:21 AM, num...@ovn.org wrote: > >> From: Numan Siddique > >> > >> After the commit in the Fixes tag, ovn-controller was not creating ct zo

Re: [ovs-dev] [PATCH ovn] ovn-northd: Add the option to configure probe interval

2020-07-17 Thread Numan Siddique
e to latch on to connections for a long time due to the > short inactivity probe interval value. Hi Girish, Thanks for reporting the issue. I'll take a look into it next week. Thanks Numan > > Regards, > ~Girish > > On Wed, Mar 4, 2020 at 10:54 PM Numan Siddique wrote:

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix the missing flows with monitor-all set to True

2020-07-15 Thread Numan Siddique
On Thu, Jul 16, 2020 at 1:34 AM Dumitru Ceara wrote: > > On 7/15/20 7:56 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > When the config ovn-monitor-all is set to True, then ovn-controller is not > > programming the flows completely when it binds the

<    8   9   10   11   12   13   14   15   16   17   >