Re: [ovs-dev] [PATCH] northd-ddlog: Fix compilation error.

2021-05-27 Thread Numan Siddique
On Thu, May 27, 2021 at 7:09 PM Ben Pfaff wrote: > > On Thu, May 27, 2021 at 06:47:04PM -0400, num...@ovn.org wrote: > > From: Numan Siddique > > > > After the commit in the Fixes tag, compilation is failing with > > the below error: > > > > ddlog -i ../

Re: [ovs-dev] [PATCH ovn] northd: Avoid memory reallocation while building lb rules.

2021-06-01 Thread Numan Siddique
On Tue, May 25, 2021 at 4:46 AM Dumitru Ceara wrote: > > On 5/20/21 9:02 PM, Ilya Maximets wrote: > > This is one of the hottest points in the northd in case of big number > > of load balancers and we're reallocating matches and actions several > > times for each vIP for each load balancer. > > >

Re: [ovs-dev] [PATCH ovn 1/2] Prepare for 21.06.0

2021-06-01 Thread Numan Siddique
On Tue, Jun 1, 2021 at 6:30 AM Ilya Maximets wrote: > > On 5/27/21 9:55 PM, Mark Michelson wrote: > > Signed-off-by: Mark Michelson > > --- > > NEWS | 2 +- > > configure.ac | 2 +- > > debian/changelog | 4 ++-- > > 3 files changed, 4 insertions(+), 4 deletions(-) > > > > Hi, Ma

Re: [ovs-dev] [PATCH ovn v2] ovs: Include monitor condition expected seqno fix.

2021-06-01 Thread Numan Siddique
On Thu, May 20, 2021 at 10:27 AM Ilya Maximets wrote: > > On 5/18/21 8:49 AM, Dumitru Ceara wrote: > > When setting monitor conditions ovsdb_cs_db_set_condition() returns the > > sequence number when it is expected that all updates that correspond to > > the new condition have been received. This

Re: [ovs-dev] [PATCH ovn v8 1/4] ovn-controller: Split logical flow and physical flow processing.

2021-06-01 Thread Numan Siddique
On Sun, May 30, 2021 at 11:45 PM wrote: > > From: Numan Siddique > > Presently, the 'flow_output' engine node recomputes physical > flows by calling physical_run() in the 'physical_flow_changes' > handler in some scenarios. Because of this, an engine run

Re: [ovs-dev] [PATCH ovn v8 1/4] ovn-controller: Split logical flow and physical flow processing.

2021-06-02 Thread Numan Siddique
On Wed, Jun 2, 2021 at 2:22 AM Han Zhou wrote: > > On Tue, Jun 1, 2021 at 5:10 PM Numan Siddique wrote: > > > > On Sun, May 30, 2021 at 11:45 PM wrote: > > > > > > From: Numan Siddique > > > > > > Presently, the 'flow_output' eng

Re: [ovs-dev] [PATCH ovn] ovn-sbctl: Fix lflow-list (etc.) in daemon mode and upon races.

2021-06-03 Thread Numan Siddique
bctl's stdout. > > Signed-off-by: Ben Pfaff > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1965780 > Reported-by: Alexey Roytman Acked-by: Numan Siddique Numan > --- > utilities/ovn-sbctl.c | 151 ++ > 1 file changed, 7

Re: [ovs-dev] [PATCHv2 ovn] ovn-controller: Allow configuration of tunnel DF bits

2022-05-17 Thread Numan Siddique
On Fri, May 13, 2022 at 8:34 AM Jochen Friedrich via dev < ovs-dev@openvswitch.org> wrote: > Add ovn-encap-df_default configuration option to set df_default on OVN > tunnels. > > Signed-off-by: Jochen Friedrich > Thanks for the v2. The patch LGTM. Can you please also add the documentation abou

Re: [ovs-dev] [PATCH ovn] physical.c: Avoid NULL ptr deref in populate_remote_chassis_macs

2022-05-17 Thread Numan Siddique
; char *chassis_mac_bridge = strtok_r(token, ":", &save_ptr2); > char *chassis_mac_str = strtok_r(NULL, "", &save_ptr2); > +if(!chassis_mac_str) { > As per the coding guidelines, this should be if (!chassis_mac_str) I think Mark/Ha

Re: [ovs-dev] [PATCH ovn v3] controller/binding: prevent claiming container lport to ovs bridge

2022-05-17 Thread Numan Siddique
On Wed, Apr 27, 2022 at 8:39 AM Mohammad Heib wrote: > currently ovn-controller allow users to claim lport of type container > to ovs bridge which is invalid use-case. > > This patch will prevent such invalid use-cases by ignoring the claiming > requests for container lports and will throw a warn

Re: [ovs-dev] [PATCH ovn] tests: fixed multiple flaky tests

2022-05-17 Thread Numan Siddique
On Tue, May 17, 2022 at 1:47 PM Mark Michelson wrote: > Thanks for this, Xavier. I really like seeing new macros being added to > the testsuite to increase reliability. > > Acked-by: Mark Michelson > Thanks for improving the test cases. Applied to the main branch. Numan > > On 5/12/22 05:23,

Re: [ovs-dev] [PATCH ovn] northd: Honor ct-snat-zone option for common case.

2022-05-17 Thread Numan Siddique
se this zone when > possible. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2061619 > > Signed-off-by: Mark Michelson > Thanks for fixing this. Acked-by: Numan Siddique Numan > --- > controller/lflow.c | 18 + > include/ovn/actions.h|

Re: [ovs-dev] [PATCH ovn] utilities: nbctl: dump lbs in load_balancer group running {ls, lr}-lb-list

2022-05-18 Thread Numan Siddique
On Tue, May 10, 2022 at 4:22 PM Mark Michelson wrote: > Thanks for this, Lorenzo. > > Acked-by: Mark Michelson > Thanks. I applied this patch to the main branch. Numan > > On 4/27/22 06:47, Lorenzo Bianconi wrote: > > Dump load balancers belonging to the load_balancer groups attached to the

Re: [ovs-dev] [PATCH ovn v2] Do not set 'up' attribute in the port-binding table if ovn-northd is at an older version.

2022-05-18 Thread Numan Siddique
On Tue, May 17, 2022 at 9:55 AM Mark Michelson wrote: > OK thanks for the explanations, Xavier and Mary. This is pretty > important since we expect that ovn-controller should be upgraded before > ovn-northd. > > I'm acking the patch because the content is correct. I suggest that when > this is me

Re: [ovs-dev] [PATCH ovn 0/3] Adding generic port security flows.

2022-05-18 Thread Numan Siddique
On Mon, May 16, 2022 at 5:42 PM Numan Siddique wrote: > > > On Mon, May 16, 2022 at 4:27 PM Mark Michelson > wrote: > >> Hi Numan, >> >> I've taken a close look at the patches in this series, and they seem >> really good. They're very well comm

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Consider zone 0 as a valid zone when restoring.

2022-05-18 Thread Numan Siddique
On Wed, May 18, 2022 at 4:41 PM Mark Michelson wrote: > > Looks good to me Dumitru. > > Acked-by: Mark Michelson Thanks Dumiru and Mark. I applied this patch to the main branch and backported to branch-22.03 and branch-21.12. Numan > > On 5/18/22 13:47, Dumitru Ceara wrote: > > 0 is a valid z

Re: [ovs-dev] [PATCH ovn] Allow for setting the Next server IP in the DHCP header

2022-05-18 Thread Numan Siddique
On Wed, May 11, 2022 at 11:34 AM wrote: > > From: Lucas Alvares Gomes > > In order to PXE boot a baremetal server using the OVN DHCP server we > need to allow users to set the "next-server" (siaddr) [0] field in the > DHCP header. > > While investigating this issue by comparing the DHCPOFFER and

Re: [ovs-dev] [PATCH] classifier: adjust segment boundary to execute prerequisite processing

2022-05-19 Thread Numan Siddique
or me. > I also ran the test after reverting just the C code changes in this patch and > correctly fails as expected. The Megaflow in the test has a ",nd_target=::" > at the end, which the test correctly picks up as a failure. The test is > correctly doing its job! > >

Re: [ovs-dev] [PATCH ovn v8 1/3] Update port-up on main chassis only

2022-05-19 Thread Numan Siddique
f-by: Ihar Hrachyshka The patch LGTM. Acked-by: Numan Siddique Your 2nd patch is not applying cleanly. Can you please respin another version of the series ? You can add my Acked-by tag in the v9 patch 1. Thanks Numan > --- > controller/binding.c| 9 ++--- > controller/b

Re: [ovs-dev] [PATCH ovn] ovs-sandbox: Allow specifying initial contents for OVS and VTEP databases.

2022-05-19 Thread Numan Siddique
On Thu, May 19, 2022 at 4:17 PM Mark Michelson wrote: > > Acked-by: Mark Michelson > > Since this is a new feature introduced after soft freeze for 22.06, this > shouldn't be a candidate for 22.06. However, personally I feel this is > so low-risk (and so useful) that it should be included. Does a

Re: [ovs-dev] [PATCH ovn v2 0/3] Adding generic port security flows.

2022-05-19 Thread Numan Siddique
ct/ovn/patch/20220519201733.2184302-1-num...@ovn.org/ Numan > > On 5/19/22 11:17, num...@ovn.org wrote: > > From: Numan Siddique > > > > This patch series adds generic logical flows for port security in > > the logical switch pipeline and pushes the actual port secu

Re: [ovs-dev] [PATCH ovn v2 1/2] Prepare for 22.06.0.

2022-05-19 Thread Numan Siddique
ex 1cdba4bfc..74d4029ff 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,5 +1,5 @@ > -Post v22.03.0 > -- > +OVN v22.06.0 - XX XXX XXX Looks like you missed out an 'X' as Ilya mentioned in v1. I suppose you can correct it before applying. Acked-by: Numan Siddique

Re: [ovs-dev] [PATCH ovn v2 2/2] Prepare for post-22.06.0.

2022-05-19 Thread Numan Siddique
On Thu, May 19, 2022 at 4:15 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH ovn] ovs-sandbox: Allow specifying initial contents for OVS and VTEP databases.

2022-05-19 Thread Numan Siddique
On Thu, May 19, 2022 at 4:19 PM Numan Siddique wrote: > > On Thu, May 19, 2022 at 4:17 PM Mark Michelson wrote: > > > > Acked-by: Mark Michelson > > > > Since this is a new feature introduced after soft freeze for 22.06, this > > shouldn't be a candid

Re: [ovs-dev] [PATCH ovn] Allow for setting the Next server IP in the DHCP header

2022-05-19 Thread Numan Siddique
On Thu, May 19, 2022 at 4:11 AM Lucas Alvares Gomes wrote: > > Hi, > > Thanks Numan for the review. See the replies below. > > On Thu, May 19, 2022 at 12:36 AM Numan Siddique wrote: > > > > On Wed, May 11, 2022 at 11:34 AM wrote: > > > > > > Fr

Re: [ovs-dev] [PATCH ovn 1/2] physical.c: Move localport remote output flow definition

2022-05-24 Thread Numan Siddique
On Mon, May 23, 2022 at 4:46 AM Ales Musil wrote: > > The localport should always delegate traffic locally, > move the definition into consider_port_binding as > the physical_run is not evaluated during I-P. > > Reported-at: https://bugzilla.redhat.com/2076604 > Signed-off-by: Ales Musil > --- H

Re: [ovs-dev] [PATCH ovn v2] physical.c: Avoid NULL ptr deref in populate_remote_chassis_macs

2022-05-24 Thread Numan Siddique
On Mon, May 23, 2022 at 12:56 AM Ales Musil wrote: > > When the "ovn-chassis-mac-mappings" had wrong format it would > crash the ovn-controller as it tried to deref NULL pointer. > > Add check if the token is a valid pointer, if not log warning > and skip this value. > > Reported-at: https://bugzi

Re: [ovs-dev] [PATCHv3 ovn] ovn-controller: Allow configuration of tunnel DF bits

2022-05-26 Thread Numan Siddique
On Wed, May 25, 2022 at 1:11 PM Jochen Friedrich via dev wrote: > > Add ovn-encap-df_default configuration option to set df_default on OVN > tunnels. > > Signed-off-by: Jochen Friedrich Thanks. I applied this patch to the main branch. I also added a NEWS entry for this and added you to the AU

Re: [ovs-dev] [PATCH ovn v2 2/2] binding.c: Make sure that localport is removed from local datapath

2022-05-26 Thread Numan Siddique
On Wed, May 25, 2022 at 2:52 AM Ales Musil wrote: > > When localport is removed from NB, and it is the last port > remaining on the host, it is not part of local datapath > anymore. Which can cause troubles when there is recompute > happening in between the removal from NB and the removal > of int

Re: [ovs-dev] [PATCH ovn v10 3/4] Clone packets to all port chassis

2022-05-26 Thread Numan Siddique
On Thu, May 26, 2022 at 12:19 PM Ihar Hrachyshka wrote: > > When multiple chassis are set in requested-chassis, port binding is > configured in multiple cluster locations. In case of live migration > scenario, only one of the locations run a workload at a particular > point in time. Yet, it's expe

Re: [ovs-dev] [PATCH ovn v3 2/2] binding.c: Make sure that localport is removed from local datapath

2022-05-27 Thread Numan Siddique
On Fri, May 27, 2022 at 3:38 AM Ales Musil wrote: > > When localport is removed from NB, and it is the last port > remaining on the host, it is not part of local datapath > anymore. Which can cause troubles when there is recompute > happening in between the removal from NB and the removal > of int

Re: [ovs-dev] [PATCH ovn v10 2/4] Support LSP:options:requested-chassis as a list

2022-05-27 Thread Numan Siddique
s, these fields are lists. > > Signed-off-by: Ihar Hrachyshka There's one minor comment below. With that addressed: Acked-by: Numan Siddique > --- > NEWS | 1 + > controller/binding.c | 294 --- > con

Re: [ovs-dev] [PATCH ovn v10 3/4] Clone packets to all port chassis

2022-05-27 Thread Numan Siddique
On Thu, May 26, 2022 at 9:54 PM Numan Siddique wrote: > > On Thu, May 26, 2022 at 12:19 PM Ihar Hrachyshka wrote: > > > > When multiple chassis are set in requested-chassis, port binding is > > configured in multiple cluster locations. In case of live migration >

Re: [ovs-dev] [Patch ovn] OVN - Add Support for Remote Port Mirroring

2022-05-30 Thread Numan Siddique
Hi Abhiram, Thanks for the patch. Please see below for some comments. On Mon, May 9, 2022 at 12:14 PM Abhiram R N wrote: > > On Mon, May 09, 2022 at 03:34:47PM +0530, Abhiram R N wrote: > > Hi Ihar, > > > > > On Fri, May 06, 2022 at 07:46:17PM -0400, Ihar Hrachyshka wrote: > > > Hi Abhiram,

Re: [ovs-dev] [PATCH ovn] ci: Add UB Sanitizer.

2022-05-30 Thread Numan Siddique
On Mon, May 30, 2022 at 3:15 PM Dumitru Ceara wrote: > > Pick up latest OVS UB fixes too, specifically: > c8c49a9db9f2 ("netdev-linux: Properly access 32-bit aligned > rtnl_link_stats64 structs.") > a5cc859a4228 ("ofp-actions: Use aligned structures when decoding ofp > actions.") > 08c3e5e

Re: [ovs-dev] [RFC PATCH ovn 0/3] Add ovn drop debugging

2022-06-01 Thread Numan Siddique
On Wed, May 11, 2022 at 2:45 PM Mark Michelson wrote: > > On 5/10/22 12:27, Adrian Moreno wrote: > > [...] > > > Some good alternatives to using the lflow UUID as a datapath > identifier would be > > * The value of the OXM_METADATA register. > * The southbound datapath_bin

Re: [ovs-dev] [PATCH ovn] northd: add the capability to inherit logical routers lbs on logical switches

2022-06-01 Thread Numan Siddique
On Thu, May 19, 2022 at 2:23 PM Lorenzo Bianconi wrote: > > Add the capability to automatically deploy a load-balancer on each > logical-switch connected to a logical router where the load-balancer > has been installed by the CMS. This patch allow to overcome the > distributed gw router scenario l

Re: [ovs-dev] [PATCH ovn 1/1] IPsec: Add option to force NAT-T encapsulation

2022-06-01 Thread Numan Siddique
On Wed, Jun 1, 2022 at 11:39 AM Andreas Karis wrote: > > Provide an option to enforce NAT-T UDP > encapsulation (encapsulation=true or forceencaps=true depending on the > chosen backend). This may be required in environments where firewalls > drop ESP traffic but where NAT-T detection fails becaus

Re: [ovs-dev] [PATCH ovn] northd: Use ct_lb_mark only when all chassis support it.

2022-06-01 Thread Numan Siddique
On Wed, Jun 1, 2022 at 12:52 PM Mark Michelson wrote: > > Thanks Dumitru. This looks good to me. > > Acked-by: Mark Michelson Thanks Dumitru. I applied this patch to main and branch-22.06. Looks like it's not applying cleanly to branch-22.03. Numan > > On 6/1/22 10:36, Dumitru Ceara wrote:

Re: [ovs-dev] [PATCH ovn v3 1/1] IPsec: Add option to force NAT-T encapsulation

2022-06-02 Thread Numan Siddique
detection fails because packets are not > subject to NAT. > > Signed-off-by: Andreas Karis > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2041681 Thanks. Acked-by: Numan Siddique Numan > --- > Documentation/tutorials/ovn-ipsec.rst

Re: [ovs-dev] [PATCH v12 ovn] Implement RARP activation strategy for ports

2022-06-02 Thread Numan Siddique
On Wed, Jun 1, 2022 at 7:00 PM Ihar Hrachyshka wrote: > > This is the remaining piece in multi-chassis series. This new version > has no flow modification done in pinctrl thread. Instead, I-P engine > is notified of any newly activated ports, which then triggers pflow > update for lports. > > Ihar

Re: [ovs-dev] [PATCH ovn branch-22.03 0/2] Release patches for v22.03.1.

2022-06-03 Thread Numan Siddique
s(+), 3 deletions(-) For both the patches: Acked-by: Numan Siddique Numan > > -- > 2.31.1 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >

Re: [ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.1.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.2.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH ovn branch-22.06 1/2] Set release date for 22.06.0.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 2 +- > debian/changelog | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn branch-21.12 1/2] Set release date for 21.12.2.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn branch-21.12 2/2] Prepare for 21.12.3.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:56 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH ovn branch-22.06 2/2] Prepare for 22.06.1.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH ovn 2/2] northd.c: Add option to enable MAC learning on localnet

2022-06-03 Thread Numan Siddique
On Wed, Jun 1, 2022 at 8:28 AM Ales Musil wrote: > > The localnet is excluded from MAC learning for scale > reason. However there might be a valid workflow > when yo uwant to enable the learning and benefit > for that for HW offload. Add option called > 'localnet_learn_fdb' to LSP, which will enab

Re: [ovs-dev] [PATCH ovn v2 0/2] Add option to enable MAC learning on localnet port

2022-06-06 Thread Numan Siddique
On Mon, Jun 6, 2022 at 6:47 AM Ales Musil wrote: > > Add new option for LSP called 'localnet_learn_fdb', > which will allow localnet LSP to add entries to FDB > when set to true. The default is false. > > --- > v2: Address comments and rebase on main Thanks for the v2. I applied both the patches

Re: [ovs-dev] [PATCH v2 ovn] northd: add the capability to inherit logical routers lbs on logical switches

2022-06-06 Thread Numan Siddique
On Wed, Jun 1, 2022 at 3:43 PM Lorenzo Bianconi wrote: > > Add the capability to automatically deploy a load-balancer on each > logical-switch connected to a logical router where the load-balancer > has been installed by the CMS. This patch allow to overcome the > distributed gw router scenario li

Re: [ovs-dev] [PATCH v3 ovn] northd: add the capability to inherit logical routers lbs on logical switches

2022-06-07 Thread Numan Siddique
router scenario limitation where a load-balancer must be > installed on each datapath to properly reach the load-balancer. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2043543 > Signed-off-by: Lorenzo Bianconi Thanks for the rebase. Acked-by: Numan Siddique Numa

Re: [ovs-dev] [PATCH RFC ovn] nb: Remove possibility of disabling logical datapath groups.

2022-06-08 Thread Numan Siddique
On Wed, Jun 8, 2022 at 1:19 AM Han Zhou wrote: > > On Tue, Jun 7, 2022 at 8:20 AM Dumitru Ceara wrote: > > > > In large scale scenarios this option hugely reduces the size of the > > Southbound database positively affecting end to end performance. In > > such scenarios there's no real reason to

Re: [ovs-dev] [RFC ovn 0/2] Basic eBPF/XDP support in OVN.

2022-06-08 Thread Numan Siddique
f its possible to leverage eBPF/XDP for this. > On Wed, 8 Jun 2022 at 14:43, Han Zhou wrote: > > > On Mon, May 30, 2022 at 5:46 PM wrote: > > > > > > From: Numan Siddique > > > > > > XDP program - ovn_xdp.c added in this RFC patch series impleme

Re: [ovs-dev] [PATCH v5 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-13 Thread Numan Siddique
On Thu, Jun 9, 2022 at 2:47 PM Mark Michelson wrote: > > I added Ihar's Ack and my Ack to both patches and pushed them to main, > branch-22.06, branch-22.03, and branch-21.12. > Looks like this patch or the other one has caused regressions. "ovn-ctl start_northd" is not starting ovn-northd. -- /

Re: [ovs-dev] [PATCH ovn 1/2] Fix pidfile_is_running when $cmd is not passed

2022-06-13 Thread Numan Siddique
On Mon, Jun 13, 2022 at 3:00 PM Ihar Hrachyshka wrote: > > [ -z $string ] needs double quotes to handle zero-length strings > properly. > > Fixes: 09dc4866fd32 ("Handle re-used pids in pidfile_is_running") > Signed-off-by: Ihar Hrachyshka I still see the same issue with this patch. If I remove

Re: [ovs-dev] [PATCH ovn 2/2] ovn-ctl: [ -s $file ] implies [ -e $file ]

2022-06-13 Thread Numan Siddique
On Mon, Jun 13, 2022 at 3:00 PM Ihar Hrachyshka wrote: > > Signed-off-by: Ihar Hrachyshka With this patch I also applied, I see the below error /usr/share/ovn/scripts/ovn-ctl: line 53: test: syntax error: `-s' unexpected I think it should be - test -s "$pidfile" && Thanks Numan > ---

Re: [ovs-dev] [PATCH ovn v2] Fix pidfile_is_running when $cmd is not passed

2022-06-14 Thread Numan Siddique
On Mon, Jun 13, 2022 at 8:59 PM Ihar Hrachyshka wrote: > > FYI checked that with -fake-multinode. Also checked that if I modify > start_northd to pass $cmd (as ovsdb-server), it also correctly matches > it (and failing when $cmd is anything different). Thanks for fixing this issue. The function

Re: [ovs-dev] [PATCH ovn v15] Implement RARP activation strategy for ports

2022-06-14 Thread Numan Siddique
On Tue, Jun 14, 2022 at 1:08 AM Han Zhou wrote: > > On Mon, Jun 13, 2022 at 6:07 PM Ihar Hrachyshka wrote: > > > > On Mon, Jun 13, 2022 at 6:30 PM Han Zhou wrote: > > > > > > > > > > > > On Mon, Jun 13, 2022 at 11:41 AM Ihar Hrachyshka > wrote: > > > > > > > > When options:activation-strategy

Re: [ovs-dev] [PATCH ovn v15] Implement RARP activation strategy for ports

2022-06-14 Thread Numan Siddique
On Tue, Jun 14, 2022 at 1:26 PM Ihar Hrachyshka wrote: > > On Tue, Jun 14, 2022 at 1:02 PM Numan Siddique wrote: > > > > On Tue, Jun 14, 2022 at 1:08 AM Han Zhou wrote: > > > > > > On Mon, Jun 13, 2022 at 6:07 PM Ihar Hrachyshka > > > wrote: >

Re: [ovs-dev] [ovn patch v2 ]OVN-CI: remove ddlog test cases.

2022-06-17 Thread Numan Siddique
On Wed, Jun 15, 2022 at 5:33 AM Dumitru Ceara wrote: > > On 6/9/22 14:27, Mohammad Heib wrote: > > currently there is no new changes applied to the ddlog code base > > in ovn and we keep skipping ddlog test cases in our ci runs which leads > > to so many skips lines printed to the ci logs and that

Re: [ovs-dev] [PATCH ovn v18] Implement RARP activation strategy for ports

2022-06-17 Thread Numan Siddique
On Thu, Jun 16, 2022 at 3:50 PM Mark Michelson wrote: > > On 6/15/22 21:42, Ihar Hrachyshka wrote: > > For this version, the IP engine still doesn't trigger _run functions > > nor iterative handlers when ovsdb commit fails and no ovsdb > > transaction is available, so activation flows are not flus

Re: [ovs-dev] [PATCH ovn v18] Implement RARP activation strategy for ports

2022-06-17 Thread Numan Siddique
' On Fri, Jun 17, 2022 at 5:26 PM Numan Siddique wrote: > > On Thu, Jun 16, 2022 at 3:50 PM Mark Michelson wrote: > > > > On 6/15/22 21:42, Ihar Hrachyshka wrote: > > > For this version, the IP engine still doesn't trigger _run functions > > > nor

Re: [ovs-dev] [OVN v2] OVN - Add Support for Remote Port Mirroring

2022-06-17 Thread Numan Siddique
On Mon, Jun 13, 2022 at 9:53 AM Abhiram R N wrote: > > Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. > While Mirror creation just creates the mirror, the lsp-attach-mirror > triggers the sequence to create Mirror in OVS DB on compute node. > OVS already supports Port Mirrori

Re: [ovs-dev] [PATCH v3 ovn] northd: add the capability to inherit logical routers lbs on logical switches

2022-06-17 Thread Numan Siddique
On Tue, Jun 7, 2022 at 9:07 AM Numan Siddique wrote: > > On Mon, Jun 6, 2022 at 6:44 PM Lorenzo Bianconi > wrote: > > > > Add the capability to automatically deploy a load-balancer on each > > logical-switch connected to a logical router where the load-balancer > &

Re: [ovs-dev] [PATCH ovn v19] Implement RARP activation strategy for ports

2022-06-20 Thread Numan Siddique
On Fri, Jun 17, 2022 at 8:55 PM Ihar Hrachyshka wrote: > > When options:activation-strategy is set to "rarp" for LSP, when used in > combination with multiple chassis names listed in > options:requested-chassis, additional chassis will install special flows > that would block all ingress and egres

Re: [ovs-dev] [PATCH ovn v4 1/1] IPsec: Add option to force NAT-T encapsulation

2022-06-22 Thread Numan Siddique
On Mon, Jun 6, 2022 at 12:54 PM Andreas Karis wrote: > > Provide options to enforce NAT-T UDP encapsulation. Options are > encapsulation=true for libreswan and forceencaps=true for strongswan. > This may be required in environments where firewalls drop ESP > traffic but where NAT-T detection fails

Re: [ovs-dev] [PATCH ovn v2 0/6] MAC binding aging mechanism

2022-06-24 Thread Numan Siddique
On Fri, Jun 24, 2022 at 11:49 AM Han Zhou wrote: > > On Fri, Jun 24, 2022 at 1:11 AM Ales Musil wrote: > > > > Hi Han, > > > > after our discussion I did he suggested test and the throughput does not > seem to be affected, > > I did the test with aging set to 2 sec, and during the test period (36

Re: [ovs-dev] [PATCH v3] ovsdb idl: Add the support to specify the uuid for row insert.

2022-06-24 Thread Numan Siddique
On Wed, Jun 15, 2022 at 1:59 PM wrote: > > From: Numan Siddique > > ovsdb-server already supports specifying the uuid in the insert > transaction by the client. But the C IDL client library was > missing this feature. This patch adds this support. > > For each schema

Re: [ovs-dev] [PATCH] python: Add Python bindings TODO file.

2022-06-27 Thread Numan Siddique
On Mon, Jun 27, 2022 at 11:27 AM Terry Wilson wrote: > > On Mon, Jun 27, 2022 at 5:44 AM Dumitru Ceara wrote: > > > > For now include the IDL related TODO items as discussed at: > > https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393516.html > > > > Signed-off-by: Dumitru Ceara > > ---

Re: [ovs-dev] [PATCH ovn v2] northd.c: Add flow to skip put_nd action if ip6.src or nd.sll is 0

2022-06-29 Thread Numan Siddique
On Wed, Jun 29, 2022 at 8:27 AM Dumitru Ceara wrote: > > On 6/29/22 07:47, Ales Musil wrote: > > The ip6.src or nd.sll does not have to be always set. > > According to rfc4861: > > > > Source Address > > Either an address assigned to the interface from > >

Re: [ovs-dev] [PATCH ovn] ovn-northd.at: Add OVN_FOR_EACH_NORTHD around LR NB Static_MAC_Binding table

2022-06-29 Thread Numan Siddique
On Wed, Jun 29, 2022 at 8:30 AM Dumitru Ceara wrote: > > On 6/29/22 07:47, Ales Musil wrote: > > This is continuation after discussion during review on > > 80187a803 (ovn-northd: Add flow to use eth.src if nd.tll is 0 > > in put_nd() action.) > > > > Signed-off-by: Ales Musil > > --- > > Looks go

Re: [ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-04 Thread Numan Siddique
On Mon, Jul 4, 2022 at 7:48 AM Vladislav Odintsov wrote: > > Hi, > > we’ve found a wrong behaviour with service_monitor record status for a > health-checked Load Balancer. > Its status can stay online forever even if virtual machine is stopped. This > leads to load balanced traffic been sent to

Re: [ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-04 Thread Numan Siddique
no longer claimed by any ovn-controller. I'm more inclined to handle this in ovn-northd. What do you think? Thanks Numan > > Regards, > Vladislav Odintsov > > > On 4 Jul 2022, at 19:51, Numan Siddique wrote: > > > > On Mon, Jul 4, 2022 at 7:48 AM Vladislav Odin

Re: [ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-05 Thread Numan Siddique
c->logical_port: sw1-p1, > svc->status: online > > I guess this is a result of my misunderstanding of principle of incremental > engine operation. > Can you help to get an idea of why port_binding structure has stale state and > how to "pull changes" for it? >

Re: [ovs-dev] [PATCH ovn v4] OVN-CI: Add test cases with monitor-all enabled.

2022-07-05 Thread Numan Siddique
On Fri, Jul 1, 2022 at 4:18 PM Dumitru Ceara wrote: > > On 6/30/22 13:59, Mohammad Heib wrote: > > currently ovn ci only has one test case with the option > > ovn-monitor-all enabled, this patch will add one more > > execution with option ovn-monitor-all=true for each test case that > > are wrappe

Re: [ovs-dev] [PATCH ovn] northd: set svc_mon status to offline if port_binding released

2022-07-07 Thread Numan Siddique
On Tue, Jul 5, 2022 at 1:54 PM Vladislav Odintsov wrote: > > This patch fixes situation where a Load Balancer > has corresponding Load_Balancer_Health_Check and > current checks are successful. This means > Service_Monitor record in SBDB has status == "online". > > In case VM (or container) stops

Re: [ovs-dev] [PATCH v2 ovn] Always funnel multichassis port traffic through tunnels

2022-07-07 Thread Numan Siddique
On Fri, Jul 1, 2022 at 1:52 PM Mark Michelson wrote: > > Looks good to me. Thanks, Ihar. > > Acked-by: Mark Michelson > > On 6/24/22 18:35, Ihar Hrachyshka wrote: > > Before the patch, for switches with a localnet port, > > > > - traffic to a multichassis port was funneled through tunnels; but >

Re: [ovs-dev] [PATCH v2 ovn] Always funnel multichassis port traffic through tunnels

2022-07-11 Thread Numan Siddique
On Fri, Jul 8, 2022 at 9:22 AM Ihar Hrachyshka wrote: > > On Thu, Jul 7, 2022 at 4:39 PM Numan Siddique wrote: > > > > On Fri, Jul 1, 2022 at 1:52 PM Mark Michelson wrote: > > > > > > Looks good to me. Thanks, Ihar. > > > > > > Acked-

Re: [ovs-dev] [PATCH ovn] Use _[add, del]value to manage additional_[chassis, encap]

2022-07-11 Thread Numan Siddique
On Wed, Jun 29, 2022 at 3:06 PM Mark Michelson wrote: > > Wow, nice improvement, Ihar! > > Acked-by: Mark Michelson Thanks. I applied this patch to the main branch. Numan > > On 6/29/22 12:47, Ihar Hrachyshka wrote: > > Signed-off-by: Ihar Hrachyshka > > --- > > controller/binding.c | 63 +

Re: [ovs-dev] [PATCH ovn] fix typo

2022-07-11 Thread Numan Siddique
On Mon, Jul 11, 2022 at 4:35 AM Dumitru Ceara wrote: > > On 7/11/22 11:23, Igor Zhukov wrote: > > From: Igor Zhukov > > > > Signed-off-by: Igor Zhukov > > Acked-by: Dumitru Ceara > > --- Thanks for the fix. I applied this patch to the main branch. I also added your name to the AUTHORS.rst fi

Re: [ovs-dev] [PATCH ovn] Build tests with asan and ubsan together to reduce CI time.

2022-07-11 Thread Numan Siddique
On Mon, Jul 11, 2022 at 6:16 AM Ales Musil wrote: > > Hi Igor, > > thank you for the patch. Yeah I was not quick enough to reply on the PR :) > > Acked-by: Ales Musil Thanks for the patch. Can you please split this patch into 2 patches. Patch 1 to fix the memory leak in utilities/ovn-dbctl.c a

Re: [ovs-dev] [PATCH ovn] Build tests with asan and ubsan together to reduce CI time.

2022-07-11 Thread Numan Siddique
On Mon, Jul 11, 2022 at 1:45 PM Dumitru Ceara wrote: > > On 7/11/22 19:55, Numan Siddique wrote: > > On Mon, Jul 11, 2022 at 6:16 AM Ales Musil wrote: > >> > >> Hi Igor, > >> > >> thank you for the patch. Yeah I was not quick enough to r

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Fix priority arg of lrp-set-gateway-chassis

2022-07-11 Thread Numan Siddique
On Fri, Jul 8, 2022 at 2:45 AM Ales Musil wrote: > > When the lrp-set-gateway-chassis was followed by chained > command (--) the command tried to parse -- as priority > when the priority was not specified. > > Check if the command argument count is actually 4 > instead of checking argv[3]. > > Rep

Re: [ovs-dev] [RFC ovn] controller: send GARPs for LSPs in vlan-backed network scenario

2022-07-14 Thread Numan Siddique
On Thu, Jul 14, 2022 at 3:36 AM Lorenzo Bianconi wrote: > > > On 7/13/22 18:07, Lorenzo Bianconi wrote: > > >> On 6/17/22 00:31, Lorenzo Bianconi wrote: > > >>> When using VLAN backed networks and OVN routers leveraging the > > >>> 'ovn-chassis-mac-mappings' option, the eth.src field is replaced b

Re: [ovs-dev] [PATCH ovn] Cancel previous runs in the PR when you push new commits

2022-07-14 Thread Numan Siddique
On Wed, Jul 13, 2022 at 6:53 AM Ales Musil wrote: > > Ok, thanks. > > Acked-by: Ales Musil > Thanks. I applied this patch to the main branch. Numan > On Wed, Jul 13, 2022 at 1:50 PM Igor Zhukov wrote: > > > Yes, as far as I understand. > > I found some github repos also use it: > > https://g

Re: [ovs-dev] [PATCH ovn] ci: Use CFLAGS instead of OVS_CFLAGS

2022-07-14 Thread Numan Siddique
On Tue, Jul 12, 2022 at 4:04 PM Mark Michelson wrote: > > Thanks Ales. > > Acked-by: Mark Michelson Thanks. I applied this patch to the main branch. Numan > > On 7/12/22 02:30, Ales Musil wrote: > > The OVS_CFLAGS variable is for internal use only. > > Use regular CFLAGS instead. This also ha

Re: [ovs-dev] [PATCH ovn] tests: Fix flaky "interconnection - IGMP/MLD multicast" test.

2022-07-15 Thread Numan Siddique
On Thu, Jul 14, 2022 at 5:00 AM Dumitru Ceara wrote: > > Make sure the IGMP/MLD group is learned and processed before sending > traffic. Otherwise the IP multicast packets get dropped. > > Spotted in one of the ovsrobot runs: > https://github.com/ovsrobot/ovn/runs/7321368564?check_suite_focus=tru

Re: [ovs-dev] [PATCH v4] ovsdb idl: Add the support to specify the uuid for row insert.

2022-07-18 Thread Numan Siddique
On Tue, Jul 12, 2022 at 6:02 AM Ilya Maximets wrote: > > On 6/29/22 18:57, num...@ovn.org wrote: > > From: Numan Siddique > > > > ovsdb-server allows the OVSDB clients to specify the uuid for > > the row inserts [1]. The C IDL client library is missing this >

Re: [ovs-dev] [OVN v3] OVN - Add Support for Remote Port Mirroring

2022-07-18 Thread Numan Siddique
On Wed, Jun 22, 2022 at 1:36 PM Abhiram R N wrote: > > Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. > While Mirror creation just creates the mirror, the lsp-attach-mirror > triggers the sequence to create Mirror in OVS DB on compute node. > OVS already supports Port Mirrori

Re: [ovs-dev] [RFC ovn] controller: send GARPs for LSPs in vlan-backed network scenario

2022-07-19 Thread Numan Siddique
On Thu, Jul 14, 2022 at 1:30 PM Dumitru Ceara wrote: > > On 7/14/22 17:35, Numan Siddique wrote: > > On Thu, Jul 14, 2022 at 3:36 AM Lorenzo Bianconi > > wrote: > >> > >>> On 7/13/22 18:07, Lorenzo Bianconi wrote: > >>>>> On 6/17/22 00:31

Re: [ovs-dev] [PATCH ovn 1/4] multicast: Document reserved multicast groups.

2022-07-19 Thread Numan Siddique
On Tue, Jul 5, 2022 at 7:09 AM Dumitru Ceara wrote: > > Signed-off-by: Dumitru Ceara Thanks. I applied this patch to the main branch. Numan > --- > lib/mcast-group-index.h | 26 +- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/lib/mcast-group-i

Re: [ovs-dev] [PATCH ovn 2/4] tests: Add 'IP-multicast' keyword to all relevant tests.

2022-07-19 Thread Numan Siddique
On Tue, Jul 5, 2022 at 7:09 AM Dumitru Ceara wrote: > > Signed-off-by: Dumitru Ceara Thanks. I applied this patch to the main branch. Numan > --- > tests/ovn.at|7 --- > tests/system-ovn.at |2 +- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tests/

Re: [ovs-dev] [PATCH ovn 3/4] tests: Factor out reset_pcap_file() helper.

2022-07-19 Thread Numan Siddique
On Tue, Jul 5, 2022 at 7:11 AM Dumitru Ceara wrote: > > Signed-off-by: Dumitru Ceara Thanks for this patch. The below test cases is failing with this patch 347. ovn.at:14447: 347. localnet connectivity with multiple requested-chassis -- ovn-northd -- parallelization=yes -- ovn_monitor_all=yes

Re: [ovs-dev] [PATCH ovn 4/4] multicast: Properly flood IGMP queries and reports.

2022-07-19 Thread Numan Siddique
, > > this will expire at some point) > > > > What I did was to change ML2/OVN to set mcast_flood to False on the > > LSPs, apply the series of patches in OVN and then run the tests. > > > > Tested-By: > > https://review.opendev.org/c/openstack/neutron

Re: [ovs-dev] [PATCH ovn] ovn-ic: do not learn routes with link-local next-hops

2022-07-19 Thread Numan Siddique
On Tue, Jul 12, 2022 at 2:25 PM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks. I applied this patch to the main branch and backported to branch-22.06. I will be backporting to branch-22.03 soon (running tests). Numan > > On 6/24/22 05:41, Lorenzo Bianconi wrote: > > Do not learn

Re: [ovs-dev] [PATCH ovn] ovn-trace: implement chk_lb_hairpin_reply and ct_snat_to_vip actions

2022-07-19 Thread Numan Siddique
On Fri, Jul 1, 2022 at 1:41 PM Mark Michelson wrote: > > Thanks for this Lorenzo, > > Acked-by: Mark Michelson Thanks. I applied this patch to the main branch. Numan > > On 6/30/22 09:22, Lorenzo Bianconi wrote: > > Add chk_lb_hairpin_reply and ct_snat_to_vip implementations for ovn-trace > >

Re: [ovs-dev] [PATCH v2 ovn] lflow: fix possible use-after-free in add_lb_vip_hairpin_reply_action

2022-07-19 Thread Numan Siddique
On Mon, Jul 18, 2022 at 6:48 AM Dumitru Ceara wrote: > > On 7/16/22 08:45, Lorenzo Bianconi wrote: > > ofpbuf_put_zeros routine can rellocate the buffer if the requested size > > is bigger than buffer tailroom. Reload ol pointer before running > > ofpact_finish_LEARN in order to avoid a possible u

Re: [ovs-dev] [PATCH ovn] pinctrl: del redundant row.

2022-07-19 Thread Numan Siddique
On Fri, Jul 15, 2022 at 8:33 AM wangchuanlei wrote: > > The row of code is useless, need to be deleted. > > Signed-off-by: wangchuanlei Thanks. I applied this patch to the main branch. Numan > --- > controller/pinctrl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/controller/pinct

Re: [ovs-dev] [PATCH ovn] pinctrl: fix ovn-controller abort when service start.

2022-07-19 Thread Numan Siddique
On Fri, Jul 15, 2022 at 8:35 AM wangchuanlei wrote: > > Hi, > when start service ovn-controller, the br-int may be not connected, in > case, swconn->version = -1, > on my enviroment, i have loadlalancer, in the process of sending health > check packet, ofp_proto is 0, which will leads

<    1   2   3   4   5   6   7   8   9   10   >