-by: Xavier Simonart
---
tests/system-ovn.at | 55 ++---
1 file changed, 27 insertions(+), 28 deletions(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index aadd68634..345384223 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -1449,42
Hi Mark
Thanks for your feedback, and sorry for delay as I moved to other
tasks...
On Thu, 2021-08-05 at 15:57 +0100, Mark Gray wrote:
> On 04/08/2021 10:01, Xavier Simonart wrote:
> > This test sends requests to LB and checks that each server receives
> > at
> > least one r
*wait_column "true" nb:Logical_Switch_Port up name=sw0-p1*
Thanks
Xavier
On Thu, Sep 16, 2021 at 11:40 AM Mark Gray wrote:
> On 15/09/2021 09:52, Xavier Simonart wrote:
> > Test was waiting for port to be up in SBDB before checking number of
> flows
>
> Would this feature pr
) is
installed.
Also fixed small typo in logging (for the same test).
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2004390
Fixes: f8a81693b0 ("ovn-controller: Fix the missing flows with monitor-all set
to True")
Signed-off-by: Xavier Simonart
---
tests/o
ction for lb with no backends")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1989517
Signed-off-by: Xavier Simonart
---
v1 -> v2
* Address the fact that tcpdump sends to stderr
---
tests/system-ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/sy
ction for lb with no backends")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1989517
Signed-off-by: Xavier Simonart
---
tests/system-ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 4288d80e5..2d21fb
This test sends requests to LB and checks that each server receives at
least one request. However, even if 20 requests are sent to 3 servers,
there was a possibility that one server did not get any request (0.3%).
Signed-off-by: Xavier Simonart
---
tests/system-ovn.at | 115
/show_bug.cgi?id=1858221
Signed-off-by: Xavier Simonart
---
tests/system-common-macros.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index b742a2cb9..616a87fcf 100644
--- a/tests/system-common-macros.at
+++ b
This test sends requests to LB and checks that each server receives at
least one request. However, even if 20 requests are sent to 3 servers,
there was a possibility that one server did not get any request (0.3%).
Signed-off-by: Xavier Simonart
---
tests/system-ovn.at | 115
This test was failing randomly, probably on slow systems.
It was waiting for gratuitous ARP which were potentially generated earlier.
Fixes: 1c9e46ab ("northd: add check_pkt_larger lflows for ingress traffic")
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 23 +++--
With those two minor changes, OVN could add its own statistics.
Do you think that such changes to the OVS stopwatch could be accepted
upstream?
Thanks
Xavier
On Thu, Oct 14, 2021 at 9:39 PM Aaron Conole wrote:
> Xavier Simonart writes:
>
> > Hi Aaron
> >
> > Thanks for l
: f8a81693b0 ("ovn-controller: Fix the missing flows with monitor-all set
to True")
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 28 ++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 172b5c713..080991b89 100644
-
, but check whether ARP responder has been installed
by counting the number of flows related to it.
Thanks
Xavier
On Thu, Sep 16, 2021 at 1:23 PM Xavier Simonart wrote:
> Hi Mark
>
> Thanks for looking into this.
> Yes and no... I do not think that the patch itself will help, but it
export calc_percentile function (and percentile struct) so that
it can be used in other libraries such as OVN.
Signed-off-by: Xavier Simonart
---
lib/stopwatch.c | 24 +---
lib/stopwatch.h | 26 ++
2 files changed, 27 insertions(+), 23 deletions
:
- VLAN transparency, passthru=true, multiple hosts
- VLAN transparency, passthru=true, multiple hosts, custom ethtype
- VLAN transparency, passthru=true, multiple hosts, flat/untagged
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 21 -
1 file changed, 20 insertions(+), 1
Hi
I have the following question on when ovn is reporting a port to be up if
conditional monitoring is enabled.
In the current ovn master, if conditional monitoring is enabled, a port is
reported up too early i.e. before all related flows are properly installed
in ovs.
Packets sent through ovs
Openflow tables OFTABLE_REMOTE_OUTPUT, OFTABLE_LOCAL_OUTPUT
and OFTABLE_CHECK_LOOPBACK numbering changed, but documentation
was not updated.
Fixes: dd94f1266c ("northd: MAC learning: Add logical flows for fdb.")
Signed-off-by: Xavier Simonart
---
controller/physic
k \!parallelization=yes" to run all tests
If less than four physical cores are available, then 1 socket/four cores
dummy-numa
is used to excercice parallel northd
Signed-off-by: Xavier Simonart
---
tests/ovn-macros.at | 17 ++---
tests/ovs-macros.at | 6 +-
2 files chang
- options:requested-chassis for logical port
- NAT and Load Balancer flows
- 2LSs IGMP and MLD
- Dynamic neighbor between LRs
- (userspace test) conntrack TCP reset
- Dont flood fill local datapaths beyond distributed gateway port
- 1 LR with distributed router gateway port
Signed-off-by: Xavier
Hi Dumitru
On Mon, Mar 21, 2022 at 12:02 PM Dumitru Ceara wrote:
> On 3/21/22 10:56, Xavier Simonart wrote:
> > - send gratuitous arp on localnet
> > - send gratuitous arp for nat ips in localnet
> > - dns lookup : 1 HV, 2 LS, 2 LSPs/LS -- ovn-northd -- dp-groups=yes
>
On gateway routers egress packets might be both:
- unDNATted
- SNATted
Reply packets should not be SNATted (they must of course be UnDNATted
if DNAT was applied).
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2061593
Signed-off-by: Xavier Simonart
---
northd/northd.c | 1
;, causing the test to fail
from time to time. The test case was also updated as part of this patch
to check that ovn-installed was always properly set.
Signed-off-by: Xavier Simonart
---
v2: Remove debugging leftover, add back empty line and rebase.
---
controller/binding.c | 2 +-
tests/ovn.at
The issue might have caused potential memory leaks or crashes in northd
Signed-off-by: Xavier Simonart
---
northd/northd.c | 100
1 file changed, 67 insertions(+), 33 deletions(-)
diff --git a/northd/northd.c b/northd/northd.c
index 2fb0a93c2
On gateway routers egress packets might be both:
- unDNATted
- SNATted
Reply packets should not be SNATted (they must of course be UnDNATted
if DNAT was applied).
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2061593
Signed-off-by: Xavier Simonart
---
v2: replaced "<<
- send gratuitous arp on localnet
- send gratuitous arp for nat ips in localnet
- dns lookup : 1 HV, 2 LS, 2 LSPs/LS -- ovn-northd -- dp-groups=yes
- send gratuitous arp for NAT rules on distributed router
- 2 HVs, 1 lport/HV, localport ports
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 20
;
> On 10/1/21 11:12, Mark Gray wrote:
> > On 01/10/2021 14:26, Xavier Simonart wrote:
> >> Tests were waiting for ports to be reported up before sending packets.
> >> However, waiting for both ports to be up is not enough to guarantee
> >> that all flows a
transparency, passthru=true, multiple hosts
- VLAN transparency, passthru=true, multiple hosts, custom ethtype
- VLAN transparency, passthru=true, multiple hosts, flat/untagged
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 37 -
1 file changed, 36 insertions(+), 1
Hi Mark
Thanks for fixing this. Nice catch...
Should the --dummy-numa option not also be added to northd documentation?
Does the --dummy-numa option have any other effect than setting the number
of threads? I mean does it have for instance any "numa" or pinning effect?
e.g. is there any
;, causing the test to fail
from time to time. The test case was also updated as part of this patch
to check that ovn-installed was always properly set.
Signed-off-by: Xavier Simonart
---
controller/binding.c | 2 +-
tests/ovn.at | 10 +-
2 files changed, 10 insertions(+), 2 deletion
Hi Ales
Thanks for the fix and help decreasing the duration of the testsuite.
I have one comment (we are unexpectedly skipping some clang system tests)
- see embedded below.
I was also wondering:
Some parts of northd would not be covered anymore by testing. I agree that
those non-covered parts
should have been added
Thanks
Xavier
On Fri, Sep 15, 2023 at 11:59 PM Numan Siddique wrote:
> On Fri, Sep 15, 2023 at 3:09 AM Ales Musil wrote:
> >
> > On Fri, Sep 15, 2023 at 8:21 AM Xavier Simonart
> wrote:
> > >
> > > QoS was not configured in OVS db when d
.
This issue was identified by some random failures in system test
"egress qos".
Signed-off-by: Xavier Simonart
---
v2: - rebased on origin/main
- handled comments from Ales
---
controller/binding.c| 133
controller/binding.h
Hi Mark
Thanks for the review and the comments.
On Mon, Sep 25, 2023 at 9:48 PM Mark Michelson wrote:
>
> Hi Xavier,
>
> Functionality-wise, this looks good. I have a couple of small comments
> though.
>
> On 9/20/23 11:45, Xavier Simonart wrote:
> > Before this patc
Those extra flows are added when 1st localnet_learn_fdb is enabled.
They are however not removed if/when last localnet_learn_fdb got disabled.
Signed-off-by: Xavier Simonart
---
controller/binding.c| 12
controller/binding.h| 3 +++
controller/lflow.c | 28
Move the submodule to the tip of OVS branch3.2. This picks up:
- 0d0e95cd2ae6 ("ovsdb: Fix potential leak when making diff of conditions.")
fixing multiple memory leaks in OVN unit tests.
Signed-off-by: Xavier Simonart
---
ovs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
When a logical switch port was deleted and added back quickly, it could
happen that the lsp was never reported up
Signed-off-by: Xavier Simonart
---
northd/northd.c | 17 +++--
tests/ovn.at| 45 +
2 files changed, 56 insertions(+), 6
We might get less recomputes than expected: e.g. Port_Binding->chassis and
Port_Binding->up might be received by northd within the same idl transaction.
Signed-off-by: Xavier Simonart
---
v2: check number of recomputes within bounds (min/max) instead of just a max.
v3: lflow and sync
if localnet_learn_fdb is
not
enabled.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2242830
Signed-off-by: Xavier Simonart
---
controller/lflow.c | 37 -
controller/lflow.h | 1 +
controller/lport.c | 22 ++-
controller/lport.h | 4
Xavier Simonart (2):
controller: FDB entries for localnet should not overwrite entries for
vifs
controller: avoid extra flows if localnet_learn_fdb is disabled
controller/binding.c | 12 ++
controller/binding.h | 3 +
controller/lflow.c | 51
The following tests:
- ipam
- ipam connectivity
- ipam to non-ipam
set the mac_prefix using nbctl.
However, it can happen that both northd and nbctl sets the mac_prefix
at the same time, which might result in the mac_prefix from nbctl to
be dropped.
Signed-off-by: Xavier Simonart
---
tests
As otherwise ports might be down before the recompute and up after,
causing the test to fail. This error happened with
"LSP incremental processing" tests.
Signed-off-by: Xavier Simonart
---
tests/ovn-northd.at | 40
1 file changed, 24 inserti
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/ovn.at b/tests/ovn.at
index 637d92bed..a855392fc 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -26366,10 +26366,13 @@ check ovn-nbctl lsp-add ts ts-lr3 \
wait_for_ports_up
ovn_as
"kill pid" does not wait for process to be terminated.
Wait for ovsdb-server termination before restarting it.
Signed-off-by: Xavier Simonart
---
tests/ovn-nbctl.at | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index
The test was sometimes failing if IPv6 packets were received.
Signed-off-by: Xavier Simonart
---
tests/system-ovn-kmod.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/system-ovn-kmod.at b/tests/system-ovn-kmod.at
index 2492b9412..fb95ba881 100644
--- a/tests
Xavier Simonart (5):
tests: fixed "interconnection - static multicast" and "- IGMP/MLD
multicast"
tests: fixed system test "LR with SNAT fragmentation needed for
external server".
tests: fixed "ovn-nbctl - daemon retry connection"
tes
if localnet_learn_fdb is
not
enabled.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2242830
Signed-off-by: Xavier Simonart
---
v2: ovn.at update: check PACKET_IN2 count from ovs-vswitchd.log
---
controller/lflow.c | 37 -
controller/lflow.h | 1 +
controller/lport.c
Those extra flows are added when 1st localnet_learn_fdb is enabled.
They are however not removed if/when last localnet_learn_fdb got disabled.
Signed-off-by: Xavier Simonart
---
controller/binding.c| 12
controller/binding.h| 3 +++
controller/lflow.c | 28
*** BLURB HERE ***
Xavier Simonart (2):
controller: FDB entries for localnet should not overwrite entries for
vifs
controller: avoid extra flows if localnet_learn_fdb is disabled
controller/binding.c | 12 ++
controller/binding.h | 3 +
controller/lflow.c
succeeded).
Test case has been adapted so that ct_zone recompute usually happens
before adding the sw0-lr0 port.
Signed-off-by: Xavier Simonart
---
v2: - updated comment as suggested by Dumitru
- rebased on origin/main
---
controller/ovn-controller.c | 5 +++--
tests/ovn.at
_node (recompute_allowed=true, node=0x7ffd19ba5b70) at
lib/inc-proc-eng.c:503
13 engine_run (recompute_allowed=recompute_allowed@entry=true) at
lib/inc-proc-eng.c:528
14 0x0040ade2 in main (argc=, argv=) at
controller/ovn-controller.c:5709
Signed-off-by: Xavier Simonart
---
v2: Fixed p
module to recompute.
This patch fixed issues two and three by moving the work of setting pb->chassis
and pb->up to the if-status module.
Signed-off-by: Xavier Simonart
---
v2: Avoid clearing iface if already deleted
v3: - handled Mark's feedback i.e.
- clear comment in claimed_lpo
Signed-off-by: Xavier Simonart
---
controller/binding.c | 74 +---
1 file changed, 36 insertions(+), 38 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
index 8020d052f..9a09b2074 100644
--- a/controller/binding.c
+++ b/controller
Signed-off-by: Xavier Simonart
---
controller/binding.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/controller/binding.c b/controller/binding.c
index bd48db621..cc316f390 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -1841,7 +1841,9
Xavier Simonart (3):
binding: slight refactor if no local binding in consider_iface_release
binding: handle pb->chassis and pb->up from if-status module
Fix flows not removed in ha migration
controller/binding.c| 221 ++--
controller/bin
This patch fixes the segfault but might cause a memory leak. I'll send a v2
There is also an (unrelated) flaky test ("Check default openflow
flows") which will be fixed later in a different patch
Thanks
Xavier
On Mon, Oct 23, 2023 at 12:04 PM Xavier Simonart wrote:
>
> W
Hi
Thanks Ilya for the review.
Comments below. I'll send a v2
Xavier
On Wed, Sep 20, 2023 at 9:05 PM Ilya Maximets wrote:
> On 9/20/23 19:28, Xavier Simonart wrote:
> > OVN unit tests highlight this:
> >
> > ERROR: LeakSanitizer: detected memory leaks
> > Direc
nter 5 5 5 -1` to indicate that the number could
> actually be 5 - 1 and we'd still consider that a pass.
>
> What do you think?
>
> On 9/18/23 12:47, Xavier Simonart wrote:
> > We might get less recomputes than expected: e.g. Port_Binding->chassis
> and
> > Po
e tests.
We could change the tests for this, or update ovn-controller so that it
only starts looping when pinctrl is connected
Thanks
Xavier
On 9/18/23 12:46, Xavier Simonart wrote:
> > Xavier Simonart (15):
> >tests: fixed multiple ovn-ic tests
> >tests: fixed "Lo
Signed-off-by: Xavier Simonart
---
controller/binding.c | 74 +---
1 file changed, 36 insertions(+), 38 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
index fd08aaafa..dbd2d52b7 100644
--- a/controller/binding.c
+++ b/controller
Signed-off-by: Xavier Simonart
---
controller/binding.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/controller/binding.c b/controller/binding.c
index fff631e7f..d7dd84a1b 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -1853,7 +1853,9
as
the binding module.
Signed-off-by: Xavier Simonart
---
controller/binding.c | 2 +-
controller/binding.h | 3 +++
controller/if-status.c | 11 ++-
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
index fd08aaafa..dda4c9162
succeeded).
Test case has been adapted so that ct_zone recompute usually happens
before adding the sw0-lr0 port.
Signed-off-by: Xavier Simonart
---
controller/ovn-controller.c | 1 +
tests/ovn.at| 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/cont
ver, when pb->chassis is finally updated by sb (to the new hv), flows were
not re-installed, as runtime_data was not seen as updated.
This caused some random failures in test "external logical port".
Signed-off-by: Xavier Simonart
---
controller/binding.c | 1 +
1 file changed, 1 in
re failing
if more garp were received, and were slower than expected as always waiting for
a few additional packets).
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 297 +++
1 file changed, 88 insertions(+), 209 deletions(-)
diff --git a/tests/ovn.
phase, as otherwise there is no guarentee that packet are
fully handled when
we update the ACL rules.
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 76
1 file changed, 41 insertions(+), 35 deletions(-)
diff --git a/tests/ovn.at b/tests
Fixes: 0c89c0fddb4f ("tests: fixed another flake in "send gratuitous ARP for
NAT rules on HA distributed router"")
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index
Multiple ovn-ic tests change routes in az1 and check whether the routes are
properly
updated in az2. Some of those tests add some ovn-nbctl --wait=sb sync in az2.
However, if ovn-ic processes are slow for whatever reasons, such tests might
have failed.
Signed-off-by: Xavier Simonart
---
tests
trim_zeros was redefined multiple times in ovn.at, and was
undefined for one test.
Signed-off-by: Xavier Simonart
---
tests/ovn-macros.at | 4
tests/ovn.at| 53 -
2 files changed, 4 insertions(+), 53 deletions(-)
diff --git a/tests/ovn
module to recompute.
This patch fixed issues two and three by moving the work of setting pb->chassis
and pb->up to the if-status module.
Signed-off-by: Xavier Simonart
---
controller/binding.c| 122 -
controller/binding.h| 18 +
controll
At test startup, there is no guarantee that northd gets the lock instead of
northd-backup.
Some northd tests query northd using "as northd ovn-appctl -t ovn-northd ..".
Hence those query might go to the inactive northd, and tests were randomly
failing.
Signed-off-by: Xavier Simonart
- dhcpv4 : 1 HV, 2 LS
- Remote port binding
- MLD snoop/querier/relay
- basic connectivity with multiple requested-chassis
Signed-off-by: Xavier Simonart
---
tests/ovn-northd.at | 2 +-
tests/ovn.at| 15 +++
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git
Remote output flows are setup when binding of remote port is received.
Hence those flows can be setup after ports have been reported up.
- 3 HVs, 1 VIFs/HV, 1 software GW, 1 LS
- 3 HVs, 3 LS, 3 lports/LS, 1 LR
- 2 HVs, 2 LRs connected via LS, gateway router
Signed-off-by: Xavier Simonart
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/ovn.at b/tests/ovn.at
index 863f7c71d..31e41c012 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -34484,6 +34484,7 @@ AT_CLEANUP
OVN_FOR_EACH_NORTHD([
AT_SETUP([MAC binding aging
There is no guarantee that ovn-northd and not its 'backup' gets
the lock. Hence we need to check both logs.
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index d4e0016e5..02c763593 100644
The test was sometimes failing if an arp packet was received
after installing priority=0 flow, and before installing
the flow matching arp.
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index
Signed-off-by: Xavier Simonart
---
tests/ovn-ipsec.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn-ipsec.at b/tests/ovn-ipsec.at
index 10ef97878..f8df8d60e 100644
--- a/tests/ovn-ipsec.at
+++ b/tests/ovn-ipsec.at
@@ -48,11 +48,11 @@ ovn-nbctl set nb_global
We might get less recomputes than expected: e.g. Port_Binding->chassis and
Port_Binding->up might be received by northd within the same idl transaction.
Signed-off-by: Xavier Simonart
---
tests/ovn-northd.at | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tes
The test was checking if a lport was properly released, but in
some race condition the logging message is slighly different.
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 6aabe985b
Both tests were randomly failing as not properly checking that ovn-controller
really exited.
Fixes: 4caf8da7e81b ("tests: fixed "Encaps tunnel cleanup does not interfere
with multiple controller on the same host"")
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 7 +++
Xavier Simonart (15):
tests: fixed multiple ovn-ic tests
tests: fixed "Logical router policy packet marking"
tests: fixed "options:requested-chassis for logical port"
tests: tests fixed "Encaps tunnel cleanup ..." and "ovn-controller
exit"
t
Signed-off-by: Xavier Simonart
---
controller/binding.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/controller/binding.c b/controller/binding.c
index 92ca3ebbe..bac38fc5f 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -1853,7 +1853,9
Signed-off-by: Xavier Simonart
---
controller/binding.c | 74 +---
1 file changed, 36 insertions(+), 38 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
index fd08aaafa..dbd2d52b7 100644
--- a/controller/binding.c
+++ b/controller
module to recompute.
This patch fixed issues two and three by moving the work of setting pb->chassis
and pb->up to the if-status module.
Signed-off-by: Xavier Simonart
---
v2: Avoid clearing iface if already deleted
---
controller/binding.c| 122 --
/master-ovn/ovs/ovsdb/ovsdb-server.c:224:9
#12 0x512e80 in main /root/master-ovn/ovs/ovsdb/ovsdb-server.c:507:5
#13 0x7f9ecf675b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
Signed-off-by: Xavier Simonart
---
ovsdb/monitor.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion
-server.c:417:9
11 0x517550 in main_loop ovsdb/ovsdb-server.c:224:9
12 0x512e80 in main ovsdb/ovsdb-server.c:507:5
13 0x7f9ecf675b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
Fixes: ef1da757f016 ("ovsdb: condition: Process condition changes
incrementally.")
Signed-off-
_node (recompute_allowed=true, node=0x7ffd19ba5b70) at
lib/inc-proc-eng.c:503
13 engine_run (recompute_allowed=recompute_allowed@entry=true) at
lib/inc-proc-eng.c:528
14 0x0040ade2 in main (argc=, argv=) at
controller/ovn-controller.c:5709
Signed-off-by: Xavier Simonart
---
contr
-by: Xavier Simonart
---
ic/ovn-ic.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c
index e2023c2ba..bb91bad11 100644
--- a/ic/ovn-ic.c
+++ b/ic/ovn-ic.c
@@ -2216,10 +2216,19 @@ main(int argc, char *argv[])
ovn_db_run
Signed-off-by: Xavier Simonart
---
ic/ovn-ic.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c
index e2023c2ba..eec466ec4 100644
--- a/ic/ovn-ic.c
+++ b/ic/ovn-ic.c
@@ -1630,13 +1630,18 @@ collect_lr_routes(struct ic_context *ctx,
const
Xavier Simonart (5):
tests: fixed multiple tests not properly waiting for packets to be
received
tests: do not start backup-northd by default
tests: fixed "LSP incremental processing"
tests: fixed "ipsec -- basic configuration"
tests: wait for all flows to be inst
re failing
if more garp were received, and were slower than expected as always waiting for
a few additional packets).
Signed-off-by: Xavier Simonart
---
v2: rebased on origin/main
---
tests/ovn.at | 268 ---
1 file changed, 81 insertions(+), 187 deletion
We might get less recomputes than expected: e.g. Port_Binding->chassis and
Port_Binding->up might be received by northd within the same idl transaction.
Signed-off-by: Xavier Simonart
---
v2: check number of recomputes within bounds (min/max) instead of just a max
---
tests/ovn-northd.a
Remote output flows are setup when binding of remote port is received.
Hence those flows can be setup after ports have been reported up.
- 3 HVs, 1 VIFs/HV, 1 software GW, 1 LS
- 3 HVs, 3 LS, 3 lports/LS, 1 LR
- 2 HVs, 2 LRs connected via LS, gateway router
Signed-off-by: Xavier Simonart
-northd might hide a northd crash.
- Some tests expects northd.log (and not northd-backup.log) to contain some
specific strings. Having northd-backup running makes such tests to fail
flakily.
Signed-off-by: Xavier Simonart
---
v2: do not start northd-backup instead of fixing test cases 1 by 1
Signed-off-by: Xavier Simonart
---
v2: rebased on origin/main
---
tests/ovn-ipsec.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn-ipsec.at b/tests/ovn-ipsec.at
index 10ef97878..f8df8d60e 100644
--- a/tests/ovn-ipsec.at
+++ b/tests/ovn-ipsec.at
@@ -48,11
Hi Mark, Dumitru
Thanks for the feedback
On Fri, Oct 6, 2023 at 12:57 PM Dumitru Ceara wrote:
>
> On 10/6/23 09:08, Dumitru Ceara wrote:
> > Hi Xavier, Mark,
> >
> > On 9/21/23 15:27, Xavier Simonart wrote:
> >> Hi Mark
> >>
> >> Tha
be immediately
visible in different az.
- Expecting routes updates between az to happen immediately.
Reported-at: https://issues.redhat.com/browse/FDP-98
Signed-off-by: Xavier Simonart
---
tests/ovn-ic.at | 44 ++--
1 file changed, 26 insertions(+), 18
Hi Han
Thanks for looking into this and for your feedback.
Please see comments below
On Tue, May 17, 2022 at 8:03 AM Han Zhou wrote:
>
>
> On Thu, May 12, 2022 at 2:04 AM Xavier Simonart
> wrote:
> >
> > When VIF ports are claimed on a chassis, SBDB Port_Bi
ion is disabled.
Otherwise an error is thrown.
Note that, if set-n-threads failed for any reason (e.g. failure to setup some
semaphore), parallelization is disabled, and get-n-thread will return 1.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2078552
Signed-off-by: Xavier Simonart
---
argument (--ovn-northd-n-threads) has also been added to
ovn-ctl.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2078552
Signed-off-by: Xavier Simonart
---
v2: - handled Dumitru's comments
- added missing mutex_destroy
- fixed issue when use_logical_dp_group is enabled after
Hi Dumitru
Thanks for the review.
I'll go through your suggestions and submit a v2.
Just commented here on your question - see embedded.
Thanks
Xavier
On Fri, May 13, 2022 at 2:46 PM Dumitru Ceara wrote:
> Hi Xavier,
>
> On 5/12/22 11:04, Xavier Simonart wrote:
> > When VIF po
1 - 100 of 347 matches
Mail list logo
