As commented, previously flex_array was used because "we can have large
hash-table without large contiguous kernel memory".
Actually how large can the flow hash table can be? Will this backport
affect currently supported hash table size?
Thanks,
Yifeng
On Wed, Mar 27, 2019 at 9:06 AM 0-day
I've create a pull request on github as v2 because this patch contains
long lines that can't be handled by email protocol.
https://github.com/openvswitch/ovs/pull/278
Thanks,
Yifeng
On Mon, Mar 18, 2019 at 10:42 AM Yifeng Sun wrote:
>
> Thanks Darrell for the review. Will do.
&g
)
by 0x58566F: dpctl_unixctl_handler (dpctl.c:2589)
by 0x52D660: process_command (unixctl.c:308)
by 0x52D660: run_connection (unixctl.c:342)
by 0x52D660: unixctl_server_run (unixctl.c:393)
by 0x407366: main (ovs-vswitchd.c:126)
Signed-off-by: Yifeng Sun
---
lib/dpif-netlink.c | 8
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13432
Signed-off-by: Yifeng Sun
---
tests/oss-fuzz/odp_target.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/oss-fuzz/odp_target.c b/tests/oss-fuzz/odp_target.c
index a7a8bbffcaa7..ae61cdca322f
; On Fri, Mar 15, 2019 at 7:20 PM Yifeng Sun wrote:
>
>> These fragment-related tests are failing on later kernels (4.19.x)
>> because kernel quietly drops any packet fragment that is not the last
>> but has a size smaller than IPV6_MIN_MTU. This patch fixes
>> them by
Looks good to me, thanks.
Reviewed-by: Yifeng Sun
On Sat, Mar 16, 2019 at 11:50 AM Darrell Ball wrote:
> The macro 'OVS_CHECK_KERNEL' was checking for maximum supported kernel
> version. This means checks like 'OVS_CHECK_KERNEL(3, 10, 4, 18)'
> in various tests need to be updated
These fragment-related tests are failing on later kernels (4.19.x)
because kernel quietly drops any packet fragment that is not the last
but has a size smaller than IPV6_MIN_MTU. This patch fixes
them by increasing their sizes to IPV6_MIN_MTU.
Signed-off-by: Yifeng Sun
---
tests/system
/yifsun/ovs-travis/builds/507034016
Signed-off-by: Yifeng Sun
---
.travis.yml | 2 +
NEWS | 2 +
acinclude.m4 | 20 -
datapath/conntrack.c | 72
Looks good to me, thanks.
Reviewed-by: Yifeng Sun
On Tue, Feb 12, 2019 at 12:37 PM Greg Rose wrote:
> Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations
> and to build this the kernel compilation requires the libelf-dev
> package. Add the dependency to the d
Thanks Greg for reviewing, I ran the tests locally and there is no issue.
Ben, could you backport this patch to 2.11 if you can? thanks!
Yifeng
On Tue, Jan 29, 2019 at 4:45 PM Gregory Rose wrote:
>
> On 1/29/2019 2:18 PM, Yifeng Sun wrote:
> > No code changing is necessary to su
No code changing is necessary to support 4.18.x.
Only one kernel test failed and it is in the process of being fixed.
Updated .travis.yml to include 4.18.x and also use latest 4.17 version.
Updated test files to test 4.18 kernel.
Signed-off-by: Yifeng Sun
---
.travis.yml
ts the log file because this test doesn't
dpends on the log file.
Fixes: e8833217914f9c071c49 ("system-traffic.at: avoid a race condition on
monitor log")
CC: David Marchand
Signed-off-by: Yifeng Sun
---
tests/system-traffic.at | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tes
re skipped by kernel 4.15 and older versions.
Kernel 4.16 and later kernels start showing this failure.
Signed-off-by: Yifeng Sun
---
lib/dpif-netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index dfa9d9199a73..e23a35da4
Thanks Darrell, I will send a new version tomorrow.
On Thu, Jan 31, 2019 at 5:19 PM Darrell Ball wrote:
> Minor comments about the commit message Yifeng
>
> On Thu, Jan 31, 2019 at 3:10 PM Yifeng Sun wrote:
>
>> Test "flow resume with geneve tun_m
ts the log file because this test doesn't
depend on the log file.
Fixes: e8833217914f9c071c49 ("system-traffic.at: avoid a race condition on
monitor log")
CC: David Marchand
Signed-off-by: Yifeng Sun
---
v1->v2: Fixed commit message by Darrell's suggestion, thanks Darrell!
test
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12557
Signed-off-by: Yifeng Sun
---
include/openvswitch/ofp-actions.h | 4
lib/ofp-actions.c | 5 +
2 files changed, 9 insertions(+)
diff --git a/include/openvswitch/ofp-actions.h
b/include/openvswitch
`encap = nl_msg_start_nested(key, OVS_KEY_ATTR_ENCAP)` ensures that
key->size >= (encap + NLA_HDRLEN), so the `if` statement is safe.
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11306
Signed-off-by: Yifeng Sun
---
lib/odp-util.c | 4
1 file changed, 4 inse
Thanks for the fix. I am wondering if we can output some useful information
in 'struct ds' for this case?
On Mon, Feb 4, 2019 at 3:45 PM Ashish Varma
wrote:
> Added the check for NULL in "next_ct_states" argument passed to the
> "ofproto_trace()" function. Under normal scenario, this is
Thanks Ben, please backport to 2.11 if possible.
On Mon, Feb 4, 2019 at 1:36 PM Ben Pfaff wrote:
> On Fri, Feb 01, 2019 at 11:11:45AM -0800, Yi-Hung Wei wrote:
> > On Fri, Feb 1, 2019 at 10:02 AM Yifeng Sun
> wrote:
> > >
> > > Test "flow resume with
' for kernels listed below:
3.10.0-957.5.1.el7.x86_64
4.4.0-142-generic
4.17.14
4.18.0-16-generic
4.19.34
4.20.17
Travis passed at
https://travis-ci.org/yifsun/ovs-travis/builds/519011670
Signed-off-by: Yifeng Sun
v1->v2: Fixed the CONFIG_NF_NAT_IPV4 bug by using Greg's con
Thanks Yi-Hung! I will look at it and come up with a new version.
Yifeng
On Mon, Apr 15, 2019 at 5:39 PM Yi-Hung Wei wrote:
>
> On Fri, Apr 12, 2019 at 10:23 AM Yifeng Sun wrote:
> >
> > This patch introduces changes needed by OVS to support latest
> > Linux kernels (4.
wrote:
> > On Wed, Apr 03, 2019 at 09:49:13AM -0700, Yifeng Sun wrote:
> > > From: Flavio Leitner
> > >
> > > Upstream commit:
> > > commit 7f6d6558ae44bc193eb28df3617c364d3bb6df39
> > > Author: Flavio Leitner
> > > Date:
om both.
> >
> > Signed-off-by: Florian Westphal
> > Signed-off-by: Pablo Neira Ayuso
> >
> > This patch backports the above upstream patch to OVS.
> >
> > Cc: Florian Westphal
> > Signed-off-by: Yifeng Sun
> > Acked-by: Yi-Hung W
-kmod \
RPMBUILD_OPT='-D "kversion 3.10.0-957.10.1.el7.x86_64 \
3.10.0-957.12.1.el7.x86_64"'
Signed-off-by: Yifeng Sun
---
rhel/openvswitch-kmod-fedora.spec.in | 9 +
rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh | 11 +++
2 files c
Hi Ben,
Can you please backport this patch to 2.10, thanks.
Yifeng
On Thu, Aug 16, 2018 at 9:14 AM Gregory Rose wrote:
>
>
> On 8/15/2018 6:24 AM, Yifeng Sun wrote:
> > In compatable gre module, skb->cb is solely used as ovs_gso_cb.
> > However, IPCB(skb) also poi
.
>
> On Thu, Jun 06, 2019 at 04:47:59PM -0700, Yifeng Sun wrote:
> > Hi Ben,
> >
> > Could you check and backport this patch to branch-2.10.
> > I checked and branch-2.10 doesn't contain this fix.
> >
> > Thanks Greg for the checking!
> >
> > Th
Fri, Jul 20, 2018 at 11:04 AM, Yifeng Sun wrote:
> > > Without this patch, OVS kernel module can delete itn->fb_tunnel_dev
> > > one more time than necessary, which causes kernel crash.
> > >
> > > On kernel 4.4.0-116-generic, the crash can be reproduced by r
Look good to me, thanks.
Reviewed-by: Yifeng Sun
On Fri, Jun 7, 2019 at 1:03 PM 0-day Robot wrote:
>
> Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting
Thanks Ashish for the fix.
Reviewed-by: Yifeng Sun
On Fri, Jun 7, 2019 at 3:45 PM Ashish Varma wrote:
>
> Fixed a bug where checking for major version 3.10 and major revision not
> equal to 327 or 693 or 957 should have gone to the default else at the end.
> In the current code,
Hi Ben,
group_first_live_bucket() can still return zero-weighted bucket, then
this bucket will
be used via pick_ff_group() and xlate_group_action__(). I am wondering
if it is an
issue?
Thanks,
Yifeng
On Fri, Jun 7, 2019 at 12:04 PM 0-day Robot wrote:
>
> Bleep bloop. Greetings Ben Pfaff, I am
d at
https://travis-ci.org/yifsun/ovs-travis/builds/536527230
with latest Linux kernel version.
In addition, this patch doesn't introduce failed tests for latest kernels
of Ubuntu (bionic, trusty, xenial), fedora, centos 73, rhel (74, 75, 76).
Reported-by: Ilya Maximets
Signed-off-by: Yifeng Sun
On Fri, May 24, 2019 at 10:59 AM Yi-Hung Wei wrote:
>
> On Thu, May 23, 2019 at 4:58 PM Yifeng Sun wrote:
> >
> > 4.9.172+ kernel backported upstream patch 70b095c843266
> > ("ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module")
> > and this caused
-by: Ido Schimmel
Reviewed-by: David Ahern
Signed-off-by: David S. Miller
This patch backports the above upstream patch and also adds fixes
in compat code.
Cc: Petr Machata
Signed-off-by: Yifeng Sun
---
acinclude.m4| 3 +++
datapath/linux/compat
% the same with __tcp_checksum_complete().
Signed-off-by: Yifeng Sun
---
datapath/linux/compat/stt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c
index 5f045120ed20..21fef09f4329 100644
--- a/datapath/linux/compat/stt.c
+++ b/datapath/li
This patch updated acinclude.m4 so that OVS can be compiled on
5.0.x kernels.
This patch also updated travis files so that 5.0.x kernel versions
are used during travis test builds.
Besides, NEWS and releases.rst are also updated to reflect this
new support.
Signed-off-by: Yifeng Sun
Signed-off-by: Yifeng Sun
---
acinclude.m4 | 4
datapath/actions.c| 13 +
datapath/flow.c | 6 +++---
datapath/flow.h | 2 +-
datapath/flow_netlink.c
/ovs/pull/278
Travis passed at:
https://travis-ci.org/yifsun/ovs-travis/builds/543907186
In addition, builds succeeded and 'make check-kmod' passed on:
CentOS73, Fedora, RHEL74, RHEL75, RHEL76 and Ubuntu (bionic, trusty,
xenial, Disco Dingo).
Yifeng Sun (5):
datapath: Check extack argument
Upstream commit d0522f1cd25edb796548f91e04766fa3cbc3b6df ("net:
Add extack argument to rtnl_create_link") added new argument
to rtnl_create_link(). This introduced compiling errors in
the code of kernel datapath.
This patch fixes this issue.
Signed-off-by: Yifeng Sun
---
ac
Thanks Ben and Darrell.
Yifeng
On Thu, Jun 13, 2019 at 10:12 AM Darrell Ball wrote:
>
>
>
> On Wed, Jun 12, 2019 at 3:38 PM Yifeng Sun wrote:
>>
>> This series of patches enabled OVS to run on kernel 5.0.x.
>>
>> Tests shows that this series of patches
ues.
Yifeng Sun (5):
datapath: Check extack argument of rtnl_create_link()
OVS: remove use of VLAN_TAG_PRESENT
datapath: Backport the removal of __tcp_checksum_complete()
net: core: dev: Add extack argument to dev_change_flags()
datapath: Support kernel version 5.0.x
.travis.
Thanks Yi-Hung, I will rebase .travis.yml, fix the small issue you
mentioned in another email, and send v2.
Yifeng
On Wed, Jun 12, 2019 at 2:21 PM Yi-Hung Wei wrote:
>
> On Mon, Jun 10, 2019 at 4:46 PM Yifeng Sun wrote:
> >
> > This patch updated acinclude.m4 so that O
This series were already acked by YiHung.
On Wed, Jun 12, 2019 at 3:35 PM Yifeng Sun wrote:
>
> This series of patches enabled OVS to run on kernel 5.0.x.
>
> Tests shows that this series of patches passed check-kmod tests or
> didn't introduce new failed check-kmod tests fo
-by: Yifeng Sun
---
v1->v2: Rebased changes for .travis.yml, thanks YiHung.
.travis.yml| 1 +
.travis/linux-build.sh | 4 +++-
Documentation/faq/releases.rst | 2 +-
NEWS | 1 +
acinclude.m4 | 10 ++
5 files changed,
-by: Ido Schimmel
Reviewed-by: David Ahern
Signed-off-by: David S. Miller
This patch backports the above upstream patch and also adds fixes
in compat code.
Cc: Petr Machata
Acked-by: Yi-Hung Wei
Signed-off-by: Yifeng Sun
---
acinclude.m4| 3
% the same with __tcp_checksum_complete().
Acked-by: Yi-Hung Wei
Signed-off-by: Yifeng Sun
---
datapath/linux/compat/stt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c
index 5f045120ed20..21fef09f4329 100644
--- a/datapath/linux/compat/s
Upstream commit d0522f1cd25edb796548f91e04766fa3cbc3b6df ("net:
Add extack argument to rtnl_create_link") added new argument
to rtnl_create_link(). This introduced compiling errors in
the code of kernel datapath.
This patch fixes this issue.
Acked-by: Yi-Hung Wei
Signed-off-by:
backports the above upstream patch to OVS and adds
extra checking in kernel module's compat code.
Cc: Michał Mirosław
Acked-by: Yi-Hung Wei
Signed-off-by: Yifeng Sun
---
v1->v2: Add an upstream fixup commit, thanks Yihung for pointing
it out.
acinclude.m4
Please use v3, v2 was messed up, sorry.
Thanks,
Yifeng
On Fri, May 10, 2019 at 11:31 AM Ben Pfaff wrote:
>
> Please do in this case. It simplifies my workflow.
>
> On Fri, May 10, 2019 at 11:28:16AM -0700, Yifeng Sun wrote:
> > Hi Ben,
> >
> > All the patches
Thanks Greg, I've put your tags in the cover letter.
Yifeng
On Fri, May 10, 2019 at 12:47 PM Gregory Rose wrote:
>
> My tags are missing.
>
> For the series:
>
> Tested-by: Greg Rose
> Reviewed-by: Greg Rose
>
> On 5/10/2019 12:30 PM, Yifeng Sun wrote:
> > T
it now.
Signed-off-by: Gao Feng
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS.
Cc: Gao Feng
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
v1->v2: Rebase previous patch's changes.
acinclude
into a header, then used from both.
Signed-off-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
acinclude.m4 | 2 ++
datapath
> On 5/10/19, 12:31 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yifeng
> Sun"
> wrote:
>
> Upstream kernel commit a0ae2562 ("netfilter: conntrack: remove l3proto
> abstraction") removed header file net/netfilter/nf_conntrack_l3proto.h.
>
Hi Ben,
All the patches in this series got acked. Do I need to send v2 for
those patches that were acked in v1?
Thanks,
Yifeng
On Wed, May 8, 2019 at 4:36 PM Yifeng Sun wrote:
>
> Sure, I will submit new versions after testing is done.
> Thanks,
> Yifeng
>
> On Wed, May 8, 2
This patch fixes the compilation errors of OVS on 4.19+ kernels.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
datapath/linux/compat/include/net/netfilter/nf_conntrack_count.h | 4 ++--
datapath/linux/compat/nf_conncount.c | 6 +-
2 files changed, 7
This patch updated acinclude.m4 so that OVS can be compiled on 4.19.x
and 4.20.x kernels.
This patch also updated travis files so that latest kernel versions
are used during travis test builds.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
.travis.yml | 18 ++
NEWS
it now.
Signed-off-by: Gao Feng
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS.
Cc: Gao Feng
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
v1->v2: Rebase previous patch's changes.
acinclude
tch to OVS.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
v1->v2: Fixed nf_ct_invert_tuplepr by YiHung's comments, Thanks YiHung.
datapath/conntrack.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/datapath/conntrack.c b/da
Upstream kernel commit a0ae2562 ("netfilter: conntrack: remove l3proto
abstraction") removed header file net/netfilter/nf_conntrack_l3proto.h.
This patch detects it and fixes compilation errors of OVS on 4.19+ kernels.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
ac
This patch updated acinclude.m4 so that OVS can be compiled on 4.19.x
and 4.20.x kernels.
This patch also updated travis files so that latest kernel versions
are used during travis test builds.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
.travis.yml | 18 ++
NEWS
ian Westphal
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS and fixes compiling
errors on RHEL kernels.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
v1->v2: Fixed by YiHung's comments, thanks YiHung.
acincl
This patch fixes the compilation errors of OVS on 4.19+ kernels.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
datapath/linux/compat/include/net/netfilter/nf_conntrack_count.h | 4 ++--
datapath/linux/compat/nf_conncount.c | 6 +-
2 files changed, 7
tch to OVS.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
v1->v2: Fixed nf_ct_invert_tuplepr by YiHung's comments, Thanks YiHung.
datapath/conntrack.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/datapath/conntrack.c b/da
it now.
Signed-off-by: Gao Feng
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS.
Cc: Gao Feng
Signed-off-by: Yifeng Sun
---
v1->v2: Rebase previous patch's changes.
acinclude.m4 | 3 +++
.../li
tch to OVS.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
---
v1->v2: Fixed nf_ct_invert_tuplepr by YiHung's comments, Thanks YiHung.
datapath/conntrack.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/datapath/conntrack.c b/datapath/conntrack.c
and Ubuntu (bionic, trusty,
xenial).
Yifeng Sun (7):
datapath: Handle removal of nf_conntrack_l3proto.h
datapath: Pass nf_hook_state to nf_conntrack_in()
datapath: Use new header file net/ipv6_frag.h
datapath: Fix conntrack_count related compilation errors
openvswitch: use nf_ct_get_tuplepr
Upstream kernel commit a0ae2562 ("netfilter: conntrack: remove l3proto
abstraction") removed header file net/netfilter/nf_conntrack_l3proto.h.
This patch detects it and fixes compilation errors of OVS on 4.19+ kernels.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
ac
and Ubuntu (bionic, trusty,
xenial).
Yifeng Sun (7):
datapath: Handle removal of nf_conntrack_l3proto.h
datapath: Pass nf_hook_state to nf_conntrack_in()
datapath: Use new header file net/ipv6_frag.h
datapath: Fix conntrack_count related compilation errors
openvswitch: use nf_ct_get_tuplepr
ian Westphal
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS and fixes compiling
errors on RHEL kernels.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
v1->v2: Fixed by YiHung's comments, thanks YiHung.
acincl
into a header, then used from both.
Signed-off-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
acinclude.m4 | 2 ++
datapath
e
> (Signed-off-by should be last) and applied this series to master.
> Thanks, everyone!
>
> On Fri, May 10, 2019 at 12:53:08PM -0700, Yifeng Sun wrote:
> > Thanks Greg, I've put your tags in the cover letter.
> > Yifeng
> >
> > On Fri, May 10, 2019 at 12:47 PM G
d at
https://travis-ci.org/yifsun/ovs-travis/builds/536527230
with latest Linux kernel version.
In addition, this patch doesn't introduce failed tests for latest kernels
of Ubuntu (bionic, trusty, xenial), fedora, centos 73, rhel (74, 75, 76).
Reported-by: Ilya Maximets
Signed-off-by: Yifeng Sun
Thanks YiHung, I will check it out.
Yifeng
On Thu, May 23, 2019 at 1:55 PM Yi-Hung Wei wrote:
>
> On Tue, May 21, 2019 at 11:07 AM Yifeng Sun wrote:
> >
> > Forgot to put reported-by.
> >
> > Reported-by: Ilya Maximets
> >
> >
> > O
Thanks for reviewing, please see my acks in below.
Yifeng
On Wed, May 8, 2019 at 2:19 PM Yi-Hung Wei wrote:
>
> On Mon, May 6, 2019 at 2:59 PM Yifeng Sun wrote:
> >
> > From: Florian Westphal
> >
> > Upstream commit:
> > commit 60e3be94e6a1c5162a0
is placed into a header, then used from both.
Signed-off-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
---
v1->v2: Fixed by YiHung's comments, thanks YiHung!
acinclude
ian Westphal
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS and fixes compiling
errors on RHEL kernels.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
---
v1->v2: Fixed by YiHung's comments, thanks YiHung.
acincl
Thanks for the review, please see my acks in below.
On Wed, May 8, 2019 at 1:53 PM Yi-Hung Wei wrote:
>
> On Mon, May 6, 2019 at 2:58 PM Yifeng Sun wrote:
> >
> > From: Florian Westphal
> >
> > Upstream Commit:
> > commit 93e66024b0249cec81e91328c55a
Thank for the review, I will fix in next version.
Yifeng
On Wed, May 8, 2019 at 1:54 PM Yi-Hung Wei wrote:
>
> On Mon, May 6, 2019 at 2:58 PM Yifeng Sun wrote:
> >
> > From: Florian Westphal
> >
> > Upstream commit:
> > commit 70b095c84326640eeac
Sure, I will submit new versions after testing is done.
Thanks,
Yifeng
On Wed, May 8, 2019 at 4:05 PM Ben Pfaff wrote:
>
> On Wed, May 08, 2019 at 02:27:57PM -0700, Yi-Hung Wei wrote:
> > On Mon, May 6, 2019 at 3:01 PM Yifeng Sun wrote:
> > >
> > > This patch up
Forgot to put reported-by.
Reported-by: Ilya Maximets
On Mon, May 20, 2019 at 4:58 PM Yifeng Sun wrote:
>
> 4.9.172+ kernel backported upstream patch 70b095c843266
> ("ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module")
> and this caused compilation error
I tested it and it works fine. Thanks.
Yifeng
Tested-by: Yifeng Sun
Reviewed-by: Yifeng Sun
On Mon, May 20, 2019 at 6:29 AM Ilya Maximets wrote:
>
> Instead of managing kernel minor versions manually we could always test
> with the most recent stable release of the desir
Thanks for the fix.
Reviewed-by: Yifeng Sun
On Mon, May 20, 2019 at 3:49 PM Ben Pfaff wrote:
>
> Reported-by: Numan Siddique
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2019-May/359144.html
> Signed-off-by: Ben Pfaff
> ---
> .travis/linux-buil
d at
https://travis-ci.org/yifsun/ovs-travis/builds/535047469
with latest Linux kernel version.
Signed-off-by: Yifeng Sun
---
datapath/linux/compat/nf_conntrack_reasm.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/datapath/linux/compat/nf_conntrack_
CC: Greg Rose
CC: Yi-Hung Wei
Fixes: f72469405eec9 ("datapath: meter: Use struct_size() in kzalloc()")
Signed-off-by: Yifeng Sun
---
v1->v2: Update 4.14.111 in travis by Greg's suggestion, thanks!
v2->v3: Fix patch title and comment of endif, thanks Yi-Hu
Upstream kernel commit a0ae2562 ("netfilter: conntrack: remove l3proto
abstraction") removed header file net/netfilter/nf_conntrack_l3proto.h.
This patch detects it and fixes compilation errors of OVS on 4.19+ kernels.
Signed-off-by: Yifeng Sun
---
acinclude.m4
ned-off-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS and fixes compiling
errors on RHEL kernels.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
---
acinclude.m4 | 5 +
datap
This patch fixes the compilation errors of OVS on 4.19+ kernels.
Signed-off-by: Yifeng Sun
---
datapath/linux/compat/include/net/netfilter/nf_conntrack_count.h | 4 ++--
datapath/linux/compat/nf_conncount.c | 6 +-
2 files changed, 7 insertions(+), 3 deletions
This patch updated acinclude.m4 so that OVS can be compiled on 4.19.x
and 4.20.x kernels.
This patch also updated travis files so that latest kernel versions
are used during travis test builds.
Signed-off-by: Yifeng Sun
---
.travis.yml | 18 ++
NEWS | 2
This patch updated acinclude.m4 so that OVS can be compiled on 4.19.x
and 4.20.x kernels.
This patch also updated travis files so that latest kernel versions
are used during travis test builds.
Signed-off-by: Yifeng Sun
---
.travis.yml | 18 ++
NEWS | 2
it now.
Signed-off-by: Gao Feng
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS.
Cc: Gao Feng
Signed-off-by: Yifeng Sun
---
acinclude.m4 | 3 +++
.../linux/compat/include/net/netfilter
eam kernel patch to OVS.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
---
acinclude.m4| 2 ++
datapath/conntrack.c| 17 +++--
.../include/net/netfilter/nf_conntrack_core.h | 19 +++
datap
and Ubuntu (bionic, trusty,
xenial).
Yifeng Sun (7):
datapath: Handle removal of nf_conntrack_l3proto.h
datapath: Pass nf_hook_state to nf_conntrack_in
datapath: Use new header file net/ipv6_frag.h
datapath: Fix conntrack_count related compilation errors
openvswitch: use nf_ct_get_tuplepr
is placed into a header, then used from both.
Signed-off-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
This patch backports the above upstream patch to OVS.
Cc: Florian Westphal
Signed-off-by: Yifeng Sun
---
acinclude.m4 | 2 ++
datapath
CC: Greg Rose
Fixes: f72469405eec9 ("datapath: meter: Use struct_size() in kzalloc()")
Signed-off-by: Yifeng Sun
---
acinclude.m4 | 2 ++
datapath/linux/compat/include/linux/overflow.h | 2 +-
datapath/meter.c | 1
Hi Greg,
I saw the compilation error for kernel 4.14.111 because `struct_size`
isn't defined in kernel source tree. I didn't dig into it though.
Thanks,
Yifeng
On Fri, Apr 26, 2019 at 1:13 PM Gregory Rose wrote:
>
>
> On 4/26/2019 11:07 AM, Yifeng Sun wrote:
> > CC: Greg
Sure, I will do that.
Thanks!
Yifeng
On Fri, Apr 26, 2019 at 1:31 PM Gregory Rose wrote:
>
>
>
> On 4/26/2019 1:18 PM, Yifeng Sun wrote:
> > Hi Greg,
> >
> > I saw the compilation error for kernel 4.14.111 because `struct_size`
> > isn't defined in kernel sour
CC: Greg Rose
Fixes: f72469405eec9 ("datapath: meter: Use struct_size() in kzalloc()")
Signed-off-by: Yifeng Sun
---
v1->v2: update 4.14.111 in travis by Greg's suggestion, thanks!
.travis.yml| 2 +-
acinclude.m4
Got it, thanks for the fix.
Reviewed-by: Yifeng Sun
On Thu, Jun 27, 2019 at 6:51 AM Ben Pfaff wrote:
>
> I don't think we're planning to backport 5.0 support to OVS 2.11.x, because
> that would be counter to our usual practice.
>
> CC: Yifeng Sun
> Fixes: 2adada0e3db2 (
Got it, thanks!
Reviewed-by: Yifeng Sun
On Wed, Apr 10, 2019 at 10:43 AM Gregory Rose wrote:
>
>
>
> On 4/1/2019 10:21 AM, Yifeng Sun wrote:
> > As commented, previously flex_array was used because "we can have large
> > hash-table without large contiguous ker
Thanks Ben for pointing this out. There surely is a mistake that we need to fix.
We will come up a new version.
Thanks,
Yifeng
On Tue, Jul 16, 2019 at 3:04 PM Ben Pfaff wrote:
>
> On Tue, Jul 16, 2019 at 10:55:08AM -0700, Yifeng Sun wrote:
> > For userspace datapath, currently onl
Reviewed-by: Yifeng Sun
On Tue, Aug 27, 2019 at 2:06 PM Greg Rose wrote:
>
> A Centos 7.5 kernel with an unencountered set of minor build numbers
> caused an upgrade bug. Adding the case for the rhel 7.5 kmod management
> script fixes the problem.
>
> Signed-off-by: Greg R
301 - 400 of 513 matches
Mail list logo
