[Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-24 Thread Jörn Friedrich Dreyer
I am currently merging master into my personal stable4-oracle branch and will commit oracle support tomorrow. This will allow us to give the implementation a lot of testing before owncloud customers will be using it in production. On the bad side I had to make changes to ALL SQL statements. On the

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-24 Thread Diederik de Haas
On Friday 24 August 2012 19:31:42 Jörn Friedrich Dreyer wrote: > I am currently merging master into my personal stable4-oracle branch and > will commit oracle support tomorrow. On Monday 20 August 2012 17:52:38 Frank Karlitschek wrote: > [Owncloud] github and contributor agreement > - We will mig

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-25 Thread Thomas Müller
Hi, due to the big impact Oracle has on the ownCloud code and the pretty high risk to screw up the system (which is actually the case - git master is unusable). I'd like to vote for a revert of the change in the current state of the release cycle. Last week MTGap and members of the community sta

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-25 Thread Trey Nolen
I definitely vote for holding off on Oracle. I think the vast majority of the community will not need it. Also, Oracle has not been a positive force in open source development, so I think they should be on the back burner for those efforts. There are a lot of ways Owncloud can improve, and a

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-25 Thread Steve Riley
On 08/25/2012 07:02 PM, Thomas Müller wrote: > > In addition to that I'd like to ask the community's opinion on ownCloud > supporting Oracle database. My point of view is pretty clear - which is a > non-business point of view: > I don't need it - I don't want it - I don't want to maintain it!

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-26 Thread Frank Karlitschek
On 26.08.2012, at 02:02, Thomas Müller wrote: > Hi, > > due to the big impact Oracle has on the ownCloud code and the pretty high risk > to screw up the system (which is actually the case - git master is unusable). > > I'd like to vote for a revert of the change in the current state of the >

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-26 Thread Jörn Friedrich Dreyer
First of all I would like to apologize for pushing in code that touches every SQL query. That was not very professional development. I should have added the code in smaller chunks. First putting in place the libraries needed for oracle and then introduce the limit parameter. Up to this point nothin

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Thomas Müller
Am Sonntag, dem 26.08.2012 um 11:41 schrieb Frank Karlitschek: > On 26.08.2012, at 02:02, Thomas Müller wrote: > > > Hi, > > > > due to the big impact Oracle has on the ownCloud code and the pretty high > > risk > > to screw up the system (which is actually the case - git master is > > unusab

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Thomas Müller
Am Sonntag, dem 26.08.2012 um 15:27 schrieb Jörn Friedrich Dreyer: > First of all I would like to apologize for pushing in code that touches > every SQL query. That was not very professional development. I should > have added the code in smaller chunks. First putting in place the > libraries need

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Arthur Schiwon
On 08/27/2012 12:27 PM, Thomas Müller wrote: That being said, I am eager to get a lot of users for owncloud by >providing our customers with oracle support. Timing is an important >thing here, and I wanted to test the implementation thoroughly, thats >why I committed the code. My main activitie

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Thomas Müller
Am Montag, dem 27.08.2012 um 13:45 schrieb Arthur Schiwon: > On 08/27/2012 12:27 PM, Thomas Müller wrote: > >> That being said, I am eager to get a lot of users for owncloud by > >> >providing our customers with oracle support. Timing is an important > >> >thing here, and I wanted to test the imple

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Diederik de Haas
On Monday 27 August 2012 12:20:14 Thomas Müller wrote: > > Oracle support is already working and we have 4 weeks left to fix > > remaining small problems. > > I think the point of time has been choose suboptimal - tomorrow beta1 shall > be delivered. A much better time would have been to merge thi

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Thomas Tanghus
On Monday 27 August 2012 17:08 Diederik de Haas wrote: > On Monday 27 August 2012 12:20:14 Thomas Müller wrote: > > > Oracle support is already working and we have 4 weeks left to fix > > > remaining small problems. > > Another solution would be to postpone Oracle support after 4.5 release, so > i

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Tim Bell
wncloud@kde.org > Subject: Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL > without escaped identifiers > > On Monday 27 August 2012 17:08 Diederik de Haas wrote: > > On Monday 27 August 2012 12:20:14 Thomas Müller wrote: > > > > Oracle support is al

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Victor Dubiniuk
lf Of Thomas Tanghus > > Sent: 27 August 2012 18:29 > > To: owncloud@kde.org > > Subject: Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL > > without escaped identifiers > > > > On Monday 27 August 2012 17:08 Diederik de Haas wrote: > > > On Monda

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Jörn Friedrich Dreyer
oud-boun...@kde.org <mailto:owncloud-boun...@kde.org> > [mailto:owncloud-boun...@kde.org <mailto:owncloud-boun...@kde.org>] On > > Behalf Of Thomas Tanghus > > Sent: 27 August 2012 18:29 > > To: owncloud@kde.org <mailto:owncloud@kde.org> >

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Bernhard Posselt
> Instead of using the MDB2 'clob' type use 'text' and set a length. > CLOB is incompatible with indexes on some databases or MDB2 does not > handle it correctly. Without a length MDB2 will pick an internal length > which it thinks is right but breaks current mysql eg. And it will force > you to th

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Thomas Tanghus
On Monday 27 August 2012 18:29 Thomas Tanghus wrote: > On Monday 27 August 2012 17:08 Diederik de Haas wrote: > > On Monday 27 August 2012 12:20:14 Thomas Müller wrote: > > > > Oracle support is already working and we have 4 weeks left to fix > > > > remaining small problems. > > > > Another solut

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Thomas Tanghus
On Monday 27 August 2012 23:14 Thomas Tanghus wrote: > On Monday 27 August 2012 18:29 Thomas Tanghus wrote: > > On Monday 27 August 2012 17:08 Diederik de Haas wrote: > > > On Monday 27 August 2012 12:20:14 Thomas Müller wrote: > > > > > Oracle support is already working and we have 4 weeks left to

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Frank Karlitschek
On 27.08.2012, at 23:56, Thomas Tanghus wrote: > On Monday 27 August 2012 23:14 Thomas Tanghus wrote: >> On Monday 27 August 2012 18:29 Thomas Tanghus wrote: >>> On Monday 27 August 2012 17:08 Diederik de Haas wrote: On Monday 27 August 2012 12:20:14 Thomas Müller wrote: >> Oracle suppo

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-27 Thread Andre Gemuend
On 08/27/2012 07:20 PM, Victor Dubiniuk wrote: I'm not an Oracle fan neither. But it seems to be the matter of syntax and naming conventions mostly. So it would be nice to have a page with clear "Do" and "Don't" checklist at least. The spacewalk project has collected a page with informati

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-28 Thread Sebastian Kügler
On Friday, August 24, 2012 19:31:42 Jörn Friedrich Dreyer wrote: > I am currently merging master into my personal stable4-oracle branch and > will commit oracle support tomorrow. This will allow us to give the > implementation a lot of testing before owncloud customers will be using > it in product

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-28 Thread Thomas Müller
Am Montag, dem 27.08.2012 um 21:57 schrieb Bernhard Posselt: > > Instead of using the MDB2 'clob' type use 'text' and set a length. > > CLOB is incompatible with indexes on some databases or MDB2 does not > > handle it correctly. Without a length MDB2 will pick an internal length > > which it thin

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-28 Thread eMerzh
Please no orm or at least one that is easily by-passable ... if we use an orm doing complex query other than select ... where a=b is really hard... but i agree that it's really easier to do things like update, insert or simple selects the problem is to find a light, powerfull and bypassable o

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-28 Thread Thomas Müller
Am Dienstag, dem 28.08.2012 um 10:57 schrieb eMerzh: > Please no orm > or at least one that is easily by-passable ... if we use an orm doing > complex query other than select ... where a=b is really hard... > but i agree that it's really easier to do things like update, insert > or simple sel

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-28 Thread Arthur Schiwon
On 08/27/2012 09:57 PM, Bernhard Posselt wrote: Instead of using the MDB2 'clob' type use 'text' and set a length. >CLOB is incompatible with indexes on some databases or MDB2 does not >handle it correctly. Without a length MDB2 will pick an internal length >which it thinks is right but breaks

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-28 Thread Thomas Müller
Am Dienstag, dem 28.08.2012 um 10:42 schrieb Sebastian Kügler: > On Friday, August 24, 2012 19:31:42 Jörn Friedrich Dreyer wrote: > > I am currently merging master into my personal stable4-oracle branch and > > will commit oracle support tomorrow. This will allow us to give the > > implementation

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-28 Thread Jörn Friedrich Dreyer
On 28.08.2012 10:42, Sebastian Kügler wrote: > On Friday, August 24, 2012 19:31:42 Jörn Friedrich Dreyer wrote: >> I am currently merging master into my personal stable4-oracle branch and >> will commit oracle support tomorrow. This will allow us to give the >> implementation a lot of testing befor

Re: [Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

2012-08-28 Thread Thomas Müller
Am Dienstag, dem 28.08.2012 um 11:54 schrieb Jörn Friedrich Dreyer: > On 28.08.2012 10:42, Sebastian Kügler wrote: > > On Friday, August 24, 2012 19:31:42 Jörn Friedrich Dreyer wrote: > >> I am currently merging master into my personal stable4-oracle branch and > >> will commit oracle support tomor