lokeshj1703 commented on pull request #1459:
URL: https://github.com/apache/hadoop-ozone/pull/1459#issuecomment-712178445
@bshashikant @linyiqun Thanks for reviewing the PR! I have committed it to
master branch.
This is an a
linyiqun commented on pull request #1459:
URL: https://github.com/apache/hadoop-ozone/pull/1459#issuecomment-712021874
Good to know the testing result. +1 for this change. Thanks @lokeshj1703 .
This is an automated message fr
lokeshj1703 commented on a change in pull request #1502:
URL: https://github.com/apache/hadoop-ozone/pull/1502#discussion_r507591562
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java
##
@@ -130,9 +130,7 @@ public void
cxorm commented on pull request #1301:
URL: https://github.com/apache/hadoop-ozone/pull/1301#issuecomment-711871349
> Thanks @cxorm for the update. The latest PR LGTM overall, a few comments
added inline.
Thank you @xiaoyuyao for the careful review.
The fix was added to addressed
lokeshj1703 commented on pull request #1459:
URL: https://github.com/apache/hadoop-ozone/pull/1459#issuecomment-711778460
@linyiqun currently we allow block deletion for only closed containers. For
open containers deletion needs to be done via ratis pipeline which is not
currently implemen
aryangupta1998 closed pull request #1440:
URL: https://github.com/apache/hadoop-ozone/pull/1440
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
runzhiwang commented on pull request #1371:
URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-711495208
@ChenSammi Thanks for merging it, @bshashikant @xiaoyuyao @GlenGeng Thanks
for review.
This is an autom
ChenSammi commented on pull request #1371:
URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-711494972
LGTM + 1.
Thanks @runzhiwang for the contribution and @bshashikant @xiaoyuyao
@GlenGeng for the review.
ChenSammi merged pull request #1371:
URL: https://github.com/apache/hadoop-ozone/pull/1371
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
runzhiwang opened a new pull request #1504:
URL: https://github.com/apache/hadoop-ozone/pull/1504
## What changes were proposed in this pull request?
This is a design doc, which is moved from google doc to make it easier to
track the progress.
## What is the link to the Apache
bharatviswa504 commented on a change in pull request #1498:
URL: https://github.com/apache/hadoop-ozone/pull/1498#discussion_r507293372
##
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java
##
@@ -116,6 +116,13 @@ private OzoneC
bharatviswa504 commented on a change in pull request #1498:
URL: https://github.com/apache/hadoop-ozone/pull/1498#discussion_r507293372
##
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java
##
@@ -116,6 +116,13 @@ private OzoneC
linyiqun commented on a change in pull request #1503:
URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r507038746
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -2205,6 +2272,167 @@ private void listS
linyiqun commented on a change in pull request #1503:
URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r507038746
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -2205,6 +2272,167 @@ private void listS
linyiqun commented on a change in pull request #1503:
URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r506883082
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -2205,6 +2272,167 @@ private void listS
amaliujia commented on pull request #1482:
URL: https://github.com/apache/hadoop-ozone/pull/1482#issuecomment-711083779
@elek friendly ping on this PR~
This is an automated message from the Apache Git Service.
To respond to t
linyiqun commented on a change in pull request #1503:
URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r506954736
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -2205,6 +2272,167 @@ private void listS
linyiqun commented on a change in pull request #1503:
URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r506792006
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
##
@@ -583,4 +588,112 @@ public s
linyiqun commented on a change in pull request #1503:
URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r506887372
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -2205,6 +2272,167 @@ private void listS
linyiqun commented on a change in pull request #1503:
URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r506854548
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -2205,6 +2272,167 @@ private void listS
linyiqun commented on a change in pull request #1503:
URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r506790946
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -1831,6 +1838,62 @@ private OzoneFileSt
rakeshadr opened a new pull request #1503:
URL: https://github.com/apache/hadoop-ozone/pull/1503
## What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/HDDS-4332
## What is the link to the Apache JIRA
This task is to perform look up of
mukul1987 opened a new pull request #1502:
URL: https://github.com/apache/hadoop-ozone/pull/1502
## What changes were proposed in this pull request?
Avoid spamming of logs because of deleted transactions.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/
runzhiwang commented on a change in pull request #1419:
URL: https://github.com/apache/hadoop-ozone/pull/1419#discussion_r505970425
##
File path: hadoop-hdds/docs/content/design/storage-class.md
##
@@ -19,10 +19,331 @@ author: Marton Ele
See the License for the specific lang
maobaolong commented on pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407#issuecomment-709296180
Thank @elek for trigger ci checks for me, now it getting green, could you
please to merge this PR?
This
maobaolong commented on pull request #1110:
URL: https://github.com/apache/hadoop-ozone/pull/1110#issuecomment-709294091
@bharatviswa504 Thanks for bring this PR back, as s3g without enable the
security, so I think EndpointBase#SignatureProcessor shouldn't be inject as
AWSSignatureProcesso
flirmnave commented on pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490#issuecomment-709086213
Thanks @cxorm for reviewing and committing it, and @jojochuang for the
review.
This is an automated mess
cxorm merged pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cxorm commented on pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490#issuecomment-709020567
Thanks @flirmnave for the work, +1.
And thanks @jojochuang for the report and review.
I have committed it.
-
cxorm commented on pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#issuecomment-709002336
Thank you @amaliujia for the fixes addressed comments.
The work is great to me, but I think we would commit it after HDDS-4308.
---
amaliujia edited a comment on pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#issuecomment-708945714
@ChenSammi thanks for your pointer. I find the way to create linked bucket
from there: just construct a bucket args by setting source volume name and
bucket name
amaliujia edited a comment on pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#issuecomment-708945714
@ChenSammi thanks for your pointer. I find the way to create linked bucket
from there: just construct a bucket args by setting source volume name and
bucket name.
amaliujia commented on pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#issuecomment-708945714
@ChenSammi thanks for your pointer. I find the way to create linked bucket
there: just construct a bucket args by setting source volume name and bucket
name.
Have
ChenSammi commented on pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#issuecomment-708879034
It seems there is no example UT so far. You can refer to links.robot for CLI
examples, and HDDS-3612.
T
hanishakoneru merged pull request #1493:
URL: https://github.com/apache/hadoop-ozone/pull/1493
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
hanishakoneru commented on pull request #1493:
URL: https://github.com/apache/hadoop-ozone/pull/1493#issuecomment-708718652
Thanks @bharatviswa504. +1 for merge.
This is an automated message from the Apache Git Service.
To re
bharatviswa504 closed pull request #1228:
URL: https://github.com/apache/hadoop-ozone/pull/1228
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
bharatviswa504 commented on pull request #1228:
URL: https://github.com/apache/hadoop-ozone/pull/1228#issuecomment-708672417
Closing this, it is committed thru #1499
This is an automated message from the Apache Git Service.
bharatviswa504 commented on pull request #1499:
URL: https://github.com/apache/hadoop-ozone/pull/1499#issuecomment-708671730
Thank You @GlenGeng for the contribution.
This is an automated message from the Apache Git Service.
bharatviswa504 merged pull request #1499:
URL: https://github.com/apache/hadoop-ozone/pull/1499
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
bharatviswa504 commented on a change in pull request #1493:
URL: https://github.com/apache/hadoop-ozone/pull/1493#discussion_r504974154
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
##
@@ -397,33 +399,29 @@ pub
sodonnel opened a new pull request #1501:
URL: https://github.com/apache/hadoop-ozone/pull/1501
## What changes were proposed in this pull request?
Add a series of intergration tests to prove nodes can enter and leave
maintenance correctly and address any issues in the code when addi
sodonnel opened a new pull request #1500:
URL: https://github.com/apache/hadoop-ozone/pull/1500
## What changes were proposed in this pull request?
An earlier change moved the maintenance endtime into the NodeStatus object.
However when adding a node to the decommission monitor the e
sodonnel merged pull request #1495:
URL: https://github.com/apache/hadoop-ozone/pull/1495
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
asfgit merged pull request #1496:
URL: https://github.com/apache/hadoop-ozone/pull/1496
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
GlenGeng commented on pull request #1499:
URL: https://github.com/apache/hadoop-ozone/pull/1499#issuecomment-708522091
@bharatviswa504 For the S3G NPE case, please check this patch.
This is an automated message from the Apach
hanishakoneru commented on a change in pull request #1493:
URL: https://github.com/apache/hadoop-ozone/pull/1493#discussion_r504812062
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
##
@@ -397,33 +399,29 @@ publ
GlenGeng opened a new pull request #1499:
URL: https://github.com/apache/hadoop-ozone/pull/1499
## What changes were proposed in this pull request?
Fix s3g met NPE exception while write file by multiPartUpload.
For more detail, please refer to conversions of
https://github.com
linyiqun edited a comment on pull request #1459:
URL: https://github.com/apache/hadoop-ozone/pull/1459#issuecomment-708509231
@lokeshj1703 , seems the original purpose of letting only one transaction
per container to delete on datanode is to make container block deletion more
balanced. So
linyiqun commented on pull request #1459:
URL: https://github.com/apache/hadoop-ozone/pull/1459#issuecomment-708509231
@lokeshj1703 , seems the original purpose of letting only one transaction
per container to delete on datanode is to make container block deletion more
balanced. So the con
bharatviswa504 commented on a change in pull request #1228:
URL: https://github.com/apache/hadoop-ozone/pull/1228#discussion_r504746102
##
File path: tencent/python-client/OzoneS3.py
##
@@ -0,0 +1,89 @@
+import boto3
+from botocore.config import Config
+from botocore.exceptions
bharatviswa504 commented on a change in pull request #1228:
URL: https://github.com/apache/hadoop-ozone/pull/1228#discussion_r504746102
##
File path: tencent/python-client/OzoneS3.py
##
@@ -0,0 +1,89 @@
+import boto3
+from botocore.config import Config
+from botocore.exceptions
codecov-io commented on pull request #1496:
URL: https://github.com/apache/hadoop-ozone/pull/1496#issuecomment-708435644
#
[Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1496?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`HDDS-1880-Decom@f74
captainzmc closed pull request #1497:
URL: https://github.com/apache/hadoop-ozone/pull/1497
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
timmylicheng opened a new pull request #1498:
URL: https://github.com/apache/hadoop-ozone/pull/1498
## What changes were proposed in this pull request?
Skip aws signature retrieval in AWSSignatureProcessor. It was causing NPE
when signature is absent in header.
(Please fill in cha
captainzmc opened a new pull request #1497:
URL: https://github.com/apache/hadoop-ozone/pull/1497
## What changes were proposed in this pull request?
, rest LGTM.
Thanks @bharatviswa504 for the detailed reviews. I've updated the p
bharatviswa504 merged pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
bharatviswa504 commented on pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#issuecomment-707853993
Thank You @errose28 for the contribution and @avijayanhwx for the review
This is an automated messag
flirmnave commented on a change in pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490#discussion_r503964885
##
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/HddsVolumeUtil.java
##
@@ -212,6 +212,9 @
github-actions[bot] commented on pull request #1487:
URL: https://github.com/apache/hadoop-ozone/pull/1487#issuecomment-707740455
To re-run CI checks, please follow these steps with the source branch
checked out:
```
git commit --allow-empty -m 'trigger new CI check'
git push
``
aryangupta1998 commented on pull request #1487:
URL: https://github.com/apache/hadoop-ozone/pull/1487#issuecomment-707740142
/retest
This is an automated message from the Apache Git Service.
To respond to the message, please
jojochuang commented on a change in pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490#discussion_r503922135
##
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/HddsVolumeUtil.java
##
@@ -212,6 +212,9
sodonnel closed pull request #1461:
URL: https://github.com/apache/hadoop-ozone/pull/1461
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sodonnel commented on pull request #1461:
URL: https://github.com/apache/hadoop-ozone/pull/1461#issuecomment-707693651
This PR was merged manually from the CLI to preserve the history. Therefore
I am closing this PR.
This is
sodonnel opened a new pull request #1491:
URL: https://github.com/apache/hadoop-ozone/pull/1491
## What changes were proposed in this pull request?
The existing CLI command `ozone admin datanode list` provides output like:
```
bash-4.2$ ozone admin datanode list
Datanode:
sodonnel merged pull request #1488:
URL: https://github.com/apache/hadoop-ozone/pull/1488
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
flirmnave opened a new pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490
## What changes were proposed in this pull request?
Adding a log makes it easy to track the problem.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/bro
201 - 300 of 12474 matches
Mail list logo
