captainzmc opened a new pull request #1489:
URL: https://github.com/apache/hadoop-ozone/pull/1489
## What changes were proposed in this pull request?
Currently volumeArgs using getCacheValue and put the same object in
doubleBuffer, this might cause issue.
Let's take the below
xiaoyuyao commented on a change in pull request #1301:
URL: https://github.com/apache/hadoop-ozone/pull/1301#discussion_r503654340
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketAddAclRequest.java
##
@@ -58,6 +60,19
GlenGeng commented on a change in pull request #1228:
URL: https://github.com/apache/hadoop-ozone/pull/1228#discussion_r503653865
##
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java
##
@@ -562,13 +562,18 @@ private Respons
GlenGeng commented on a change in pull request #1228:
URL: https://github.com/apache/hadoop-ozone/pull/1228#discussion_r503653865
##
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java
##
@@ -562,13 +562,18 @@ private Respons
avijayanhwx merged pull request #1456:
URL: https://github.com/apache/hadoop-ozone/pull/1456
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
amaliujia commented on pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#issuecomment-707456469
@ChenSammi
Thanks for the point that linked bucket case. Is there an example to show
now linked bucket is tested (e.g. as a unit test)? I am trying to find a way t
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r503628506
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @@
+/*
bharatviswa504 commented on pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#issuecomment-707398681
Thank You for the updated patch.
I have one comment, (resolved fixed comments), rest LGTM.
Th
fapifta commented on a change in pull request #1456:
URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r503559123
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/upgrade/OMFinalizeUpgradeRequest.java
##
@@ -63,11 +64,20
fapifta commented on a change in pull request #1456:
URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r503556816
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java
##
@@ -0,0 +1,328 @@
+/**
+ * Lice
fapifta commented on a change in pull request #1456:
URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r503552977
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java
##
@@ -0,0 +1,328 @@
+/**
+ * Lice
avijayanhwx commented on a change in pull request #1456:
URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r503538733
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java
##
@@ -0,0 +1,328 @@
+/**
+ *
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r503496882
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r503496882
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @
hanishakoneru commented on pull request #1470:
URL: https://github.com/apache/hadoop-ozone/pull/1470#issuecomment-707266148
Thanks @errose28 for fixing this.
LGTM. +1.
This is an automated message from the Apache Git Serv
hanishakoneru merged pull request #1470:
URL: https://github.com/apache/hadoop-ozone/pull/1470
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sodonnel opened a new pull request #1488:
URL: https://github.com/apache/hadoop-ozone/pull/1488
## What changes were proposed in this pull request?
If you create a container, and then close it, the BCSID is synced on the
datanodes and then the value is updated in SCM via setting the
ChenSammi commented on pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#issuecomment-707100115
@amaliujia , could you add a new UT for bucket link case? Linked bucket
should not be counted in the namespace quota.
-
GlenGeng commented on pull request #1371:
URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-707094391
+1
Thanks for the work! LGTM
This is an automated message from the Apache Git Service.
To respond to th
aryangupta1998 opened a new pull request #1487:
URL: https://github.com/apache/hadoop-ozone/pull/1487
## What changes were proposed in this pull request?
Currently, single node pipeline creation is ON by default in ozone, though
its not used by default in Ozone write path. It would b
prashantpogde commented on a change in pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r502986692
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##
@@ -400,6 +405,66 @@ public void pro
prashantpogde commented on a change in pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r502986622
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##
@@ -400,6 +405,66 @@ public void pro
prashantpogde commented on a change in pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r502986176
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##
@@ -400,6 +405,66 @@ public void pro
prashantpogde commented on a change in pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r502985988
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/LayoutVersionReportHandler.java
##
@@ -0,0 +1,54 @@
+/**
+
prashantpogde commented on a change in pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r502985808
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/AbstractLayoutVersionManager.java
##
@@ -107,6 +121,10 @@ publi
prashantpogde commented on a change in pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r502985808
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/AbstractLayoutVersionManager.java
##
@@ -107,6 +121,10 @@ publi
linyiqun commented on a change in pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r502803755
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##
@@ -400,6 +405,66 @@ public void processN
linyiqun commented on a change in pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r502803755
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##
@@ -400,6 +405,66 @@ public void processN
linyiqun commented on a change in pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r502802281
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/AbstractLayoutVersionManager.java
##
@@ -107,6 +121,10 @@ public voi
rakeshadr commented on pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#issuecomment-706558715
> +1 from me. Thanks @rakeshadr for working on this.
Thank you for the quick response and your review comments helped a lot to
cover many cases.
-
rakeshadr commented on pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#issuecomment-706515468
> Thank you @linyiqun and @bharatviswa504 for the continuous help in
reviews. Please let me know if any more comments.
@linyiqun, @bharatviswa504 Can you please ap
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502755091
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected OmMet
timmylicheng merged pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
timmylicheng commented on pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706478866
LGTM. +1. Merging.
This is an automated message from the Apache Git Service.
To respond to the message
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502734677
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
##
@@ -453,4 +456,145 @@ public
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502734533
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @@
+/*
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502699811
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502696947
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502697158
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502690355
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
##
@@ -453,4 +456,145 @@ pu
adoroszlai commented on pull request #1476:
URL: https://github.com/apache/hadoop-ozone/pull/1476#issuecomment-706409745
Thanks @elek for reviewing and committing it, and @amaliujia for the review.
This is an automated messag
adoroszlai commented on pull request #1454:
URL: https://github.com/apache/hadoop-ozone/pull/1454#issuecomment-706409317
Thanks @xiaoyuyao for reviewing and committing it, @ChenSammi and @linyiqun
for the review, and @elek for finding the issue.
---
avijayanhwx commented on pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#issuecomment-706377348
cc @fapifta / @sodonnel Please review.
This is an automated message from the Apache Git Service.
To re
prashantpogde opened a new pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486
## What changes were proposed in this pull request?
SCM changes to process Layout Info in heartbeat request/response
## What is the link to the Apache JIRA
https://issues
bharatviswa504 commented on pull request #1436:
URL: https://github.com/apache/hadoop-ozone/pull/1436#issuecomment-706312696
Thank You @hanishakoneru for the review.
This is an automated message from the Apache Git Service.
T
bharatviswa504 merged pull request #1436:
URL: https://github.com/apache/hadoop-ozone/pull/1436
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
hanishakoneru commented on pull request #1436:
URL: https://github.com/apache/hadoop-ozone/pull/1436#issuecomment-706304462
Thanks Bharat. LGTM. +1.
This is an automated message from the Apache Git Service.
To respond to the
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502565993
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected OmMe
rakeshadr commented on pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#issuecomment-706282123
Thank you @linyiqun and @bharatviswa504 for the continuous help in reviews.
Please let me know if any more comments.
--
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502546088
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502546088
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected
hanishakoneru commented on pull request #1480:
URL: https://github.com/apache/hadoop-ozone/pull/1480#issuecomment-706275207
Thank you @linyiqun and @prashantpogde for the reviews.
Agree that setting aside 16 bits for epoch doesn't work for both the epoch
as well as the transaction i
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502525148
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected OmMe
xiaoyuyao commented on pull request #1468:
URL: https://github.com/apache/hadoop-ozone/pull/1468#issuecomment-706258012
bq. Is it a backward compatible change? If I understood well both the old
method and new method is good enough for validation, but the new version is
more standard.
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502350594
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected OmMe
xiaoyuyao commented on pull request #1454:
URL: https://github.com/apache/hadoop-ozone/pull/1454#issuecomment-706248107
Thanks @adoroszlai for the update. LGTM, +1.
This is an automated message from the Apache Git Service.
To
xiaoyuyao merged pull request #1454:
URL: https://github.com/apache/hadoop-ozone/pull/1454
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502393095
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected OmMet
sodonnel commented on a change in pull request #1484:
URL: https://github.com/apache/hadoop-ozone/pull/1484#discussion_r502444281
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java
##
@@ -294,6 +294,9 @@ private boo
sodonnel commented on pull request #1484:
URL: https://github.com/apache/hadoop-ozone/pull/1484#issuecomment-706203898
Thanks for taking a look @elek
> Can you please share more details. It would help me to understand the
changes.
I added some comments inline with each change
elek merged pull request #1476:
URL: https://github.com/apache/hadoop-ozone/pull/1476
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
adoroszlai merged pull request #1481:
URL: https://github.com/apache/hadoop-ozone/pull/1481
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
adoroszlai commented on pull request #1483:
URL: https://github.com/apache/hadoop-ozone/pull/1483#issuecomment-705355508
Thanks @avijayanhwx for reviewing and committing it.
This is an automated message from the Apache Git Se
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501645890
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @@
+/*
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501717309
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,275 @@
+/**
+
errose28 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r501976342
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/AbstractOMKeyDeleteResponse.java
##
@@ -0,0 +1,143 @
ChenSammi merged pull request #1458:
URL: https://github.com/apache/hadoop-ozone/pull/1458
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
maobaolong commented on a change in pull request #1083:
URL: https://github.com/apache/hadoop-ozone/pull/1083#discussion_r502165402
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DropTable.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache So
codecov-io edited a comment on pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048
#
[Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1)
Report
> Merging
[#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src
ChenSammi commented on pull request #1458:
URL: https://github.com/apache/hadoop-ozone/pull/1458#issuecomment-706132636
LGTM +1.
This is an automated message from the Apache Git Service.
To respond to the message, please log
elek merged pull request #1477:
URL: https://github.com/apache/hadoop-ozone/pull/1477
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
prashantpogde commented on pull request #1480:
URL: https://github.com/apache/hadoop-ozone/pull/1480#issuecomment-705775239
General comment on using the epoch id that increments with every OM restart.
This can get tricky.
If OM goes in crash restart loop then we have just 2^16 increment
ChenSammi commented on pull request #1454:
URL: https://github.com/apache/hadoop-ozone/pull/1454#issuecomment-705945770
@adoroszlai , thanks for the explanation. +1.
This is an automated message from the Apache Git Service.
elek commented on pull request #1083:
URL: https://github.com/apache/hadoop-ozone/pull/1083#issuecomment-706156646
Merging it now. Thanks the review @bharatviswa504 and @avijayanhwx and the
patch @maobaolong
This is an auto
elek commented on a change in pull request #1451:
URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r502352349
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -919,12 +920,32 @@ private boolean isKeyEmp
elek merged pull request #1083:
URL: https://github.com/apache/hadoop-ozone/pull/1083
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
umamaheswararao merged pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501443397
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @
adoroszlai commented on pull request #1454:
URL: https://github.com/apache/hadoop-ozone/pull/1454#issuecomment-705673221
Thanks @xiaoyuyao for the suggestion to directly pass down the block token.
I have updated the patch accordingly.
-
elek commented on a change in pull request #1484:
URL: https://github.com/apache/hadoop-ozone/pull/1484#discussion_r502419123
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java
##
@@ -294,6 +294,9 @@ private boolean
umamaheswararao commented on pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485#issuecomment-705697044
Thanks @adoroszlai for working on this. The changes looks good to me.
+1
This is an automated me
captainzmc commented on a change in pull request #1458:
URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r50227
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##
@@ -218,6 +219,8 @@
codecov-io commented on pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048
#
[Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1)
Report
> Merging
[#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=
adoroszlai commented on pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485#issuecomment-705710675
Thanks @umamaheswararao for reviewing and merging it.
This is an automated message from the Apache Git S
maobaolong closed pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
prashantpogde edited a comment on pull request #1480:
URL: https://github.com/apache/hadoop-ozone/pull/1480#issuecomment-705775239
General comment on using the epoch id that increments with every OM restart.
This can get tricky.
If OM goes in crash restart loop then we have just 2^16 in
ChenSammi commented on a change in pull request #1458:
URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r502231114
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##
@@ -218,6 +219,8 @@ p
bharatviswa504 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r501938720
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/AbstractOMKeyDeleteResponse.java
##
@@ -0,0 +1
elek commented on a change in pull request #1484:
URL: https://github.com/apache/hadoop-ozone/pull/1484#discussion_r502419123
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java
##
@@ -294,6 +294,9 @@ private boolean
elek merged pull request #1477:
URL: https://github.com/apache/hadoop-ozone/pull/1477
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
elek merged pull request #1083:
URL: https://github.com/apache/hadoop-ozone/pull/1083
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
elek commented on pull request #1083:
URL: https://github.com/apache/hadoop-ozone/pull/1083#issuecomment-706156646
Merging it now. Thanks the review @bharatviswa504 and @avijayanhwx and the
patch @maobaolong
This is an auto
codecov-io edited a comment on pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048
#
[Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1)
Report
> Merging
[#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502393095
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected OmMet
ChenSammi merged pull request #1458:
URL: https://github.com/apache/hadoop-ozone/pull/1458
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ChenSammi commented on pull request #1458:
URL: https://github.com/apache/hadoop-ozone/pull/1458#issuecomment-706132636
LGTM +1.
This is an automated message from the Apache Git Service.
To respond to the message, please log
elek commented on a change in pull request #1451:
URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r502358863
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -919,12 +920,32 @@ private boolean isKeyEmp
elek commented on a change in pull request #1451:
URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r502357778
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -919,12 +920,32 @@ private boolean isKeyEmp
elek commented on a change in pull request #1451:
URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r502356956
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java
##
@@ -298,21 +296,11 @@ public static S
codecov-io commented on pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048
#
[Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1)
Report
> Merging
[#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=
301 - 400 of 12474 matches
Mail list logo