elek commented on a change in pull request #1451:
URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r502352349
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -919,12 +920,32 @@ private boolean isKeyEmp
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502350594
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected OmMe
captainzmc commented on a change in pull request #1458:
URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r50227
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##
@@ -218,6 +219,8 @@
ChenSammi commented on a change in pull request #1458:
URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r502232094
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
##
@@ -279,11 +279,12 @@ p
ChenSammi commented on a change in pull request #1458:
URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r502231114
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##
@@ -218,6 +219,8 @@ p
bharatviswa504 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r502165343
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/AbstractOMKeyDeleteResponse.java
##
@@ -0,0 +1
maobaolong commented on a change in pull request #1083:
URL: https://github.com/apache/hadoop-ozone/pull/1083#discussion_r502165402
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DropTable.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache So
ChenSammi commented on pull request #1454:
URL: https://github.com/apache/hadoop-ozone/pull/1454#issuecomment-705945770
@adoroszlai ， thanks for the explanation. +1.
This is an automated message from the Apache Git Service.
maobaolong closed pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
errose28 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r501976342
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/AbstractOMKeyDeleteResponse.java
##
@@ -0,0 +1,143 @
prashantpogde edited a comment on pull request #1480:
URL: https://github.com/apache/hadoop-ozone/pull/1480#issuecomment-705775239
General comment on using the epoch id that increments with every OM restart.
This can get tricky.
If OM goes in crash restart loop then we have just 2^16 in
prashantpogde commented on pull request #1480:
URL: https://github.com/apache/hadoop-ozone/pull/1480#issuecomment-705775239
General comment on using the epoch id that increments with every OM restart.
This can get tricky.
If OM goes in crash restart loop then we have just 2^16 increment
bharatviswa504 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r501938720
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/AbstractOMKeyDeleteResponse.java
##
@@ -0,0 +1
adoroszlai merged pull request #1481:
URL: https://github.com/apache/hadoop-ozone/pull/1481
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
adoroszlai commented on pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485#issuecomment-705710675
Thanks @umamaheswararao for reviewing and merging it.
This is an automated message from the Apache Git S
umamaheswararao merged pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
umamaheswararao commented on pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485#issuecomment-705697044
Thanks @adoroszlai for working on this. The changes looks good to me.
+1
This is an automated me
adoroszlai commented on pull request #1454:
URL: https://github.com/apache/hadoop-ozone/pull/1454#issuecomment-705673221
Thanks @xiaoyuyao for the suggestion to directly pass down the block token.
I have updated the patch accordingly.
-
adoroszlai opened a new pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485
## What changes were proposed in this pull request?
Make `ozone getconf -confKey` return error (255) instead of success (0) for
missing key, to be compatible with Ozone 1.0.
https
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501717309
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,275 @@
+/**
+
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501645890
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @@
+/*
adoroszlai commented on pull request #1483:
URL: https://github.com/apache/hadoop-ozone/pull/1483#issuecomment-705355508
Thanks @avijayanhwx for reviewing and committing it.
This is an automated message from the Apache Git Se
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501443397
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501436585
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @@
+/*
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501423744
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,275 @@
+/**
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501415031
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,275 @@
+/**
+
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501415031
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,275 @@
+/**
+
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501414878
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @
rakeshadr commented on pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#issuecomment-705289602
@linyiqun I've resolved the comments which are fixed. Please feel free to
re-open, if anything extra to be handled.
-
linyiqun commented on a change in pull request #1480:
URL: https://github.com/apache/hadoop-ozone/pull/1480#discussion_r501398524
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java
##
@@ -523,6 +531,32 @@ public static OmKeyInfo prepareKeyForR
avijayanhwx commented on pull request #1467:
URL: https://github.com/apache/hadoop-ozone/pull/1467#issuecomment-705227363
/pending Looking into an edge case where Ratis log index can go over applied
index, thereby causing purge not to succeed.
-
avijayanhwx merged pull request #1483:
URL: https://github.com/apache/hadoop-ozone/pull/1483
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
sodonnel opened a new pull request #1484:
URL: https://github.com/apache/hadoop-ozone/pull/1484
## What changes were proposed in this pull request?
Add a series of integration tests to prove decommission works, and that
decommission can survive a restart of SCM.
As part of add
amaliujia edited a comment on pull request #1476:
URL: https://github.com/apache/hadoop-ozone/pull/1476#issuecomment-705114071
LGTM
@adoroszlai so for creating a new module that generates proto, the changes
in this PR seems required. Will apply such change in the future when I create
amaliujia commented on pull request #1476:
URL: https://github.com/apache/hadoop-ozone/pull/1476#issuecomment-705114071
LGTM
@adoroszlai so for creating a new module, the changes in this PR seems
required. Will apply such change in the future when I create new modules.
--
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501215658
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @@
+/*
adoroszlai commented on pull request #1476:
URL: https://github.com/apache/hadoop-ozone/pull/1476#issuecomment-705108450
@amaliujia item 3 is related to HDDS-4242.
This is an automated message from the Apache Git Service.
To
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501207900
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @@
+/*
amaliujia commented on pull request #1482:
URL: https://github.com/apache/hadoop-ozone/pull/1482#issuecomment-705101169
R: @elek Can you take a look please?
BTW, the next PR should be the last PR because of the complicated
dependency issue. For all left migration, I will have to fin
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501204848
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @@
+/*
adoroszlai opened a new pull request #1483:
URL: https://github.com/apache/hadoop-ozone/pull/1483
## What changes were proposed in this pull request?
AspectJ-Maven-Plugin is [not compatible with Java
9](https://github.com/mojohaus/aspectj-maven-plugin/issues/24) or later as of
the c
vivekratnavel commented on pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#issuecomment-705037905
@adoroszlai Thanks for the review and @frischHWC thanks for the
contribution.
This is an automated
vivekratnavel merged pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
runzhiwang commented on pull request #1371:
URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-704986134
> > @bshashikant Thanks for suggestions. Actually, RandomLeaderChoosePolicy
does not choose datanode, it return null in
[chooseLeader](https://github.com/apache/hadoop-o
codecov-io commented on pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#issuecomment-704962201
#
[Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1478?src=pr&el=h1)
Report
> Merging
[#1478](https://codecov.io/gh/apache/hadoop-ozone/pull/1478?src=pr&el=
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501043202
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501041763
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501040679
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,260 @@
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501040679
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,260 @@
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501022137
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
##
@@ -253,4 +253,33 @@ publ
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500980993
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
##
@@ -253,4 +253,33 @@ publi
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500976257
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,260 @@
+/**
+
rakeshadr commented on pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#issuecomment-704863482
Thanks a lot @bharatviswa504 and @linyiqun for the review efforts and useful
comments. I've made another commit by addressing your comments.
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500920112
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -129,6 +132,10 @@
* |--
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500919915
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,260 @@
+/**
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500919741
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,260 @@
+/**
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500919600
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,260 @@
+/**
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500919334
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @@
+/*
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500914750
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected OmMe
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500914750
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -227,6 +247,9 @@ protected OmMe
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500913715
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @@
+/*
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500911479
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,283 @@
+/*
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500911297
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
##
@@ -126,6 +144,23 @@ public void setDataSize(
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500910910
##
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/file/TestOMFileCreateRequestV1.java
##
@@ -0,0 +1,456 @@
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500909870
##
File path:
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/OMMetadataManager.java
##
@@ -399,4 +399,15 @@ String getMul
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500910318
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/file/OMFileCreateResponseV1.java
##
@@ -0,0 +1,81 @@
+/
adoroszlai commented on pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#issuecomment-704792520
Thanks @frischHWC for updating the patch. Sorry, I forgot
`TestOzoneConfigurationFields`, a unit test that checks whether properties in
`ozone-default.xml` and the `*Co
adoroszlai commented on pull request #1472:
URL: https://github.com/apache/hadoop-ozone/pull/1472#issuecomment-704783593
> One thing I notice that you suggest use LineLengthCheck instead of
LineLength module. I think it is typo
Today I learned: both forms work fine.
However, y
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500795676
##
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/file/TestOMFileCreateRequest.java
##
@@ -146,7 +141,7 @@
amaliujia opened a new pull request #1482:
URL: https://github.com/apache/hadoop-ozone/pull/1482
## What changes were proposed in this pull request?
Copy UserVolumeInfo to PersistedUserVolumeInfo in interface-storage
## What is the link to the Apache JIRA
https://issues.
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500805730
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
##
@@ -413,7 +461,8 @@ public KeyInfo getProtobuf
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500782708
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -129,6 +132,10 @@
* |---
frischHWC commented on a change in pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#discussion_r500779381
##
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServerConfigKeys.java
##
@@ -60,31 +60,31 @@
public static
adoroszlai commented on a change in pull request #1425:
URL: https://github.com/apache/hadoop-ozone/pull/1425#discussion_r499007546
##
File path:
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/helpers/TestInstanceHelper.java
##
@@ -0,0 +1,67 @@
+/**
+ * Licensed
vivekratnavel commented on pull request #1481:
URL: https://github.com/apache/hadoop-ozone/pull/1481#issuecomment-704705403
@dineshchitlangia Good catch! Thanks for the review!
This is an automated message from the Apache Git
bshashikant commented on pull request #1371:
URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-704702172
> @bshashikant Thanks for suggestions. Actually, RandomLeaderChoosePolicy
does not choose datanode, it return null in
[chooseLeader](https://github.com/apache/hadoop-oz
bshashikant edited a comment on pull request #1371:
URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-704702172
> @bshashikant Thanks for suggestions. Actually, RandomLeaderChoosePolicy
does not choose datanode, it return null in
[chooseLeader](https://github.com/apache/ha
adoroszlai commented on a change in pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#discussion_r500733595
##
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java
##
@@ -205,12 +205,12
dineshchitlangia commented on a change in pull request #1481:
URL: https://github.com/apache/hadoop-ozone/pull/1481#discussion_r500704979
##
File path: hadoop-ozone/pom.xml
##
@@ -294,7 +294,7 @@
src/test/resources/ssl/*
src/main/compose/ozonesecure/d
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500677311
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeyCommitResponseV1.java
##
@@ -0,0 +1,61 @@
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500676583
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,260 @@
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500676200
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,260 @@
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500674939
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,260 @@
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500674381
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java
##
@@ -0,0 +1,260 @@
vivekratnavel commented on pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#issuecomment-704627172
@frischHWC Thanks for working on this! The patch looks good to me except the
failing checkstyles. Please fix those longer lines and I can merge it.
```
hado
vivekratnavel opened a new pull request #1481:
URL: https://github.com/apache/hadoop-ozone/pull/1481
## What changes were proposed in this pull request?
Upgrade angular from 1.7.9 -> 1.8.0
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-
bharatviswa504 commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500642282
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,289 @
xiaoyuyao commented on pull request #1472:
URL: https://github.com/apache/hadoop-ozone/pull/1472#issuecomment-704608201
Thanks @adoroszlai for the review. The suggested change LGTM, I will make
change in the next commit. One thing I notice that you suggest use
LineLengthCheck instead of Li
hanishakoneru opened a new pull request #1480:
URL: https://github.com/apache/hadoop-ozone/pull/1480
## What changes were proposed in this pull request?
In a non-Ratis OM, the transaction index used to generate ObjectID is reset
on OM restart. This can lead to duplicate ObjectIDs whe
avijayanhwx merged pull request #1457:
URL: https://github.com/apache/hadoop-ozone/pull/1457
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
adoroszlai opened a new pull request #1479:
URL: https://github.com/apache/hadoop-ozone/pull/1479
## What changes were proposed in this pull request?
1. Create a separate instance of `FileSystem` in `HadoopFsGenerator` for
each test thread.
2. Move directory creation to test setup
frischHWC opened a new pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478
## What changes were proposed in this pull request?
Fix recon configs inconsistent
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4309?jql=pro
prashantpogde commented on a change in pull request #1457:
URL: https://github.com/apache/hadoop-ozone/pull/1457#discussion_r500475653
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##
@@ -240,8 +247,19 @@ public VersionR
rakeshadr commented on pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#issuecomment-704430445
Thanks a lot @linyiqun for the review comments and I have updated PR
addressing the same. Please take another look at it when you get a chance.
-
rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r500470079
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
##
@@ -413,7 +461,8 @@ public KeyInfo getProtobu
errose28 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r500389769
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java
##
@@ -0,0 +1,233 @@
+/
adoroszlai opened a new pull request #1477:
URL: https://github.com/apache/hadoop-ozone/pull/1477
## What changes were proposed in this pull request?
Fix Jira, abstract and the link to the doc attached to HDDS-1466.
https://issues.apache.org/jira/browse/HDDS-4311
## How
errose28 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r500393541
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/AbstractOMKeyDeleteResponse.java
##
@@ -0,0 +1,150 @
errose28 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r500391837
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java
##
@@ -0,0 +1,233 @@
+/
errose28 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r500389769
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java
##
@@ -0,0 +1,233 @@
+/
401 - 500 of 12474 matches
Mail list logo
