https://bugzilla.redhat.com/show_bug.cgi?id=1024589
Tom Hughes t...@compton.nu changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
---
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Tom, sorry for the slow response. I think that the naming proposed by Jamie is
OK: nodejs-zlibjs and js-zlib. The tarball is called zlibjs, so even upstream
seems to skip
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Argh, wrong url:
Spec URL: http://in.waw.pl/~zbyszek/fedora/js-zlib.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/js-zlib-0.2.0-3.fc20.src.rpm
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
Jamie Nguyen jamieli...@fedoraproject.org changed:
What|Removed |Added
Blocks||1077322
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
Jamie Nguyen jamieli...@fedoraproject.org changed:
What|Removed |Added
Blocks|977137 |
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
--- Comment #8 from Jamie Nguyen jamieli...@fedoraproject.org ---
(And in case it wasn't obvious, the symlink is so that we aren't building the
same source twice, which would seem less than ideal.)
--
You are receiving this mail because:
You
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
--- Comment #9 from Tom Hughes t...@compton.nu ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues
==
[!]: Rpmlint is run on all installed
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
--- Comment #10 from Tom Hughes t...@compton.nu ---
Other than the rpmlint warning, my other question is whether we should be
packaging the .map files?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
--- Comment #11 from Jamie Nguyen jamieli...@fedoraproject.org ---
Hmmm. They would be useful to have. I'm not sure what the guidelines would say
about having the *.map in jsdir along with the rest of the minified javascript,
but since they
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
--- Comment #12 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Package looks OK.
The rpmlint warning is bogus: reimplemented is what is commonly used, and
re-implemented looks foreign.
--
You are receiving this mail because:
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
--- Comment #4 from Jamie Nguyen jamieli...@fedoraproject.org ---
Spec URL: http://jamielinux.fedorapeople.org/gruntjs/js-zlib.spec
SRPM URL:
http://jamielinux.fedorapeople.org/gruntjs/SRPMS/js-zlib-0.2.0-2.fc21.src.rpm
* Fri Mar 14 2014
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
Jamie Nguyen jamieli...@fedoraproject.org changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
Tom Hughes t...@compton.nu changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
--- Comment #2 from Tom Hughes t...@compton.nu ---
First things first, latest upstream release is 0.2.0 so this needs updating to
that.
Next, and before I do a full review, I think we need to establish what rules we
are working to here. There
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
Sandro Mani manisan...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
Sandro Mani manisan...@gmail.com changed:
What|Removed |Added
Status|ASSIGNED|NEW
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
Bug 1024589 depends on bug 1023848, which changed state.
Bug 1023848 Summary: Review Request: closure-compiler - JavaScript minifier and
checker
https://bugzilla.redhat.com/show_bug.cgi?id=1023848
What|Removed
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:
What|Removed |Added
Blocks||977137
https://bugzilla.redhat.com/show_bug.cgi?id=1024589
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:
What|Removed |Added
Depends On||1023848
19 matches
Mail list logo
