https://bugzilla.redhat.com/show_bug.cgi?id=1201662
Jonathan Underwood jonathan.underw...@gmail.com changed:
What|Removed |Added
Flags|fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #15 from Marek Skalický mskal...@redhat.com ---
I agree. Sorry, moved.
Spec URL: https://mskalick.fedorapeople.org/wiredtiger/wiredtiger.spec
SRPM URL:
https://mskalick.fedorapeople.org/wiredtiger/wiredtiger-2.5.1-5.fc23.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #17 from Marek Skalický mskal...@redhat.com ---
Changed...
Jonathan, thank you very much for the review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #13 from Marek Skalický mskal...@redhat.com ---
(In reply to Jonathan Underwood from comment #12)
Package Review
Issues:
===
- Packages have proper BuildRequires/Requires on jpackage-utils
The -java package should
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #14 from Jonathan Underwood jonathan.underw...@gmail.com ---
Hmm... You've put the Requires: jpackage-utils in the main package, rather than
the -java sub-package. I believe it should be in the -java sub-package.
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #12 from Jonathan Underwood jonathan.underw...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Packages have
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #11 from Marek Skalický mskal...@redhat.com ---
(In reply to Jonathan Underwood from comment #9)
Still some rpmlint flagged issues:
(1)
wiredtiger.src:66: W: rpm-buildroot-usage %build sed -i -r
s|(\(PYTHON_INSTALL_ARG\))|\1
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
Jonathan Underwood jonathan.underw...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #5 from Jonathan Underwood jonathan.underw...@gmail.com ---
(In reply to Marek Skalický from comment #3)
(In reply to Jonathan Underwood from comment #1)
Output of rpmlint following a mock rebuild of the packages:
$ rpmlint
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #2 from Jonathan Underwood jonathan.underw...@gmail.com ---
Hi Merek,
A number of those rpmlint messages need fixes, so I'll wait for an updated
package before doing the full review.
--
You are receiving this mail because:
You
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #4 from Marek Skalický mskal...@redhat.com ---
Spec URL: https://mskalick.fedorapeople.org/wiredtiger/wiredtiger.spec
SRPM URL:
https://mskalick.fedorapeople.org/wiredtiger/wiredtiger-2.5.1-2.fc23.src.rpm
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #3 from Marek Skalický mskal...@redhat.com ---
(In reply to Jonathan Underwood from comment #1)
Output of rpmlint following a mock rebuild of the packages:
$ rpmlint *.rpm
wiredtiger.src: W: name-repeated-in-summary C
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
Jonathan Underwood jonathan.underw...@gmail.com changed:
What|Removed |Added
Flags|
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #1 from Jonathan Underwood jonathan.underw...@gmail.com ---
Output of rpmlint following a mock rebuild of the packages:
$ rpmlint *.rpm
wiredtiger.src: W: name-repeated-in-summary C WiredTiger
wiredtiger.src:64: W:
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #8 from Marek Skalický mskal...@redhat.com ---
Yes I know, sorry. I weren't able to connect fedorapeople...
Spec URL: https://mskalick.fedorapeople.org/wiredtiger/wiredtiger.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #6 from Marek Skalický mskal...@redhat.com ---
(In reply to Jonathan Underwood from comment #5)
(In reply to Marek Skalický from comment #3)
(In reply to Jonathan Underwood from comment #1)
Output of rpmlint following a mock
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #7 from Jonathan Underwood jonathan.underw...@gmail.com ---
OK, great - don't forget to upload the fixed spec and srpm. :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #9 from Jonathan Underwood jonathan.underw...@gmail.com ---
Still some rpmlint flagged issues:
(1)
wiredtiger.src:66: W: rpm-buildroot-usage %build sed -i -r
s|(\(PYTHON_INSTALL_ARG\))|\1 --no-compile --install-dir
https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #10 from Jonathan Underwood jonathan.underw...@gmail.com ---
Also, small nits:
(1) This:
%files python
%dir %{python_sitelib}/%{name}
%{python_sitelib}/%{name}/*
is redundant... simply:
%files python
%{python_sitelib}/%{name}
19 matches
Mail list logo
