[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|---

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #97 from Rick Tierney --- Ok, I guess I close this BZ. Thanks for all of your help! Rick -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and compon

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #96 from Michal Schmidt --- I don't know. Try asking on the devel mailing list (de...@lists.fedoraproject.org). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #95 from Rick Tierney --- Ok. Is there anyway to configure Koji to permanently use our proxy regardless of whether we call koji directly or if it's called by fedpkg? I looked at the /etc/koji.conf file but didn't see any proxy ref

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #94 from Michal Schmidt --- > Maybe ssh accounts on fedorapeople.org could be used for that? Ah, no, because no private keys are allowed on fedorapeople.org. -- You are receiving this mail because: You are on the CC list for the

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Michal Schmidt changed: What|Removed |Added Flags|needinfo?(nhor...@redhat.co | |m)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #91 from Michal Schmidt --- That's likely due to a firewall at Intel. I replied to Rick in private with some advice (the whole world does not need to know the details, such as internal hostnames). -- You are receiving this mail b

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #90 from Doug Ledford --- OK, there's something wrong in your ssh config or else there is something blocking ssh. Can you ssh to other machines? What if you remove your password from your ssh key? Is it possible your ssh-agent i

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #89 from Rick Tierney --- I tried to clone using fedpkg again; this is the error I'm getting: [rjtierne@phbppriv13 fedora-scm]$ fedpkg clone opa-fmgui Cloning into 'opa-fmgui'... ssh: connect to host pkgs.fedoraproject.org port 22

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Doug Ledford changed: What|Removed |Added Flags|needinfo? needinfo? | --- Comment #88 from Doug Ledford --

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo? --- Comment #87 from Rick Ti

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo? --- Comment #86 from Rick Ti

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #85 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/opa-fmgui -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about cha

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #84 from Rick Tierney --- Hi Michal: It wasn't clear what URL to put in that field so I put the wrong value there; I will try again! Thanks! Rick -- You are receiving this mail because: You are on the CC list for the bug. You

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Michal Schmidt changed: What|Removed |Added Flags|needinfo?(nhor...@redhat.co | |m)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #80 from Michal Schmidt --- (In reply to Neil Horman from comment #79) > Thank you Rick. You're approved as a sponsor now Correction: s/sponsor/packager/ -- You are receiving this mail because: You are on the CC list for the bu

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags|needinfo?(rick.tierney@inte |needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags|needinfo?(nhor...@redhat.co |needinfo?(rick.tierney@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags|needinfo?(rick.tierney@inte |needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags|needinfo?(nhor...@redhat.co |needinfo?(rick.tierney@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags|needinfo?(rick.tierney@inte |needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags|needinfo?(nhor...@redhat.co |needinfo?(rick.tierney@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #74 from Rick Tierney --- Okay Jarod, thanks! I do have the e-mail rick.tier...@intel.com set on both the Fedora and Bugzilla accounts. -- You are receiving this mail because: You are on the CC list for the bug. You are always n

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #73 from Jarod Wilson --- Your bugzilla login doesn't need to match the FAS login, it needs to match the email address on file with FAS tied to your login. Bugzilla login usernames are generally (always) email addresses, FAS uses u

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #71 from Rick Tierney --- (In reply to Rick Tierney from comment #70) > (In reply to Neil Horman from comment #68) > > Additionally, what is your fedora account user name? It needs to be the > > same as your bugzilla account, but

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #70 from Rick Tierney --- (In reply to Neil Horman from comment #68) > Additionally, what is your fedora account user name? It needs to be the > same as your bugzilla account, but I don't seem to find it. This is strange! My acco

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags|needinfo?(rick.tierney@inte | |l.com)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags||needinfo?(rick.tierney@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags|needinfo?(rick.tierney@inte | |l.com)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags||needinfo?(rick.tierney@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags|needinfo?(rick.tierney@inte | |l.com)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags|needinfo?(nhor...@redhat.co | |m)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-07-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #60 from Rick Tierney --- Great! It was a long road, but I'm glad it's done! Thanks to everyone for all of your help! Rick -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags|needinfo?(nhor...@redhat.co |fedora-review+ |m)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags|needinfo?(rick.tierney@inte |needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #57 from Rick Tierney --- Thanks Doug, that's a great explanation! I followed Option 1 and saw that the documentation was copied to /usr/share/doc/opa-fmgui and the licenses were copied to /usr/share/licenses/opa-fmgui. After re

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags||needinfo?(rick.tierney@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #56 from Doug Ledford --- Looking at your spec file, you are placing your license files and other non-runtime files in your runtime java directory. I don't know if that's standard or not. But there are a couple ways of solving th

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags|needinfo?(rick.tierney@inte | |l.com)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags||needinfo?(rick.tierney@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #54 from Rick Tierney --- I see! Yes I do have /usr/share/java/opa-fmgui under %files... so that's why the duplicates. I will revise this and try again. Thanks! -- You are receiving this mail because: You are on the CC list for t

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #53 from Doug Ledford --- (In reply to Rick Tierney from comment #52) > Neil: > > Now that you have run the review (which seems slightly different from the > way I do), I can see where some things are wrong and some things I'm not

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #52 from Rick Tierney --- Neil: Now that you have run the review (which seems slightly different from the way I do), I can see where some things are wrong and some things I'm not sure why they're being flagged: 1. - Package does

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #51 from Neil Horman --- Looks pretty good, a few minor nits and I think we're good to go. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Iss

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags|needinfo?(robert.amato@inte | |l.com)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #49 from Neil Horman --- I'm not sure what problem you ran into but its working fine for me. I've closed your new bz as a dup of this one, and will continue the review here -- You are receiving this mail because: You are on the

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #48 from Neil Horman --- *** Bug 1348668 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and compon

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #46 from Rick Tierney --- Spec URL: https://github.com/01org/opa-fmgui/releases/download/v1.4/opa-fmgui.spec SRPM URL: https://github.com/01org/opa-fmgui/releases/download/v1.4/opa-fmgui-10.0.0.0.3-4.fc25.src.rpm Description: The

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo? --- Comment #45 from Rick Ti

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #44 from Jarod Wilson --- dnf localinstall opa-fmgui-10.0.0.0.3-3.fc25.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Attachment|0 |1 #1162275 is|

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #42 from Don Dutile --- +1 to what Jarod said. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component __

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #41 from Jarod Wilson --- "Requires" means "you cannot install this package without this/these packages already installed, unless you force it". That is 100% by design. That's what we have things like yum and dnf for -- they automa

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-06-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added CC||robert.am...@intel.com Flags

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #38 from Rick Tierney --- Sorry Neil I didn't mean to imply you didn't know what jar files were. I was just trying to get to the bottom of the misunderstanding. In any case, I understand your point of view and I will attempt to in

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags|needinfo?(robert.amato@inte | |l.com)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #34 from Neil Horman --- Well, just to be clear, what I'm saying is that both the binaries and the licenses should be removed, so you're not really using the 3rd party jar file at all. The only exception is the gritty jar file, fo

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #33 from Rick Tierney --- Thanks Neil! I will review this with our Legal team but it sounds like we should remove the 3rd party jar files after we build opa-fmgui and get rid of the licenses altogether. This surprises me a little

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #32 from Neil Horman --- Rick, ideally it would be better if you just removed the libraries that you are pulling in via build requires from the project alltogether, but given that the license tag is supposed to apply to the binary

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Attachment|0 |1 #1162001 is|

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags|needinfo?(nhor...@redhat.co | |m)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #27 from Rick Tierney --- Great, I'm glad that we cleared that up! We don't have immediate plans to replace gritty, but it is likely that we will implement our own version of this functionality in the future. Thanks! -- You are

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #25 from Rick Tierney --- Created attachment 1162001 --> https://bugzilla.redhat.com/attachment.cgi?id=1162001&action=edit opa-fmgui spec file I'm a bit unsure of your use of the term "incorporations", so let me clarify... The

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #26 from Neil Horman --- oh, you're right, my bad. I saw the license issues you put up and assumed you were using them direct from your project. You're good on hibernate and jfreechart As for gritty, I concur with your approach.

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags|needinfo? | --- Comment #24 from Neil Horman ---

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo? --- Comment #23 from Rick Ti

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #22 from Rick Tierney --- I started researching the issue this morning, and in addition to the link you sent, I believe there is some evidence that it can be done; but I will have to run some tests to see if I can get this working.

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags||needinfo?(robert.amato@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #20 from Rick Tierney --- The classpath is needed for dependency resolution at run-time, whereas maven and ant are build tools only used at compile-time. I don't currently have a solution for the removal of the Class-Path field fr

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #19 from Neil Horman --- The URL tag is a bit arbitrary. rpmlint flags it for various conditions, but just pointing it to a wiki page for the project should be sufficient. For the source URL you should be able to tag a version o

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #18 from Rick Tierney --- Thanks, that works! Ok, so I have a few issues I'll need help with... Rpmlint (4 warnings) - 1. The URL tag is supposed to point to a public web site where we have documentation, but

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Honggang LI changed: What|Removed |Added Flags|needinfo?(robert.amato@inte | |l.com) needinfo?

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo? --- Comment #16 from Rick Ti

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added CC||rick.tier...@intel.com --- Comment #15

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-05-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #14 from Honggang LI --- Robert, any update? thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #13 from Neil Horman --- What you need to do is go through the code and determine which code is licensed in which way. Your spec file indicates its all BSD, but the docs in the source tarball indicate their are multiple licenses.

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #12 from robert.am...@intel.com --- (In reply to Neil Horman from comment #6) > > This is a review *template*. Besides handling the [ ]-marked tests you are > also supposed to fix the template before pasting into bugzilla: > - Add

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags||needinfo?(robert.amato@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #11 from robert.am...@intel.com --- (In reply to Honggang LI from comment #10) > Please fix those issues pointed out by Neil. Will do. -- You are receiving this mail because: You are on the CC list for the bug. You are always not

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #10 from Honggang LI --- Please fix those issues pointed out by Neil. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 robert.am...@intel.com changed: What|Removed |Added Flags|needinfo?(robert.amato@inte | |l.com)

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Honggang LI changed: What|Removed |Added Flags||needinfo?(robert.amato@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #7 from Honggang LI --- (In reply to Neil Horman from comment #6) > [x]: Package consistently uses macros (instead of hard-coded directory > names). > [!]: Package is named according to the Package Naming Guidelines. > > Pack

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #6 from Neil Horman --- This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags||needinfo?(robert.amato@inte

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Honggang LI changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mai

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #5 from Neil Horman --- perfect, thank you! I'll run the review now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

2016-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 robert.am...@intel.com changed: What|Removed |Added Flags|needinfo?(robert.amato@inte | |l.com)

  1   2   >