[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 Simone Caronni changed: What|Removed |Added Status|ASSIGNED|CLOSED

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 Luya Tshimbalanga changed: What|Removed |Added Blocks||485251

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #21 from Luya Tshimbalanga --- Thank you Simone! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 Simone Caronni changed: What|Removed |Added Flags|fedora-review? |fedora-review+

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #19 from Luya Tshimbalanga --- (In reply to Simone Caronni from comment #18) > Please, the next time you post a package for review make sure that at least > it builds and at least check through the main

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #18 from Simone Caronni --- Please, the next time you post a package for review make sure that at least it builds and at least check through the main guidelines. -- You are receiving this mail because: You

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #17 from Simone Caronni --- There are many things to fix here. You have to remove the line: %{_libdir}/%{yname}_v3_interface.py* from the files section to make it build. YafaRay.src: W: spelling-error

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #16 from Luya Tshimbalanga --- In reply to Simone Caronni from comment #8) > Sorry, now that you implemented the conditionals for setting source urls > with conditionals you might want to do the same for

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #15 from Simone Caronni --- Forgot one thing, you require the following: BuildRequires: libappstream-glib For the AppData validation in %check. -- You are receiving this mail because: You are on the CC

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #14 from Simone Caronni --- The install section should be like this: %install %make_install VERBOSE=1 # Let RPM pick docs in the file section rm -fr %{buildroot}%{_docdir}/%{yname} And then I had to

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #13 from Simone Caronni --- Sorry, I made a typo in comment #10; these are the parameters (Debug/ON): -DCMAKE_SKIP_RPATH:BOOL=true \ -DDEBUG_BUILD=ON \ -DUSER_DBGFLAGS="%{optflags}" \ -- You

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #12 from Simone Caronni --- Ok, you just need the following to get verbose building: %make_build VERBOSE=1 I confirm the compiler flags are correct with the above settings as in comment #10. -- You are

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #11 from Simone Caronni --- Sed commands do not work for me in the form you've written them. If I check the CMakeLists.txt file I don't see any change. I've changed them from what's written in the spec file

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #10 from Simone Caronni --- I've played a bit with CMake options, with these 3 options you can fix Debuginfo extraction, Compiler flags and Runtime paths: -DCMAKE_SKIP_RPATH:BOOL=true \

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #9 from Simone Caronni --- While building, I see lots of messages like this one: -- Set runtime path of "/builddir/build/BUILDROOT/YafaRay-3.2.0-0.2.20170212git.fc25.x86_64/usr/lib/libyafaray_v3_core.so" to

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #8 from Simone Caronni --- (In reply to Luya Tshimbalanga from comment #7) > SRPM URL: > https://luya.fedorapeople.org/packages/SRPMS/YafaRay-3.2.0-0.2.git20170212. > fc25.src.rpm Actual URL is:

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #7 from Luya Tshimbalanga --- Here is the updated files with latest git snapshot Spec URL: https://luya.fedorapeople.org/packages/SPECS/YafaRay.spec SRPM URL:

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #6 from Simone Caronni --- Alternatively, you can also set the conditions to check dynamically for the source url to check snapshots and for the release tag, for example: Release:

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #5 from Simone Caronni --- There is libtiff missing in the build dependencies, build fails with: Make Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:148 (message): Could NOT find

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #4 from Luya Tshimbalanga --- Here is the updated files with latest git snapshot Spec URL: https://luya.fedorapeople.org/packages/SPECS/YafaRay.spec SRPM URL:

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 Simone Caronni changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #3 from Luya Tshimbalanga --- (In reply to Michael Schwendt from comment #2) > > Source0: > > Source1: > > 404 not found Fixed > > > > %package blender > > Summary: Blender integration scripts > >

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #2 from Michael Schwendt --- > Source0: > Source1: 404 not found > %package blender > Summary: Blender integration scripts > Requires: %{name} = %{version}-%{release} Since there are arch-specific builds

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #1 from Luya Tshimbalanga --- This package is a revival of the recently retired version. The build will not work but I think this is a place to provide guidance and suggestion. -- You are receiving this