[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 Neal Gompa changed: What|Removed |Added Status|NEW |CLOSED Resolution|---

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #23 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-yarn -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ ---

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #21 from Zuzana Svetlikova --- Rebuilt with new nodejs-packaging. Spec URL: https://fedorapeople.org/~zvetlik/nodejs-yarn/nodejs-yarn.spec SRPM URL:

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #20 from Neal Gompa --- Also, the spec and SRPM don't match, at least with the changelog, though it looks like it's because you fixed the changelog entries in the spec... -- You are receiving this mail

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #19 from Neal Gompa --- The nodejs-yarn package has "npm()" Provides for all the bundled nodejs modules, which would confuse and break things. -- You are receiving this mail because: You are on the CC list

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #18 from Zuzana Svetlikova --- Spec URL: https://fedorapeople.org/~zvetlik/nodejs-yarn/nodejs-yarn.spec SRPM URL: https://fedorapeople.org/~zvetlik/nodejs-yarn/nodejs-yarn-1.5.1-2.fc29.src.rpm -- You are

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #17 from Neal Gompa --- The SRPM URL is invalid. Please post a working SRPM link. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #16 from Zuzana Svetlikova --- So, I looked into it.. it generated provides just fine, and for requires it skips the uppermost node_modules directory, but still generates requires for bundled modules. Here I

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 Peter Oliver changed: What|Removed |Added CC||ma...@mavit.org.uk

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #14 from Tom Hughes --- Ah it has generated both sorts of provide and also requires. That is a bug... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #13 from Tom Hughes --- That does look like something has gone wrong with the dependency generator :-( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #12 from Tom Hughes --- Build is failing for me anyway because it's still trying to symlink global modules in %check... Might work in mock I guess. -- You are receiving this mail because: You are on the CC list

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #11 from Tom Hughes --- If the bundling is done properly then the generator auto generate bundled() provides instead of normal ones? -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #10 from Neal Gompa --- The package looks good, though there is one problem: * nodejs-yarn is producing Provides + Requires for node modules that are already bundled in the package. This would cause a lot of

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #9 from Zuzana Svetlikova --- So I tried packaging from GH and avoiding webpack, so all the node modules don't end up squashed in one file. Spec URL:

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #8 from Tom Hughes --- Also this is installing in /usr/lib/node_modules/nodejs-yarn which should be /usr/lib/node_modules/yarn. -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 Tom Hughes changed: What|Removed |Added CC||t...@compton.nu ---

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #6 from Zuzana Svetlikova --- That would be the case if I were building yarn from GH sources. In this case I just install the (already built) tarball. -- You are receiving this mail because: You are on the

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #5 from Neal Gompa --- (In reply to Zuzana Svetlikova from comment #4) > > Upstream does not advise that yarn sources are retrieved from npm and > > suggest it should be packaged from the pristine sources

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #4 from Zuzana Svetlikova --- > Upstream does not advise that yarn sources are retrieved from npm and suggest > it should be packaged from the pristine sources uploaded to GitHub. I haven't seen such

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 Neal Gompa changed: What|Removed |Added Flags|needinfo?(ngomp...@gmail.co |

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 Zuzana Svetlikova changed: What|Removed |Added Flags|

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

https://bugzilla.redhat.com/show_bug.cgi?id=1518262 Zuzana Svetlikova changed: What|Removed |Added Blocks||956806