[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 dan.cer...@cgc-instruments.com changed: What|Removed |Added Status|POST|CLOSED

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #29 from Till Hofmann --- Since we can't add this package to Fedora releases older than F30 (due to the renaming), I set up a COPR so we can have bear for those releases: https://copr.fedorainfracloud.org/coprs/thofmann/bear/ I

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #28 from dan.cer...@cgc-instruments.com --- (In reply to Darryl T. Agostinelli from comment #27) > > it is not being submitted for EPEL > Of course that is your choice, though supporting EPEL can increase your > package's reach.

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #27 from Darryl T. Agostinelli --- A small comment. - You can compact this: %if 0%{?fedora} BuildRequires: python3-lit %endif To this: %{?fedora:BuildRequires: python3-lit} - Re: EPEL > it is not being submitted for EPEL

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #26 from dan.cer...@cgc-instruments.com --- Spec URL: https://pagure.io/Bear_rpm/raw/master/f/bear.spec SRPM URL:

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #25 from dan.cer...@cgc-instruments.com --- Spec URL: https://pagure.io/Bear_rpm/raw/master/f/bear.spec SRPM URL:

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #24 from Till Hofmann --- Some remarks: - The license should be GPLv3+, not GPLv3. - As Robert-André pointed out, you don't need to Require python. - The shebang replacement should keep the timestamp. Your version is also not

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 Till Hofmann changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #23 from Till Hofmann

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #21 from dan.cer...@cgc-instruments.com --- > I'm only talking about the archive name, instead of %{version}.tar.gz use > %{name}-%{version}.tar.gz. It it less ambiguous. > > - Use a more meaningful name for your archive: > >

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #20 from Robert-André Mauchin --- (In reply to dan.cermak from comment #19) > Thanks for the extensive review, I have tried to address most of the issues > and pushed the new version to pagure >

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #19 from dan.cer...@cgc-instruments.com --- Thanks for the extensive review, I have tried to address most of the issues and pushed the new version to pagure (https://pagure.io/Bear_rpm/blob/master/f/bear.spec) and copr

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #18 from dan.cer...@cgc-instruments.com --- > I would have preferred if you'd taken part in the ongoing effort to rename > and package instead of just submitting your own review request without any > prior coordination. But it's

[Bug 1565848] Review Request: bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #16 from Darryl T. Agostinelli --- > As pointed out on the mailing list and in #1539207, all distros other than > Fedora use the name bear. The general agreement on fedora devel was to rename > the current bear and use the name

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #15 from Till Hofmann --- I disagree. As pointed out on the mailing list and in #1539207, all distros other than Fedora use the name bear. The general agreement on fedora devel was to rename the current bear and use the name bear

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #14 from Darryl T. Agostinelli --- > I'd therefore keep the name, if that is unambiguous enough. I have also asked > upstream and the author would also be fine with calling it build-ear. Please use build-ear then. I think we

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 Till Hofmann changed: What|Removed |Added CC||thofm...@fedoraproject.org

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #12 from dan.cer...@cgc-instruments.com --- The conflicting package bear has been renamed to bear-factory (https://bugzilla.redhat.com/show_bug.cgi?id=1546544). I'd therefore keep the name, if that is unambiguous enough. I have

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #10 from Darryl T. Agostinelli --- I couldn't say what the best name would be, though naming it build-ear does sound appropriate to me. Yourself or upstream would know best. Renaming the existing project would involve working

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 dan.cer...@cgc-instruments.com changed: What|Removed |Added Depends On||1546544 Referenced

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #9 from dan.cer...@cgc-instruments.com --- Spec URL: https://pagure.io/Bear_rpm/raw/master/f/bear.spec SRPM URL:

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #8 from Darryl T. Agostinelli --- - Spec and SRPM URL Create a new comment with the first two lines being the spec and srpm links, like you did the first time. The fedora-review tool is smart enough to

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #7 from dan.cer...@cgc-instruments.com --- Thanks for the informal review! Unfortunately I don't know how to edit the original bugreport. Is it sufficient to include the url in a later message? Otherwise, I have updated the rpm

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 Darryl T. Agostinelli changed: What|Removed |Added CC|

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #5 from dan.cer...@cgc-instruments.com --- I have fixed the problem on EL, the new spec file now builds successfully on Copr (https://copr.fedorainfracloud.org/coprs/defolos/devel/build/740012/). -- You are receiving this mail

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #4 from dan.cer...@cgc-instruments.com --- And now the CentOS build failed. I'll report back when I have fixed it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #3 from dan.cer...@cgc-instruments.com --- My apologies, I have forgotten one unversioned python in the spec file. The Copr build without that is: https://copr.fedorainfracloud.org/coprs/defolos/devel/build/739830/ -- You are

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 --- Comment #2 from dan.cer...@cgc-instruments.com --- Thank you for the swift review! I have addressed your comments and fixed the issues. I have also uploaded the spec & patch file to pagure: https://pagure.io/Bear_rpm and pushed the new

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 Iwicki Artur changed: What|Removed |Added CC||fed...@svgames.pl

[Bug 1565848] Review Request: Bear - Tool that generates a compilation database for clang tooling

https://bugzilla.redhat.com/show_bug.cgi?id=1565848 dan.cer...@cgc-instruments.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR)