https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Mattia Verga changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #38 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/vcglib
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about ch
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Robert-André Mauchin changed:
What|Removed |Added
Summary|Review Request: vcglib |Review Request: vcglib -
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Robert-André Mauchin changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #37
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Robert-André Mauchin changed:
What|Removed |Added
Flags|fedora-review+ |fedora-review?
--
You are rec
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Assi
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
CC||sanjay.an...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #34 from J. Scheurich ---
Fedora Account System Username: muftii
Sorry, typo:
Fedora Account System Username: mufti11
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about cha
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #33 from J. Scheurich ---
Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.fc29.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Petr Menšík changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #31 from J. Scheurich ---
Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.fc29.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #30 from Petr Menšík ---
Thanks. However, there is still copy of all wrap into target directory, copying
there all cpp files not required.
Please remove these lines on line 44-45:
mkdir -p %{buildroot}%{_includedir}/%{name}
cp -a
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #29 from J. Scheurich ---
Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.fc29.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #28 from Petr Menšík ---
(In reply to J. Scheurich from comment #27)
>
> Updated specfile
Please!
in %build section remove lines:
mkdir -p %{buildroot}%{_includedir}/%{name}/wrap
cp -r vcg img %{buildroot}%{_includedir}/%{name}
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #27 from J. Scheurich ---
pec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short)
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #26 from J. Scheurich ---
Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short)
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #25 from Petr Menšík ---
Please remove %{build}%{_includedir} and %{build}%{_datarootdir} from both
build and install sections.
rpm -E '%{build}' is not defined and expands just to the same text. That is
wrong.
Use just pkgconfig
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #24 from J. Scheurich ---
pec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short)
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #23 from Petr Menšík ---
Oh, noticed just now. Thank you for moving to build phase. But %{build} is not
defined in such phase, nor is %{buildroot}. It should just work relative to
current directory.
find "%{build}%{_includedir}/%{
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #22 from Petr Menšík ---
Any cpp file should NOT be part of devel package anyway, I had on mind.
If getopt is nowhere used, just delete wrap/system/getopt.*
wrap/system/qgetopt.* in prep or build.
I think if you add GPLv2+ to Lic
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #21 from Petr Menšík ---
(In reply to J. Scheurich from comment #20)
> (In reply to Petr Menšík from comment #19)
> Is there soemthing is could do with the getopt problem ?
> It looks like vcglib shios its own version of getopt 8-(
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #20 from J. Scheurich ---
(In reply to Petr Menšík from comment #19)
> Rpmlint
> ---
...
> vcglib-devel.x86_64: E: incorrect-fsf-address
> /usr/include/vcglib/wrap/system/getopt.cpp
> vcglib-devel.x86_64: E: incorrect-fsf-addre
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #19 from Petr Menšík ---
Almost there. License tag is wrong, most headers have GPLv2 or later, while
some files have no license tags. Since there is conflict between main license
file and file headers, both must be declared in Lice
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #18 from J. Scheurich ---
Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short)
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #17 from Petr Menšík ---
No! No prefix of such kind is necessary here, on the contrary.
If you check what flags are supplied by pkg-config vcglib, which we have now
installed:
$ pkg-config --cflags vcglib
-I/usr/include/vcglib -I
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #16 from J. Scheurich ---
Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short)
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #15 from Petr Menšík ---
1)
Requires: %{name} is not enough. It has to be versioned, must depend on same.
And depend also on the same architecture. Like I mentioned in comment #13.
2)
eigenlib prefix from includes has to be remov
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #14 from J. Scheurich ---
Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short)
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Petr Menšík changed:
What|Removed |Added
CC||space...@gmail.com
Flags|
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #13 from Petr Menšík ---
One more thing, devel subpackage does not contain license. That is ok, but it
must depend on package that contains it.
%package devel must include:
Requires: %{name}%{?_isa} = %{name}-%{version}
--
You ar
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #12 from Petr Menšík ---
pkgconfig file is great, but please move creation of it into %prep section.
Just use cat > vcglib.pc ... in %prep, then in %install just:
install vcglib.pc %{buildroot}%{_datarootdir}/pkgconfig/vcglib.pc
P
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Petr Menšík changed:
What|Removed |Added
Blocks||1687351
Referenced Bugs:
https://bugz
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #11 from J. Scheurich ---
Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.fc30.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #10 from Petr Menšík ---
Found by coincidence, that meshlab project [1] already bundles this library.
That is a another reason to produce separate package that can be reused also by
it. Is seems to be high-quality project without s
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #9 from Petr Menšík ---
comment #1 states main package vcglib should be empty. It does not mean you
have to remove examples from tarball. I think on contrary, it should not be
deleted from source archive. We expect you would releas
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #8 from Petr Menšík ---
It would be very good if library had its own configure, which could prepare
also makefiles for all examples. Examples could be installed into some place.
But if they can verify library actually works, they s
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Petr Menšík changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Petr Menšík changed:
What|Removed |Added
Blocks||1658153
Referenced Bugs:
https://bugz
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #7 from Petr Menšík ---
Releases should be the same for any distribution, you should not make different
releases for Fedora only. Just include all software related to vcglib inside,
it is always possible to not install it. Examples
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #6 from Petr Menšík ---
second sed command is missing -i, should be
sed -e '/^#include/ s,"../../eigenlib/\(.*\)",<\1>,' -i math/eigen.h
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always n
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #5 from Petr Menšík ---
Removed eigenlib prefix with this command:
pushd vcg
sed -e '/^#include/ s/,' math/eigen.h
popd
However, libary itself does not provide any way to configure or build examples,
does it? No Makefile is provid
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #4 from J. Scheurich ---
The only test example in vcglib that uses a older Eigen3 version to not compile
with
the fedora 30 Eigen version:
$ pwd
/xxx/vcglib/apps/sample/trimesh_indexing
$ make
make: *** No rule to make target '.
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Petr Menšík changed:
What|Removed |Added
CC||pemen...@redhat.com
--- Comment #3 from
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #2 from J. Scheurich ---
Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.fc30.src.rpm
Description: The Visualization and Computer Graphics Library (VCG for short)
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
Jerry James changed:
What|Removed |Added
CC||loganje...@gmail.com
--- Comment #1 fro
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
J. Scheurich changed:
What|Removed |Added
Summary|Review Request: -|Graphics Library
--
You are rec
47 matches
Mail list logo
