https://bugzilla.redhat.com/show_bug.cgi?id=1926697
Didik Supriadi changed:
What|Removed |Added
CC||didiksupriad...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #42 from Tomas Hrcka ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/openjdk-asmtools
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #41 from Jaya ---
Sure :) Thank you!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #40 from jiri vanek ---
Thanx. The package is already approved,nothng changed in meantime.
Please proceed with release.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #39 from Jaya ---
Thank you Jiri!! That highly simplified version :)
Now the changes are done and verified.
Spec file URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #38 from jiri vanek ---
Hi!
you can simplify it a lot:
https://jvanek.fedorapeople.org/jaya/openjdk-asmtools.spec
https://jvanek.fedorapeople.org/jaya/openjdk-asmtools.in
Namely just added placeholder to the in file:
run @SCD@
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #37 from Jaya ---
Added sub-launchers. Could you please verify?
I have uploaded the changes:
Spec file URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
jiri vanek changed:
What|Removed |Added
Flags||fedora-review+
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #36 from jiri vanek ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- This seems like a Java package, please install
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #35 from Jaya ---
(In reply to jiri vanek from comment #33)
> @fabio
> Thanx a lot!
>
> @jaya
> You still mess the requires x buildrequires
> BuildRequires: java-headless
> is nonsense. Your build requires java-devel , which
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #34 from jiri vanek ---
Please add the sub launcher is you can, as for
https://bugzilla.redhat.com/show_bug.cgi?id=1926697#c20 and
https://bugzilla.redhat.com/show_bug.cgi?id=1926697#c19
That will cost you nothing and will be
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #33 from jiri vanek ---
@fabio
Thanx a lot!
@jaya
You still mess the requires x buildrequires
BuildRequires: java-headless
is nonsense. Your build requires java-devel , which is transitively inherited
from buildrequiring of
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #32 from Jaya ---
(In reply to Fabio Valentini from comment #30)
> %global major 7.0
> %global minor b10
> Name: openjdk-asmtools
> Version:%{major}.%{minor}
> Release:pre.0.1%{?dist}
>
> - "pre" does
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #31 from Jaya ---
(In reply to jiri vanek from comment #29)
> jaya, the javadoc package works for you? Is it empty, does rpm with it even
> exists?
> it do nto work for me. If it do not work for you, then you hsould probably
>
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
Fabio Valentini changed:
What|Removed |Added
Flags|needinfo?(decathorpe@gmail. |
|com)
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #29 from jiri vanek ---
jaya, the javadoc package works for you? Is it empty, does rpm with it even
exists?
it do nto work for me. If it do not work for you, then you hsould probably
remove all javadoc subpackage declarations.
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #28 from jiri vanek ---
jaya, pls use:
https://github.com/openjdk/asmtools/archive/7eadbbf8f41b8174f7991a5ad1fe79519fe108d4.tar.gz
As source. Feel free to use it as it is or rename it. But for sure use it in
the comment.
Please
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
jiri vanek changed:
What|Removed |Added
Flags||needinfo?(decathorpe@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #27 from jiri vanek ---
(In reply to Fabio Valentini from comment #23)
> I wonder where the .pre.0.1 part of the Version comes from?
To use this versioning was my suggestion, aas it is indeed pre of b10.
> It does not exist in
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #26 from Jaya ---
I have addressed the latest review comments and uploaded the files
Spec file URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #25 from Jaya ---
(In reply to Fabio Valentini from comment #23)
> I wonder where the .pre.0.1 part of the Version comes from?
> It does not exist in the upstream project.
>
> If you want to denote that it's a pre-release
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #24 from Jaya ---
(In reply to jiri vanek from comment #19)
> %global major 7.0
> %global minor b09
>
> Name: openjdk-asmtools
> Version:7.0.b10.pre.0.1
>
> I think it should be
>
> %global major 7.0
> %global
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #23 from Fabio Valentini ---
I wonder where the .pre.0.1 part of the Version comes from?
It does not exist in the upstream project.
If you want to denote that it's a pre-release snapshot, then you're doing it
wrong, since your
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #22 from jiri vanek ---
> [!] missing Requires java-headless. Please doule check that JRE is really the
> only needed thing and nothing from SDK is used.
java-headless is generated requirement. Pls verify it is enough. Nothng
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #21 from jiri vanek ---
[!] missing Requires java-headless. Please doule check that JRE is really the
only needed thing and nothing from SDK is used.
[!] bad version in changelog
[!] the javadoc package was not generated
[!]
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #20 from jiri vanek ---
Man page for: openjdk-asmtools is good. TY
Man pages for openjdk-asmtools-jasm, openjdk-asmtools-jdis,
openjdk-asmtools-jcoder, openjdk-asmtools-jdec and openjdk-asmtools-jcdec are
NOT necessary
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #19 from jiri vanek ---
%global major 7.0
%global minor b09
Name: openjdk-asmtools
Version:7.0.b10.pre.0.1
I think it should be
%global major 7.0
%global minor b10
Name: openjdk-asmtools
Version:
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #18 from Jaya ---
(In reply to jiri vanek from comment #17)
> Yo still have "# java runtime decompiler launch script" in the launcher :)
>
> But nvm, will go through that more deeply.
Yes :) my bad !! somehow missed that ;)
Now
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #17 from jiri vanek ---
Yo still have "# java runtime decompiler launch script" in the launcher :)
But nvm, will go through that more deeply.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #16 from Fabio Valentini ---
There seems to be another problem: Your Source0 URL references
%{name}-%{version}.tar.gz, but the %setup call does still use "master".
That most certainly won't work.
You also don't need to document a
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #15 from Fabio Valentini ---
Yes, this is like the recommended approach for packaging maven projects:
https://fedora-java.github.io/howto/latest/#maven
However, I see one big issue: do **never** reference an upstream *branch*,
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #14 from Jaya ---
Now I fixed it!!
@jvanek and @decathor Could you please take a look?
Spec file URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #13 from Jaya ---
@decatho...@gmail.com
Thanks for your suggestion to use : %files -f maven/.mfiles
Spec file URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
Fabio Valentini changed:
What|Removed |Added
CC||decatho...@gmail.com
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #11 from Jaya ---
%files
%license LICENSE
%doc README.md
/usr/share/java/openjdk-asmtools/*
/usr/share/javadoc/openjdk-asmtools/*
/usr/share/maven-metadata/*
/usr/share/maven-poms/openjdk-asmtools/*
%attr(755, root, -)
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #10 from Jaya ---
sed -i "s|ln -sv|cp -r|g" mvngen.sh
-> Good idea! However, why "cp -r?" Are there really some directories linked?
Yes. Because, if "-r " is not used then , "sh mvngen.sh" fails as below:
$ sh mvngen.sh
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #9 from jiri vanek ---
hi!
The link to specfile is broken, but NVM, was easy to find.
thanx for update, the specfile and launcher went a bit wild, before
continuinfg with review, many nits:
BuildRequires: java-1.8.0-openjdk
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #8 from Jaya ---
I have uploaded the below after addressing the review comments provided above:
Spec URL: https://jhuttana.fedorapeople.org/openjdk-asmtools
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #7 from jiri vanek ---
Please fix all [!] items and all rpmlint Errors, and some warings (eg the dot,
but eg spell chekc is wrong and you are right)
Maybe except "openjdk-asmtools.noarch: E: incorrect-fsf-address
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
jiri vanek changed:
What|Removed |Added
Status|ASSIGNED|POST
--- Comment #6 from jiri vanek
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #5 from jiri vanek ---
nvm, done on your behalf. On quick glance all looks good. Running fedora-review
now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #4 from jiri vanek ---
Spec URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.spec
SRPM URL:
https://jhuttana.fedorapeople.org/openjdk-asmtools-7.0.b10.pre.0.1-pre.0.1.src.rpm
--
You are receiving this mail because:
You
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #3 from jiri vanek ---
Please adapt the links then., Otherwise automation can not dinf them :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #2 from Jaya ---
I have made changes to spec file also to reflect the suggested change:
https://jhuttana.fedorapeople.org/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
Jaya changed:
What|Removed |Added
Summary|Review Request: asmtools - |Review Request:
|An
45 matches
Mail list logo
