https://bugzilla.redhat.com/show_bug.cgi?id=2132022
Miro Hrončok changed:
What|Removed |Added
Flags||fedora-review?
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
--- Comment #1 from Miro Hrončok ---
> BuildRequires: pytest
I'd use python3-pytest here, for consistency.
> BuildRequires: pre-commit
> BuildRequires: python3-mypy
Is it possible to test without those?
I see this BuildRequires poetr
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
--- Comment #2 from Tomáš Hrnčiar ---
(In reply to Miro Hrončok from comment #1)
> > BuildRequires: pytest
>
> I'd use python3-pytest here, for consistency.
>
done
>
> > BuildRequires: pre-commit
> > BuildRequires: python3-mypy
>
> Is
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
--- Comment #3 from Miro Hrončok ---
Does %{?bootstrap: -R} actually work? I've only ever seen %{?with_bootstrap:
-R}
And, does %pytest work when bootstrapping? If so, I'd just always use -R and
add a comment explaining why.
--
You are rec
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
--- Comment #4 from Tomáš Hrnčiar ---
(In reply to Miro Hrončok from comment #3)
> Does %{?bootstrap: -R} actually work? I've only ever seen %{?with_bootstrap:
> -R}
>
You are right, it should be %{?with_bootstrap: -R}.
> And, does %pytest
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
--- Comment #5 from Miro Hrončok ---
3 minor suggestions:
1) I'd use the new (less confusing) %bcond syntax:
%bcond bootstrap 0
2) I'd comment near the bootstrap bcond why it is necessary.
3) I'd extend the test deps comment with something
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
--- Comment #6 from Miro Hrončok ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its o
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
--- Comment #7 from Tomáš Hrnčiar ---
Thank you for the review. I have correctly marked the LICENSE file and
addressed the other suggestions.
Spec URL:
https://download.copr.fedorainfracloud.org/results/thrnciar/poetry/fedora-rawhide-x86_64/0
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
Miro Hrončok changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
Status|ASSIGN
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
--- Comment #9 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-poetry-plugin-export
--
You are receiving this mail because:
You are on the CC list for the bug.
You are alw
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
Miro Hrončok changed:
What|Removed |Added
Resolution|--- |RAWHIDE
Status|POST
11 matches
Mail list logo
