https://bugzilla.redhat.com/show_bug.cgi?id=915864
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|CLOSED
Fixed In Version|
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Gang Wei changed:
What|Removed |Added
Flags|fedora-review+ |fedora-review?
--- Comment #43 from Gang Wei
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Gang Wei changed:
What|Removed |Added
Flags|fedora-review? fedora-cvs+ |fedora-review+ fedora-cvs?
--
You are receiv
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #44 from Gang Wei ---
Package Change Request
==
Package Name: oat
New Branches: el6
Owners: gwei3
InitialCC:
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Jon Ciesla changed:
What|Removed |Added
Flags|fedora-cvs? |fedora-cvs+
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #45 from Jon Ciesla ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=qKWVuMp7t6&a=cc_unsubscribe
_
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Steven Dake changed:
What|Removed |Added
Flags||fedora-review+
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Steven Dake changed:
What|Removed |Added
Flags|fedora-review+ |
--
You are receiving this mail because:
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Steven Dake changed:
What|Removed |Added
Status|NEW |ASSIGNED
C
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Steven Dake changed:
What|Removed |Added
Flags||fedora-review?
--
You are
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #1 from Steven Dake ---
This package includes 74 bundled libraries:
[sdake@freedom JAR_SOURCE]$ ls *jar | wc -l
74
Please note bundling is not allowed in Fedora unless a Fedora exception is
granted. It appears this h
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Dan Radez changed:
What|Removed |Added
CC||dra...@redhat.com
--- Commen
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #3 from Dan Radez ---
Couple additions to my review:
%post should not mkdir
%install should and you should list the directories in your files
%post is not intended to completely configure the app so it can be starte
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #4 from Gang Wei ---
The biggest bundling issue was worked on for a while. By far, most bundled
dependencies were resolved by either removal of redundant jars or found
corresponding fedora packages. There are still fou
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Gang Wei changed:
What|Removed |Added
Depends On||870977, 865787
--
You are re
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Gang Wei changed:
What|Removed |Added
CC||tcall...@redhat.com
--- Comme
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #6 from Gang Wei ---
glassfish-jaxws was approved. Please continue to review the v2 oat package.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/toke
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #7 from Steven Dake ---
Gang Wei,
Typically it is better (tips for next time) to keep each version of the RPM and
update the spec file with version numbers so diffs can be done against the spec
files. As you update the spec file, bum
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Bug 915864 depends on bug 865787, which changed state.
Bug 865787 Summary: Review Request: xmlstreambuffer - XML Stream Buffer
https://bugzilla.redhat.com/show_bug.cgi?id=865787
What|Removed |Added
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #8 from Gang Wei ---
Spec URL: http://gwei3.fedorapeople.org/package_review/oat/v3/oat.spec
SRPM URL:
http://gwei3.fedorapeople.org/package_review/oat/v3/oat-1.6.0-2.fc18.src.rpm
Fixed all issues pointed by Steven in last comment.
-
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #9 from Steven Dake ---
Jimmy,
The file oat-1.6.0-pregen-xsd.patch looks troubling. What creates this file?
If upstream version changes, how is it recreated? Pregeneration of code should
happen in the %build section, not in a patc
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #10 from Gang Wei ---
Steven,
Thanks for the review.
We were working for removing the generated code for a while, likely to make it
done very soon. It is previously generated by a modified xjb tools, now we are
trying to change to
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #11 from Gang Wei ---
Spec URL: http://gwei3.fedorapeople.org/package_review/oat/v4/oat.spec
SRPM URL:
http://gwei3.fedorapeople.org/package_review/oat/v4/oat-1.6.0-3.fc18.src.rpm
Fixed all issues pointed by Steven in comment 9. Test
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #13 from Steven Dake ---
Note:
regarding lack of manual pages, review will not block on missing manual pages,
but I would really appreciate it if you opened upstream bugs for each of those
binaries to provide manual pages. Projects w
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #14 from Steven Dake ---
rpmlint errors along with suggested fixes are documented here:
http://fedoraproject.org/wiki/Common_Rpmlint_issues
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #15 from Gang Wei ---
Spec URL: http://gwei3.fedorapeople.org/package_review/oat/v5/oat.spec
SRPM URL:
http://gwei3.fedorapeople.org/package_review/oat/v5/oat-1.6.0-4.fc20.src.rpm
Fixed all major issues pointed by Steven in comment 1
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #17 from Steven Dake ---
rm -rf %{buildroot} is not needed, please remove it. Also remove the other rm
-rf commands in the script that are removing stuff in the buildroot. These are
cause of concern in later packaging efforts.
rpml
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #18 from Gang Wei ---
> files in confdir (/etc) need a confdir directive so they can be upgraded
> properly - otherwise the old configuration will be totally wiped out on an
> upgrade.
I didn't understand how I should do this. Can
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #19 from Steven Dake ---
(In reply to Gang Wei from comment #18)
> > files in confdir (/etc) need a confdir directive so they can be upgraded
> > properly - otherwise the old configuration will be totally wiped out on an
> > upgrade
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #20 from Gang Wei ---
Thanks steven.
I have almost fixed all warnings and will upload a new pacage soon.
some warnings are not intended to be fixed for approval:
1. manual-page warnings: will push upstream to make update and then pu
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #21 from Steven Dake ---
Jimmy,
the systemd script is indeed a false positive and can be ignored.
The man pages as an update sounds reasonable to me.
Its 10pm here, so I am headed to bed, but I'll review your package once I get
don
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #22 from Gang Wei ---
(In reply to Steven Dake from comment #21)
> Jimmy,
>
> the systemd script is indeed a false positive and can be ignored.
>
> The man pages as an update sounds reasonable to me.
>
> Its 10pm here, so I am head
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #23 from Gang Wei ---
Spec URL: http://gwei3.fedorapeople.org/package_review/oat/v6/oat.spec
SRPM URL:
http://gwei3.fedorapeople.org/package_review/oat/v6/oat-1.6.0-5.fc20.src.rpm
Fixed all rpmlint warnings expect one systemd script
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #24 from Steven Dake ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Packages have proper BuildRequires/Requires on jpackage-u
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #25 from Steven Dake ---
Jimmy,
getting really close! Forgive the missed review points from previous reviews -
this is my first java package review and I want to make sure I get it right.
BLOCKERS:
from https://fedoraproject.org/wi
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #26 from Gang Wei ---
Steve,
I will work on 1 & 2. But for 3, since oat-client are not require the
oat-appraiser (they usually installed on separate systems), it should not
applies to oat package.
I will make a update asap. please w
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #27 from Gang Wei ---
Steve,
BTW, can you help to karma below two dependencies?
https://admin.fedoraproject.org/updates/FEDORA-2013-9225/glassfish-jaxws-2.2.7-1.fc19
https://admin.fedoraproject.org/updates/FEDORA-2013-9237/glassfish-
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #28 from Steven Dake ---
Jimmy,
Karma requires testing, which I can't do, because I don't know how your
software works :) I believe they will automatically enter the repo after a set
period of time, however and are already present i
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #29 from Gang Wei ---
I think the guideline is new package can be branched for X-2 ~ X, currently it
mean f17~f19, why can't branch for f19?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe fro
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #30 from Tom "spot" Callaway ---
You can branch into f19. Not sure what Steve is talking about there. :)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #31 from Gang Wei ---
the oat-appraiser subpackage can't pass buid if given noarch. So I can only
build oat-doc, oat-commandtool & oat-javadoc in noarch. Is it enough?
--
You are receiving this mail because:
You are on the CC list f
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #32 from Gang Wei ---
Spec URL: http://gwei3.fedorapeople.org/package_review/oat/v7/oat.spec
SRPM URL:
http://gwei3.fedorapeople.org/package_review/oat/v7/oat-1.6.0-6.fc20.src.rpm
fixed for comment 25. please review.
--
You are rec
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #33 from Steven Dake ---
(In reply to Gang Wei from comment #31)
> the oat-appraiser subpackage can't pass buid if given noarch. So I can only
> build oat-doc, oat-commandtool & oat-javadoc in noarch. Is it enough?
Yes. oat-appraise
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Steven Dake changed:
What|Removed |Added
Flags|fedora-review? |
Flags|
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Gang Wei changed:
What|Removed |Added
Flags||fedora-cvs?
--- Comment #35 from Gang Wei --
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #36 from Steven Dake ---
(In reply to Tom "spot" Callaway from comment #30)
> You can branch into f19. Not sure what Steve is talking about there. :)
Tom,
I had heard this feature request was denied by fesco because it didn't make th
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #37 from Gang Wei ---
(In reply to Steven Dake from comment #34)
> APPROVED - nice work Jimmy. Please submit a SCM request.
Steve,
Appreciate for the huge effort you spent for oat package review!
Thanks a lot and have a good weeke
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #38 from Gang Wei ---
New Package SCM Request
===
Package Name: oat
Short Description: package for OpenAttestation project
Owners: gwei3
Branches: f19
InitialCC: gwei3
--
You are receiving this mail because:
You
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Bug 915864 depends on bug 870977, which changed state.
Bug 870977 Summary: Review Request: glassfish-jaxws - JAX-WS Reference
Implementation (RI) Project
https://bugzilla.redhat.com/show_bug.cgi?id=870977
What|Removed
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #39 from Gang Wei ---
New Package SCM Request
===
Package Name: oat
Short Description: Attestation Service & Host Agent based on OpenAttestation
SDK
Owners: gwei3
Branches: f19
InitialCC:
--
You are receiving thi
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #40 from Jon Ciesla ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=rt0RhWoy53&a=cc_unsubscribe
_
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Jon Ciesla changed:
What|Removed |Added
Flags|fedora-cvs? |
Flags|
https://bugzilla.redhat.com/show_bug.cgi?id=915864
Fedora Update System changed:
What|Removed |Added
Status|ASSIGNED|MODIFIED
--
You are receiving th
https://bugzilla.redhat.com/show_bug.cgi?id=915864
--- Comment #41 from Fedora Update System ---
oat-1.6.0-6.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/oat-1.6.0-6.fc19
--
You are receiving this mail because:
You are on the CC list for the bug.
U
54 matches
Mail list logo
