Re: [pacman-dev] [PATCH] makepkg: do not save fflags when creating packages

2019-10-07 Thread Eli Schwartz
On 10/7/19 10:59 PM, Allan McRae wrote: > On 8/10/19 12:48 pm, Eli Schwartz wrote: >> On 10/7/19 10:34 PM, Allan McRae wrote: >>> On 8/10/19 7:18 am, Eli Schwartz wrote: This breaks reproducible builds due to encoding information specific to the filesystem which was used to build the

Re: [pacman-dev] [PATCH] makepkg: do not save fflags when creating packages

2019-10-07 Thread Allan McRae
On 8/10/19 12:48 pm, Eli Schwartz wrote: > On 10/7/19 10:34 PM, Allan McRae wrote: >> On 8/10/19 7:18 am, Eli Schwartz wrote: >>> This breaks reproducible builds due to encoding information specific to >>> the filesystem which was used to build the package, information which we >>> are never

Re: [pacman-dev] [PATCH] makepkg: do not save fflags when creating packages

2019-10-07 Thread Eli Schwartz
On 10/7/19 10:34 PM, Allan McRae wrote: > On 8/10/19 7:18 am, Eli Schwartz wrote: >> This breaks reproducible builds due to encoding information specific to >> the filesystem which was used to build the package, information which we >> are never interested in for packaging purposes anyway. >> >>

[pacman-dev] [PATCH] makepkg: do not save fflags when creating packages

2019-10-07 Thread Eli Schwartz
This breaks reproducible builds due to encoding information specific to the filesystem which was used to build the package, information which we are never interested in for packaging purposes anyway. It also means that attempting to extract a package file as root (or fakeroot) might result in

[pacman-dev] [PATCH v2 1/2] signing: modify question text with unknwon uid

2019-10-07 Thread Christian Hesse
From: Christian Hesse If the key's uid is unknown (for example with db signatures) the question was: :: Import PGP key 02FD1C7A934E614545849F19A6234074498E9CEE, "(null)"? [Y/n] Let's display a modified question for unknown uid. Signed-off-by: Christian Hesse --- src/pacman/callback.c | 10

Re: [pacman-dev] [PATCH 1/2] signing: modify question text with unknwon uid

2019-10-07 Thread Christian Hesse
Allan McRae on Mon, 2019/10/07 23:44: > On 7/10/19 11:35 pm, Christian Hesse wrote: > > [...] > > Typo Uups, typing too fast. :-p > > + if (q->key->uid == NULL) { > > + q->import = yesno(_("Import PGP > > key %s with unknown uid?"),

Re: [pacman-dev] [PATCH 1/2] signing: modify question text with unknwon uid

2019-10-07 Thread Allan McRae
On 7/10/19 11:35 pm, Christian Hesse wrote: > From: Christian Hesse > > If the key's uid is unknown (for example with db signatures) the > question was: > > :: Import PGP key 02FD1C7A934E614545849F19A6234074498E9CEE, "(null)"? [Y/n] > > Let's display a modified question for unknwon uid. Typo

[pacman-dev] [PATCH 1/2] signing: modify question text with unknwon uid

2019-10-07 Thread Christian Hesse
From: Christian Hesse If the key's uid is unknown (for example with db signatures) the question was: :: Import PGP key 02FD1C7A934E614545849F19A6234074498E9CEE, "(null)"? [Y/n] Let's display a modified question for unknwon uid. Signed-off-by: Christian Hesse --- src/pacman/callback.c | 10

[pacman-dev] [PATCH 2/2] signing: handle unknown uid in key import

2019-10-07 Thread Christian Hesse
From: Christian Hesse With unknown uid pacman crashed. Return with error from email_from_uid() if uid is NULL. Signed-off-by: Christian Hesse --- lib/libalpm/signing.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c index

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-227-gd5c3ed12

2019-10-07 Thread Allan McRae
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via d5c3ed129c80c7a0676994d06c140f5e67b8b07d (commit)

Re: [pacman-dev] [PATCH v3] pacman-key: receive keys from WKD with -r/--recv-keys

2019-10-07 Thread Allan McRae
On 7/10/19 8:56 pm, Jonas Witschel wrote: > If an email address is specified, we use --locate-key to look up the key > using WKD and keyserver as a fallback. If the key is specified as a key > ID, this doesn't work, so we use the normal keyserver-based --recv-keys. > > Note that --refresh-keys

[pacman-dev] [PATCH v3] pacman-key: receive keys from WKD with -r/--recv-keys

2019-10-07 Thread Jonas Witschel
If an email address is specified, we use --locate-key to look up the key using WKD and keyserver as a fallback. If the key is specified as a key ID, this doesn't work, so we use the normal keyserver-based --recv-keys. Note that --refresh-keys still uses the keyservers exclusively for refreshing,

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-226-g5d2e48d1

2019-10-07 Thread Allan McRae
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 5d2e48d17f5a6268c8d290320da85da8dca19b85 (commit)

Re: [pacman-dev] pacman-5.2 progress

2019-10-07 Thread Allan McRae
On 7/10/19 6:11 pm, Jonas Witschel wrote: > Hi Allan, > > On 2019-10-07 09:55, Allan McRae wrote: >> Now the WKD patches have landed [...] > Great, thanks for reviewing and merging these! > > During the latest iteration, I got confused with the number of patches > and accidentally dropped the

Re: [pacman-dev] [PATCH 5/5 v2] pacman-key: receive keys from WKD with -r/--recv-keys

2019-10-07 Thread Allan McRae
On 6/8/19 1:32 am, Jonas Witschel wrote: > If an email address is specified, we use --locate-key to look up the key > using WKD and keyserver as a fallback. If the key is specified as a key > ID, this doesn't work, so we use the normal keyserver-based --recv-keys. > > Note that --refresh-keys

Re: [pacman-dev] pacman-5.2 progress

2019-10-07 Thread Jonas Witschel
Hi Allan, On 2019-10-07 09:55, Allan McRae wrote: > Now the WKD patches have landed [...] Great, thanks for reviewing and merging these! During the latest iteration, I got confused with the number of patches and accidentally dropped the changes to pacman-key ("pacman-key: receive keys from WKD

[pacman-dev] pacman-5.2 progress

2019-10-07 Thread Allan McRae
Hi all, I attacked the patch queue today - I think everything that was ready to be committed was, and everything that was not has been commented on. Now the WKD patches have landed, the only thing on my radar is the exec XferCommand patch, but I am not worried if that does not make this release.

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-225-g7e79cf73

2019-10-07 Thread Allan McRae
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 7e79cf73fac6fdd7d6cbfb35fe240b137e81c028 (commit)

Re: [pacman-dev] [PATCH] makepkg: propagate E_REMOVE_BUILD_DEPS

2019-10-07 Thread Allan McRae
On 21/1/19 8:14 am, Alad Wenter wrote: > remove_deps is called once, at the end of clean_up() before makepkg > exit. If remove_deps returns >0 (e.g. when pressing "n" in the resulting > prompt), the error is caught by the ERR signal handler. This in turns > sends SIGUSR1 to the process group, with

Re: [pacman-dev] [pacman] [PATCH] makepkg: remove makedepends before installing built package

2019-10-07 Thread Allan McRae
On 12/9/19 11:22 pm, a...@eckner.net wrote: > From: Erich Eckner > > When running `makepkg -i` it may be necessary to first remove make- and > checkdepends before installing the built package - for example if they > conflict each other. This is the case for wireguard-arch which > makedepends and

[pacman-dev] [PATCH] makepkg: wait for process to finish

2019-10-07 Thread Allan McRae
Without the -f option to wait, we might move on and try to delete the logpipe before the process is completed. Signed-off-by: Allan McRae --- This is a follow-up to the logpipe discussion. Hopefully this prevents the need for rm -f on $logpipe, but we will have to wait and see if that issue is