Previously parseopts checked if there was an argument by checking
that the string was non-empty, resulting in empty arguments being
incorrectly considered non-existent. This change makes parseopts check
if arguments exist at all, rather than checking that they are non-empty
Signed-off-by: Ethan So
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On Thu, 24 Oct 2019, Eli Schwartz wrote:
On 10/24/19 3:28 AM, a...@eckner.net wrote:
Since the update to pacman 5.2.0, `makepkg --printsrcinfo` may emmit
warnings about invalid packager format. However, all config variables in
/etc/makepkg.conf,
On 10/24/19 3:28 AM, a...@eckner.net wrote:
> Since the update to pacman 5.2.0, `makepkg --printsrcinfo` may emmit
> warnings about invalid packager format. However, all config variables in
> /etc/makepkg.conf, as well as directory permissions are not relevant if
> `--printsrcinfo` is given. So
Use after free.
Signed-off-by: Allan McRae
---
lib/libalpm/be_package.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/libalpm/be_package.c b/lib/libalpm/be_package.c
index 0f45c331..73d466de 100644
--- a/lib/libalpm/be_package.c
+++ b/lib/libalpm/be_package.c
@@ -759,7
Am 24.10.19 um 02:10 schrieb Allan McRae:
> On 24/10/19 12:31 am, Daan van Rossum wrote:
>> * on Wednesday, 2019-10-23 22:05 +1000, Allan McRae
>> wrote:
>>
>>> Now, ignoring my comment about not commenting... My design principle for
>>> additions to makepkg is an addition should be mostly straig
From: Erich Eckner
Variables from the config make no difference with `--printsrcinfo`, also
the directory permissions ($SRCDEST, $PKGDEST, $SRCPKGDEST, $BUILDDIR)
do not matter in that case.
This relieves one from customizing /etc/makepkg.conf on a system, where
only ever `makepkg --printsrcinfo
Since the update to pacman 5.2.0, `makepkg --printsrcinfo` may emmit
warnings about invalid packager format. However, all config variables in
/etc/makepkg.conf, as well as directory permissions are not relevant if
`--printsrcinfo` is given. So we simply skip the lint_conf and directory
permisis