Re: [pacman-dev] [PATCH] srcinfo.sh: remove trailing newline

2020-06-03 Thread Eli Schwartz
On 6/4/20 1:00 AM, Erich Eckner wrote: > In case my voice counts anything in this discussion: I would prefer the > empty lines between the sections and at the end to stay. I regularly > parse .SRCINFOs (or the output of `makepkg --printsrcinfo`) and > terminate parsing of sections on the empty

Re: [pacman-dev] [PATCH] srcinfo.sh: remove trailing newline

2020-06-03 Thread Erich Eckner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On Wed, 3 Jun 2020, Eli Schwartz wrote: On 6/3/20 8:04 PM, Eli Schwartz wrote: On 6/3/20 7:26 PM, Denton Liu wrote: When the .SRCINFO file is generated via `makepkg --printsrcinfo`, each section is concluded with an empty line. This means

Re: [pacman-dev] [PATCH] srcinfo.sh: remove trailing newline

2020-06-03 Thread Eli Schwartz
On 6/3/20 8:04 PM, Eli Schwartz wrote: > On 6/3/20 7:26 PM, Denton Liu wrote: >> When the .SRCINFO file is generated via `makepkg --printsrcinfo`, each >> section is concluded with an empty line. This means that at the end of >> the file, an empty line remains. When running `git diff --check`, Git

Re: [pacman-dev] [PATCH] srcinfo.sh: remove trailing newline

2020-06-03 Thread Allan McRae
On 4/6/20 9:26 am, Denton Liu wrote: > When the .SRCINFO file is generated via `makepkg --printsrcinfo`, each > section is concluded with an empty line. This means that at the end of > the file, an empty line remains. When running `git diff --check`, Git > will complain about this as a whitespace

Re: [pacman-dev] [PATCH v3] Fallback to detached signatures during keyring check

2020-06-03 Thread Andrew Gregory
On 06/01/20 at 11:45pm, Anatol Pomozov wrote: > Pacman has a 'key in keyring' verification step that makes sure the signatures > have a valid keyid. Currently pacman parses embedded package signatures only. > > Add a fallback to detached signatures. If embedded signature is missing then > it >

Re: [pacman-dev] [PATCH] srcinfo.sh: remove trailing newline

2020-06-03 Thread Eli Schwartz
On 6/3/20 7:26 PM, Denton Liu wrote: > When the .SRCINFO file is generated via `makepkg --printsrcinfo`, each > section is concluded with an empty line. This means that at the end of > the file, an empty line remains. When running `git diff --check`, Git > will complain about this as a whitespace

[pacman-dev] [PATCH] srcinfo.sh: remove trailing newline

2020-06-03 Thread Denton Liu
When the .SRCINFO file is generated via `makepkg --printsrcinfo`, each section is concluded with an empty line. This means that at the end of the file, an empty line remains. When running `git diff --check`, Git will complain about this as a whitespace error, saying "new blank line at EOF."