[pacman-dev] [PATCH] Allow specifying shell for running scriptlets

2012-02-09 Thread Allan McRae
configure option to explicitly set the shell being used to run install scripts. Signed-off-by: Allan McRae --- configure.ac|8 lib/libalpm/Makefile.am |4 +++- lib/libalpm/trans.c |2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/conf

Re: [pacman-dev] [PATCH] Allow specifying shell for running scriptlets

2012-02-10 Thread Allan McRae
On 11/02/12 01:42, Dan McGee wrote: > On Fri, Feb 10, 2012 at 1:31 AM, Allan McRae wrote: >> Some distributions insist on using bash specific commands in their >> install scripts under the assumption that "sh" is a symlink to bash. >> This can causes issues if (e.g.

[pacman-dev] [PATCH] makepkg: disable extglob when sourcing BUILDSCRIPT

2012-02-10 Thread Allan McRae
that these function names are unsupported in bash and could break again even with this "fix" in future bash releases. Signed-off-by: Allan McRae --- scripts/makepkg.sh.in |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg

[pacman-dev] [PATCHv2] Allow specifying shell for running scriptlets

2012-02-10 Thread Allan McRae
configure option to explicitly set the shell being used to run install scripts. Signed-off-by: Allan McRae --- configure.ac|9 + lib/libalpm/trans.c |2 +- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 45e0111..a88e551 10

[pacman-dev] [PATCH] Move ROOTDIR definition into config.h

2012-02-10 Thread Allan McRae
This was the only variable of its kind when a define was done on the compiler command line. Move it into config.h instead. Signed-off-by: Allan McRae --- configure.ac |1 + src/pacman/Makefile.am |1 - src/util/Makefile.am |1 - 3 files changed, 1 insertions(+), 2

[pacman-dev] [PATCH] Reset errno before opening archive

2012-02-10 Thread Allan McRae
man-4.0.1-4-i686.pkg.tar.gz.sig: Unrecognized archive format Cannot find the given file. After: > testpkg pacman-4.0.1-4-i686.pkg.tar.gz.sig error: could not open file pacman-4.0.1-4-i686.pkg.tar.gz.sig: Unrecognized archive format Cannot open the given file. Signed-off-by: Allan McRae --- I h

[pacman-dev] [PATCH] testpkg: set gpgdir

2012-02-10 Thread Allan McRae
Without setting gpgdir, testpkg outputs: warning: Public keyring not found; have you run 'pacman-key --init'? Signed-off-by: Allan McRae --- Note that this uses a compile time patch to the GPGDIR. testpkg does this for DBPATH too. It is probably not worth allowing these to be over

[pacman-dev] [PATCH] Rmove unnecessary defines from src/util/Makefile.am

2012-02-10 Thread Allan McRae
Signed-off-by: Allan McRae --- src/util/Makefile.am |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/src/util/Makefile.am b/src/util/Makefile.am index e386d95..8e98324 100644 --- a/src/util/Makefile.am +++ b/src/util/Makefile.am @@ -2,15 +2,12 @@ conffile

[pacman-dev] [PATCH] pactree: allow comments after repo section header

2012-02-10 Thread Allan McRae
Duplicate the fix in config file parsing from d95c0494. Signed-off-by: Allan McRae --- src/util/pactree.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/pactree.c b/src/util/pactree.c index a7dab9f..aa02c80 100644 --- a/src/util/pactree.c +++ b/src

[pacman-dev] [PATCH] Skip reading sync db detlas files if UseDelta is unset

2012-02-10 Thread Allan McRae
Signed-off-by: Allan McRae --- lib/libalpm/be_sync.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/libalpm/be_sync.c b/lib/libalpm/be_sync.c index f162199..a686def 100644 --- a/lib/libalpm/be_sync.c +++ b/lib/libalpm/be_sync.c @@ -511,7 +511,7 @@ static int

[pacman-dev] [PATCH] makepkg: allow specifying compression options

2012-02-11 Thread Allan McRae
-by: Allan McRae --- Adjust patch from FS#27430. Sending to list for final comments. doc/makepkg.conf.5.txt |4 etc/makepkg.conf.in| 10 ++ scripts/makepkg.sh.in |8 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/doc/makepkg.conf.5.txt b/doc

Re: [pacman-dev] [PATCH] makepkg: allow specifying compression options

2012-02-11 Thread Allan McRae
On 11/02/12 19:56, Florian Pritz wrote: > On 11.02.2012 10:56, Allan McRae wrote: >> From: Christian Hesse >> >> Adds the ability to override the commands used to compressing >> compiled and source packages. This is useful for those wanting >> to use a

[pacman-dev] [PATCH] Do not check for ALPM_ERR_PKG_INVALID_ARCH on remove operation

2012-02-11 Thread Allan McRae
alpm_trans_prepare can not return ALPM_ERR_PKG_INVALID_ARCH on a remove operation so there is no point in checking for it Signed-off-by: Allan McRae --- src/pacman/remove.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/pacman/remove.c b/src/pacman/remove.c

Re: [pacman-dev] [PATCH 3/3] makepkg: complain when the buildfile isn't writeable

2012-02-15 Thread Allan McRae
On 15/02/12 04:58, Dave Reisner wrote: > If the PKGBUILD isn't writeable for devel_update, throw a warning > instead of silently ignoring it. Some logical reordering is present in > this patch to reduce the number of nested if's. > > Signed-off-by: Dave Reisner > --- > scripts/makepkg.sh.in |

Re: [pacman-dev] [PATCH 1/3] makepkg: restrict usage of errexit to user functions

2012-02-15 Thread Allan McRae
On 15/02/12 04:57, Dave Reisner wrote: > It's expected that this will lead to unwanted behavior, and needs > widespread testing. It's desirable to commit this for a few reasons: > > - there's no reason we can't do our own error checking for code that we > write. > - it avoids the need for ||true

Re: [pacman-dev] [PATCH] Fix typo in help message

2012-02-15 Thread Allan McRae
On 16/02/12 10:47, Eric Bélanger wrote: > Close FS#28434 > > Signed-off-by: Eric Bélanger > --- > contrib/pacsysclean.in |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/contrib/pacsysclean.in b/contrib/pacsysclean.in > index 17f7681..28c1493 100755 > --- a/contrib

Re: [pacman-dev] [PATCH 1/3] makepkg: restrict usage of errexit to user functions

2012-02-15 Thread Allan McRae
On 16/02/12 02:26, Dave Reisner wrote: > On Wed, Feb 15, 2012 at 7:05 AM, Allan McRae wrote: > >> On 15/02/12 04:57, Dave Reisner wrote: >>> It's expected that this will lead to unwanted behavior, and needs >>> widespread testing. It's de

[pacman-dev] SyncFirst

2012-02-16 Thread Allan McRae
I was thinking about SyncFirst today and decided we need a good summary of what the issues are and why the current and old implementations fail. Why the current (pacman-4.0) implementation fails: When a package in SyncFirst is to be updated, pacman will update that first and pull everything in its

[pacman-dev] [PATCH] [RFC] Add configuration option for Upgrade operation SigLevel

2012-02-16 Thread Allan McRae
Add LocalFileSigLevel and RemoteFileSigLevel to control the signature checking for "pacman -U " and "pacman -U " operations respectively. Both values take the default of "Optional TrustedOnly". Signed-off-by: Allan McRae --- I would like to have the default level

[pacman-dev] [PATCH] Add information on how an installed package was validated

2012-02-17 Thread Allan McRae
When installing a package, store information on which validation method was used and output this on "pacman -Qi" operations. e.g. Validated By : SHA256 Sum Possible values are Unknown, None, MD5 Sum, SHA256 Sum, Signature. Signed-off-by: Allan McRae --- The only thing I am conce

[pacman-dev] [PATCH v2] Add configuration option for Upgrade operation SigLevel

2012-02-18 Thread Allan McRae
The specified values override and/or supplement this initial value. Note there is no destintion between setting "Required" and "PackageRequired" as there is not database options for Upgrade operations. Signed-off-by: Allan McRae --- This fixes all the issues I was concerned about i

[pacman-dev] [PATCH 1/3 v2] Add information on how an installed package was validated

2012-02-19 Thread Allan McRae
When installing a package, store information on which validation method was used and output this on "pacman -Qi" operations. e.g. Validated By : SHA256 Sum Possible values are Unknown, None, MD5 Sum, SHA256 Sum, Signature. Signed-off-by: Allan McRae --- Changed alpm_pkgvalidat

[pacman-dev] [PATCH 2/3] Remove _alpm_csum

2012-02-19 Thread Allan McRae
The enum alpm_pkgvalidation_t is essentially a more generic version of _alpm_csum, so use it instead. Signed-off-by: Allan McRae --- lib/libalpm/be_package.c |4 ++-- lib/libalpm/package.c|2 +- lib/libalpm/sync.c |2 +- lib/libalpm/util.c |6 +++--- lib/libalpm

[pacman-dev] [PATCH 3/3] Simplify package validation info output for sync packages

2012-02-19 Thread Allan McRae
Unify the output for local and sync packages by only printing a list of possible validation types for sync packages. This also has the advantage of not printing the very long sha256 checksum which line wrapped on a standard width terminal. Signed-off-by: Allan McRae --- lib/libalpm/be_sync.c

Re: [pacman-dev] [PATCH] Don't check for diskspace when using --dbonly

2012-02-19 Thread Allan McRae
On 20/02/12 15:49, Dan McGee wrote: > It doesn't make much sense, as we aren't going to be manipulating any > package files other than local database entries. > I'd say great minds think alike... but they are both you so that proves nothing! http://projects.archlinux.org/pacman.git/commit/?id=e

[pacman-dev] [PATCH] Update copyright years

2012-02-20 Thread Allan McRae
Add 2012 to the copyright range for all libalpm and pacman source files. Signed-off-by: Allan McRae --- We are crap at keeping these updated when changes are made. Also, according to the GNU people, updating all files like this is OK as long as a "release" is made in that year. Here

[pacman-dev] [PATCH] Use "mode" in _alpm_makepath_mode

2012-02-20 Thread Allan McRae
It seems that if we pass the permissions that we want the created directory to have, then we should probably use it... Signed-off-by: Allan McRae --- NOW I LOOK LIKE THE ASS WHO DIDNT FIX IT lib/libalpm/util.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib

[pacman-dev] [PATCH] Write mtree of package files to local database

2012-02-21 Thread Allan McRae
When installing a package, write an mtree of the package files into the local database. This will be useful for doing validation of all files on a system. Signed-off-by: Allan McRae --- Query: should we keep the info on .INSTALL and .CHANGELOG files? Changing a .INSTALL file would be an

Re: [pacman-dev] pacman on NetBSD

2012-02-21 Thread Allan McRae
On 22/02/12 08:13, Schreiberstein wrote: > Hello! > > I'm trying to build pacman on NetBSD 5.1x, but unfortunately it fails : > http://pastebin.com/9NkbdX4G > > How to solve this problem? ("use arch" is not an option ;-) ) > > Have a nice day! > Alex > Can you confirm if you are building from

[pacman-dev] [PATCH] Do not dereference symlinks when calculating size

2012-02-24 Thread Allan McRae
Passing the "-L" flag to stat means we get the size of the file being pointed to for symlinks instead of the size of the symlink. Signed-off-by: Allan McRae --- configure.ac |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac ind

Re: [pacman-dev] [PATCH] Do not dereference symlinks when calculating size

2012-02-24 Thread Allan McRae
On 25/02/12 01:59, Dan McGee wrote: > On Fri, Feb 24, 2012 at 6:04 AM, Allan McRae wrote: >> Passing the "-L" flag to stat means we get the size of the file >> being pointed to for symlinks instead of the size of the symlink. >> >> Signed-off-by: Allan Mc

[pacman-dev] [PATCH v2] Do not dereference symlinks when calculating size

2012-02-24 Thread Allan McRae
Passing the "-L" flag to stat means we get the size of the file being pointed to for symlinks instead of the size of the symlink. Keep "-L" usage in repo-add as we want the actual size of the package/delta/signature there. Signed-off-by: Allan McRae --- Version 2: No

Re: [pacman-dev] [PATCH] Write mtree of package files to local database

2012-02-27 Thread Allan McRae
On 23/02/12 17:09, Dan McGee wrote: > On Tue, Feb 21, 2012 at 10:02 PM, Allan McRae wrote: >> When installing a package, write an mtree of the package files into >> the local database. This will be useful for doing validation of all >> files on a system. >> &g

Re: [pacman-dev] [PATCH] Write mtree of package files to local database

2012-02-27 Thread Allan McRae
On 28/02/12 14:35, Allan McRae wrote: > On 23/02/12 17:09, Dan McGee wrote: >> On Tue, Feb 21, 2012 at 10:02 PM, Allan McRae wrote: >>> When installing a package, write an mtree of the package files into >>> the local database. This will be useful for doing valid

Re: [pacman-dev] [PATCH] checkupdates: add new contrib script

2012-02-29 Thread Allan McRae
On 24/02/12 15:39, keenerd wrote: > checkupdates provides a way of checking for new updates without > touching the local sync database. Based heavily on a script > by Dave Reisner. Ack. Although note there was a line wrap done in the middle of this patch. Did you send using git-send-email? Alla

Re: [pacman-dev] Arguments for alpm_initialize

2012-02-29 Thread Allan McRae
On 01/03/12 17:10, Zameer Manji wrote: > Hello, > > This is my first time posting on this list, so my apologies if this is > the incorrect place to ask for help. I've been trying to create a > wrapper around libalpm for my own uses and I'm trying to get the > project off the ground with a simple p

Re: [pacman-dev] Why need keyrings to be signed?

2012-03-03 Thread Allan McRae
On 04/03/12 01:25, Pierre Schmitz wrote: > Hi all, > > while working on our keyring package again I am still stuck at this > question. pacman-key --populate checks if the files to import are > signed. The man page tell us: > >This prevents a potentially malicious repository >addin

Re: [pacman-dev] Mirroring with Deltas - Established Procedure

2012-03-04 Thread Allan McRae
On 05/03/12 08:43, Brendan Hide wrote: > Hi all > > Is there an established procedure to add deltas to an existing > rsync-maintained mirror server? The tools that come with pacman > (pkgdelta and repo-add) appear to be aimed at maintaining your own > repository rather than with mirroring an exist

[pacman-dev] [PATCH] makepkg: append pkgbase to BUILDDIR if specified

2012-03-08 Thread Allan McRae
This means multiple packages can be build using the same BUILDDIR without their source files all ending up extracted in the same directory. Fixes FS#28417. Signed-off-by: Allan McRae --- scripts/makepkg.sh.in | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a

[pacman-dev] [PATCH 0/6] fix some safety issues in makepkg

2012-03-08 Thread Allan McRae
variables that almost certainly cannot start with a "-n"), but there is no harm in applying them globally. Allan McRae (6): makepkg: the rhs in string comparisons should be quoted makepkg: use printf rather than echo to output variable makepkg: prevent issues with files starting wit

[pacman-dev] [PATCH 1/6] makepkg: the rhs in string comparisons should be quoted

2012-03-08 Thread Allan McRae
Signed-off-by: Allan McRae --- scripts/makepkg.sh.in | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 8763ffb..601c7e2 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -311,7

[pacman-dev] [PATCH 2/6] makepkg: use printf rather than echo to output variable

2012-03-08 Thread Allan McRae
Signed-off-by: Allan McRae --- scripts/makepkg.sh.in | 62 - 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 601c7e2..384e142 100644 --- a/scripts/makepkg.sh.in +++ b/scripts

[pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-08 Thread Allan McRae
Most places in makepkg deal with full file paths, but a few use the file name only. Protect from potential issues when a file name starts with a hyphen. Signed-off-by: Allan McRae --- scripts/makepkg.sh.in | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[pacman-dev] [PATCH 4/6] makepkg: abort when failing to create BUILDDIR

2012-03-08 Thread Allan McRae
Signed-off-by: Allan McRae --- scripts/makepkg.sh.in |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 8dd2d39..9cd8af8 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -2052,8 +2052,11 @@ readonly

[pacman-dev] [PATCH 5/6] makepkg: quote removed filename as it can have spaces

2012-03-08 Thread Allan McRae
Signed-off-by: Allan McRae --- scripts/makepkg.sh.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 9cd8af8..534f6f8 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -170,7 +170,7 @@ clean_up

[pacman-dev] [PATCH 6/6] makepkg: safely change directories

2012-03-08 Thread Allan McRae
In preparation for the removal of the global error trap we need a way to ensure changing directories succeeds. Add a "cd_safe" wrapper that performs the necessary check. Signed-off-by: Allan McRae --- scripts/makepkg.sh.in | 40 1 file c

[pacman-dev] [PATCH] makepkg: deal with overriden package arch properly

2012-03-09 Thread Allan McRae
h" in the PKGBUILD for that package. Fixes FS#27204. Signed-off-by: Allan McRae --- scripts/makepkg.sh.in | 51 - 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index f21c638..8abd69c

[pacman-dev] [PATCH] Skip special files when cleaning package cache

2012-03-09 Thread Allan McRae
Ignore .sig, *.db*, and *.src.tar* when cleaning the package cache. Fixes FS#25166. Signed-off-by: Allan McRae --- I am bad at regex... so I am sure some of these could be tightened up. src/pacman/sync.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src

Re: [pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-09 Thread Allan McRae
On 10/03/12 00:01, Dave Reisner wrote: > On Fri, Mar 09, 2012 at 05:59:06PM +1000, Allan McRae wrote: >> Most places in makepkg deal with full file paths, but a few use the >> file name only. Protect from potential issues when a file name >> starts with a hyphen. > >

Re: [pacman-dev] [PATCH 6/6] makepkg: safely change directories

2012-03-09 Thread Allan McRae
On 10/03/12 01:23, Dave Reisner wrote: > On Fri, Mar 09, 2012 at 05:59:09PM +1000, Allan McRae wrote: >> In preparation for the removal of the global error trap we need a >> way to ensure changing directories succeeds. Add a "cd_safe" >> wrapper that performs the ne

[pacman-dev] [PATCH v2] Skip special files when cleaning package cache

2012-03-09 Thread Allan McRae
Ignore *.sig, *.db*, and *.src.tar* when cleaning the package cache. Fixes FS#25166. Signed-off-by: Allan McRae --- Why didn't I know about fnmatch before... so much easier than the regex stuff I was doing before! src/pacman/sync.c | 18 ++ 1 file changed, 18 inser

Re: [pacman-dev] [PATCH 1/2] makepkg: fix extraction of soname in find_libdepends

2012-03-09 Thread Allan McRae
On 05/03/12 06:19, Florian Pritz wrote: > libperl.so results in soname="libperl.so.so" which is wrong. > > This returns the correct string: "libperl.so" > > Fix-by: Dave Reisner > Signed-off-by: Florian Pritz > --- > This should be applied to both master and maint. Ugh.. I didn't review this

Re: [pacman-dev] [PATCH 1/2] makepkg: fix extraction of soname in find_libdepends

2012-03-09 Thread Allan McRae
On 10/03/12 11:43, Allan McRae wrote: > On 05/03/12 06:19, Florian Pritz wrote: >> libperl.so results in soname="libperl.so.so" which is wrong. >> >> This returns the correct string: "libperl.so" >> >> Fix-by: Dave Reisner >> Signed-off-

Re: [pacman-dev] [PATCH 2/6] makepkg: use printf rather than echo to output variable

2012-03-10 Thread Allan McRae
On 10/03/12 01:20, Dave Reisner wrote: > On Fri, Mar 09, 2012 at 05:59:05PM +1000, Allan McRae wrote: >> Signed-off-by: Allan McRae >> --- >> scripts/makepkg.sh.in | 62 >> - >> 1 file changed, 31 insertions(+),

Re: [pacman-dev] [PATCH 4/6] makepkg: abort when failing to create BUILDDIR

2012-03-10 Thread Allan McRae
On 10/03/12 01:21, Dave Reisner wrote: > On Fri, Mar 09, 2012 at 05:59:07PM +1000, Allan McRae wrote: >> Signed-off-by: Allan McRae >> --- >> scripts/makepkg.sh.in |7 +-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/script

Re: [pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-12 Thread Allan McRae
On 13/03/12 01:24, Dan McGee wrote: > On Fri, Mar 9, 2012 at 9:01 AM, Dave Reisner wrote: >> On Fri, Mar 09, 2012 at 05:59:06PM +1000, Allan McRae wrote: >>> Most places in makepkg deal with full file paths, but a few use the >>> file name only. Protect from potent

Re: [pacman-dev] [PATCH 2/6] makepkg: devel_check(): determine vcs

2012-03-12 Thread Allan McRae
On 13/03/12 05:22, Matthew Monaco wrote: > On 03/12/2012 01:13 PM, Dave Reisner wrote: >> On Mon, Mar 12, 2012 at 12:53:11PM -0600, dgbale...@0x01b.net wrote: >>> From: Matthew Monaco >>> >>> Rather than prioritizing an arbitrary VCS, collect all development >>> directives. If there is more than o

Re: [pacman-dev] [PATCH 5/6] makepkg: devel_check(): only work for -vcs pkgnames

2012-03-12 Thread Allan McRae
On 13/03/12 04:53, dgbale...@0x01b.net wrote: > From: Matthew Monaco > > If the package's name does not end in -git/svn/etc, then don't touch > the pkgver or pkgrel. This changes the current semantics of makepkg, but > it shouldn't be too mind blowing. Well... even if Dave's ramblings are to

Re: [pacman-dev] [PATCH 1/6] makepkg: remove unused variable

2012-03-12 Thread Allan McRae
On 13/03/12 04:53, dgbale...@0x01b.net wrote: > From: Matthew Monaco > > --- > scripts/makepkg.sh.in |1 - > 1 file changed, 1 deletion(-) Pulled to my patchqueue. Thanks, Allan > diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in > index 89cd118..05a611d 100644 > --- a/scripts/m

Re: [pacman-dev] [PATCH v2 2/6] makepkg: devel_check(): determine vcs

2012-03-12 Thread Allan McRae
On 13/03/12 06:37, dgbale...@0x01b.net wrote: > From: Matthew Monaco > > EDITS: > - user arithmetic contexts for integer comparison > - use the regex comparison operator to test array membership > > Rather than prioritizing an arbitrary VCS, collect all development > directives. If there is

[pacman-dev] The great VCS packages overhaul of 2015

2012-03-12 Thread Allan McRae
It is well know that the VCS package support in makepkg is subpar... The number of bugs about this is into double figures. There have also been some patches submitted attempting to be able to use the source=() array in PKGBUILDs to specify a VCS repo and remove a lot of the repetitive crap involve

Re: [pacman-dev] [PATCH v3 0/5] development package cleanups

2012-03-12 Thread Allan McRae
On 13/03/12 11:14, Matthew Monaco wrote: > From: Matthew Monaco > > Some cleanup in the devel_check() function. The semantics aren't really > changed here. Guard against the potential to specify multiple groups of > development directives. > > Matthew Monaco (5): > makepkg: remove unused varia

Re: [pacman-dev] The great VCS packages overhaul of 2015

2012-03-13 Thread Allan McRae
On 13/03/12 15:36, Matthew Monaco wrote: > On 03/12/2012 09:58 PM, Allan McRae wrote: >> 2) Specifying commit to work with: >> I think that this is the difficult bit... the syntax with the source >> array is already convoluted enough, so I do not think they should be >

Re: [pacman-dev] The great VCS packages overhaul of 2015

2012-03-13 Thread Allan McRae
On 13/03/12 20:13, Thomas Bächler wrote: >> What makepkg does: >> > 1) goes into $vcsdir, checks for the pacman directory >> >- if not present, do the git checkout >> >- if present, enter and do a "git pull" unless --holdver is specified > This should be a path under SRCDIR. This should als

Re: [pacman-dev] The great VCS packages overhaul of 2015

2012-03-13 Thread Allan McRae
On 13/03/12 20:39, Thomas Bächler wrote: > Am 13.03.2012 11:36, schrieb Allan McRae: >> On 13/03/12 20:13, Thomas Bächler wrote: >>>> What makepkg does: >>>>> 1) goes into $vcsdir, checks for the pacman directory >>>>>- if not present, do the

Re: [pacman-dev] The great VCS packages overhaul of 2015

2012-03-13 Thread Allan McRae
On 13/03/12 20:25, Thomas Bächler wrote: > Am 13.03.2012 09:21, schrieb Allan McRae: >>> Is it at all feasible to just use the build date for package ordering if >>> it's a >>> vcs package? This way the pkgver can be the ref that was checked out: >>

Re: [pacman-dev] The great VCS packages overhaul of 2015

2012-03-13 Thread Allan McRae
On 13/03/12 21:23, Dan McGee wrote: > On Tue, Mar 13, 2012 at 7:20 AM, Florian Pritz wrote: >> On 13.03.2012 12:05, Allan McRae wrote: >>> I do understand the branch name is useless once you have a tag/commit >>> id. That is why later in the email I sa

Re: [pacman-dev] The great VCS packages overhaul of 2015

2012-03-13 Thread Allan McRae
On 13/03/12 21:53, Dan McGee wrote: > On Tue, Mar 13, 2012 at 7:41 AM, Florian Pritz wrote: >> On 13.03.2012 04:58, Allan McRae wrote: >>> 1) URL: >>> There were previous patches to the mailing list that never really got >>> finished, but I think w

Re: [pacman-dev] The great VCS packages overhaul of 2015

2012-03-13 Thread Allan McRae
On 14/03/12 01:49, Matthew Monaco wrote: > On 03/13/2012 06:15 AM, Allan McRae wrote: >> >> Hmm... good idea using the fragment identifier for specifying the >> branch/tag/commit to checkout. Being inspired by how pypi uses these to >> provide checksums, could I even s

Re: [pacman-dev] The great VCS packages overhaul of 2015

2012-03-13 Thread Allan McRae
On 14/03/12 02:12, Thomas Bächler wrote: > Am 13.03.2012 13:15, schrieb Allan McRae: >> #branch=maint >> #tag=v4.0.1 >> #commit=f42ad345 >> >> This gives full clarity to what is being specified an allows for >> potential cases where branches and tags hav

Re: [pacman-dev] [PATCH 1/2] Revert "makepkg: calculate exact total file size"

2012-03-14 Thread Allan McRae
On 15/03/12 06:41, Dave Reisner wrote: > btrfs's cow snapshots seem to do very strange things, causing du to not > count data still in filesystem buffers. Repackaging the same build of > handbrake within a chroot on brynhild, I witnessed (via bash xtrace) du > reporting a different $pkgdir size eve

Re: [pacman-dev] The great VCS packages overhaul of 2015

2012-03-18 Thread Allan McRae
On 18/03/12 05:47, Matthew Monaco wrote: > > In the meantime I'm playing with Xyne's great idea of plugins. > Just so you know... splitting out parts of makepkg has been discussed quite a bit already. That including solutions for how to enable running makepkg both from within the source tree a

[pacman-dev] Debug symbol packages bikeshedding

2012-03-20 Thread Allan McRae
I have been looking at the patches for automatic creation of packages with debug symbols. I think they are good starts, but before I polish them we need to decide on a few things. My preferences are highlighted with a (*) 1) the option in makepkg.conf and PKGBUILD options=() array - debug (*)

Re: [pacman-dev] [PATCH] libalpm: add pkg-config file

2012-03-20 Thread Allan McRae
On 20/03/12 14:00, Dave Reisner wrote: > Borrowed heavily from libarchive. > > Signed-off-by: Dave Reisner > --- > Throw a bone to the few projects who link against us... > > configure.ac |1 + > lib/libalpm/Makefile.am |3 +++ > lib/libalpm/libalpm.pc.in | 11 +

[pacman-dev] [PATCH] Make selecting scriptlet shell work

2012-03-23 Thread Allan McRae
The initial patch to implement this achieved nothing apart from adding a configure option. This patch makes that configure option do what it advertises. Bug-found-by: Dave Reisner Signed-off-by: Allan McRae --- lib/libalpm/trans.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [pacman-dev] [PATCH] Make selecting scriptlet shell work

2012-03-23 Thread Allan McRae
On 24/03/12 00:47, Dave Reisner wrote: > On Sat, Mar 24, 2012 at 12:14:01AM +1000, Allan McRae wrote: >> The initial patch to implement this achieved nothing apart from >> adding a configure option. This patch makes that configure option >> do what it advertises. > &

Re: [pacman-dev] [PATCH 4/4] pacman-key: Actually verify signatures and exit with correct codes

2012-03-25 Thread Allan McRae
On 25/03/12 22:10, Pierre Schmitz wrote: > We cannot rely on gpg's exit code. Instead we have to check the status-fd to > figoure out whether a signature is valid or not. typo ^ > In addition to this pacman-key --verify can now be used in scripts as it will > return an exit code of 1 if the signa

Re: [pacman-dev] [PATCH 3/4] pacman-key: reduce verbosity of --populate

2012-03-25 Thread Allan McRae
On 25/03/12 22:10, Pierre Schmitz wrote: > Do not bother the user with gpg's verbose output. > > Signed-off-by: Pierre Schmitz > --- > scripts/pacman-key.sh.in |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/pacman-key.sh.in b/scripts/pacman-key.sh.in >

Re: [pacman-dev] Unable to compile pacman in ubuntu-11.10

2012-03-28 Thread Allan McRae
On 28/03/12 20:10, Talespin Kit wrote: >> sounds like you didn't google, since googling this issue shows me that > >> people tried to include openssl.h. So the issue could be that you are >> missing openssl-dev. Take a look at pacman's dependencies with: > > I initally thought that might be probl

[pacman-dev] [PATCH] Check minimum required gpgme version

2012-03-28 Thread Allan McRae
We use interfaces first introduced in gpgme-1.3.0 so test we have at least that version. Signed-off-by: Allan McRae --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index b44e8ba..0fe3287 100644 --- a/configure.ac +++ b

Re: [pacman-dev] [PATCH v2 2/3] pkgdelta: implement requirments for delta generation

2012-04-06 Thread Allan McRae
On 07/04/12 08:07, Florian Pritz wrote: > Big deltas or deltas for very small packages are not needed so we should > check that and not generate any. > > Signed-off-by: Florian Pritz > --- > This now checks for numeric values as per Dave suggestion. > > scripts/pkgdelta.sh.in | 51 >

Re: [pacman-dev] [PATCH] repo-remove: remove deltas file is it becomes empty

2012-04-06 Thread Allan McRae
On 07/04/12 02:22, Florian Pritz wrote: > Signed-off-by: Florian Pritz > --- > scripts/repo-add.sh.in |5 + > 1 file changed, 5 insertions(+) > > diff --git a/scripts/repo-add.sh.in b/scripts/repo-add.sh.in > index 043a0b8..1febfae 100644 > --- a/scripts/repo-add.sh.in > +++ b/scripts/re

Re: [pacman-dev] [PATCH 2/2] pacman-key: avoid use of tempfile in verify_sig

2012-04-08 Thread Allan McRae
On 09/04/12 04:13, Dave Reisner wrote: > Use --status-fd rather than --status-file to keep this contained in a > pipeline. > > Signed-off-by: Dave Reisner > --- > scripts/pacman-key.sh.in |6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/scripts/pacman-key.sh.in b

Re: [pacman-dev] [arch-general] SOLVED - Re: Need help understanding new "make install" failures - libtool: install: error: relink `blah...la' ??

2012-04-10 Thread Allan McRae
On 10/04/12 20:24, Martti Kühne wrote: > On Tue, Apr 10, 2012 at 10:47:35AM +0300, Bogdan Ionuț wrote: >> On Mon, Apr 9, 2012 at 17:02, David C. Rankin < >> drankina...@suddenlinkmail.com> wrote: >> >>> On 04/07/2012 06:54 PM, David C. Rankin wrote: Guys, After the latest updates,

[pacman-dev] [PATCH] Remove SyncFirst option

2012-04-11 Thread Allan McRae
. Signed-off-by: Allan McRae --- doc/pacman.conf.5.txt|9 -- etc/pacman.conf.in |2 -- src/pacman/conf.c|3 -- src/pacman/conf.h|1 - src/pacman/sync.c| 47 --- test/pacman/README |1

Re: [pacman-dev] [PATCH 8/8][RFC]: bash version check

2012-04-12 Thread Allan McRae
On 13/04/12 00:54, Dave Reisner wrote: > --- > This was on the top of my parse-opts branch. Figured I'd send it along to > see if anyone else cares about this sort of thing. Easily nuked... > > Since we're using associative arrays in pacman-key, 4.0 is a requirement. > However, 4.0 is also full of

Re: [pacman-dev] [PATCH 6/8] pacman-key: allow verification of multiple sig files

2012-04-12 Thread Allan McRae
On 13/04/12 00:54, Dave Reisner wrote: > Loop through arguments passed to verify_sig and treat each as a > signature to be verified against a source file. Output each file as its > checked to avoid ambiguity. > > Signed-off-by: Dave Reisner > --- > doc/pacman-key.8.txt |2 +- > scripts/p

Re: [pacman-dev] [PATCH 7/8] validate shell scripts with $(BASH_SHELL) on build

2012-04-12 Thread Allan McRae
On 13/04/12 00:54, Dave Reisner wrote: > Pass $(OURSCRIPTS) through the bash parser in read only mode to validate > syntax. Note that this doesn't actually catch all errors, but it might > be useful for developers working on these scripts. > > Signed-off-by: Dave Reisner > --- > contrib/Makefile

Re: [pacman-dev] [PATCH 4/8] pacman-key: adopt parseopts for option parsing

2012-04-12 Thread Allan McRae
On 13/04/12 00:54, Dave Reisner wrote: > This requires an ugly amount of reworking of how pacman-key handles > options. The change simply to avoid passing keys, files, and directories > as arguments to options, but to leave them as arguments to the overall > program. This is reasonable since pacman

Re: [pacman-dev] [PATCH 2/8] makepkg: adopt parseopts for option parsing

2012-04-12 Thread Allan McRae
On 13/04/12 00:54, Dave Reisner wrote: > Signed-off-by: Dave Reisner Ack once a patch is added to prevent pkgname containing a comma. As no package in existence (being the Arch repos and the AUR...) has a comma in its name, that will not break anything so I decided it is best to be proactive here

Re: [pacman-dev] [PATCH 1/8] scripts/library: introduce parseopts

2012-04-12 Thread Allan McRae
On 13/04/12 00:54, Dave Reisner wrote: > This will replace our current options parser used in pacman-key and > makepkg. It follows heuristics closer to that of GNU getopt long (and > thus pacman itself), with the exception that it does not allow for > options with optional arguments. Due to the way

Re: [pacman-dev] [PATCH 7/8] validate shell scripts with $(BASH_SHELL) on build

2012-04-13 Thread Allan McRae
On 13/04/12 20:49, Florian Pritz wrote: > On 13.04.2012 05:30, Allan McRae wrote: >> On 13/04/12 00:54, Dave Reisner wrote: >>> Pass $(OURSCRIPTS) through the bash parser in read only mode to validate >>> syntax. Note that this doesn't actually catch all errors

Re: [pacman-dev] [PATCH 4/8] pacman-key: adopt parseopts for option parsing

2012-04-13 Thread Allan McRae
On 13/04/12 22:31, Dave Reisner wrote: > On Thu, Apr 12, 2012 at 11:50 PM, Allan McRae wrote: > >> On 13/04/12 00:54, Dave Reisner wrote: >>> This requires an ugly amount of reworking of how pacman-key handles >>> options. The change simply to avoid passing keys,

Re: [pacman-dev] [PATCH 7/8] validate shell scripts with $(BASH_SHELL) on build

2012-04-13 Thread Allan McRae
On 13/04/12 22:57, Dave Reisner wrote: > On Fri, Apr 13, 2012 at 6:57 AM, Allan McRae wrote: > >> On 13/04/12 20:49, Florian Pritz wrote: >>> On 13.04.2012 05:30, Allan McRae wrote: >>>> On 13/04/12 00:54, Dave Reisner wrote: >>>>> Pass $(OURSCRIP

[pacman-dev] [RFC] [PATCH] repo-add: Add SOURCE entry

2012-04-21 Thread Allan McRae
When repo-add is passed a source package, add it to the desc file. Signed-off-by: Allan McRae --- This patch is crap... but I want to know if an idea like this would even be considered before I make it suck less and implement the pacman side. The idea is "pacman -B/--build " would do

Re: [pacman-dev] [PATCH v1.1] Append timestamp to .pacsave files; PacsaveDate config option

2012-04-22 Thread Allan McRae
On 23/04/12 01:28, Florian Pritz wrote: > This implements FS#7308 > > Signed-off-by: Florian Pritz > --- > For reference: Dan suggests using .1, .2 ... for extensions logrotate style instead of dates here: http://mailman.archlinux.org/pipermail/pacman-dev/2011-August/013972.html Note that wit

[pacman-dev] [PATCH] makepkg: add mtree file into package

2012-04-29 Thread Allan McRae
Add an mtree file to the package with all file information. This can be added to the local pacman database on install allowing full package verification. Signed-off-by: Allan McRae --- Two things I want to query here... 1) bsdtar -czf .MTREE When creating the package, we use gzip instead

[pacman-dev] [PATCH] Extract .MTREE file into local package database

2012-04-29 Thread Allan McRae
Signed-off-by: Allan McRae --- lib/libalpm/add.c |5 + 1 file changed, 5 insertions(+) diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c index b007766..b98346e 100644 --- a/lib/libalpm/add.c +++ b/lib/libalpm/add.c @@ -164,6 +164,11 @@ static int extract_single_file(alpm_handle_t

[pacman-dev] [PATCH] makepkg: fix package arch detection

2012-04-30 Thread Allan McRae
get_pkg_arch checked for the arch variable being overridden in the package_$1() function when used with a package as a parameter. However, when there was no override, it did not fall back to the global value. Signed-off-by: Allan McRae --- scripts/makepkg.sh.in |1 + 1 file changed, 1

[pacman-dev] [PATCH] Add functions for reading mtree file from local db

2012-05-01 Thread Allan McRae
Signed-off-by: Allan McRae --- I have not tested this actually reads the mtree file correctly yet... but I would like some feedback if people think that this is the right approach to take before I spend more time on it. lib/libalpm/be_local.c | 60

<    1   2   3   4   5   6   7   8   9   10   >