[pacman-dev] [PATCH] Ensure makepkg-wrapper is built after makepkg

makepkg-wrapper did not get rebuilt if makepkg was regenerated due to library changes. Ensure makepkg-wrapper is always generated and linked any time makepkg changes. Signed-off-by: Allan McRae <al...@archlinux.org> --- scripts/Makefile.am | 7 ++- 1 file changed, 2 insertions

Re: [pacman-dev] [PATCH] Remove contrib

On 10/10/16 23:09, Levente Polyak wrote: > On 10/01/2016 09:38 AM, Allan McRae wrote: >> delete mode 100644 contrib/bash_completion.in >> delete mode 100644 contrib/zsh_completion.in >> > > Moving out all the contrib stuff make sense to focus on the main > projec

[pacman-dev] [PATCH] Move bash/zsh completion out of contrib

Signed-off-by: Allan McRae <al...@archlinux.org> --- The "remove contrib" patch has been rebased on top of this. contrib/Makefile.am| 22 ++-- scripts/Makefile.am| 29 +- sc

Re: [pacman-dev] [PATCH v2] Give a "success!" message on database check

On 10/10/16 00:53, Patrick Eigensatz wrote: > Yes, I was asked to add the -q / --quiet flag to the documentation > (manpage, --about output) as well. Patch v2 includes those changes. > I was asking about the two different emails that were sent with "Patch v2". A

Re: [pacman-dev] [PATCH v2] Give a "success!" message on database check

On 08/10/16 05:45, Patrick Eigensatz wrote: > 'pacman -Dk' prints a "success!" message if there were no errors. > It is possible to suppress the output using the '-q / --quiet' flag. > > This implements the feature discussed at https://bugs.archlinux.org/task/50087 > Was there a difference

Re: [pacman-dev] [PATCH 1/1] lint_pkgbuild/pkgname: pkgname is not allowed to be empty

On 08/10/16 22:11, Rikard Falkeborn wrote: > 2016-10-04 10:21 GMT+02:00 Christian Hesse : > >> From: Christian Hesse >> >> We checked for empty array elements, but did not catch empty array. Add >> a check for that case as well. >> >> Signed-off-by: Christian Hesse

Re: [pacman-dev] [PATCH v3 1/2] makepkg: Move parseopts from library to libmakepkg

On 09/10/16 03:34, Alad Wenter wrote: > parseopts is used in makepkg and other scripts such as pacman-key as a > getopt replacement. > > Instead of including it in those scripts via a macro, move it to > libmakepkg/util/option.sh and have scripts source libmakepkg where > appropriate. > > To

Re: [pacman-dev] [PATCH v3 1/2] makepkg: Move parseopts from library to libmakepkg

On 09/10/16 19:16, Alad Wenter wrote: > > As a side note, if someone knows a way to automatically generate those > code line numbers in the .po files (this seems possible according to the > gettext manual), feel free to tell me. :D Never touch the po files. These are all generated

Re: [pacman-dev] [PATCH v3 2/2] libmakepkg: generate scripts in util

On 09/10/16 03:34, Alad Wenter wrote: > util/util.sh, util/message.sh, and util/option.sh were the only > remaining scripts which were not generated by make. They also do not need generated by make. All the other scripts do change when run through the edit function. A

Re: [pacman-dev] [PATCH v3 1/2] makepkg: Move parseopts from library to libmakepkg

On 09/10/16 20:29, Rikard Falkeborn wrote: >>> Why not move it to util/parseopts.sh if it should be moved into > libmakepkg? >>> >> I suppose that makes sense. util/util.sh ("General utility functions") > may also be appropriate if we don't want to create a new file. > > Why do you want to move

[pacman-dev] [PATCH] Remove pacman-optimize

The people who believe that pacman-optimize is actually doing something useful are the same people who are voting for Trump. Signed-off-by: Allan McRae <al...@archlinux.org> --- scripts/.gitignore| 1 - scripts/Makefile.am | 6 -- scripts/pacman-optimize.sh.in

Re: [pacman-dev] [RFC v3 13/13] bacman: make gettext useful

On 01/10/16 19:16, Olivier Brunel wrote: > On Sat, 1 Oct 2016 17:41:51 +1000 > Allan McRae <al...@archlinux.org> wrote: > >> On 30/09/16 22:14, Dave Reisner wrote: >>> On Fri, Sep 30, 2016 at 01:48:01PM +0200, Gordian Edenhofer wrote: >>>> Ex

Re: [pacman-dev] [PATCH] fix --printsrcinfo unify arch and non-arch specific variables

On 30/09/16 08:57, Levente Polyak wrote: > This fixes the issue with --printsrcinfo that all arch specific variants > of a variable get merged into their non arch specific variant. > > The .SRCINFO file ends up having $depends containing $depends_x86_64 > and omitting the latter. Thanks. Note

Re: [pacman-dev] [RFC v3 13/13] bacman: make gettext useful

On 30/09/16 22:14, Dave Reisner wrote: > On Fri, Sep 30, 2016 at 01:48:01PM +0200, Gordian Edenhofer wrote: >> Export TEXTDOMAIN and TEXTDOMAINDIR in order for the strings to be >> translatable with gettext. >> --- >> contrib/bacman.sh.in | 28 ++-- >> 1 file changed, 22

Re: [pacman-dev] [PATCH 00/11] Streamline syntax of contrib scripts

On 29/09/16 21:25, Gordian Edenhofer wrote: > On Thu, 2016-09-29 at 20:40 +1000, Dave Reisner wrote: >> On Sep 29, 2016 06:23, "Gordian Edenhofer" > om> >> wrote: >> >> Reorganize scripts in contrib to fit the syntax and style of makepkg. >> Unify multiple different

Re: [pacman-dev] [PATCH 01/11] checkupdates: streamline usage function

On 29/09/16 20:37, Dave Reisner wrote: > On Sep 29, 2016 06:23, "Gordian Edenhofer" > wrote: > > Signed-off-by: Gordian Edenhofer > --- > contrib/checkupdates.sh.in | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > >

Re: [pacman-dev] [PATCH] Give a "success!" message on database check

On 29/09/16 05:29, Patrick Eigensatz wrote: > Ps: Is it possible to tell git send-email to reply to the message with > this ID? > --in-reply-to= (although I am fairly sure no-one does that...)

Re: [pacman-dev] Fwd: [arch-general] Removing infinality

On 28/09/16 19:03, Martin Kühne wrote: > Having a mechanism to choose from past transactions and undoing them > properly has to be done by hand right now and tends to be tedious and > error-prone. There might be ways to mitigate that by parsing the logs > and offering actions based on such data,

Re: [pacman-dev] Fwd: [arch-general] Removing infinality

On 28/09/16 17:14, Martin Kühne wrote: > ...actually, would a mechanism like beneath implemented natively in > pacman be worth a feature request? > > cheers! > mar77i > I have no context, so I'll assume we can already do that and it is user error. Allan > > -- Forwarded message

Re: [pacman-dev] [PATCH] [RFC] Remove internal md5 and sha2 implementations

On 25/09/16 19:22, Allan McRae wrote: > The internal implementations for md5 and sha256 checksums have not been merged > from upstream sources for a long time. Instead of us carrying copies of code > from other projects, we should just support building against multiple > libraries &g

[pacman-dev] [PATCH] Remove SHA224 support

This was included due to use of PolarSSL's implementation for our internal SHA2 support. As our internal checksum calculations are now removed, we can also remove this unused code path. Signed-off-by: Allan McRae <al...@archlinux.org> --- lib/libalpm/util.

[pacman-dev] [PATCH] [RFC] Remove internal md5 and sha2 implementations

to be supported if anyone wishes to add them. Signed-off-by: Allan McRae <al...@archlinux.org> --- The PolarSSL code has not been merged since 2010. PolarSSL has not existed for over a year... configure.ac| 5 + lib/libalpm/Makefile.am | 6 - lib/libalpm/md5.c

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.0.1-76-g0d2ba87

Foster <ivy.fos...@gmail.com> Signed-off-by: Allan McRae <al...@archlinux.org> commit ae56a32273df8a36f4e84e0f37ce1f34e84f15a3 Author: Gordian Edenhofer <gordian.edenho...@gmail.com> Date: Sun Sep 4 18:14:06 2016 +0200 bacman: add manual page Signed-off-by:

Re: [pacman-dev] [PATCH v8 01/12] bacman: allow for multiple packages as arguments

On 21/09/16 20:08, Gordian Edenhofer wrote: > On Wed, 2016-09-21 at 00:08 +1000, Allan McRae wrote: >> On 09/09/16 16:21, Allan McRae wrote: >>> >>> Correct - most changes will be pulled from this patchset. Just not >>> the >>> parallelization

Re: [pacman-dev] [PATCH v8 01/12] bacman: allow for multiple packages as arguments

On 09/09/16 16:21, Allan McRae wrote: > Correct - most changes will be pulled from this patchset. Just not the > parallelization patches. I will pull the other patches to my patchqueue > branch soon. You can now see what I intend to commit on my "bacman" branch: https://git.

Re: [pacman-dev] [PATCH v8 11/12] bacman: add manual page

On 05/09/16 02:14, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer I made some minor wording changes and adjusted the examples section formatting. A

Re: [pacman-dev] [PATCH v8 10/12] bacman: add option to specify the number of jobs

On 05/09/16 02:14, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer As discussed, this will not be included. A

Re: [pacman-dev] [PATCH v8 04/12] bacman: proper option handling

On 20/09/16 23:32, Allan McRae wrote: > On 05/09/16 02:13, Gordian Edenhofer wrote: >> Switch to parseopts instead of merely checking the first argument. >> >> Signed-off-by: Gordian Edenhofer <gordian.edenho...@gmail.com> > > OK. I made minor modifications due

Re: [pacman-dev] [PATCH v8 07/12] bacman: quote pkg_pkger variable

On 05/09/16 02:14, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer > --- OK.

Re: [pacman-dev] [PATCH v8 08/12] bacman: add option to print fewer status updates

On 05/09/16 02:14, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer > --- > contrib/bacman.sh.in | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > OK.

Re: [pacman-dev] [PATCH v8 06/12] bacman: code structuring

On 05/09/16 02:14, Gordian Edenhofer wrote: > Adding and clarifying comments. > Adding and removing some new lines. > > Signed-off-by: Gordian Edenhofer OK.

Re: [pacman-dev] [PATCH v8 05/12] bacman: rewrite usage function

On 05/09/16 02:14, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer > --- > contrib/bacman.sh.in | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/contrib/bacman.sh.in b/contrib/bacman.sh.in > index

Re: [pacman-dev] [PATCH v8 04/12] bacman: proper option handling

On 05/09/16 02:13, Gordian Edenhofer wrote: > Switch to parseopts instead of merely checking the first argument. > > Signed-off-by: Gordian Edenhofer OK. I made minor modifications due to not include patch #3. A

Re: [pacman-dev] [PATCH v8 02/12] bacman: handle SIGHUP, SIGINT, SIGTERM signals

On 05/09/16 02:13, Gordian Edenhofer wrote: > Trap SIGHUP, SIGINT, SIGTERM and remove working directories accordingly. > > Signed-off-by: Gordian Edenhofer OK

Re: [pacman-dev] [PATCH v8 01/12] bacman: allow for multiple packages as arguments

On 05/09/16 02:13, Gordian Edenhofer wrote: > To enable the creation of multiple packages with one command move the > assembly process into its own function. > > Signed-off-by: Gordian Edenhofer OK

Re: [pacman-dev] [PATCH v8 03/12] bacman: parallel packaging

On 05/09/16 02:13, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer As discussed, this will not be pulled.

Re: [pacman-dev] [PATCH] Fix gcc strict-overflow error

On 18/09/16 01:13, Rikard Falkeborn wrote: > Recent gcc (tested with 6.2.1) produces the following error when > compiling with both --enable-warningflags and --enable-debug. > In particular, it seems it is the combination of GCC_STACK_PROTECT_LIB > and -Wstrict-overflow=5 produces the error. > >

Re: [pacman-dev] Versioned packages

On 12/09/16 22:59, Johannes Löthberg wrote: > On 12/09, Sergey Petrenko via pacman-dev wrote: >> Well, of course! I can also build kernel outside package management, >> or write a hook to backup kernels, but I'd like to see solution that >> would not require such dire and time consuming measures,

Re: [pacman-dev] Versioned packages

On 10/09/16 08:41, Sergey Petrenko via pacman-dev wrote: > Here is my attempt to solve seven years old infamous problem: > https://bugs.archlinux.org/task/16702 > > Patch won't solve problem out of the box, a small changes in kernel PKGBUILD > will be required, but only concerning install part. >

Re: [pacman-dev] [PATCH v8 01/12] bacman: allow for multiple packages as arguments

On 05/09/16 03:37, Gordian Edenhofer wrote: > On Sun, 2016-09-04 at 11:21 -0500, Doug Newgard wrote: >> On Sun, 4 Sep 2016 18:13:56 +0200 >> Gordian Edenhofer wrote: >> >>> >>> To enable the creation of multiple packages with one command move >>> the >>> assembly

[pacman-dev] [PATCH] repo-add: fix error in directories with a space in their name

From: Fabio Castell <web...@vbsimple.net> Fixes FS#50285 Signed-off-by: Allan McRae <al...@archlinux.org> --- scripts/repo-add.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/repo-add.sh.in b/scripts/repo-add.sh.in index d62f9c4..4da2c31 100644 -

Re: [pacman-dev] [PATCH] Option to pass packages' versions to hook. Linearize code in _alpm_hook_trigger_match_pkg.

On 05/09/16 03:44, Sergey Petrenko via pacman-dev wrote: > I'm writing hooks to solve infamous kernel problem. Having version in hook > isn't necessary, > but will save me lot of work (and lot of time at each hook run). > Can you post an example hook with what your are trying to achieve. Allan

[pacman-dev] Downloader options - Was: Add configuration options for libcurl's "low speed" timeout

On 30/08/16 22:48, Christian Hesse wrote: > Dave Reisner on Tue, 2016/08/30 08:46: >> On Tue, Aug 30, 2016 at 02:12:23PM +0200, Christian Hesse wrote: >>> From: Christian Hesse >>> >>> Add LowSpeedLimit and LowSpeedTime configuration options to correspond >>>

Re: [pacman-dev] [PATCH v6 2/9] bacman: parallel packaging

On 03/09/16 00:50, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer > --- To be completely explicit, I am not going to accept parallel packaging patches (2, 7, and 9 in patchset v6). There are many other tools available to handle running scripts in

Re: [pacman-dev] [PATCH v6 5/9] bacman: add option to print fewer status updates

On 03/09/16 00:50, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer > --- > contrib/bacman.sh.in | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/contrib/bacman.sh.in b/contrib/bacman.sh.in > index f5807b5..a567e7d 100644

Re: [pacman-dev] [PATCH] bash-completion: fix leaking "files" array into shell environment

On 02/09/16 13:40, Eli Schwartz wrote: > Signed-off-by: Eli Schwartz > --- Thanks, Allan

Re: [pacman-dev] [PATCH v5 4/8] bacman: rewrite usage page and version information

On 03/09/16 01:07, Gordian Edenhofer wrote: > On Fri, 2016-09-02 at 23:37 +1000, Allan McRae wrote: >> On 02/09/16 22:51, Gordian Edenhofer wrote: >>> >>> echo 'Copyright (C) 2008 locci >>> ' >>> + echo 'Copyright (C) 2016 Gordian Edenhofer &

Re: [pacman-dev] [RFC, PATCHES]: Very preliminary work towards clean build with clang -Weverything

On 03/09/16 12:08, ivy.fos...@gmail.com wrote: > First of all, don't worry; I'm under no illusion that the > pie-in-the-sky Subject line is anything that will happen in the near > future, nor even necessarily a goal for the project (given just how > finicky -Weverything is). > > Basically, I'm

[pacman-dev] [PATCH] Fix memory leak in remove_notify_needed_optdepends

Also add pactest which captures this leak when run under valgrind. Reported-by: Sergey Petrenko Signed-off-by: Allan McRae <al...@archlinux.org> --- lib/libalpm/remove.c | 1 + test/pacman/tests/TESTS | 1 + .../

Re: [pacman-dev] Memleak

On 03/09/16 19:26, Sergey Petrenko via pacman-dev wrote: > libalpm/remove.c: > > in remove_notify_needed_optdepends(): > > char *optstring = alpm_dep_compute_string(optdep); > > isn't freed after being used. > > Ought to thank Valgrind for this one. > Thanks. We did not cover this

Re: [pacman-dev] [PATCH v5 4/8] bacman: rewrite usage page and version information

On 02/09/16 22:51, Gordian Edenhofer wrote: > echo 'Copyright (C) 2008 locci ' > + echo 'Copyright (C) 2016 Gordian Edenhofer > ' > echo 'Copyright (C) 2008-2016 Pacman Development Team > ' You want your name included

Re: [pacman-dev] [PATCH v5 8/8] bacman: add manual page

On 02/09/16 22:51, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer > --- > contrib/doc/.gitignore | 1 + > contrib/doc/Makefile.am | 5 +++- > contrib/doc/bacman.8.txt | 71 > > 3 files changed, 76

Re: [pacman-dev] [PATCH v3 4/8] bacman: rewrite usage page and version information

On 01/09/16 23:36, Gordian Edenhofer wrote: > On Thu, 2016-09-01 at 13:59 +1000, Allan McRae wrote: >> On 01/09/16 07:05, Gordian Edenhofer wrote: >>> >>> Signed-off-by: Gordian Edenhofer <gordian.edenho...@gmail.com> >>> --- >>> contrib/bacman.

[pacman-dev] [PATCH] [RFC] Provide source files for useful debug packages

location. This requires using the "debugedit" program which is provided as part of the RPM sources. Signed-off-by: Allan McRae <al...@archlinux.org> --- This is a first pass at making debug packages useful... Some things I want comments on: 1) It feels dirty depending on an RPM to

Re: [pacman-dev] [PATCH v3 4/8] bacman: rewrite usage page and version information

On 01/09/16 13:59, Allan McRae wrote: > On 01/09/16 07:05, Gordian Edenhofer wrote: >> Signed-off-by: Gordian Edenhofer <gordian.edenho...@gmail.com> >> --- >> contrib/bacman.sh.in | 33 + >> 1 file changed, 21 insertions(+), 1

Re: [pacman-dev] [PATCH v3 5/8] bacman: add option to print fewer status updates

On 01/09/16 07:05, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer > --- > contrib/bacman.sh.in | 21 - > 1 file changed, 16 insertions(+), 5 deletions(-) > Look at the definition of msg2() etc: scripts/library/output_format.sh

Re: [pacman-dev] [PATCH v3 3/8] bacman: proper option handling

On 01/09/16 07:05, Gordian Edenhofer wrote: > Switch to parseopts instead of merely checking the first argument. > > Signed-off-by: Gordian Edenhofer > --- > contrib/bacman.sh.in | 63 > ++-- > 1 file changed, 41

[pacman-dev] [PATCH] Fix typo in pacman-db-upgrade usage message

Signed-off-by: Allan McRae <al...@archlinux.org> --- scripts/pacman-db-upgrade.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/pacman-db-upgrade.sh.in b/scripts/pacman-db-upgrade.sh.in index 94085ba..79e1c59 100644 --- a/scripts/pacman-db-upgrade.sh.in

Re: [pacman-dev] [PATCH v2 1/3] bacman: allow for parallel packaging

On 01/09/16 09:44, Gordian Edenhofer wrote: > On Thu, 2016-09-01 at 08:28 +1000, Allan McRae wrote: >> On 01/09/16 08:08, Dave Reisner wrote: >>> >>> On Wed, Aug 31, 2016 at 11:18:32PM +0200, Gordian Edenhofer wrote: >>>> >>>>> >>&g

Re: [pacman-dev] [PATCH v2 1/3] bacman: allow for parallel packaging

On 01/09/16 08:08, Dave Reisner wrote: > On Wed, Aug 31, 2016 at 11:18:32PM +0200, Gordian Edenhofer wrote: > The second probably would not be accepted... I urge you to reconsider. Parallelization increases the speed of this >>> >>> I don't think anyone is suggesting that

Re: [pacman-dev] [PATCH] Remove AC_FUNC_MALLOC check.

On 31/08/16 11:13, Alastair Hughes wrote: > We weren't supplying the rpl_malloc function needed if this failed, and > didn't check for realloc, so just remove. > > Signed-off-by: Alastair Hughes > --- > > The build will currently fail if cross compiling or if >

Re: [pacman-dev] [PATCH] Replace CURLOPT_PROGRESSFUNCTION with CURLOPT_XFERINFOFUNCTION

On 31/08/16 06:33, ivy.fos...@gmail.com wrote: > From: Ivy Foster > > Curl 7.32.0 added CURLOPT_XFERINFOFUNCTION, which deprecates > CURLOPT_PROGRESSFUNCTION and means less casting doubles to size_ts for > alpm. This change has no user-facing nor frontend-facing effects. >

[pacman-dev] I'm back (mostly)

Hi all, I had a low presence over the last couple of months due to purchasing a house, moving and the subsequent delay of internet connection. But I am back! Ping any patches that I have missed in my flurry tonight and I will review them. Cheers, Allan

Re: [pacman-dev] [PATCH v2] Make DUFLAGS be overrideable during configure

On 20/08/16 06:52, Alastair Hughes wrote: > Not all du implementations on linux accept --apparent-size, so let the > user configure the arguments passed to du if required. > > This fixes FS#47943. > > Signed-off-by: Alastair Hughes > --- Why this approach over the

Re: [pacman-dev] [PATCH] Add option MaxDlSpeed to limit download speed

On 20/08/16 04:12, Olivier Brunel wrote: > Signed-off-by: Olivier Brunel > --- > doc/pacman.8.txt | 5 + > doc/pacman.conf.5.txt | 6 ++ > lib/libalpm/alpm.h| 3 +++ > lib/libalpm/dload.c | 1 + > lib/libalpm/handle.c | 26 ++ >

Re: [pacman-dev] [PATCH v2 2/3] bacman: proper option handling plus more options

On 15/08/16 06:39, Gordian Edenhofer wrote: > * Add option for printing fewer status updates > * Add option for controlling the output directory > * Add option for specyfying the the maximum number of jobs > * Adjust output to the number of jobs > * Rewrite usage page > * Alter version information

Re: [pacman-dev] [PATCH v2 3/3] bacman: add manual page

On 15/08/16 06:39, Gordian Edenhofer wrote: > Signed-off-by: Gordian Edenhofer > --- > * Fix some typos > * Adjust man page according to v2 of this patch series > > doc/.gitignore | 1 + > doc/Makefile.am | 4 > doc/bacman.8.txt | 71 >

Re: [pacman-dev] [PATCH v2 1/3] bacman: allow for parallel packaging

On 15/08/16 06:39, Gordian Edenhofer wrote: > * move the actual assembly process into its own function > * allow for packaging multiple packages with one command > * handle SIGHUP SIGINT SIGTERM and remove working dirs accordingly > * add some comments > > Signed-off-by: Gordian Edenhofer

Re: [pacman-dev] [PATCH] pacman.8: fix typo in the documentation of --asexplicit

On 20/08/16 21:46, Lukas Fleischer wrote: > Add a space between the option and its argument. Also, do not enclose > the argument in asterisk characters. > > Fixes a typo introduced in aa4c61f (Document database checking options, > 2014-12-28). Thanks, A

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.0.1-54-g406c9b6

The following properties are verified for each package in the database: - existence of the package file - file size - MD5 and SHA256 checksum (--checksum) Signed-off-by: Florian Pritz <bluew...@xinu.at> commit 1ec7fa89ad6ad650cedeafd5c7cbc36dcf29239f

Re: [pacman-dev] Default XferCommand breaks when resuming incomplete downloads on some servers

On 19/08/16 07:39, Quint Guvernator wrote: > Hello all, > > The default value of XferCommand (/usr/bin/curl -C - -f %u > %o) tells > curl to try to resume downloads from a particular byte position if they > are stopped prematurely. Not all servers support this, though, so curl > may die with exit

Re: [pacman-dev] [PATCH 1/2] contrib: Add verify-pacman-repo-db.pl

On 07/08/16 23:13, Florian Pritz wrote: > On 07.08.2016 08:28, Allan McRae wrote: >> A commit message would be nice... > > Would a copy of the manpage description be fine or do you have something > else in mind? > >> Is there any reason PGP checksums are not checked?

Re: [pacman-dev] [PATCH 1/2] contrib: Add verify-pacman-repo-db.pl

On 19/07/16 00:28, Florian Pritz wrote: > Signed-off-by: Florian Pritz A commit message would be nice... Is there any reason PGP checksums are not checked? > --- > contrib/doc/verify-pacman-repo-db.1.txt | 50 ++ > contrib/verify-pacman-repo-db.pl| 279 >

Re: [pacman-dev] [PATCH] Clarify alpm-hooks(5)

On 24/07/16 06:15, Přemysl Janouch wrote: > While studying gtk-update-icon-cache.hook, which had the following contents: > > Target = usr/share/icons/*/ > Target = !usr/share/icons/*/?* > > it was not obvious from the documentation what and how this matches, > which I'm trying to rectify

Re: [pacman-dev] [PATCH] can_remove_file: do not follow symlinks

On 03/08/16 08:43, Joseph Burt wrote: > The symlink itself should be checked, not its target. > > Signed-off-by: Joseph Burt > --- > > This check also does more harm than good at the moment. If it fails once, > the rest of the package files are silently left on the

Re: [pacman-dev] [PATCH] Normalize alpm download callback's frontend cb arguments

On 09/07/16 13:11, ivy.fos...@gmail.com wrote: > From: Ivy Foster > > When curl calls alpm's dlcb, alpm calls the frontend's cb with the > following (dlsize, totalsize) arguments: > > 0, -1: initialize > 0, 0: no change since last call > x {x>0, x0}: data

Re: [pacman-dev] [PATCH] libmakepkg: look for architecture-specific hashes in get_integlist

On 24/06/16 00:18, Jack O'Connor wrote: > `makepkg -g` looks for existing checksums in the PKGBUILD file, so that > it can generate new sums of the same type. Previously it only checked > variables of the form "sha256sums", and not "sha256sums_x86_64". That > meant it would always fall back to MD5

Re: [pacman-dev] [PATCH] Update email address in copyright message

On 27/07/16 22:48, Giulio Fidente wrote: > hi Allan, > > thanks. By doing a git blame I realized there isn't a single line left > in that script from my original contribution so ... I don't know if > it's worth to update the email address or rather delete the line > entirely, your call. > > Keep

Re: [pacman-dev] [PATCH] Update email address in copyright message

On 27/07/16 22:07, Giulio Fidente wrote: > hi, > > this would be useful for me as I plan to delete my email alias. > > Thanks for your understanding. > This will be included in the next release. I am swamped at the moment, so patches are sitting in a queue. A

[pacman-dev] [PATCH] Add newline to the end of error messages for signature format issues

Signed-off-by: Allan McRae <al...@archlinux.org> --- I'll add this to the list of things I should manually update in the translation files to avoid duplicate work occuring. lib/libalpm/signing.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/l

Re: [pacman-dev] [PATCH] configure.ac: Fix handling --with-libcurl

On 27/06/16 05:30, Olivier Brunel wrote: > It was reported being --with-libcurl in the help (and the check for libcurl > being installed used $with_libcurl accordingly), but the option handling was > set > using $with_curl and, therefore, expected option --with-curl. > > In the end,

Re: [pacman-dev] [PATCH] hook.c: replace fstatat with stat

On 28/06/16 12:23, Andrew Gregory wrote: > macOS < 10.10 do not provide fstatat. We were constructing the full > path to the hook file for all other operations anyway, so there was no > real benefit to using fstatat. > > Fixes FS#49771 > > Signed-off-by: Andrew Gregory

Re: [pacman-dev] [PATCH] hook.c: replace readdir_r with readdir

On 28/06/16 12:23, Andrew Gregory wrote: > glibc 2.24 deprecates readdir_r. > > Signed-off-by: Andrew Gregory Thanks, Allan

[pacman-dev] Transifex - Was: [PATCH] Fix typo in german translation

On 27/06/16 02:32, Matthias Gorissen wrote: > As an aside, I should also note that outscourcing translations to > Transifex was one of the worst decisions ever made on this list. > Transifex lacks a decent VCS, which means that I cannot easily see > changes done by my collaborators. Things were

Re: [pacman-dev] [RFC] [PATCH] Implement a du --apparent-size equivalent

On 14/06/16 06:07, Alastair Hughes wrote: > On 6/12/16, Allan McRae <al...@archlinux.org> wrote: >> On 11/06/16 17:53, Alastair Hughes wrote: >>> From: Alastair Hughes <hobbitalast...@yandex.com> >>> >>> Add a pkgsize binary which mimics the behavio

[pacman-dev] Merging -S and -U - Was: DWIM if user attempts to sync on a file

On 18/06/16 01:21, Andrew Gregory wrote: > I would love to rearrange pacman's UI and merge -S and -U into > a generic install operation. I haven't worked on it in a while, but > I would like to see something like this: > https://wiki.archlinux.org/index.php/User:Apg#pacman_ui_reorganization That

Re: [pacman-dev] [PATCH] Handle all POSIX compliant systems in mbscasecmp.

On 19/06/16 02:58, Tobias Stoeckmann wrote: > The width of wchar_t is allowed to be of the same width as long, > according to standards. The return type of mbscasecmp is int though. > > On amd64 with a 32 bit int, this means that mbscasecmp can return > zero (indicating that strings are equal)

Re: [pacman-dev] [PATCH] Reject files larger than INT_MAX in read_sigfile.

On 19/06/16 02:41, Tobias Stoeckmann wrote: > If signature files are larger than SIZE_MAX, not enough memory could > be allocated for this file. The script repo-add rejects files which > are larger than 16384 bytes, therefore handle these as errors here, > too. > > While at it, I also rearranged

Re: [pacman-dev] [PATCH RFC] DWIM if user attempts to sync on a file

On 16/06/16 10:01, Andrew Eikum wrote: > I get bit by this fairly often when I build AUR packages. From my > perspective as a user, the distinction between -U and -S seems > irrelevant: I just want to install this package. So let's just have > pacman offer to Do What I Mean and install the files

Re: [pacman-dev] [RFC] [PATCH] Implement a du --apparent-size equivalent

On 17/06/16 01:37, Florian Pritz wrote: > On 13.06.2016 22:07, Alastair Hughes wrote: >>> I really don't want to provide a binary just to do this. >> >> I'm cross compiling; in that case, the host system has a different du >> than the target system > > How about implementing the functionality in

Re: [pacman-dev] [PATCH] mbscasecmp fails in 1% of time.

On 11/06/16 17:26, Tobias Stoeckmann wrote: > On Fri, Jun 10, 2016 at 07:10:56PM -0400, Andrew Gregory wrote: >> Good catch, but the solution needs work. > > You were able to grasp the idea of this non-issue. > > Now you can adjust your code the way you want. > Good old passive aggression...

Re: [pacman-dev] [PATCH] Fix out of boundary reads in pacsort.

On 11/06/16 17:27, Tobias Stoeckmann wrote: > On Fri, Jun 10, 2016 at 07:11:16PM -0400, Andrew Gregory wrote: >> I was saying that your rationale for just dropping support for -t '\0' >> was incorrect. NUL not being legal in a path name is irrelevant. > > Yup, it's irrelevant. The relevant part

Re: [pacman-dev] [PATCH] pacman-key: reject armored signatures

On 12/06/16 18:28, Pierre Neidhardt wrote: > On 16-06-12 14:28:48, Allan McRae wrote: >> pacman expectes and unarmored signature. > > Typos? > yes... fixed.

Re: [pacman-dev] [PATCH] Release resources on error paths.

On 07/06/16 04:12, Tobias Stoeckmann wrote: > Some resources (memory or file descriptors) are not released on all > error paths. > > Signed-off-by: Tobias Stoeckmann > --- > Thanks for your valueable review, Andrew. :) Looks good. I thought I got all of these during my

Re: [pacman-dev] [PATCH] Files that contain references to srcdir and pkgdir are listed

On 26/05/16 07:21, Ashley Whetter wrote: > Fixes FS#31558 > > Signed-off-by: Ashley Whetter > --- > .../libmakepkg/lint_package/build_references.sh.in | 22 > ++ > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git

Re: [pacman-dev] [PATCH] Can place local source files in directories

On 02/05/16 01:37, Ashley Whetter wrote: > For example a source file 'mydir/myfile.sh' is now valid, > whereas before 'myfile.sh' would have needed to be placed in the same > directory > as the PKGBUILD. > > Fixes FS#43020 > > Signed-off-by: Ashley Whetter > --- > I've

[pacman-dev] [PATCH] pacman-key: reject armored signatures

pacman expectes and unarmored signature. makepkg forces the generation of unarmored signatures, and repo-add will reject any armored signature. For consistency pacman-key should also reject armored signatures. Signed-off-by: Allan McRae <al...@archlinux.org> --- scripts/pacman-key.sh.

Re: [pacman-dev] [RFC] [PATCH] Implement a du --apparent-size equivalent

On 11/06/16 17:53, Alastair Hughes wrote: > From: Alastair Hughes > > Add a pkgsize binary which mimics the behaviour of GNU du --apparent-size > -skl. > Fixes FS#47943. > > Signed-off-by: Alastair Hughes > --- > I haven't done much C

Re: [pacman-dev] [PATCH] Reject files larger than INT_MAX in read_sigfile.

On 07/06/16 03:59, Tobias Stoeckmann wrote: > Signature files larger than INT_MAX are already suspicious, > but if they are larger than SIZE_MAX, this code couldn't even > copy them into memory, accepting them as "blank" files at worst. > > While adding the INT_MAX check, I also rearranged the

Re: [pacman-dev] [PATCH] callback.c: only print download status message once with --noprogressbar

On 08/06/16 07:01, Ivy Foster wrote: > Syncing repos and downloading packages with --noprogressbar specified > often prints the status message "downloading $foo..." to several > lines in a row. > --- > src/pacman/callback.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff

<    5   6   7   8   9   10   11   12   13   14   >