Re: [pacman-dev] Alternatives system

On Mon, Apr 01, 2019 at 02:57:31PM +1000, Allan McRae wrote: > > "TODO bikeshed the separator" > > > > We're in the rather unfortunate position that neither of our database > > formats can handle multiple arbitrary filenames on a single line > > without escaping. We can use -> in PKGBUILDs if

Re: [pacman-dev] interest in using meson over autotools?

On 08.07.2018 02:07, Dave Reisner wrote: > I think the answer is ideally that we have no make no changes at all to > our tests. We could do all of the work in the build system alone -- use > a harness to wrap each test and parse the TAP output. You could also use perl's `prove` to run the tests.

Re: [pacman-dev] [PATCH] makepkg: install all dependencies simultanously, if possible when using rmdeps but not install, runtime dependencies do not need special handling for (non)removal, and can be

That subject is way too long. Please keep it around 50 chars if at all possible and put the more detailed explanation in the commit body. In this case it's probably best to simply end the subject at the first comma. Florian signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] [PATCH] Fix CVE-2016-5434 (DoS/loop and out of boundary read)

On 16.09.2017 22:21, Nils Freydank wrote: > [...] > > (Feedback is very appreciated / this is an updated patch.) This line shouldn't be part of the commit. You can add it after the "---" marker (see below) when you use `git send-email --annotate` or if you save the patch with `git format-patch`

Re: [pacman-dev] [PATCH v2 2/2] makepkg: clarify error when user passes -F

On 15.09.2017 20:30, ivy.fos...@gmail.com wrote: > - error "$(gettext "Do not use the %s option. This option is only > for use by %s.")" "'-F'" "makepkg" > + error "$(gettext "Do not use the %s option. This option is only > for internal use by %s.")" "'-F'" "makepkg"

Re: [pacman-dev] Per server options - Was: Add per-repo PinnedPubKey option

On 02.11.2016 02:31, Allan McRae wrote: > On 02/11/16 09:56, Travis Burtrum wrote: >> On November 1, 2016 7:28:07 PM EDT, Allan McRae wrote: >> Server = http://foo/ key=value key2=val2 >> > Any other opinions? Sounds fine since spaces in the URL can/have to be escaped. I'm

Re: [pacman-dev] shellcheck conformity for makepkg

On 07.10.2016 03:52, Alad Wenter wrote: > The idea would be that each warning, if applicable, is addressed in a > separate patch. Good idea. If a warning appears multiple times and requires different ways of dealing with it in certain situations, please split that into multiple patches. It

Re: [pacman-dev] [PATCH] [RFC] Remove internal md5 and sha2 implementations

On 25.09.2016 11:22, Allan McRae wrote: > The configure script will now error if at least one > library supporting checksum generation is not present How about getting rid of that double negation? Better: "The configure script will now error if no library supporting checksums is present". "at

Re: [pacman-dev] [PATCH] fixup! contrib: Add verify-pacman-repo-db.pl

On Saturday, August 20, 2016 10:54:55 AM CEST Andrew Gregory wrote: > > If Andrew signs off on this I'll squash it my branch. > > Yes, this looks correct. The 'next' in the first branch is redundant > now, though. Right, thanks. I've rebased the patches on my working branch now. @Allan: Feel

[pacman-dev] [PATCH v2 2/3] contrib: Add documentation Makefile

Makefile.am is mostly copied from ./doc/Makefile.am Signed-off-by: Florian Pritz <bluew...@xinu.at> --- v2: - Move actual documentation to dedicated commit configure.ac | 1 + contrib/Makefile.am | 6 ++ contrib/doc/Makefile.am

[pacman-dev] [PATCH v2 3/3] Document contrib/verify-pacman-repo-db.pl

Signed-off-by: Florian Pritz <bluew...@xinu.at> --- v2: - new commit contrib/doc/.gitignore | 1 + contrib/doc/Makefile.am | 5 ++- contrib/doc/verify-pacman-repo-db.1.txt | 60 + 3 files changed, 65 insertions(+), 1 de

Re: [pacman-dev] [PATCH 1/2] contrib: Add verify-pacman-repo-db.pl

On 07.08.2016 08:28, Allan McRae wrote: > A commit message would be nice... Would a copy of the manpage description be fine or do you have something else in mind? > Is there any reason PGP checksums are not checked? I don't see a mention of checksum-only verification in the gpg manpage so I'll

[pacman-dev] [PATCH 1/2] contrib: Add verify-pacman-repo-db.pl

Signed-off-by: Florian Pritz <bluew...@xinu.at> --- contrib/doc/verify-pacman-repo-db.1.txt | 50 ++ contrib/verify-pacman-repo-db.pl| 279 2 files changed, 329 insertions(+) create mode 100644 contrib/doc/verify-pacman-repo-db.1.txt creat

[pacman-dev] [PATCH 2/2] contrib: Add documentation Makefile

Makefile.am is mostly copied from ./doc/Makefile.am Signed-off-by: Florian Pritz <bluew...@xinu.at> --- configure.ac | 1 + contrib/Makefile.am | 6 + contrib/doc/.gitignore| 1 + contrib/doc/Makefile.am

Re: [pacman-dev] [RFC] [PATCH] Implement a du --apparent-size equivalent

On 13.06.2016 22:07, Alastair Hughes wrote: >> I really don't want to provide a binary just to do this. > > I'm cross compiling; in that case, the host system has a different du > than the target system How about implementing the functionality in something like awk or perl? Those should be

Re: [pacman-dev] [PATCH] Reject files larger than INT_MAX in read_sigfile.

On 05.06.2016 19:37, Tobias Stoeckmann wrote: > diff --git a/lib/libalpm/be_package.c b/lib/libalpm/be_package.c > index c9ed770..055fb1e 100644 > --- a/lib/libalpm/be_package.c > +++ b/lib/libalpm/be_package.c > @@ -700,17 +700,16 @@ static int read_sigfile(const char *sigpath, unsigned > char

Re: [pacman-dev] www.archlinux.org/pacman/

On 26.03.2016 12:00, Allan McRae wrote: > It gets updated when I remember... The main problem here being I can > never remember where to upload it to. Write a script or add it to the makefile? Florian signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] [PATCH] RFC: remove upx and optipng support from makepkg

On 02.02.2016 02:44, Allan McRae wrote: > These options were added before libmakepkg allowed passes like this to be > dropped in. I prefer only real core packaging tasks to be included in > makepkg and additional things like this to be dropped in by a user or > distribution that wants to support

[pacman-dev] [PATCH] makepkg: Output full URL in case of download failure

ing example-1.2.4.tar.gz New: ==> ERROR: Failure while downloading http://example.org/releases/1.1/example-1.2.4.tar.gz With the new format it is much more obvious that the directory name is the culprint (1.1 vs 1.2) while the old one would not display that information. Signed-off-by: Florian

Re: [pacman-dev] [PATCH] test version range restrictions corner case

On Mon, 7 Dec 2015 21:37:09 +0100 Dominik Fischer wrote: > This behavior may be intended though. If so, this corner case should > perhaps be noted in the documentation. Please review and comment. Actually that is exactly what some of our packages want to do so I'd consider it

Re: [pacman-dev] Broken pacman output when resizing

On Sun, 29 Nov 2015 13:14:46 +0100 Constantin Weißer wrote: > version1 uses a fixed 100 columns output, version2 a fixed 80 columns > output. Why do you force it to be 80 chars wide? How about simply limiting it to 80 chars? > -> [254.5 MiB] ↓7.49M/s 01:00

[pacman-dev] [PATCH v4 1/2] Document pacman -F

Signed-off-by: Florian Pritz <bluew...@xinu.at> --- v4: - Mention that onyl sync dbs are searched - Add --quiet doc/pacman.8.txt | 29 + 1 file changed, 29 insertions(+) diff --git a/doc/pacman.8.txt b/doc/pacman.8.txt index 18303c3..838b70b 100644 ---

Re: [pacman-dev] [PATCH v3 2/2] Add -F --machinereable option

On Fri, 30 Oct 2015 13:59:53 -0400 Andrew Gregory wrote: > Aside from a few style nitpicks, the code looks fine. I am curious as > to the motivation for this though. Most of our operations are made > easier to parse by using --quiet to reduce the output to a single >

Re: [pacman-dev] [PATCH v2 1/2] Document pacman -F

On Wed, 28 Oct 2015 13:17:27 +1000 Allan McRae wrote: > > +The '--list', '--search' and '--owns' options are exclusive and can not be > > combined. > > I first read that as --list can not be combined with anything else (e.g. > --refresh). I also note that we do not do

Re: [pacman-dev] [PATCH v2 2/2] Add -F --machinereable option

On Sun, 25 Oct 2015 14:14:49 -0400 Andrew Gregory <andrew.gregor...@gmail.com> wrote: > On 10/25/15 at 05:07pm, Florian Pritz wrote: > > Signed-off-by: Florian Pritz <bluew...@xinu.at> > > --- > > > > v2: > > - Always output paths without lea

[pacman-dev] [PATCH v3 2/2] Add -F --machinereable option

Signed-off-by: Florian Pritz <bluew...@xinu.at> --- v3: - Change output format to use \0 as field separator. - Only output one repo for -Fl - Combine else if - Fix incorrect placement of FREELIST(match) doc/pacman.8.txt| 5 + src/pacman/conf.h | 2 ++ src/pacman/files.c

[pacman-dev] [PATCH 1/2] Document pacman -F

Signed-off-by: Florian Pritz <bluew...@xinu.at> --- doc/pacman.8.txt | 22 ++ 1 file changed, 22 insertions(+) diff --git a/doc/pacman.8.txt b/doc/pacman.8.txt index 5c57450..a4dd1f0 100644 --- a/doc/pacman.8.txt +++ b/doc/pacman.8.txt @@ -110,6 +110,11 @@ greater than

[pacman-dev] [PATCH v2 2/2] Add -F --machinereable option

Signed-off-by: Florian Pritz <bluew...@xinu.at> --- v2: - Always output paths without leading slash doc/pacman.8.txt| 4 src/pacman/conf.h | 2 ++ src/pacman/files.c | 69 ++--- src/pacman/pacman.c | 6 + 4 files chang

[pacman-dev] [PATCH v2 1/2] Document pacman -F

Signed-off-by: Florian Pritz <bluew...@xinu.at> --- v2: - Document --refresh doc/pacman.8.txt | 26 ++ 1 file changed, 26 insertions(+) diff --git a/doc/pacman.8.txt b/doc/pacman.8.txt index 5c57450..38b8bb7 100644 --- a/doc/pacman.8.txt +++ b/doc/pacman

[pacman-dev] [PATCH 2/2] Add -F --machinereable option

Signed-off-by: Florian Pritz <bluew...@xinu.at> --- doc/pacman.8.txt| 4 +++ src/pacman/conf.h | 2 ++ src/pacman/files.c | 70 ++--- src/pacman/pacman.c | 6 + 4 files changed, 63 insertions(+), 19 deletions(-) diff --git

Re: [pacman-dev] pacman files database operations

On Sat, 17 Oct 2015 10:06:07 +0200 Florian Pritz <bluew...@xinu.at> wrote: > On Sat, 20 Jun 2015 12:39:17 +0200 Florian Pritz <bluew...@xinu.at> > wrote: > > As discussed on IRC I'll work on a -m switch that outputs an easy to > > parse format ($repo/$pkgname $p

Re: [pacman-dev] pacman files database operations

On Sat, 20 Jun 2015 12:39:17 +0200 Florian Pritz <bluew...@xinu.at> wrote: > As discussed on IRC I'll work on a -m switch that outputs an easy to > parse format ($repo/$pkgname $pkgver: $file) once the patches are > reviewed and merged. I'm working on this now and I've noticed

Re: [pacman-dev] Source code not available. FTP broken.

On 08.08.2015 07:55, Folatt wrote: But the FTP seems broken. I get a 404 message. Please never ever just say it's broken. Always provide as much information as you can, in this case the URL you are trying to download from and where you found that URL. signature.asc Description: OpenPGP

Re: [pacman-dev] Patch-proposal for makepkg: be able to use su for installations even if sudo is installed

On Mon, 27 Jul 2015 10:53:59 +0200 Jonas Große Sundrup jonas-...@letopolis.de wrote: You could solve it by configuring sudo to use the user's password for maintenance, but I simply prefer using the root-password for system related stuff sudo can be configured to ask for the target's password

Re: [pacman-dev] pacman files database operations

On 20.06.2015 09:31, Allan McRae wrote: I see that the output is similar to -Ql and -Qo, but I think it's still better to use a more verbose and easier to parse (e.g. `cut -d\ -f 2-`) format. Especially with regard to the possibility of a package being in multiple repositories which can't

Re: [pacman-dev] pacman files database operations

On 18.06.2015 14:46, Allan McRae wrote: $ pacman -Fl abs abs /etc/ abs /etc/abs.conf Does this come with -q to disable the prepended package name in the output? What happens if the package exists in multiple repos? Will I get the list of only one of them or all of them? Can I use -Fl

Re: [pacman-dev] [PATCH 1/2] makepkg-template: ignore duplicates per option

On 09.06.2015 07:34, Allan McRae wrote: I see it being reasonable to use the same template twice in a package (e.g. in split package_*() functions). So this needs detected only during recursion. I'm pretty sure I totally ignored the problem of endless recursion when writing the script and I

Re: [pacman-dev] [PATCH 1/2] makepkg-template: ignore duplicates per option

On 08.06.2015 11:28, Dominik Fischer wrote: When templates recursively include other templates, a diamond problem, similar to multiple inheritance, may occur. It is illustrated in the test case. As templates may consist of arbitrary code, it may be unwanted to execute a template twice. This

Re: [pacman-dev] [PATCH] makepkg-template.1: Clarify which file version-less markers use

On 03.06.2015 11:04, Wieland Hoffmann wrote: The old text could be interpreted such that makepkg-template compares the version numbers of the templates to find the most recent one. Rephrase this to make it explicit that $template_name.template is used. Signed-off-by: Florian Pritz bluew

Re: [pacman-dev] [PATCH v3] makepkg-template: support multiple --template-dirs

, the last one always takes precedence. Neither the default behaviour without the option given, nor the handling of a single template dir is changed. Signed-off-by: Dominik Fischer d.f.fisc...@web.de Signed-off-by: Florian Pritz bluew...@xinu.at Also pulled into my working branch for easy

Re: [pacman-dev] [PATCH v2] makepkg-template: support multiple --template-dirs

On 23.04.2015 13:59, Dominik Fischer wrote: diff --git a/scripts/makepkg-template.pl.in b/scripts/makepkg-template.pl.in index 71d2aae..49e0e37 100755 --- a/scripts/makepkg-template.pl.in +++ b/scripts/makepkg-template.pl.in @@ -98,26 +98,32 @@ sub load_template { my $ret = ; -

Re: [pacman-dev] [PATCH] makepkg-template: support multiple --template-dirs

On 22.04.2015 20:37, Dominik Fischer wrote: Especially when maintaining local templates in addition to the ones stored in /usr/share/makepkg-template, it can be useful to include templates stored in multiple different locations into one PKGBUILD. This patch makes this possible by allowing

Re: [pacman-dev] [PATCH] libalpm: Do a sanity check before manipulating final DB URL

On 13.04.2015 21:33, David Macek wrote: diff --git a/lib/libalpm/be_sync.c b/lib/libalpm/be_sync.c index 20130dc..f30698e 100644 --- a/lib/libalpm/be_sync.c +++ b/lib/libalpm/be_sync.c @@ -241,20 +241,27 @@ int SYMEXPORT alpm_db_update(int force, alpm_db_t *db)

Re: [pacman-dev] [PATCH] Add makepkg option --printproducts; fix bug #42150

On 21.03.2015 01:23, Ivy Foster wrote: On 20 Mar 2015, at 9:29 pm +0100, Florian Pritz wrote: From: Ivy Foster joyfulg...@archlinux.us I'm not really sure why that is here. Did you set the envelope sender in git (git config --global sendemail.envelopesender) or am I missing some

Re: [pacman-dev] [PATCH] Add makepkg option --printproducts; fix bug #42150

From: Ivy Foster joyfulg...@archlinux.us I'm not really sure why that is here. Did you set the envelope sender in git (git config --global sendemail.envelopesender) or am I missing some difference between the two addresses? New contributor - yay! [patch] [notes] Thanks! I'll fix it up

Re: [pacman-dev] [PATCH] paccache: added --quiet option

On 08.02.2015 23:24, Maxim Andersson wrote: Cleaner to have -q,--quiet than /dev/null in cron. You should look into using chronic from moreutils. It captures stdout/stderr and only outputs them again if the exit code != 0 (which I hope holds for paccache if it encounters errors). You really

Re: [pacman-dev] [PATCH 1/1] add option to optimize PNG images with optipng

On 22.01.2015 09:36, Christian Hesse wrote: --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1918,6 +1918,17 @@ tidy_install() { fi done fi + + if check_option optipng y; then + msg2 $(gettext Optimizing PNG images...)

Re: [pacman-dev] [PATCH] Changed copyright to 2006 - 2015 in version info

On 20.01.2015 19:26, Robin de Rooij wrote: From 749dde01efdde4c69491c36c1244a112de54ce52 Mon Sep 17 00:00:00 2001 From: Robin de Rooij rderooij...@famousgoglemailhoster.com Date: Fri, 16 Jan 2015 22:36:00 +0100 Subject: [PATCH] Changed copyright to 2006 - 2015 in version info Please use

[pacman-dev] [PATCH] Fix makepkg-template tests for make distcheck

autotools dislikes having symlinks in the tarball so create those during testing. Also fix the value of PMTEST_SCRIPT_DIR to actually point to the correct dir in the distcheck case (different build dir). Signed-off-by: Florian Pritz bluew...@xinu.at --- Makefile.am

Re: [pacman-dev] Bazaar branch check in makepkg

On 08.01.2015 23:18, David Macek wrote: I'm posting this on behalf of an MSYS2 user. I appreciate you trying to send patches upstream, but you'll likely get more/better responses if you send the patch with git-send-email so it's easy to review/comment on. Also it's probably better if the author

Re: [pacman-dev] [PATCH v5] Add testrunner for makepkg-template

On 29.12.2014 04:50, Andrew Gregory wrote: diff --git a/test/scripts/makepkg-template_test.sh b/test/scripts/makepkg-template_test.sh new file mode 100755 index 000..60cbb0c --- /dev/null +++ b/test/scripts/makepkg-template_test.sh @@ -0,0 +1,56 @@ +#!/bin/bash + +source $(dirname

Re: [pacman-dev] [PATCH v2 1/1] libalpm: generate alpm.h on the fly and add version information

On 29.12.2014 08:45, Christian Hesse wrote: From: Christian Hesse m...@eworm.de Programs linked against libalpm (for example packagekit) may want to use preprocessor macros to check version and choose correct API. This adds version information to alpm.h. Signed-off-by: Christian Hesse

[pacman-dev] [PATCH] makepkg-template: Remove linenumber/file from errors

die prints at $scriptname line $linenumber. if the string does not end with \n. This information is not of much use for us and it makes testing harder because we'd to remove it there. Signed-off-by: Florian Pritz bluew...@xinu.at --- scripts/makepkg-template.pl.in | 4 ++-- 1 file changed, 2

[pacman-dev] [PATCH v4 03/11] test makepkg-template: Add invalid-template-line-missing-name

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../invalid-template-line-missing-name/PKGBUILD | 1 + .../invalid-template-line-missing-name/testcase-config| 11 +++ 2 files changed, 12 insertions(+) create mode 100644 test/scripts/makepkg-template-tests

[pacman-dev] [PATCH v4 04/11] test makepkg-template: Add invalid-template-line-unknown-marker

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../invalid-template-line-unknown-marker/PKGBUILD | 9 + .../invalid-template-line-unknown-marker/testcase-config | 11 +++ 2 files changed, 20 insertions(+) create mode 100644 test/scripts/makepkg-template

[pacman-dev] [PATCH v4 10/11] test makepkg-template: Add template-without-version

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../makepkg-template-tests/template-without-version/PKGBUILD | 8 .../templates/template-without_version.template | 0 .../template-without-version/testcase-config | 9 + 3 files changed

[pacman-dev] [PATCH v4 08/11] test makepkg-template: Add name-charset-invalid

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../makepkg-template-tests/name-charset-invalid/PKGBUILD | 8 .../name-charset-invalid/testcase-config | 10 ++ 2 files changed, 18 insertions(+) create mode 100644 test/scripts/makepkg-template

[pacman-dev] [PATCH v4 05/11] test makepkg-template: Add keep-old-version

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../keep-old-version/PKGBUILD | 15 ++ .../templates/perl-bla-1.2.template| 1 + .../keep-old-version/templates/perl-bla.template | 1 + .../templates/perl-module-1.0.template | 6

[pacman-dev] [PATCH v4 11/11] test makepkg-template: Add update-version-with-newest-option

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../update-version-with-newest-option/PKGBUILD | 7 +++ .../templates/perl-bla-1.2.template| 1 + .../templates/perl-bla.template| 1 + .../templates/perl-module-1.0.template | 6

[pacman-dev] [PATCH v5] Add testrunner for makepkg-template

Signed-off-by: Florian Pritz bluew...@xinu.at --- v5: - remove wrong comment - look for the executable in PATH - exit after tap_bail Makefile.am| 2 + test/scripts/Makefile.am | 1 + .../testcase-config-template

[pacman-dev] [PATCH v3] Add testrunner for makepkg-template

Signed-off-by: Florian Pritz bluew...@xinu.at --- v3: + suggested by Andrew - take the executable as $1 rather than just the dir - force C locale - use $testdir when normalizing paths - fix output line of successful testcase - remove useless begin comment + replace $testdir more than

[pacman-dev] [PATCH] makepkg-template: Remove unused printf format string

I'm pretty sure this is some kind of left over stuff that was supposed to print the filename, linenumber and line content. This is already done so just remove it. Signed-off-by: Florian Pritz bluew...@xinu.at --- scripts/makepkg-template.pl.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[pacman-dev] [PATCH 04/11] test makepkg-template: Add invalid-template-line-unknown-marker

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../invalid-template-line-unknown-marker/PKGBUILD| 9 + .../invalid-template-line-unknown-marker/expected_output | 3 +++ 2 files changed, 12 insertions(+) create mode 100644 test/scripts/makepkg-template-tests

[pacman-dev] [PATCH 01/11] Add testrunner for makepkg-template

Signed-off-by: Florian Pritz bluew...@xinu.at --- Makefile.am| 2 + test/scripts/Makefile.am | 1 + test/scripts/makepkg-template-tests/.gitignore | 3 + test/scripts/makepkg-template_test.sh | 86 ++ 4

[pacman-dev] [PATCH 06/11] test makepkg-template: Add missing-template-file

Signed-off-by: Florian Pritz bluew...@xinu.at --- test/scripts/makepkg-template-tests/missing-template-file/PKGBUILD | 7 +++ .../makepkg-template-tests/missing-template-file/expected_output | 2 ++ .../missing-template-file/templates/perl-module.template | 1 + 3 files changed

[pacman-dev] [PATCH 09/11] test makepkg-template: Add name-charset-valid

Signed-off-by: Florian Pritz bluew...@xinu.at --- test/scripts/makepkg-template-tests/name-charset-valid/PKGBUILD | 8 .../makepkg-template-tests/name-charset-valid/expected_output | 1 + .../makepkg-template-tests/name-charset-valid/expected_result | 8 .../name

[pacman-dev] [PATCH 08/11] test makepkg-template: Add name-charset-invalid

Signed-off-by: Florian Pritz bluew...@xinu.at --- test/scripts/makepkg-template-tests/name-charset-invalid/PKGBUILD | 8 .../makepkg-template-tests/name-charset-invalid/expected_output | 3 +++ 2 files changed, 11 insertions(+) create mode 100644 test/scripts/makepkg-template-tests

[pacman-dev] [PATCH 07/11] test makepkg-template: Add missing-template-symlink

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../makepkg-template-tests/missing-template-symlink/PKGBUILD | 7 +++ .../missing-template-symlink/expected_output | 2 ++ .../missing-template-symlink/templates/perl-module-1.0.template| 1 + 3 files changed

[pacman-dev] [PATCH 10/11] test makepkg-template: Add template-without-version

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../makepkg-template-tests/template-without-version/PKGBUILD | 8 .../template-without-version/expected_output | 2 ++ .../templates/template-without_version.template | 0 3 files changed, 10

[pacman-dev] [PATCH 02/11] test makepkg-template: Add invalid-key

Signed-off-by: Florian Pritz bluew...@xinu.at --- test/scripts/makepkg-template-tests/invalid-key/PKGBUILD| 1 + test/scripts/makepkg-template-tests/invalid-key/expected_output | 3 +++ 2 files changed, 4 insertions(+) create mode 100644 test/scripts/makepkg-template-tests/invalid-key

[pacman-dev] [PATCH 05/11] test makepkg-template: Add keep-old-version

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../makepkg-template-tests/keep-old-version/PKGBUILD | 15 +++ .../keep-old-version/expected_output | 1 + .../keep-old-version/expected_result | 15 +++ .../keep-old-version

[pacman-dev] [PATCH 11/11] test makepkg-template: Add update-version-with-newest-option

Signed-off-by: Florian Pritz bluew...@xinu.at --- .../update-version-with-newest-option/PKGBUILD | 7 +++ .../update-version-with-newest-option/arguments | 1 + .../update-version-with-newest-option/expected_output| 1 + .../update-version-with-newest-option

Re: [pacman-dev] [PATCH 01/11] Add testrunner for makepkg-template

On 21.12.2014 16:11, Florian Pritz wrote: + $scriptdir/makepkg-template \ + --template-dir $testdir/$testcase/templates \ + -p $testdir/$testcase/PKGBUILD \ + -o $testdir/$testcase/result \ + $testdir/$testcase/output_full ${arguments

[pacman-dev] [PATCH v2] Add testrunner for makepkg-template

Signed-off-by: Florian Pritz bluew...@xinu.at --- v2: - use a temp dir for output files - mark the exit code in the expected_output file with exitcode: (tests are adjusted on my working branch) Makefile.am | 2 + test/scripts/Makefile.am | 1

[pacman-dev] [PATCH v2 2/2] Add --assume-installed to shell completion

Signed-off-by: Florian Pritz bluew...@xinu.at --- v2: Also add it to -U in zsh. Only issue I see is that it completes a package name if you complete --assume-installed tab which doesn't make a whole lot of sense. contrib/bash_completion.in | 6 +++--- contrib/zsh_completion.in | 3 +++ 2 files

[pacman-dev] [PATCH 2/2] Add --assume-installed to shell completion

Signed-off-by: Florian Pritz bluew...@xinu.at --- I tested the zsh completion, didn't test bash. contrib/bash_completion.in | 6 +++--- contrib/zsh_completion.in | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/contrib/bash_completion.in b/contrib/bash_completion.in index

Re: [pacman-dev] FS#42482 - [paccache] No candidates should not be an error

On 28.10.2014 03:44, Eric Schultz wrote: declare -a cachedirs=() candidates=() cmdopts=() whitelist=() blacklist=() -declare -i delete=0 dryrun=0 filecount=0 move=0 needsroot=0 totalsaved=0 verbose=0 +declare -i delete=0 dryrun=0 filecount=0 move=0 needsroot=0 noneisok=0 totalsaved=0

[pacman-dev] [PATCH v4] libalpm: export alpm_splitdep as alpm_dep_from_depstring and alpm_dep_free

Signed-off-by: Florian Pritz bluew...@xinu.at --- v4: - Change alpm_splitdep to alpm_dep_from_depstring - Group the functions with alpm_dep_compute_string (in alpm.h) - Add documentation to the functions (in alpm.h) lib/libalpm/alpm.h | 11 +++ lib/libalpm/be_local.c | 2

[pacman-dev] [PATCH v4 1/3] deps.c: split _alpm_depcmp into _alpm_depcmp_provides

This allows to reuse the provision checker for a simple list of provisions without a package. Signed-off-by: Florian Pritz bluew...@xinu.at --- v4: - Incorporate suggestions from Andrew lib/libalpm/deps.c | 21 ++--- lib/libalpm/deps.h | 1 + 2 files changed, 15 insertions

[pacman-dev] [PATCH v4 3/3] Add --assume-installed option

This allows to ignore specific dependencies. Signed-off-by: Florian Pritz bluew...@xinu.at --- v4: - Incorporate suggestions from Andrew - Return 1 if alpm_dep_from_depstring fails since this can only happen because of memory problems which already generate an error message. I hope

[pacman-dev] [PATCH v3] --assume-installed (was: --ignore-depends)

v3: - Change the option name to --assume-installed - Add manpage - Make the API consistent by passing around alpm_depend_t only, no char* - returning a char* list in *_get_* would require either saving it (bad) or creating it on request which would require the user to free it (bad

[pacman-dev] [PATCH v3 3/3] Add --assume-installed option

This allows to ignore specific dependencies. Signed-off-by: Florian Pritz bluew...@xinu.at --- doc/pacman.8.txt | 6 +++ lib/libalpm/alpm.h | 11 + lib/libalpm/deps.c | 8 +++- lib/libalpm/handle.c | 79

[pacman-dev] [PATCH v3 1/3] deps.c: split _alpm_depcmp into _alpm_depcmp_provides

This allows to reuse the provision checker for a simple list of provisions without a package. Signed-off-by: Florian Pritz bluew...@xinu.at --- v3: no changes here lib/libalpm/deps.c | 27 +++ lib/libalpm/deps.h | 1 + 2 files changed, 20 insertions(+), 8 deletions

[pacman-dev] [PATCH v3 2/3] libalpm: export alpm_splitdep and alpm_dep_free

Signed-off-by: Florian Pritz bluew...@xinu.at --- I'm not sure where in alpm.g the functions should be, open to suggestions. lib/libalpm/alpm.h | 2 ++ lib/libalpm/be_local.c | 2 +- lib/libalpm/be_package.c | 10 +- lib/libalpm/be_sync.c| 2 +- lib/libalpm/deps.c

[pacman-dev] [PATCH v2] --ignore-depends

v2: - Use _alpm_splitdep rather than implementing it myself (thanks to Andrew for the idea) I'd love feedback on the idea/implementation (preferably from Allan) and also general feedback on this try at documenting it (in man pacman): --ignore-depends provider=version,... Make pacman

[pacman-dev] [PATCH v2 1/2] deps.c: split _alpm_depcmp into _alpm_depcmp_provides

This allows to reuse the provision checker for a simple list of provisions without a package. Signed-off-by: Florian Pritz bluew...@xinu.at --- lib/libalpm/deps.c | 27 +++ lib/libalpm/deps.h | 1 + 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/lib

[pacman-dev] [PATCH v2 2/2] Add --ignore-depends option

This allows to ignore specific dependencies. TODO: documentation Signed-off-by: Florian Pritz bluew...@xinu.at --- lib/libalpm/alpm.h | 11 lib/libalpm/deps.c | 8 -- lib/libalpm/handle.c | 62 ++ lib

Re: [pacman-dev] [RFC] [IDEA] Possibility to ignore specific dependencies

On 13.07.2014 09:27, Allan McRae wrote: On 22/06/14 23:32, Florian Pritz wrote: So this is the process now: pacman -Syu- perl version dependency error pacman -Sd perl pacman -Su and this will change to: pacman -Syu- perl version dependency error pacman -Su --ignore-depends

[pacman-dev] [PATCH] Add --ignore-depends option

This allows to ignore specific dependencies. TODO: documentation Signed-off-by: Florian Pritz bluew...@xinu.at --- This patch is still missing documentation as noted in the commit message, but apart from that it works (at least alpm_option_set_ignoredeps(), didn't test _remove_). Now that I

[pacman-dev] [RFC] [IDEA] Possibility to ignore specific dependencies

Hi, I'm thinking about having perl packages depend on a more specific perl version (like a provided perl-5.20 instead of simply perl), but that brings the same issues we currently have with kernel modules. Everything that's not in the repos will prevent a clean upgrade because it depends on the

[pacman-dev] [PATCHv2] Add test case for the perl 5.20 dependency breakage

This test currently fails. Signed-off-by: Florian Pritz bluew...@xinu.at --- v2: - changed filename - renamed packages in the testcase to more generic ones (I don't like provides as a provided package name so I chose feature) - expectfailure = True - add to TESTS test/pacman/tests/TESTS

[pacman-dev] [PATCH] Add test case for the perl 5.20 dependency breakage

This test currently fails. Signed-off-by: Florian Pritz bluew...@xinu.at --- test/pacman/tests/sync-perl520-breakage.py | 21 + 1 file changed, 21 insertions(+) create mode 100644 test/pacman/tests/sync-perl520-breakage.py diff --git a/test/pacman/tests/sync-perl520

[pacman-dev] [PATCH] util: Use off_t instead of int for size values

Old output: Total Installed Size: -1527.44 MiB Fixed: Total Installed Size: 2568.56 MiB Bug introduced in 7b8f8753b15037bf4a88126ffde8195416432c72. Signed-off-by: Florian Pritz bluew...@xinu.at --- src/pacman/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

Re: [pacman-dev] [PATCH] Add configuration options for libcurl's low speed timeout

On 26.03.2014 21:14, Andrew Hills wrote: Please find below the third iteration of the patch, now using the new alpm_option_set methods, and with more descriptive documenting comments. From 9272595b5207e07799dfd49bac9d27b699253297 Mon Sep 17 00:00:00 2001 From: Andrew Hills ahi...@ednos.net

Re: [pacman-dev] [PATCH 1/2] contrib: adding pacsize

On 05.03.2014 17:22, Pierre Neidhardt wrote: $ pacman -Qi linux | grep Installed [0][1078] Installed Size : 67.12 MiB This is actually something I've been wondering for a while: how do you change the size unit? They are hard coded for a few

Re: [pacman-dev] [PATCH] makepkg: added a -a, --noarchive option to inhibit archive creation

The patch subject could be a little better. Try to always use the present tense (Add instead of added) and capitalize the first word to stay in line with tools like git merge and revert. Also present tense is shorter in most cases. Also use an instead of a before vowel sounds. Not too big of a

Re: [pacman-dev] [PATCH v6 6/6] be_local: Use alpm_greedy_grow

On 10.02.2014 09:54, Florian Pritz wrote: + _alpm_log(db-handle, ALPM_LOG_DEBUG, allocating %ld\n, (files_size ? files_size + 1 : 8 * sizeof(alpm_file_t))); Debug output removed in my working branch. signature.asc Description: OpenPGP digital signature

[pacman-dev] Mtree parsing v5

I hope I incorporated all suggestions. Most patches didn't change, but I'm submitting them anyway for an easier (hopefully final) review.

[pacman-dev] [PATCH v5 6/6] be_local: Use alpm_greedy_grow

Signed-off-by: Florian Pritz bluew...@xinu.at --- lib/libalpm/be_local.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c index 0b5b266..d2b0fe3 100644 --- a/lib/libalpm/be_local.c +++ b/lib/libalpm/be_local.c

[pacman-dev] [PATCH v5 5/6] be_package: Build the file list from MTREE if possible

This greatly speeds up file list generation times by avoiding uncompressing the whole package. pacman -S base with a deliberate file conflict: before: 9.1 seconds after: 2.2 seconds Signed-off-by: Florian Pritz bluew...@xinu.at --- lib/libalpm/be_package.c | 149

  1   2   3   >