Re: [parted-devel] [PATCH] unneeded stats...

2009-02-23 Thread Karel Zak
On Mon, Feb 23, 2009 at 06:01:45PM +0100, Joel Granados wrote: > Well, I still see the use for the first version of the patch, the one that > did not Sure, the patch makes a lot of sense. > Note that we are already stating and checking if they are S_IFBLK. This > comes after we make sure that

Re: [parted-devel] [PATCH] unneeded stats...

2009-02-23 Thread Joel Granados
On Mon, Feb 23, 2009 at 04:10:58PM +, Bryn M. Reeves wrote: > Joel Granados wrote: >> On Mon, Feb 23, 2009 at 03:50:02PM +, Bryn M. Reeves wrote: >>> Joel Granados Moreno wrote: Hello List Here is the reviewed patch for the unneeded stats that we are doing when looking f

Re: [parted-devel] [PATCH] unneeded stats...

2009-02-23 Thread Joel Granados
On Mon, Feb 23, 2009 at 05:46:17PM +0100, Karel Zak wrote: > On Mon, Feb 23, 2009 at 04:10:58PM +, Bryn M. Reeves wrote: > > Joel Granados wrote: > > > On Mon, Feb 23, 2009 at 03:50:02PM +, Bryn M. Reeves wrote: > > >> Joel Granados Moreno wrote: > > >>> Hello List > > >>> > > >>> Here is t

Re: [parted-devel] [PATCH] unneeded stats...

2009-02-23 Thread Bryn M. Reeves
Karel Zak wrote: # mount //dev/mapper/cyan /mnt # grep cyan /proc/mounts //dev/mapper/cyan /mnt ext3 rw,data=ordered 0 0 >>> I tested for this situation in my fedora10 environment With the latest >>> parted. And if I do the mount with "//" /proc/mounts will show it with >> Yep, jus

Re: [parted-devel] [PATCH] unneeded stats...

2009-02-23 Thread Karel Zak
On Mon, Feb 23, 2009 at 04:10:58PM +, Bryn M. Reeves wrote: > Joel Granados wrote: > > On Mon, Feb 23, 2009 at 03:50:02PM +, Bryn M. Reeves wrote: > >> Joel Granados Moreno wrote: > >>> Hello List > >>> > >>> Here is the reviewed patch for the unneeded stats that we are doing when > >>> loo

Re: [parted-devel] [PATCH] unneeded stats...

2009-02-23 Thread Bryn M. Reeves
Joel Granados wrote: > On Mon, Feb 23, 2009 at 03:50:02PM +, Bryn M. Reeves wrote: >> Joel Granados Moreno wrote: >>> Hello List >>> >>> Here is the reviewed patch for the unneeded stats that we are doing when >>> looking for mounted devices. It is modified to not search for "server >>> string

Re: [parted-devel] [PATCH] unneeded stats...

2009-02-23 Thread Joel Granados
On Mon, Feb 23, 2009 at 03:50:02PM +, Bryn M. Reeves wrote: > Joel Granados Moreno wrote: >> Hello List >> >> Here is the reviewed patch for the unneeded stats that we are doing when >> looking for mounted devices. It is modified to not search for "server >> strings" (//servername/path/to/some

Re: [parted-devel] [PATCH] unneeded stats...

2009-02-23 Thread Bryn M. Reeves
Joel Granados Moreno wrote: > Hello List > > Here is the reviewed patch for the unneeded stats that we are doing when > looking for mounted devices. It is modified to not search for "server > strings" (//servername/path/to/somewhere) > > Review appreciated There's a slight gotcha with this appr

[parted-devel] [PATCH] unneeded stats...

2009-02-23 Thread Joel Granados Moreno
Hello List Here is the reviewed patch for the unneeded stats that we are doing when looking for mounted devices. It is modified to not search for "server strings" (//servername/path/to/somewhere) Review appreciated regards Joel Andres Granados Brno, Czech Republic, Red Hat. __