On Mon, Nov 09, 2015 at 02:37:54AM +, Finucane, Stephen wrote:
> > i == count cannot happen in the loop as i will vary from 0 to count - 1.
> >
> > Signed-off-by: Damien Lespiau
> > ---
> > patchwork/management/commands/retag.py | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
On Mon, Nov 09, 2015 at 02:29:57AM +, Finucane, Stephen wrote:
> > @@ -38,6 +39,6 @@ class Command(BaseCommand):
> > for i, patch in enumerate(query.iterator()):
> > patch.refresh_tag_counts()
> > if (i % 10) == 0 or i == count:
> > -self.stdou
> On Mon, Nov 09, 2015 at 02:37:54AM +, Finucane, Stephen wrote:
> > > i == count cannot happen in the loop as i will vary from 0 to count -
> 1.
> > >
> > > Signed-off-by: Damien Lespiau
> > > ---
> > > patchwork/management/commands/retag.py | 3 ++-
> > > 1 file changed, 2 insertions(+), 1
> -Original Message-
> From: Lespiau, Damien
> Sent: Monday, November 9, 2015 4:54 AM
> To: Finucane, Stephen
> Cc: patchwork@lists.ozlabs.org
> Subject: Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout
> wrappers
>
> On Mon, Nov 09, 2015 at 02:29:57AM +, Finucane, Stephen
On Mon, Nov 09, 2015 at 02:59:49PM +, Finucane, Stephen wrote:
> > On Mon, Nov 09, 2015 at 02:37:54AM +, Finucane, Stephen wrote:
> > > > i == count cannot happen in the loop as i will vary from 0 to count -
> > 1.
> > > >
> > > > Signed-off-by: Damien Lespiau
> > > > ---
> > > > patchwor
On Mon, Nov 09, 2015 at 02:53:36PM +, Finucane, Stephen wrote:
> Ah, I get the point - I just misinterpreted the line ending character
> (it's a '\r', but I instinctively saw a '\n'). How about this?
>
> self.stdout.write('%06d/%06d\r' % (i, count), ending='')
>
> or this, if you prefer:
On Mon, Nov 09, 2015 at 03:20:39PM +, Finucane, Stephen wrote:
> > That wouldn't work either. On the last iteration (count - 1)/count would
> > be printed and count/count would never be printed.
>
> Right you are. What on earth was that code doing there at all? :)
Actually, because i goes fro
> On Mon, Nov 09, 2015 at 02:59:49PM +, Finucane, Stephen wrote:
> > > On Mon, Nov 09, 2015 at 02:37:54AM +, Finucane, Stephen wrote:
> > > > > i == count cannot happen in the loop as i will vary from 0 to count
> -
> > > 1.
> > > > >
> > > > > Signed-off-by: Damien Lespiau
> > > > > ---
>
> On Mon, Nov 09, 2015 at 03:20:39PM +, Finucane, Stephen wrote:
> > > That wouldn't work either. On the last iteration (count - 1)/count
> would
> > > be printed and count/count would never be printed.
> >
> > Right you are. What on earth was that code doing there at all? :)
>
> Actually, bec
> On Mon, Nov 09, 2015 at 02:53:36PM +, Finucane, Stephen wrote:
> > Ah, I get the point - I just misinterpreted the line ending character
> > (it's a '\r', but I instinctively saw a '\n'). How about this?
> >
> > self.stdout.write('%06d/%06d\r' % (i, count), ending='')
> >
> > or this, if
On Mon, Nov 09, 2015 at 03:30:22PM +, Finucane, Stephen wrote:
> > On Mon, Nov 09, 2015 at 03:20:39PM +, Finucane, Stephen wrote:
> > > > That wouldn't work either. On the last iteration (count - 1)/count
> > would
> > > > be printed and count/count would never be printed.
> > >
> > > Right
On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote:
> PS: Since we're talking, if you have time to address the remaining comments
> on the 'series' series it would be appreciated. I don't want to just do the
> rework without you input in case I miss something. It's one of three block
On Mon, Nov 09, 2015 at 03:39:09PM +, Finucane, Stephen wrote:
> > On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote:
> > > PS: Since we're talking, if you have time to address the remaining
> > comments
> > > on the 'series' series it would be appreciated. I don't want to just
> On Mon, Nov 09, 2015 at 03:39:09PM +, Finucane, Stephen wrote:
> > > On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote:
> > > > PS: Since we're talking, if you have time to address the remaining
> > > comments
> > > > on the 'series' series it would be appreciated. I don't wan
> On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote:
> > PS: Since we're talking, if you have time to address the remaining
> comments
> > on the 'series' series it would be appreciated. I don't want to just do
> the
> > rework without you input in case I miss something. It's one of
On Fri, Nov 06, 2015 at 07:02:31PM +0100, Johannes Berg wrote:
> +Konstantin, the kernel.org sysadmin. The context is that patchwork has
> just removed (see subject) support for Django 1.6, but I've been told
> that RHEL/EPEL7 which you run has only that version, so updating to the
> latest patchwo
Hi Don,
Em Mon, 09 Nov 2015 11:22:50 -0500
Don Zickus escreveu:
> On Fri, Nov 06, 2015 at 07:02:31PM +0100, Johannes Berg wrote:
> > +Konstantin, the kernel.org sysadmin. The context is that patchwork has
> > just removed (see subject) support for Django 1.6, but I've been told
> > that RHEL/EPE
> Hi Don,
>
> Em Mon, 09 Nov 2015 11:22:50 -0500
> Don Zickus escreveu:
>
> > On Fri, Nov 06, 2015 at 07:02:31PM +0100, Johannes Berg wrote:
> > > +Konstantin, the kernel.org sysadmin. The context is that patchwork has
> > > just removed (see subject) support for Django 1.6, but I've been told
>
> Hi,
>
> Just to throw another datapoint at folks. RHEL-7 has this notion of
> software collections. It allows customers to update a collection tools to
> a
> newer version (RH supported) in the /opt area. Then using a script (which
> sets env variables), a program can easily use python3 and p
On Mon, Nov 09, 2015 at 05:20:00PM +, Finucane, Stephen wrote:
> > Hi,
> >
> > Just to throw another datapoint at folks. RHEL-7 has this notion of
> > software collections. It allows customers to update a collection tools to
> > a
> > newer version (RH supported) in the /opt area. Then usin
> On Mon, Nov 09, 2015 at 05:20:00PM +, Finucane, Stephen wrote:
> > > Hi,
> > >
> > > Just to throw another datapoint at folks. RHEL-7 has this notion of
> > > software collections. It allows customers to update a collection tools
> to
> > > a
> > > newer version (RH supported) in the /opt a
On Mon, Nov 09, 2015 at 08:03:09PM +, Finucane, Stephen wrote:
> > > I notice Rails is listed as a package there. What's the possibility of
> > getting
> > > Django added? Nigh-on non-existent? To say Django is widespread would be
> > an
> > > understatement. I'd envision quite a few users for
22 matches
Mail list logo
