Re: [PATCH 1/2] wsgi: Move wsgi file to expected location

2016-03-31 Thread Damien Lespiau
On Fri, Feb 05, 2016 at 05:35:37PM +, Stephen Finucane wrote: > Django places a wsgi.py file in the root of each application's > directory. Do this, adding a symlink to preserve existing > operation for users. Even if the commit message mentions a symlink, there isn't one in the commit?

Re: [PATCH 2/2] xmlrpc: Treat negative max_count as meaning "return last N results"

2016-03-31 Thread Damien Lespiau
On Fri, Feb 05, 2016 at 05:21:20PM +, Stephen Finucane wrote: > @@ -602,6 +607,8 @@ def patch_list(filt=None): > > if max_count > 0: > return list(map(patch_to_dict, patches[:max_count])) > +elif max_count < 0: > +return list(map(patch_to_dict,

Re: getting meta-data out of patchwork

2016-03-23 Thread Damien Lespiau
On Wed, Mar 23, 2016 at 09:01:43AM -0500, Andy Doan wrote: > On 03/22/2016 10:41 PM, Jeremy Kerr wrote: > >Hi Stephen, > > > >>Is there anyway to get statistics out of patchwork about how long > >>patches sit around, reject/accept rates, and patch sizes? > > > >There's no exposed interface for

News from the freedesktop.org patchwork I

2016-02-19 Thread Damien Lespiau
Hi all, I've written about the current state of the patchwork deployed on freedesktop.org. This might be of some interest to some of you to understand where that branch is going: http://damien.lespiau.name/2016/02/augmenting-mailing-lists-with-patchwork.html In particular, the testing part

Re: Patch tagging/classification

2016-02-08 Thread Damien Lespiau
On Mon, Feb 08, 2016 at 04:39:15PM +0200, Ruslan Kuprieiev wrote: > Hi Damien, > > That looks great! > Is it a pure pwclient you are using? This is a different version of patchwork that I maintain for our own use (I'm part of the i915 kernel team at Intel). That version is deployed on

Re: Patch tagging/classification

2016-02-08 Thread Damien Lespiau
On Mon, Feb 08, 2016 at 03:28:26PM +0200, Ruslan Kuprieiev wrote: > Hi All, > > Btw, is patchwork able to group several patches from one patchset? > I.e. typical git-send-email structure: > [PATCH 00/03] intro > |-[PATCH 01/03] first > |-[PATCH 02/03] second > |-[PATCH 03/03] third >

Re: Patch tagging/classification

2016-02-08 Thread Damien Lespiau
On Mon, Feb 08, 2016 at 08:08:58PM +0200, Ruslan Kuprieiev wrote: > >As mentioned before, Freedesktop's patchwork has a somewhat strong > >opinion on distribution dependencies. It favours deploying patchwork in > >an isolated, sateless, WM/container (or at least in a virtualenv) with a > >tight

Re: Patch tagging/classification

2016-02-08 Thread Damien Lespiau
On Mon, Feb 08, 2016 at 04:18:53PM +0100, Thomas Petazzoni wrote: > I think it's not a big deal if patchwork sometimes doesn't recognize a > new version of a series as being a new version, and leaves it to the > project admins to mark the old version of the series as superseded > manually. > >

Re: Patch tagging/classification

2016-02-08 Thread Damien Lespiau
On Mon, Feb 08, 2016 at 05:19:37PM +0200, Ruslan Kuprieiev wrote: > It looks fantastic, and it is exactly what I've been looking for for a long > time now. > Why aren't these features merged into base patchwork yet? I wanted to make some fairly big design decisions that didn't resonate well with

Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-10 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 03:39:09PM +, Finucane, Stephen wrote: > > On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote: > > > PS: Since we're talking, if you have time to address the remaining > > comments > > > on the 'series' series it would be appreciated. I don't want to just

Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote: > PS: Since we're talking, if you have time to address the remaining comments > on the 'series' series it would be appreciated. I don't want to just do the > rework without you input in case I miss something. It's one of three

Re: [PATCH 2/2] retag: Properly display the final count

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 03:30:22PM +, Finucane, Stephen wrote: > > On Mon, Nov 09, 2015 at 03:20:39PM +, Finucane, Stephen wrote: > > > > That wouldn't work either. On the last iteration (count - 1)/count > > would > > > > be printed and count/count would never be printed. > > > > > >

Re: [PATCH 2/2] retag: Properly display the final count

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 02:59:49PM +, Finucane, Stephen wrote: > > On Mon, Nov 09, 2015 at 02:37:54AM +, Finucane, Stephen wrote: > > > > i == count cannot happen in the loop as i will vary from 0 to count - > > 1. > > > > > > > > Signed-

Re: [PATCH 2/2] retag: Properly display the final count

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 03:20:39PM +, Finucane, Stephen wrote: > > That wouldn't work either. On the last iteration (count - 1)/count would > > be printed and count/count would never be printed. > > Right you are. What on earth was that code doing there at all? :) Actually, because i goes

Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 03:39:09PM +, Finucane, Stephen wrote: > > On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote: > > > PS: Since we're talking, if you have time to address the remaining > > comments > > > on the 'series' series it would be appreciated. I don't want to just

Re: [PATCH 2/2] retag: Properly display the final count

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 02:37:54AM +, Finucane, Stephen wrote: > > i == count cannot happen in the loop as i will vary from 0 to count - 1. > > > > Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> > > --- > > patchwork/management/commands/ret

Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 02:29:57AM +, Finucane, Stephen wrote: > > @@ -38,6 +39,6 @@ class Command(BaseCommand): > > for i, patch in enumerate(query.iterator()): > > patch.refresh_tag_counts() > > if (i % 10) == 0 or i == count: > > -

[PATCH 2/2] retag: Properly display the final count

2015-11-07 Thread Damien Lespiau
i == count cannot happen in the loop as i will vary from 0 to count - 1. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/management/commands/retag.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/patchwork/management/commands/retag.py b/pat

Re: [PATCH v2 0/4] Remove support for Django 1.6

2015-11-06 Thread Damien Lespiau
On Fri, Nov 06, 2015 at 01:04:10PM +0100, Johannes Berg wrote: > Hi, > > > A possible solution: [...] > > I'm not involved in the maintenance of kernel.org, so I can't really > say. However, in the past we've been told that they can only upgrade > patchwork if the django requirement can be

Re: Patchwork instance for SNPS ARC Linux

2015-11-02 Thread Damien Lespiau
On Mon, Nov 02, 2015 at 10:05:47AM +, Alexey Brodkin wrote: > Hello, Hi, > I'm wondering if there's a chance to get a patchwork project instance > for SNPS ARC Linux mailing list > (http://lists.infradead.org/pipermail/linux-snps-arc/) > on http://patchwork.ozlabs.org/? I can't help you

[PATCH 0/2] Atomicity & parsemail.sh

2015-10-20 Thread Damien Lespiau
Damien Lespiau (2): lock: Import file lock class from mercurial parsemail: Make parsing an email atomic operation patchwork/bin/parsemail.py | 20 +++ patchwork/lock.py| 301 +++ patchwork/tests/test_lock.py | 290

[PATCH 1/2] lock: Import file lock class from mercurial

2015-10-20 Thread Damien Lespiau
With series now in production, I realized I needed the mail parsing to be atomic. Because of the race can happen between mutiple process a file lock seems like it could work. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/lock.py

[PATCH 13/14] series: New series with similar titles as previous ones are new revisions

2015-10-20 Thread Damien Lespiau
v3: Rebase on top of the SERIES_DEFAULT_NAME change Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/bin/parsemail.py | 46 +- patchwork/tests/test_series.py | 73 +- 2 files changed, 117 insertions

[PATCH 12/14] series: Add a signal to notify when a revision is complete

2015-10-20 Thread Damien Lespiau
To decouple some high level and rather complex parsing code from the models, let's add a signal when a SeriesRevision is complete. One can use that signal to hook some logic there, for instance from the mail parsing code. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: S

[PATCH 02/14] parsemail: Make find_content() return a MailContent object

2015-10-20 Thread Damien Lespiau
Returning tuples is not super scalable. I now want to return a Series object along with a patch or a comment. So let's put the return values into a class, used as a typed dictionary really. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <step

[PATCH 01/14] parsemail: Return the list of prefixes when cleaning up the subject

2015-10-20 Thread Damien Lespiau
The patch is a preparation step towards understanding series. It will be handy to parse those prefixes, looking for 'x/n' to retrieve the order of a patch in a series. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --

[PATCH 03/14] parsemail: Add a function to parse series markers eg. "1/12"

2015-10-20 Thread Damien Lespiau
This can be used to identify cover letters, patches part of series, length of series, ... Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- patchwork/bin/parsemail.py | 12 pat

[PATCH 04/14] parsemail: Extract building the list of mail references

2015-10-20 Thread Damien Lespiau
We'll need to figure out whether the mail we are parsing is the root of the thread to automatically build series, and we'll need the list of references for that. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- p

[PATCH 4/7] api: Add a basic REST API to access Series/Revisions and Patches

2015-10-20 Thread Damien Lespiau
v2: Merge commits introducing basic objects v3: Introduce the SeriesListMixin class v4: Add the expand get parameter v5: Introduce /api/1.0/ metadata entry point Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- docs/api.rst

[PATCH 5/7] models: Add Event and EventLog models

2015-10-20 Thread Damien Lespiau
overkill. I have to mind to attach more properties to events. For instance link a state to an event so we can generically set the state of a series/patch when a certain event is created. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/migrations/0005_event_eventlog.p

[PATCH 2/7] models: Monkey patch User to have a name() method

2015-10-20 Thread Damien Lespiau
The name is really a poperty of the User. Not always having to retrieve the profile for that makes things simpler. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/models.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/patchwork/models.py b/patchwork/mod

[PATCH 7/7] api: Expose events

2015-10-20 Thread Damien Lespiau
so a bot can retrieve its patches and test them. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- docs/api.rst | 51 patchwork/serializers.py | 8 +++- patchwork/urls.py| 5 + patchwork/views/api.py

[PATCH 6/7] series: Add a 'new-series-revision' event

2015-10-20 Thread Damien Lespiau
in the SeriesLog table. v2: Rebase on top of SERIES_DEFAULT_NAME changes Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/fixtures/default_events.xml | 6 + patchwork/models.py | 8 ++ patchwork/tests/test_bundles.py | 2 +- patchwork

Re: [PATCH 00/15] Series models & parsing (v2)

2015-10-20 Thread Damien Lespiau
On Sat, Oct 10, 2015 at 12:21:28AM +0100, Finucane, Stephen wrote: > I've replied to all the patches available bar one (which I want to > investigate a little further). However, I'm missing two patches. Can > you submit these separately or resend the series (ideally after > addressing comments)?

[PATCH 10/14] tests: Add a utility class to create Series

2015-10-20 Thread Damien Lespiau
a TestSeries classes that can create a series with n patches with or without a cover letter. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- patchwork/tests/test_series.py | 51 - patchwork/te

[PATCH 07/14] series: Create Series objects when parsing mails

2015-10-20 Thread Damien Lespiau
at a later point. Single patches are treated as a Series of 1 patch, named with the subject of that patch. v2: SERIES_DEFAULT_NAME change Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- patchwork

[PATCH 09/14] tests: Save the test project if we're going to use it

2015-10-20 Thread Damien Lespiau
create_email() can use the default project for its mail. If that is the case, chances are we are going to use that email later in a test where we'll want that project to exist. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@

[PATCH 3/7] models: Don't return the email along with the name in Person's __unicode__

2015-10-20 Thread Damien Lespiau
If we have a person name, that's enough to identify her/him. We don't need to add ones email address there. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/models.py b/pat

[PATCH 1/7] models: Split a user_name() helper out of UserProfile

2015-10-20 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/models.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/patchwork/models.py b/patchwork/models.py index 6660cad..a1d6840 100644 --- a/patchwork/models.py +++ b/patchwork/models.py @@

Re: [PULL] github.com/stephenfin/development

2015-10-19 Thread Damien Lespiau
On Fri, Oct 16, 2015 at 07:08:45PM +0100, Finucane, Stephen wrote: > # 1) Add additional project configuration options: > > We should add the following options to the 'Project' model > > * Add an optional list property to specify the tests contexts that > have to run in order for a patch to be

Re: [PULL] github.com/stephenfin/development

2015-10-16 Thread Damien Lespiau
On Thu, Oct 15, 2015 at 11:46:30PM +, Finucane, Stephen wrote: > Hey, > > First pull request (request-pull style, that is). Hope I've done > everything correctly :S This PR includes two fixes and the code enable > the check API. It's got positive reviews first time round and I > haven't heard

Re: missing patches

2015-10-16 Thread Damien Lespiau
Hi, On Mon, Oct 12, 2015 at 01:54:24PM -0700, Brian Norris wrote: > Occasionally, I'll run across patches from the linux-mtd mailing list > that never show up on the ozlabs.org Patchwork instance. I don't > really have much visibility into this problem, so I wanted to reach > out here. > > For

Re: [PULL] github.com/stephenfin/development

2015-10-16 Thread Damien Lespiau
On Fri, Oct 16, 2015 at 04:11:50PM +0100, Finucane, Stephen wrote: > You appear to be insisting there should be a more static configuration > of "runnable tests". However, I don't think this would scale or allow > the fluidity of Thomas' proposal. I'm insisting it's *possible* to have a list of

[PATCH 0/3] A few details fixed in my peregrinations

2015-10-09 Thread Damien Lespiau
Nothing too exiting here, but good to have fixed. -- Damien Damien Lespiau (3): gitignore: Only ignore quilt files at the root of the repository gitignore: Explicitely ignore sub-directories in lib/packages tests: Fix a typo in the MboxPassThroughHeaderTest description .gitignore

[PATCH 1/3] gitignore: Only ignore quilt files at the root of the repository

2015-10-09 Thread Damien Lespiau
So, say, a 'series' directory in the project (added in a later patch) doesn't get ignored. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- .gitignore | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 52707be..94481ad

[PATCH 3/3] tests: Fix a typo in the MboxPassThroughHeaderTest description

2015-10-09 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/tests/test_mboxviews.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/tests/test_mboxviews.py b/patchwork/tests/test_mboxviews.py index 02d04cb..fbea322 100644 --- a/patchwork

[PATCH] parsemail: Don't catch exceptions when saving patches and comments

2015-10-09 Thread Damien Lespiau
We'd like to know when those operations fail in production so we can at least inspect what happened through the email send to settings.ADMINS in main(). Catching those exceptions early prevents that. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/bin/parsemail.p

[PATCH] wsgi.conf: Fix the path in the Directory directive

2015-10-09 Thread Damien Lespiau
The path in didn't match the one defined in Alias. While at it, remove the unnecessary quotes. Reported-by: Michael Wood <michael.g.w...@intel.com> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- lib/apache2/patchwork.wsgi.conf | 6 +++--- 1 file changed, 3 inse

[PATCH 03/15] parsemail: Add a function to parse series markers eg. "1/12"

2015-10-09 Thread Damien Lespiau
This can be used to identify cover letters, patches part of series, length of series, ... Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/bin/parsemail.py | 12 patchwork/tests/test_patchparser.py | 9 - 2 files changed, 20 insertions

[PATCH 05/15] tests: Make sure all emails have a valid msgid

2015-10-09 Thread Damien Lespiau
Messages ids will be used by the Series code as the way to uniquely identify series. We must ensure every single email that goes through the parser has a valid msgid to not fail once we parse series. v2: Rebase on top upstream Signed-off-by: Damien Lespiau <damien.lesp...@intel.

[PATCH 00/15] Series models & parsing (v2)

2015-10-09 Thread Damien Lespiau
r instance, resending a full v2 series as a reply of the v1 cover letter doesn't work and, while I have seen that occurence happen on intel-gfx, it's usually new contributors that don't quite know how we'd like v2 of series to be sent (because it's not really well clear/documented). -- Dami

[PATCH 01/15] parsemail: Return the list of prefixes when cleaning up the subject

2015-10-09 Thread Damien Lespiau
The patch is a preparation step towards understanding series. It will be handy to parse those prefixes, looking for 'x/n' to retrieve the order of a patch in a series. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/bin/parsemail.py | 6 +++--- patchwork

[PATCH 07/15] series: Provide the migration step to add series

2015-10-09 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/migrations/0003_series.py | 73 + 1 file changed, 73 insertions(+) create mode 100644 patchwork/migrations/0003_series.py diff --git a/patchwork/migrations/0003_series.py b/pat

[PATCH 02/15] parsemail: Make find_content() return a MailContent object

2015-10-09 Thread Damien Lespiau
Returning tuples is not super scalable. I now want to return a Series object along with a patch or a comment. So let's put the return values into a class, used as a typed dictionary really. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/bin/parsemail.py

[PATCH 06/15] series: Add a Series model

2015-10-09 Thread Damien Lespiau
v2: Add 'order' metadata to revisions as they do have a natural ordering. v3: Add a couple of utility functions to Series and SeriesRevision v4: Provide a get_absolute_url() method on Series v5: Add a dump() method to series, handy for debugging Signed-off-by: Damien Lespiau <damien.l

[PATCH 15/15] docs: Add a user-oriented explanation of series parsing

2015-10-09 Thread Damien Lespiau
It's really necessary to start documenting what Patchwork knows about when parsing emails. This time, it's about series and new revision of series. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- docs/index.rst | 1 + docs/manual.rst

[PATCH 04/15] parsemail: Extract building the list of mail references

2015-10-09 Thread Damien Lespiau
We'll need to figure out whether the mail we are parsing is the root of the thread to automatically build series, and we'll need the list of references for that. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/bin/parsemail.py | 33 +++--

[PATCH 13/15] series: Add a signal to notify when a revision is complete

2015-10-09 Thread Damien Lespiau
To decouple some high level and rather complex parsing code from the models, let's add a signal when a SeriesRevision is complete. One can use that signal to hook some logic there, for instance from the mail parsing code. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- pat

[PATCH 08/15] series: Create Series objects when parsing mails

2015-10-09 Thread Damien Lespiau
at a later point. Single patches are treated as a Series of 1 patch, named with the subject of that patch. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/bin/parsemail.py | 86 +++--- 1 file changed, 81 insertions(+), 5 deletion

[PATCH 1/2] tests: Factor out a MailFromPatchTest base class

2015-10-09 Thread Damien Lespiau
We're going to write a test that needs to craft a mail and InitialPatchStateTest was already doing what we wanted. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/tests/test_patchparser.py | 31 ++- 1 file changed, 18 insertions(+), 13 del

[PATCH 2/2] project: Provide a setting to only consider git send-email patches

2015-10-09 Thread Damien Lespiau
. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/bin/parsemail.py | 5 ++- .../migrations/0004_project_git_send_email_only.py | 19 +++ patchwork/models.py| 1 + patchwork/tests/test_patchpar

[PATCH 0/2] Only consider git send-email mails as potential patches

2015-10-09 Thread Damien Lespiau
I have quite a few false positives of patches: patchwork considering mails with diffs as patches, but are really people suggesting something. To avoid those false positive, let's introduce a per-project option to only consider git send-email patches. -- Damien Damien Lespiau (2): tests

[PATCH 4/4] docs: Remove incorrect command

2015-10-04 Thread Damien Lespiau
That one doesn't make sense and shouldn't be there. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- docs/development.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/development.rst b/docs/development.rst index e81f0fd..8bcd2e3 100644 --- a/docs/development.rst +++

[PATCH 0/4] A few more documentation fixes

2015-10-04 Thread Damien Lespiau
A few assorted fixes, on top of: https://lists.ozlabs.org/pipermail/patchwork/2015-October/001730.html -- Damien Damien Lespiau (4): docs: Remove duplicated 'the' docs: Fix a missing 3rd person 's' docs: Fix a few code blocks docs: Remove incorrect command docs/development.rst | 20

[PATCH 3/4] docs: Fix a few code blocks

2015-10-04 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- docs/development.rst | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/docs/development.rst b/docs/development.rst index 7472b50..e81f0fd 100644 --- a/docs/development.rst +++ b/docs/developme

[PATCH 2/4] docs: Fix a missing 3rd person 's'

2015-10-04 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- docs/development.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/development.rst b/docs/development.rst index 8ecab06..7472b50 100644 --- a/docs/development.rst +++ b/docs/development.rst @@ -107,7

[PATCH 1/4] docs: Remove duplicated 'the'

2015-10-04 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- docs/development.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/development.rst b/docs/development.rst index a3184fe..8ecab06 100644 --- a/docs/development.rst +++ b/docs/development.rst @@ -63,7

[PATCH v2 40/51] patch: Put the download links next to the "Patch" header

2015-10-02 Thread Damien Lespiau
From: Belén Barros Peña <belen.barros.p...@intel.com> v2: Fix 'dowload' typo x 2 (Bryce Harrington) Signed-off-by: Belén Barros Peña <belen.barros.p...@intel.com> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel

[PULL] github.com/dlespiau/patchwork for-upstream

2015-10-02 Thread Damien Lespiau
ages shown paginator: Redesign the paginator patch: Put the download links next to the "Patch" header patch: Move the submitter and date out of the details Damien Lespiau (48): htdocs: Add bootstrap template: Add bootstrap to the base template list:

Re: [PULL] github.com/dlespiau/patchwork for-upstream

2015-10-02 Thread Damien Lespiau
On Thu, Oct 01, 2015 at 04:01:21PM +0100, Damien Lespiau wrote: > Hi Jeremy, > > WARNING! Not every patch in the pull request has a r-b or a-b tag, most > have though. More on that below. > > This pull requests has 3 main topics: > > - The re-design that has been float

[PATCH 34/49] style: Make the submission tables use #0A0A47

2015-10-01 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- htdocs/css/style.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index d4e9e81..10ecd3d 100644

[PATCH 35/49] patch: Remove the permalink item

2015-10-01 Thread Damien Lespiau
One just has to copy the URL, no real need to duplicate that fact. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- patchwork/templates/patchwork/patch.html | 4 1 file changed, 4 deletions(-) diff --git

[PATCH 30/49] paginator: Tweak the number of pages shown

2015-10-01 Thread Damien Lespiau
From: Belén Barros Peña <belen.barros.p...@intel.com> We don't really need that many pages displayed in the pagination, tweak the numbers down a bit. Signed-off-by: Belén Barros Peña <belen.barros.p...@intel.com> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by

[PATCH 31/49] paginator: Redesign the paginator

2015-10-01 Thread Damien Lespiau
From: Belén Barros Peña <belen.barros.p...@intel.com> A few things: - Use the … glyph - Remove the box around the page numbers - Slight restyling Signed-off-by: Belén Barros Peña <belen.barros.p...@intel.com> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com>

[PATCH 29/49] base: Use a Bootstrap badge for the number of todo items

2015-10-01 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- templates/base.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/templates/base.html b/templates/base.html index 299b0a1..e5dfee8 100644 ---

[PATCH 43/49] base: Don't put the logout button in the is_staff block

2015-10-01 Thread Damien Lespiau
Regular users didn't have their logout/profile drop down! Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- templates/base.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/base.html

[PATCH 48/49] filters: Fix submitter display when we only have an email address

2015-10-01 Thread Damien Lespiau
I'm fairly sure I fixed that already, but here we go again. It's totally valid to only have an email address for the submitter, so handle that case properly. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- patchwo

[PATCH 38/49] patch: Override Bootstrap's styling

2015-10-01 Thread Damien Lespiau
To look more like what patchwork was using. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- htdocs/css/style.css | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/htdocs/css/style.css

[PATCH 36/49] patch: Single out the commit message

2015-10-01 Thread Damien Lespiau
) Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/models.py | 11 +++ patchwork/templates/patchwork/patch.html | 19 --- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/patchwork/models.py b/patchwork/models.py

[PATCH 39/49] patch: Pull the download links next to the "Patch" header

2015-10-01 Thread Damien Lespiau
From: Belén Barros Peña <belen.barros.p...@intel.com> Signed-off-by: Belén Barros Peña <belen.barros.p...@intel.com> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- htdocs/css/style.css

[PATCH 40/49] patch: Redesign slightly the comment headers

2015-10-01 Thread Damien Lespiau
From: Belén Barros Pena <belen.barros.p...@intel.com> Signed-off-by: Belén Barros Pena <belen.barros.p...@intel.com> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- htdocs/css/style.css

[PATCH 33/49] boxes: Style boxes like the patch form

2015-10-01 Thread Damien Lespiau
Here again, a pass may be needed in the future, but for now, make things consistent. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- htdocs/css/style.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 41/49] patch: Move the submitter and date out of the details

2015-10-01 Thread Damien Lespiau
From: Belén Barros Peña <belen.barros.p...@intel.com> Trying to reduce the number of read-only fields in details. Signed-off-by: Belén Barros Peña <belen.barros.p...@intel.com> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/templates/patchwo

[PATCH 47/49] filters: Submit the form when is pressed on a closed submitter field

2015-10-01 Thread Damien Lespiau
a second time (ie. when the autocompletion option has be selected and the dropdown isn't shown), we submit the form. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/templates/patchwork/filters.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 46/49] filter: Tweak the autocompletion behaviour on

2015-10-01 Thread Damien Lespiau
for input strings that have fewer than 4 characters, the autocompletion query only triggers after that. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- patchwork/templates/patchwork/filters.html | 23 +

[PATCH 37/49] patch: Pull the patch between the commit message and comments

2015-10-01 Thread Damien Lespiau
This follows a logical flow, commit message, patch then comments. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/templates/patchwork/patch.html | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/patchwork/templates/pat

[PULL] github.com/dlespiau/patchwork for-upstream

2015-10-01 Thread Damien Lespiau
Hi Jeremy, WARNING! Not every patch in the pull request has a r-b or a-b tag, most have though. More on that below. This pull requests has 3 main topics: - The re-design that has been floating around for some time now. One can evaluate the state of the re-design on the freedesktop.org

Re: [PATCH v2 01/10] models: Resolve issues with Patch.state

2015-10-01 Thread Damien Lespiau
On Thu, Oct 01, 2015 at 03:52:25PM +0100, Stephen Finucane wrote: > @@ -243,7 +243,7 @@ class Patch(models.Model): > date = models.DateTimeField(default=datetime.datetime.now) > submitter = models.ForeignKey(Person) > delegate = models.ForeignKey(User, blank = True, null = True) > -

Re: [PATCH v2 01/10] models: Resolve issues with Patch.state

2015-10-01 Thread Damien Lespiau
None. Note that > this will never be set to a null value however due to the additions to > the 'save' function. I guess it's a bit weird to weaken the db schema for the testing use case but it's doesn't really matter much to me. By the way t

[PATCH 04/49] sytle.css: Remove the body selector, letting bootstrap's shine through

2015-10-01 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- htdocs/css/style.css | 8 1 file changed, 8 deletions(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index e5bbc75..c166374 100644 --- a/htdocs/c

[PATCH 02/49] template: Add bootstrap to the base template

2015-10-01 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- templates/base.html | 9 + 1 file changed, 9 insertions(+) diff --git a/templates/base.html b/templates/base.html index 72dab34..0a2ced3 100644 --- a/templat

[PATCH 16/49] filters: Use the glyphicons for add/remove signs

2015-10-01 Thread Damien Lespiau
They give a much better contrast the the one already there. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- htdocs/css/style.css | 5 + htdocs/images/16-circle-blue-add.png | Bin 47

[PATCH 13/49] html: Turn the navbar into a breadcrumb bar

2015-10-01 Thread Damien Lespiau
All projects -> $project patches both being links, so we can return to the list of patches from any page where the project is defined. The '$project patches' link becomes insensitive in the list page. Finally the patch page adds the patch at the end. Signed-off-by: Damien Lespiau <damien.lesp...@int

[PATCH 15/49] style.css: Rename the breadcrumb selectors

2015-10-01 Thread Damien Lespiau
Bootstrap called what was the header bar "navigation". Let's rename the nav* selector with 'breadcrumb' so there's no confusion with bootstrap's nagivation elements and selectors. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen

[PATCH 19/49] filters: Fix a typo in comment

2015-10-01 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- patchwork/filters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/filters.py b/patchwork/filters.py index 8c9690e..205be29 100644 ---

[PATCH 18/49] filters: Use a more visible and human-friendly phrasing for 'filters'

2015-10-01 Thread Damien Lespiau
From: Belén Barros Peña <belen.barros.p...@intel.com> v2: Change commit message Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/templates/patchwork/filters.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/patchwork/templat

[PATCH 20/49] filters: Redesign the filters form with the help of bootstrap

2015-10-01 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- htdocs/css/style.css | 18 +-- patchwork/filters.py | 16 +++-- patchwork/templates/patchwork/filte

[PATCH 23/49] filters: Rewrite the submitter autocompletion code

2015-10-01 Thread Damien Lespiau
kend logic that allows the "free form" mechanism, but maybe we should. v2: Squash the unit tests fixes into this patch (Jeremy Kerr) Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- patchwork/filters.py | 16 ++- patchwork/templates/pa

[PATCH 25/49] package: Add the Sticky Table Header jQuery plugin

2015-10-01 Thread Damien Lespiau
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- htdocs/js/jquery.stickytableheaders.min.js | 1 + lib/packages/jquery/README | 19 ++- lib/pac

[PATCH 26/49] patch-list: Make the table header sticky

2015-10-01 Thread Damien Lespiau
So, when scrolling down the list of patches, we still get what are the field displayed. This is espacially important as I plan to add a few more. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> Acked-by: Stephen Finucane <stephen.finuc...@intel.com> --- htdocs/c

  1   2   3   >