This fixes all but the ones about too many variables/statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 76 +--
1 file changed, 58 insertions(+), 18 deletions(-)
Applied to u-boot-dm, thanks
One test still uses its own function for capturing output. Modify it to
use the standard one in test_util
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
Applied to u-boot-dm, thanks
in a later patch.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/README | 15 +++
tools/patman/func_test.py | 1 +
tools/patman/series.py| 2 +-
3 files changed, 17 insertions(+), 1 deletion(-)
Applied to u-boot-dm, thanks
.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 4 +++-
tools/patman/series.py | 6 +-
2 files changed, 8 insertions(+), 2 deletions(-)
Applied to u-boot-dm, thanks!
___
Patchwork mailing list
Patchwork
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/control.py | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
Applied to u-boot-dm, thanks!
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.or
Add tests that check that warnings are generated when expected.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 111 +---
tools/patman/main.py| 16 +-
tools/patman/patchstream.py | 2 +-
3 files changed, 116
The current instructions are out-of-date. Fix them.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/README | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
Applied to u-boot-dm, thanks!
___
Patchwork mailing list
Tested-by: Lord Edmund Blackaddër
Reviewed-by: Fred Bloggs
+ Reviewed-by: Mary Bloggs
1 new response available in patchwork
The '+' indicates a new tag. Colours are used to make it easier to read.
Signed-off-by: Simon Glass
---
Changes in v3:
- Rename GetMetaData
These lines can indicate a continuation of an error and should not be
ignored. Fix this.
Fixes: 666eb15e923 ("patman: Handle checkpatch output with notes and code")
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/checkpatch.py | 7 +--
1 file changed, 5 insert
These constants should use upper case. Update them to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 44 ++---
1 file changed, 22 insertions(+), 22 deletions(-)
Applied to u-boot-dm, thanks
Update the indenting to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
Applied to u-boot-dm, thanks
Rename these functions to lower case as per PEP8.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 6 +--
tools/patman/control.py | 6 +--
tools/patman/func_test.py | 6 +--
tools/patman/patchstream.py | 88
Drop a few arguments that are not used in functions.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
Applied to u-boot-dm, thanks!
___
Patchwork mailing
Some variables are too short or shadow other variables or types. Fix these
to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 52 ++---
1 file changed, 26 insertions(+), 26 deletions(-)
Applied to u-boot
for the same commit.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/commit.py | 2 ++
tools/patman/patchstream.py | 15 +++
2 files changed, 13 insertions(+), 4 deletions(-)
Applied to u-boot-dm, thanks!
___
Patchwork
Add missing documentation and type information. Fix up some missing docs
on exceptions also.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 82 ++---
1 file changed, 50 insertions(+), 32 deletions(-)
Applied to u-boot-dm
This is not used. Drop it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 1 +
tools/patman/patchstream.py | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
Applied to u-boot-dm, thanks!
___
Patchwork mailing
Add a new function in PatchStream to collect the warnings generated while
parsing the stream. This will allow us to adjust the logic, such as
dealing with per-commit warnings.
Two of the warnings are in fact internal errors, so change them to raise
and exception.
Signed-off-by: Simon Glass
On balance it is easier to use an iterator here, particularly if we need
to insert lines due to new functionality. The only niggle is the need to
keep the previous iterator value around in one case.
Convert this test to use iter().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools
The current functional tests run most of patman. Add a smaller test that
just checks tag handling with the PatchStream class.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 26 +-
tools/patman/patchstream.py | 23
Tidy up the extra 's' when there is only a single warning. Fix the empty
print statement also.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
Applied to u-boot-dm, thanks
Sometimes warnings are associated with a file and sometimes with the
patch as a whole. Update the regular expression to handle both cases,
even in emacs mode. Also add support for detecting new files.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/checkpatch.py | 11
At present if we fail to find the upstream then the error output is piped
to wc, resulting in bogus results. Avoid the pipe and check the output
directly.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 19 +++
tools/patman/gitutil.py | 10
Use the subject of the Commit object when printing it out.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/commit.py | 3 +++
1 file changed, 3 insertions(+)
Applied to u-boot-dm, thanks!
___
Patchwork mailing list
Patchwork
It is tedious to add review tags into the local branch and errors can
sometimes be made. Add an option to create a new branch with the review
tags obtained from patchwork.
Signed-off-by: Simon Glass
---
Changes in v3:
- Allow tags to be inserted in the middle of the commit message
tools
While reviewing feedback it is helpful to see the review comments on the
command line to check that each has been addressed. Add an option to
support that.
Update the workflow documentation to describe the new features.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2
and can produce multiple snippets,
one for each part of the code that attracts a comment.
Show the file and line-number info at the top of each snippet if
available.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 83
While reviewing feedback it is helpful to see the review comments on the
command line to check that each has been addressed. Add an option to
support that.
Update the workflow documentation to describe the new features.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2
It is tedious to add review tags into the local branch and errors can
sometimes be made. Add an option to create a new branch with the review
tags obtained from patchwork.
Signed-off-by: Simon Glass
---
Changes in v3:
- Allow tags to be inserted in the middle of the commit message
tools
and can produce multiple snippets,
one for each part of the code that attracts a comment.
Show the file and line-number info at the top of each snippet if
available.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 83
Tested-by: Lord Edmund Blackaddër
Reviewed-by: Fred Bloggs
+ Reviewed-by: Mary Bloggs
1 new response available in patchwork
The '+' indicates a new tag. Colours are used to make it easier to read.
Signed-off-by: Simon Glass
---
Changes in v3:
- Rename GetMetaData
Sometimes warnings are associated with a file and sometimes with the
patch as a whole. Update the regular expression to handle both cases,
even in emacs mode. Also add support for detecting new files.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/checkpatch.py | 11
At present if we fail to find the upstream then the error output is piped
to wc, resulting in bogus results. Avoid the pipe and check the output
directly.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 19 +++
tools/patman/gitutil.py | 10
Use the subject of the Commit object when printing it out.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/commit.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/patman/commit.py b/tools/patman/commit.py
index e49bf87dfc8..5bf2b940299 100644
--- a/tools
These lines can indicate a continuation of an error and should not be
ignored. Fix this.
Fixes: 666eb15e923 ("patman: Handle checkpatch output with notes and code")
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/checkpatch.py | 7 +--
1 file changed, 5 insert
Tidy up the extra 's' when there is only a single warning. Fix the empty
print statement also.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/patman/patchstream.py b/tools
.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 4 +++-
tools/patman/series.py | 6 +-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index 880d7ddc7f2..24040d43d62 100644
Add tests that check that warnings are generated when expected.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 111 +---
tools/patman/main.py| 16 +-
tools/patman/patchstream.py | 2 +-
3 files changed, 116
On balance it is easier to use an iterator here, particularly if we need
to insert lines due to new functionality. The only niggle is the need to
keep the previous iterator value around in one case.
Convert this test to use iter().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools
The current functional tests run most of patman. Add a smaller test that
just checks tag handling with the PatchStream class.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 26 +-
tools/patman/patchstream.py | 23
This is not used. Drop it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 1 +
tools/patman/patchstream.py | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/patman/func_test.py b/tools/patman/func_test.py
index bdeccafda0b
Add a new function in PatchStream to collect the warnings generated while
parsing the stream. This will allow us to adjust the logic, such as
dealing with per-commit warnings.
Two of the warnings are in fact internal errors, so change them to raise
and exception.
Signed-off-by: Simon Glass
Some variables are too short or shadow other variables or types. Fix these
to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 52 ++---
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/tools
Rename these functions to lower case as per PEP8.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 6 +--
tools/patman/control.py | 6 +--
tools/patman/func_test.py | 6 +--
tools/patman/patchstream.py | 88
Add missing documentation and type information. Fix up some missing docs
on exceptions also.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 82 ++---
1 file changed, 50 insertions(+), 32 deletions(-)
diff --git a/tools
Update the indenting to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index
These constants should use upper case. Update them to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 44 ++---
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/tools/patman/patchstream.py b
in a later patch.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/README | 15 +++
tools/patman/func_test.py | 1 +
tools/patman/series.py| 2 +-
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/tools/patman/README b/tools/patman/README
One test still uses its own function for capturing output. Modify it to
use the standard one in test_util
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/tools/patman
Fix up various indentation and other minor things to make pylint3 happier.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/tools/patman/func_test.py b
The current instructions are out-of-date. Fix them.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/README | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tools/patman/README b/tools/patman/README
index 52b2cf70bd0..7ede1068ee1 100644
--- a/tools
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/control.py | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tools/patman/control.py b/tools/patman/control.py
index 67e8f397efd..aea9df8c8d1 100644
--- a/tools/patman/control.py
+++ b/tools/patman/
Hi Sean,
On Sun, 25 Oct 2020 at 19:23, Sean Anderson wrote:
>
> On 10/25/20 9:04 PM, Simon Glass wrote:
> > At present it is possible to put sign-off tags before the change log. This
> > works but then it is hard for patman to add its own tags to a commit. Also
> > if th
While reviewing feedback it is helpful to see the review comments on the
command line to check that each has been addressed. Add an option to
support that.
Update the workflow documentation to describe the new features.
Signed-off-by: Simon Glass
---
Changes in v2:
- Many changes to the whole
and can produce multiple snippets,
one for each part of the code that attracts a comment.
Show the file and line-number info at the top of each snippet if
available.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 83
Tested-by: Lord Edmund Blackaddër
Reviewed-by: Fred Bloggs
+ Reviewed-by: Mary Bloggs
1 new response available in patchwork
The '+' indicates a new tag. Colours are used to make it easier to read.
Signed-off-by: Simon Glass
---
Changes in v2:
- Adjust the algorithm
It is tedious to add review tags into the local branch and errors can
sometimes be made. Add an option to create a new branch with the review
tags obtained from patchwork.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/README | 17 ++-
tools/patman/control.py
These lines can indicate a continuation of an error and should not be
ignored. Fix this.
Fixes: 666eb15e923 ("patman: Handle checkpatch output with notes and code")
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/checkpatch.py | 7 +--
1 file changed, 5 insert
Sometimes warnings are associated with a file and sometimes with the
patch as a whole. Update the regular expression to handle both cases,
even in emacs mode. Also add support for detecting new files.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/checkpatch.py | 11
Tidy up the extra 's' when there is only a single warning. Fix the empty
print statement also.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 5 +++--
tools/patman/patchstream.py | 9 +
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git
are in the wrong place.
One test patch already has the sign-off in the wrong place. Update the
second one to avoid warnings.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/README | 3 ++-
tools/patman/func_test.py | 23
Add tests that check that warnings are generated when expected.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 111 +---
tools/patman/main.py| 16 +-
tools/patman/patchstream.py | 2 +-
3 files changed, 116
On balance it is easier to use an iterator here, particularly if we need
to insert lines due to new functionality. The only niggle is the need to
keep the previous iterator value around in one case.
Convert this test to use iter().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools
This is not used. Drop it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 1 +
tools/patman/patchstream.py | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/patman/func_test.py b/tools/patman/func_test.py
index bdeccafda0b
for the same commit.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/commit.py | 2 ++
tools/patman/patchstream.py | 15 +++
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/tools/patman/commit.py b/tools/patman/commit.py
index 8d583c4ed39..e49bf87dfc8
.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 4 +++-
tools/patman/series.py | 6 +-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index 880d7ddc7f2..24040d43d62 100644
Add a new function in PatchStream to collect the warnings generated while
parsing the stream. This will allow us to adjust the logic, such as
dealing with per-commit warnings.
Two of the warnings are in fact internal errors, so change them to raise
and exception.
Signed-off-by: Simon Glass
Drop a few arguments that are not used in functions.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index 3a057fbd6c4
Rename these functions to lower case as per PEP8.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 6 +--
tools/patman/control.py | 6 +--
tools/patman/func_test.py | 6 +--
tools/patman/patchstream.py | 88
Some variables are too short or shadow other variables or types. Fix these
to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 52 ++---
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/tools
in a later patch.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/README | 15 +++
tools/patman/func_test.py | 1 +
tools/patman/series.py| 2 +-
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/tools/patman/README b/tools/patman/README
These constants should use upper case. Update them to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 44 ++---
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/tools/patman/patchstream.py b
This fixes all but the ones about too many variables/statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 76 +--
1 file changed, 58 insertions(+), 18 deletions(-)
diff --git a/tools/patman/func_test.py b/tools
Fix up various indentation and other minor things to make pylint3 happier.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/tools/patman/func_test.py b
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/control.py | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tools/patman/control.py b/tools/patman/control.py
index 67e8f397efd..aea9df8c8d1 100644
--- a/tools/patman/control.py
+++ b/tools/patman/
Hi,
This patch failed to make it into patchwork. The series is here:
http://patchwork.ozlabs.org/project/uboot/list/?series=204488
I just resent it and still don't see it.
Is this a bug?
Regards,
Simon
-- Forwarded message -
From: Simon Glass
Date: Sun, 27 Sep 2020 at 22:26
At present we use --test to indicate that tests should be run. It is
better to use a subcommand for list, like binman. Change it and adjust
the existing code to fit under a 'send' subcommand, the default.
Give this subcommand the same default arguments as the others.
Signed-off-by: Simon Glass
On Tue, 2020-07-07 at 11:09 +1000, Daniel Axtens wrote:
> Simon Glass writes:
>
> > Hi Daniel,
> >
> > On Sun, 5 Jul 2020 at 22:50, Daniel Axtens wrote:
> > > Daniel Axtens writes:
> > >
> > > > Hi Simon,
> > > >
> > >
Add a -b option to allow patches to be created from a branch other than
the current one.
Signed-off-by: Simon Glass
---
tools/patman/control.py | 13 -
tools/patman/func_test.py | 13 +++--
tools/patman/gitutil.py | 19 ++-
tools/patman/main.py
At present patman only does one thing so does not have any comments. We
want to add a few more command, so create a sub-parser for the default
command ('send').
Signed-off-by: Simon Glass
---
tools/patman/main.py | 77 +++-
1 file changed, 41 insertions
at the bottom of the
branch.
Signed-off-by: Simon Glass
---
tools/patman/control.py | 8 +---
tools/patman/func_test.py | 13 +++--
tools/patman/main.py | 2 ++
3 files changed, 18 insertions(+), 5 deletions(-)
Applied to u-boot-dm
Convert from OptionParser to ArgumentParser to match binman. With this we
can easily add sub-commands.
Signed-off-by: Simon Glass
---
tools/patman/control.py | 22 -
tools/patman/main.py | 97
tools/patman/settings.py | 10 +++--
3 files
At present all text is marked bright, which makes it stand out on the
terminal. Add a way to disable that, as is done with the Color class.
Signed-off-by: Simon Glass
---
tools/patman/terminal.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Applied to u-boot-dm
Collect response tags such as 'Reviewed-by' while parsing the stream.
This allows us to see what tags are present.
Add a new 'Fixes' tag also, since this is now quite common.
Signed-off-by: Simon Glass
---
tools/patman/commit.py | 14 ++
tools/patman/patchstream.py | 21
Hi Daniel,
On Sun, 5 Jul 2020 at 22:50, Daniel Axtens wrote:
>
> Daniel Axtens writes:
>
> > Hi Simon,
> >
> > I can't see a cover letter so apologies if I've misunderstood something
> > basic, but this doesn't appear to apply to the patchwork tree - I'm
> > guessing the patchwork relevance is
At present we use --test to indicate that tests should be run. It is
better to use a subcommand for list, like binman. Change it and adjust
the existing code to fit under a 'send' subcommand, the default.
Give this subcommand the same default arguments as the others.
Signed-off-by: Simon Glass
/projects/pwclient/en/latest/usage/
[2] https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/tree/patman-working
Simon Glass (16):
patman: Use test_util to show test results
patman: Move main code out to a control module
patman: Add a test that uses gitpython
patman: Allow creating patches
While reviewing feedback it is helpful to see the review comments on the
command line to check that each has been addressed. Add an option to
support that.
Update the workflow documentation to describe the new features.
Signed-off-by: Simon Glass
---
tools/patman/README | 36
'status' subcommand that checks patchwork
for review tags, showing those which are not present in the local branch.
This allows users to see what new review tags have been received and then
add them.
Signed-off-by: Simon Glass
---
tools/patman/README | 34
tools/patman/control.py | 31
It is tedious to add review tags into the local branch and errors can
sometimes be made. Add an option to create a new branch with the review
tags obtained from patchwork.
Signed-off-by: Simon Glass
---
tools/patman/README | 17 +++--
tools/patman/control.py | 9 ---
tools
and can produce multiple snippets,
one for each part of the code that attracts a comment.
Signed-off-by: Simon Glass
---
tools/patman/patchstream.py | 53 +
1 file changed, 53 insertions(+)
diff --git a/tools/patman/patchstream.py b/tools/patman
Most users don't want to see traceback errors. Add an option to enable
them for debugging. Disable them by default.
Signed-off-by: Simon Glass
---
tools/patman/main.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/patman/main.py b/tools/patman/main.py
index 77f187e769
Collect response tags such as 'Reviewed-by' while parsing the stream.
This allows us to see what tags are present.
Add a new 'Fixes' tag also, since this is now quite common.
Signed-off-by: Simon Glass
---
tools/patman/commit.py | 14 ++
tools/patman/patchstream.py | 21
At present all text is marked bright, which makes it stand out on the
terminal. Add a way to disable that, as is done with the Color class.
Signed-off-by: Simon Glass
---
tools/patman/terminal.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/patman/terminal.py b
At present patman only does one thing so does not have any comments. We
want to add a few more command, so create a sub-parser for the default
command ('send').
Signed-off-by: Simon Glass
---
tools/patman/main.py | 77 +++-
1 file changed, 41 insertions
Add a -b option to allow patches to be created from a branch other than
the current one.
Signed-off-by: Simon Glass
---
tools/patman/control.py | 13 -
tools/patman/func_test.py | 13 +++--
tools/patman/gitutil.py | 19 ++-
tools/patman/main.py
It is convenient to use gitpython to create a real git repo for testing
patman's operation. Add a test for this. So far it just checks that patman
produces the right number of patches for a branch.
Signed-off-by: Simon Glass
---
tools/patman/func_test.py | 151
at the bottom of the
branch.
Signed-off-by: Simon Glass
---
tools/patman/control.py | 8 +---
tools/patman/func_test.py | 13 +++--
tools/patman/main.py | 2 ++
3 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/tools/patman/control.py b/tools/patman/control.py
index
This handles skipped tests correctly, so use it instead of the existing
code.
Signed-off-by: Simon Glass
---
tools/patman/main.py | 8 ++--
tools/patman/test_util.py | 6 +++---
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/tools/patman/main.py b/tools/patman/main.py
To make testing easier, move the code out from main into a separate
'control' module and split it into four parts: setup, preparing patches,
checking patches and emailing patches.
Add comments and fix a few code-style issues while we are here.
Signed-off-by: Simon Glass
---
tools/patman
1 - 100 of 106 matches
Mail list logo
