[PATCH v3] Avoid timezone confusion

From: Veronika Kabatova Patchwork saves patches, comments etc with UTC timezone and reports this time when opening the patch details. However, internally generated processes such as events are reported with the instance's local time. There's nothing wrong with that and making PW timezone-aware wo

Re: [PATCH v3] Avoid timezone confusion

At a quick glance this looks good. I will try to test it this weekend, time permitting. Thanks! Regards, Daniel vkaba...@redhat.com writes: > From: Veronika Kabatova > > Patchwork saves patches, comments etc with UTC timezone and reports > this time when opening the patch details. However, int

Re: [PATCH v3] Avoid timezone confusion

Hi Veronika, I have become briefly sidetracked by Docker's default behaviour to set the timezone in the container to UTC. However, I did have 1 question: > diff --git a/patchwork/migrations/0024_timezone_unify.py > b/patchwork/migrations/0024_timezone_unify.py > new file mode 100644 > index

Re: [PATCH v3] Avoid timezone confusion

- Original Message - > From: "Daniel Axtens" > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Friday, February 23, 2018 3:44:25 PM > Subject: Re: [PATCH v3] Avoid timezone confusion > > Hi Veronika, > > I have become briefly sidetracked by

Re: [PATCH v3] Avoid timezone confusion

Hi Veronika, I am testing this now and I think I'm happy with it. However, I set up a container in UTC+11, and while watching the events api endpoint: - I added some patches without this patch - I applied this patch and migrated - I added some more patches - I noticed that the new events were

Re: [PATCH v3] Avoid timezone confusion

- Original Message - > From: "Daniel Axtens" > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Saturday, February 24, 2018 2:58:56 AM > Subject: Re: [PATCH v3] Avoid timezone confusion > > Hi Veronika, > > I am testing this now and I think

Re: [PATCH v3] Avoid timezone confusion

On Thu, 2018-02-22 at 16:24 +0100, vkaba...@redhat.com wrote: > From: Veronika Kabatova > > Patchwork saves patches, comments etc with UTC timezone and reports > this time when opening the patch details. However, internally generated > processes such as events are reported with the instance's loc

Re: [PATCH v3] Avoid timezone confusion

Stephen Finucane writes: > On Thu, 2018-02-22 at 16:24 +0100, vkaba...@redhat.com wrote: >> From: Veronika Kabatova >> >> Patchwork saves patches, comments etc with UTC timezone and reports >> this time when opening the patch details. However, internally generated >> processes such as events ar

Re: [PATCH v3] Avoid timezone confusion

Hi Veronika, Thank you for your patience. > Patchwork saves patches, comments etc with UTC timezone and reports > this time when opening the patch details. However, internally generated > processes such as events are reported with the instance's local time. > There's nothing wrong with that and m

Re: [PATCH v3] Avoid timezone confusion

- Original Message - > From: "Daniel Axtens" > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Wednesday, March 7, 2018 3:39:01 PM > Subject: Re: [PATCH v3] Avoid timezone confusion > > Hi Veronika, > > Thank you for your patience. >

Re: [PATCH v3] Avoid timezone confusion

On Wed, 2018-03-07 at 10:20 -0500, Veronika Kabatova wrote: [snip] > > So I: > > - made the fixup to the migration number and dependency, as discussed. > > - made a minor edit to the doc fixup (s/sooner/earlier) > > - squashed your two patches > > - added > > Tested-by: Daniel Axtens > > -

Re: [PATCH v3] Avoid timezone confusion

Stephen Finucane writes: > On Wed, 2018-03-07 at 10:20 -0500, Veronika Kabatova wrote: > > [snip] > >> > So I: >> > - made the fixup to the migration number and dependency, as discussed. >> > - made a minor edit to the doc fixup (s/sooner/earlier) >> > - squashed your two patches >> > - added