Re: [PATCH 2/2] retag: Properly display the final count

2015-11-11 Thread Finucane, Stephen
On 07 Nov 16:49, Damien Lespiau wrote: > i == count cannot happen in the loop as i will vary from 0 to count - 1. > > Signed-off-by: Damien Lespiau Merged. ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: [PATCH 2/2] retag: Properly display the final count

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 03:30:22PM +, Finucane, Stephen wrote: > > On Mon, Nov 09, 2015 at 03:20:39PM +, Finucane, Stephen wrote: > > > > That wouldn't work either. On the last iteration (count - 1)/count > > would > > > > be printed and count/count would never be printed. > > > > > >

Re: [PATCH 2/2] retag: Properly display the final count

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 02:59:49PM +, Finucane, Stephen wrote: > > On Mon, Nov 09, 2015 at 02:37:54AM +, Finucane, Stephen wrote: > > > > i == count cannot happen in the loop as i will vary from 0 to count - > > 1. > > > > > > > > Signed-off-by: Damien Lespiau >

Re: [PATCH 2/2] retag: Properly display the final count

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 03:20:39PM +, Finucane, Stephen wrote: > > That wouldn't work either. On the last iteration (count - 1)/count would > > be printed and count/count would never be printed. > > Right you are. What on earth was that code doing there at all? :) Actually, because i goes

RE: [PATCH 2/2] retag: Properly display the final count

2015-11-09 Thread Finucane, Stephen
> On Mon, Nov 09, 2015 at 02:59:49PM +, Finucane, Stephen wrote: > > > On Mon, Nov 09, 2015 at 02:37:54AM +, Finucane, Stephen wrote: > > > > > i == count cannot happen in the loop as i will vary from 0 to count > - > > > 1. > > > > > > > > > > Signed-off-by: Damien Lespiau

RE: [PATCH 2/2] retag: Properly display the final count

2015-11-09 Thread Finucane, Stephen
> On Mon, Nov 09, 2015 at 03:20:39PM +, Finucane, Stephen wrote: > > > That wouldn't work either. On the last iteration (count - 1)/count > would > > > be printed and count/count would never be printed. > > > > Right you are. What on earth was that code doing there at all? :) > > Actually,

Re: [PATCH 2/2] retag: Properly display the final count

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 02:37:54AM +, Finucane, Stephen wrote: > > i == count cannot happen in the loop as i will vary from 0 to count - 1. > > > > Signed-off-by: Damien Lespiau > > --- > > patchwork/management/commands/retag.py | 3 ++- > > 1 file changed, 2

RE: [PATCH 2/2] retag: Properly display the final count

2015-11-08 Thread Finucane, Stephen
> i == count cannot happen in the loop as i will vary from 0 to count - 1. > > Signed-off-by: Damien Lespiau > --- > patchwork/management/commands/retag.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

[PATCH 2/2] retag: Properly display the final count

2015-11-07 Thread Damien Lespiau
i == count cannot happen in the loop as i will vary from 0 to count - 1. Signed-off-by: Damien Lespiau --- patchwork/management/commands/retag.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/patchwork/management/commands/retag.py