Re: Test::Harness 2.27_01 released

2003-03-31 Thread Jarkko Hietaniemi
...and now Test::Harness 2.27_02 merged into blead (change #19103). (I _think_ I got the update right, but someone else doing a double check would be appreciated.) -- Jarkko Hietaniemi <[EMAIL PROTECTED]> http://www.iki.fi/jhi/ "There is this special biologist word we use for '

Re: Why not a smoke db ?

2002-09-23 Thread Jarkko Hietaniemi
> k, but this is a missing info from smoke report. The 'archname' from config.sh is definitely needed, then. -- Jarkko Hietaniemi <[EMAIL PROTECTED]> http://www.iki.fi/jhi/ "There is this special biologist word we use for 'stable'. It is 'dead'." -- Jack Cohen

Re: [REPATCH MANIFEST ext/B/t/o.t] Add tests for O

2002-05-09 Thread Jarkko Hietaniemi
On Thu, May 09, 2002 at 10:07:14PM -0700, chromatic wrote: > On Thursday 09 May 2002 22:07, Jarkko Hietaniemi wrote: > > > On Thu, May 09, 2002 at 10:00:10PM -0700, chromatic wrote: > > > > + 1 while unlink('lib/B/success.pm'); > > I suggest a VMS te

Re: [REPATCH MANIFEST ext/B/t/o.t] Add tests for O

2002-05-09 Thread Jarkko Hietaniemi
On Thu, May 09, 2002 at 10:00:10PM -0700, chromatic wrote: > Let's try this then: > > +END { > + 1 while unlink('lib/B/success.pm'); I suggest a VMS test drive account :-) -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist word we use for 'stable'. # It i

Re: [PATCH MANIFEST ext/B/t/o.t] Add tests for O

2002-05-09 Thread Jarkko Hietaniemi
On Thu, May 09, 2002 at 09:45:24PM -0700, chromatic wrote: > On Thursday 09 May 2002 21:32, Jarkko Hietaniemi wrote: > > > > +open(OUT, '>lib/B/success.pm') or skip_all( 'Cannot write fake backend > > > module'); > > Unportable filename. >

Re: [PATCH MANIFEST ext/B/t/o.t] Add tests for O

2002-05-09 Thread Jarkko Hietaniemi
On Thu, May 09, 2002 at 07:10:15PM -0700, chromatic wrote: > Just when you thought it was safe to smoke Perl... I'm also working on tests > for CPAN::FirstTime, though they may require a bit of reorganization to do > it right. It'll likely make the code smaller and more flexible too. > > -- c >

Re: t/TEST ported to VMS

2002-04-26 Thread Jarkko Hietaniemi
On Fri, Apr 26, 2002 at 12:13:31AM -0500, Craig A. Berry wrote: > I've finally gotten around to making t/TEST work properly on VMS. > The patch is below and works with bleadperl on VMS and also works as > before on Mac OS X. If this is too ugly or too late for 5.8.0 I can > live with that. H

Re: VMS status @14710

2002-02-15 Thread Jarkko Hietaniemi
> t/op/glob.t > > The test that is failing is: > > # ... while ($var = glob(...)) should test definedness not truth > > my $ok = "not ok 8\n"; > $ok = "ok 8\n" while my $var = glob("0"); > print $ok; > > > This test massively confuses me. What is the meaning of the "0" in > C? As far as I

Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Jarkko Hietaniemi
On Fri, Jan 11, 2002 at 05:31:49PM +0200, Jarkko Hietaniemi wrote: > On Fri, Jan 11, 2002 at 05:18:10PM +0200, Jarkko Hietaniemi wrote: > > > PS There was also a bug in runperl(). All switches were being lost. > > > > Well, this change made several tests (like run/swi

Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Jarkko Hietaniemi
On Fri, Jan 11, 2002 at 05:18:10PM +0200, Jarkko Hietaniemi wrote: > > PS There was also a bug in runperl(). All switches were being lost. > > Well, this change made several tests (like run/switches) to barf. > So I backed out that hunk. Urk, so now three of kill_perl tests te

Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Jarkko Hietaniemi
> PS There was also a bug in runperl(). All switches were being lost. Well, this change made several tests (like run/switches) to barf. So I backed out that hunk. -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist word we use for 'stable'. # It is 'dead'. --

Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Jarkko Hietaniemi
On Fri, Jan 11, 2002 at 04:26:27AM -0500, Michael G Schwern wrote: > As long ago promised, here's a patch to pull the logic out of > t/run/kill_perl.t and make it into a t/test.pl function. > > This means its no longer necessary to pile segfault checks into > t/run/kill_perl.t. They can be place

Re: Untested modules update: The Magic Number is 27

2001-12-29 Thread Jarkko Hietaniemi
On Thu, Dec 27, 2001 at 02:58:56PM -0500, Michael G Schwern wrote: > Dynaloader has a good sized documented interface which isn't > necessarily exercised by the core modules. Test that. Remember to test DynaLoader with miniperl, though, otherwise you are cheating. And not fair testing dynaloadi

Re: [REPATCH MANIFEST, ext/re/re.t] Tests for re pragma

2001-12-20 Thread Jarkko Hietaniemi
On Thu, Dec 20, 2001 at 04:16:48PM -0700, chromatic wrote: > Thanks to Benjamin Goldberg for finding a logic error in the previous version. > This also patches. Thanks, applied. Though I had to change the no_plan to a real one. -- $jhi++; # http://www.iki.fi/jhi/ # There is this specia

Re: [PATCH MANIFEST, lib/ExtUtils/t/MM_OS2.t] Tests for ExtUtils::MM_OS2

2001-12-20 Thread Jarkko Hietaniemi
On Thu, Dec 20, 2001 at 04:09:10PM -0700, chromatic wrote: > These tests all pass, though I don't have an OS2 box. I don't forsee any > difficulty there, though it would be good to check. > > -- c Thanks, applied. (.t in t/, though) -- $jhi++; # http://www.iki.fi/jhi/ # There is this

Re: [PATCH MANIFEST, lib/ExtUtils/Installed.t] Add tests for ExtUtils::Installed

2001-12-16 Thread Jarkko Hietaniemi
On Sat, Dec 15, 2001 at 11:24:40PM -0700, chromatic wrote: > This passes all tests, gets the MANIFEST patch right for once, and shouldn't > have weird sorting bugs on EBCDIC platforms. Cross your fingers. Up to the elbows. Thanks, applied. -- $jhi++; # http://www.iki.fi/jhi/ # There i

Re: Untested modules update: There's more than we thought

2001-12-15 Thread Jarkko Hietaniemi
> Ok, so that's a bit off the topic of "why use isa_ok()" but I just don't > see why people seem to object to the use of Test::More in the core Perl > tests. I can't see how it couldn't help improve the quality of the tests > while providing a standardized way to do the things that all the tests

Re: Untested modules update: There's more than we thought

2001-12-15 Thread Jarkko Hietaniemi
On Fri, Dec 14, 2001 at 05:20:24PM -0700, chromatic wrote: > On Fri, 14 Dec 2001 15:18:43 -0700, Michael G Schwern wrote: > > > ExtUtils::MM_Cygwin > > Here's a test for that. It could use someone on Cygwin testing it. Tels said > he would, but apparently got busy. Thanks, applied. -- $jhi+

Re: Untested modules update: There's more than we thought

2001-12-14 Thread Jarkko Hietaniemi
On Fri, Dec 14, 2001 at 05:50:16PM -0500, Michael G Schwern wrote: > On Sat, Dec 15, 2001 at 12:21:08AM +0200, Jarkko Hietaniemi wrote: > > On Fri, Dec 14, 2001 at 05:18:43PM -0500, Michael G Schwern wrote: > > > The good news is Nick Clark just wrote a test for Benchmark! The

Re: [PATCH] Add test for Pod::ParseUtils

2001-11-20 Thread Jarkko Hietaniemi
On Tue, Nov 20, 2001 at 02:33:14PM -1000, Tim Jenness wrote: > > Here is a new test script for Pod::ParseUtils. > > I was mainly concerned with the link parsing. There is a good chance that > Pod::ParseUtils is currently doing the wrong thing in some cases. > > Most obvious to me is that > >

Re: Make Schwern Poor before 5.8.0

2001-11-20 Thread Jarkko Hietaniemi
On Tue, Nov 20, 2001 at 03:54:05PM -0600, Dave Rolsky wrote: > On Tue, 20 Nov 2001, Tels wrote: > > > > If you would prefer to handle the > > > ExtUtils::MakeMaker and ExtUtils::MM_* changes yourself let me know. > > > > You can do it. I'll wait until the dust settles (I wrote tests for routines

Re: [PATCH t/io/argv.t vms/test.com t/test.pl] argv.t cleanup & fixes for VMS

2001-11-06 Thread Jarkko Hietaniemi
On Tue, Nov 06, 2001 at 09:27:44PM -0500, Michael G Schwern wrote: > Plowing through the list of excepted tests in vms/test.com, we start > with t/io/argv.t. This version now works under VMS and Linux. It > should work under Windows as well, but I'd like someone to give it a > shot. > > Here's

Re: [PATCH t/test.pl] Adding isnt() and next_test()

2001-11-06 Thread Jarkko Hietaniemi
On Tue, Nov 06, 2001 at 08:58:45PM -0500, Michael G Schwern wrote: > In the course of revamping t/io/argv.t for VMS, I've added two > functions to t/test.pl. > > isnt() is useful for replacing this sort of thing: > > print "not " unless defined $foo; > print "ok 42\n"; > > with > >

Re: Smoke 12847 /pro/3gl/CPAN/perl-current

2001-11-05 Thread Jarkko Hietaniemi
> > (1) How about looking for my snapshot announcements in p5p > > (or "patchlevel.h" updates in perl5-changes) and launching smokes > > from them, not from some arbitrary points in time? > > > > (2) Add a (cronjob?) suspend-all option to the smoke harness: > > basically, send a SIGSTOP signal fo

Re: Smoke 12847 /pro/3gl/CPAN/perl-current

2001-11-05 Thread Jarkko Hietaniemi
On Mon, Nov 05, 2001 at 03:05:23PM +0100, H.Merijn Brand wrote: > On Mon 05 Nov 2001 15:00, Jarkko Hietaniemi <[EMAIL PROTECTED]> wrote: > > > Automated smoke report for patch 12847 > > > > Fixed in 12848. Your smokes seem always to pick the most inconvenient >

Re: Cleaning out t/run/kill_perl.t (was Re: Perlbug 19990906.001 - segfault on long escaped quote regex)

2001-10-29 Thread Jarkko Hietaniemi
On Mon, Oct 29, 2001 at 11:33:14PM -0500, Michael G Schwern wrote: > On Tue, Oct 30, 2001 at 06:09:55AM +0200, Jarkko Hietaniemi wrote: > > Thanks, applied. Though I still think someone should go in with a > > pitchfork and clean out kill_perl.t, sorting the tests to other test

Re: [PATCH lib/Net/Config.pm, MANIFEST, t/lib/Mock/Socket.pm, lib/Net/Config.t] Add Tests for Net::Config

2001-10-22 Thread Jarkko Hietaniemi
On Mon, Oct 22, 2001 at 09:25:24PM +0100, Graham Barr wrote: > On Mon, Oct 22, 2001 at 04:27:51PM -0400, Michael G Schwern wrote: > > On Mon, Oct 22, 2001 at 02:08:05PM -0600, chromatic wrote: > > > > > So if a test depends on a module in the core it should check that > > > > > the module is avali

Re: [proposed PATCH installhtml] Re: installhtml needs a good beating out

2001-10-20 Thread Jarkko Hietaniemi
On Sat, Oct 20, 2001 at 04:25:02PM -0400, Michael G Schwern wrote: > On Sat, Oct 20, 2001 at 06:25:20PM +0300, Jarkko Hietaniemi wrote: > > You have been drinking deeply from the fount of the QA Kool-Aid, > > haven't you? I'm probably not going to be surprised one day

Re: [PATCH lib/Net/Config.pm, MANIFEST, t/lib/Mock/Socket.pm, lib/Net/Config.t] Add Tests for Net::Config

2001-10-20 Thread Jarkko Hietaniemi
On Sat, Oct 20, 2001 at 12:04:49PM -0600, chromatic wrote: > On Saturday 20 October 2001 11:54, you wrote: > > > So why is this tested using a mock-up by Net::Config? Sounds like > > a job the Socket should be testing (and it is). > > Oh, no! It's not. Mock::Socket is just a dummy object with

Re: [PATCH lib/Net/Config.pm, MANIFEST, t/lib/Mock/Socket.pm, lib/Net/Config.t] Add Tests for Net::Config

2001-10-20 Thread Jarkko Hietaniemi
> Net::Config doesn't care *how* inet_ntoa and inet_aton do their job. > It just cares that it gets data in the right format. Tying STDIN So why is this tested using a mock-up by Net::Config? Sounds like a job the Socket should be testing (and it is). > and feeding fake input to Term::Complete

Re: [PATCH lib/Net/Config.pm, MANIFEST, t/lib/Mock/Socket.pm, lib/Net/Config.t] Add Tests for Net::Config

2001-10-20 Thread Jarkko Hietaniemi
> Here's a test suite for Net::Config. In the process of writing > this, I've fixed an apparent bug that prevented single values from > becoming array references when necessary. I think it's right, but > perhaps Graham should weigh in on this. > > In the process, with some advice from perl-qa, I

Re: [proposed PATCH installhtml] Re: installhtml needs a good beating out

2001-10-20 Thread Jarkko Hietaniemi
On Sat, Oct 20, 2001 at 01:54:14AM -0600, chromatic wrote: > In article <20011020014825.J3681@blackrider>, "Michael G Schwern" > <[EMAIL PROTECTED]> wrote: > > > Convert from $opt_* globals to an %Options hash > > A fun use of map! > > Is there a test for this beast? A quick 'perl -wc inst

Re: installhtml needs a good beating out

2001-10-20 Thread Jarkko Hietaniemi
On Sat, Oct 20, 2001 at 02:02:59AM -0400, Michael G Schwern wrote: > On Sat, Oct 20, 2001 at 08:58:11AM +0300, Jarkko Hietaniemi wrote: > > > Once you've done that you can add "Refactoring" to the list of > > > buzzwords on your resume. :) > > > >

Re: installhtml needs a good beating out

2001-10-19 Thread Jarkko Hietaniemi
> Once you've done that you can add "Refactoring" to the list of > buzzwords on your resume. :) I think installhtml teeters heavily on the brink of "Rewriting" instead of "Refactoring". It hasn't changed much since 1997. -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biolo

Re: [PATCH] Test::Simple 0.32

2001-10-17 Thread Jarkko Hietaniemi
On Wed, Oct 17, 2001 at 03:42:41AM -0400, Michael G Schwern wrote: > This brings bleadperl in step with Test::Simple 0.32. This'll give us > Test::Builder, plan() and is_deeply(). Also, failure diagnostics now > go to STDERR like they used to. > > t/lib/Test/Simple/Catch/More.pm and lib/Test/Ut

Re: [PATCH t/TEST t/harness vms/test.com] Set PERL_CORE environment var

2001-10-17 Thread Jarkko Hietaniemi
On Wed, Oct 17, 2001 at 04:04:13AM -0400, Michael G Schwern wrote: > I spent a few hours synching up Test::Simple pretty much by hand. A > simple recursive diff won't produce a useful patch since there's some > things in the core version that aren't in the CPAN version. The most > prevalent exam

Re: [ANNOUNCE] Test::Simple/More/Builder 0.32

2001-10-16 Thread Jarkko Hietaniemi
> Jarkko, do you want me to submit a patch or let you handle it? It > shouldn't be as much of a hassle as last time. If at all possible I would like to avoid spreading my few free neurons too thinly. -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist word we use for

Re: [PATCH lib/Term/Cap.t] Fix Debian Failures on Test 22

2001-10-08 Thread Jarkko Hietaniemi
> Given my inspectacular track record on this test, this is worth > testing before anyone pokes poor Jarkko with the "check it in" > stick. Copying to perl-qa. Hey, it's usually me, myself, and I doing that poking... -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist

Re: [PATCH MANIFEST lib/Term/Cap.t] Add tests for Term::Cap

2001-09-30 Thread Jarkko Hietaniemi
On Sun, Sep 30, 2001 at 04:10:02PM -0600, chromatic wrote: > This adds several tests for Term::Cap. It *should* be portable, as it's pretty > cautious about avoiding platform dependencies. Time always tells. Thanks, applied. And immediately edited: trusting on particular external error message

Re: [PATCH MANIFEST lib/CGI/t/push.t] New Test for CGI::Push

2001-09-10 Thread Jarkko Hietaniemi
On Mon, Sep 10, 2001 at 03:14:01PM -0600, chromatic wrote: > Just about everything else on the untested list scares me. There are a few > modules in ExtUtils::* that need attention, and a handful of Pod::* modules. Thanks, applied. -- $jhi++; # http://www.iki.fi/jhi/ # There is this sp

Re: [PATCH t/op/misc.t] cleanup

2001-09-02 Thread Jarkko Hietaniemi
I think the wholesale renaming of t/op/misc as t/run/kill_perl is really wrong. (I think you are reading too much into the leading comments, and other people have been reading too little into them.) t/op/misc has NOT consistently been the place for core-dumping tests; it has some yes, but not al

Re: [PATCH t/op/misc.t] cleanup

2001-09-02 Thread Jarkko Hietaniemi
> @@ -739,3 +783,9 @@ > # keep this last - doesn't seem to work otherwise? This requirement magically went away while I was away? > eval "a.b.c.d.e.f;sub" > EXPECT > + > + perlbug ID 20010831.001 > +($a, b) = (1, 2); > +EXPECT > +Can't modify constant item in list assignment at - line

Re: Untested libraries.

2001-04-22 Thread Jarkko Hietaniemi
On Sun, Apr 22, 2001 at 01:54:31AM +0100, Michael G Schwern wrote: > At minimum, everything should at least have a "do I compile and export > the documented interface" test. > > Curmudgeon's anti-excuses follow. Pumpkin's anti-anti-excuses follow. > > > CGI::Carp > > > CGI::Cookie > > > CGI::Pu