Re: Test::Class - comments wanted

2002-10-15 Thread Tony Bowden
On Mon, Oct 14, 2002 at 05:46:38PM -0400, Michael G Schwern wrote: The reason I went with no_plan in Test::Inline was that unlike a dedicated test script, a T::I test is cobbled together from a series of seperated blocks of tests and it's more difficult than usual to count them all and add

Re: Test::Class - comments wanted

2002-10-13 Thread Tony Bowden
On Sun, Oct 13, 2002 at 01:40:39AM +0100, Adrian Howard wrote: - In hindsight, having a 1 test default was probably a hangover from JUnit thinking... I never really considered any alternatives. I have to say I like the way this currently is... most of my test methods only have one test

Re: Test::Class weirdness

2002-10-11 Thread Tony Bowden
On Thu, Oct 10, 2002 at 09:42:05PM +0100, Adrian Howard wrote: If you stick your loop inside a BEGIN {} block I think you'll find that it works as you expect. The attribute handler in Test::Class is set to run as a CHECK block (the default provided by Attribute::Handlers). Since you don't

Test::Class weirdness

2002-10-10 Thread Tony Bowden
Test::Class helpfully has a shortcut to allow you to run the tests from multiple classes as if they were one test: If you want to run multiple test objects in a single script you can pass runtests a list of test objects ... Since you can pass runtests class names instead of objects the

Re: Alternative code review ideas?

2002-01-29 Thread Tony Bowden
On Tue, Jan 29, 2002 at 10:23:45AM -0500, Shane Landrum wrote: When we first introduced this most of the reviews were for very basic things: you forgot strict or warnings. You didn't untaint that variable. You're not following our coding standards there. Ah, ok. So were you just grepping