Re: [PATCH] Re-work Parrot_process_args

2007-04-23 Thread chromatic
On Sunday 22 April 2007 17:38, Matt Diephouse wrote: The attached patch completely reworks Parrot_process_args. The changes are extensive and I think they make the code much clearer. Rather than just check it in, I thought I'd try to get feedback here to make sure that it is clearer to

Re: [PATCH] Re-work Parrot_process_args

2007-04-23 Thread Matt Diephouse
chromatic [EMAIL PROTECTED] wrote: On Sunday 22 April 2007 17:38, Matt Diephouse wrote: The attached patch completely reworks Parrot_process_args. The changes are extensive and I think they make the code much clearer. Rather than just check it in, I thought I'd try to get feedback here to

Re: [PATCH] Re-work Parrot_process_args

2007-04-23 Thread chromatic
On Monday 23 April 2007 17:10, Matt Diephouse wrote: It's three lines; is it worth extracting somehow? It could definitely be placed inside start_flatten(), but that would make the code a little misleading, I think. I'm not sure it's worth placing it in a function of its own; the

[PATCH] Re-work Parrot_process_args

2007-04-22 Thread Matt Diephouse
The attached patch completely reworks Parrot_process_args. The changes are extensive and I think they make the code much clearer. Rather than just check it in, I thought I'd try to get feedback here to make sure that it is clearer to everyone else and not just to myself. This patch also fixes a

[PATCH] Re-work Parrot_process_args

2007-04-22 Thread Bob Rogers
From: Matt Diephouse [EMAIL PROTECTED] Date: Sun, 22 Apr 2007 20:38:11 -0400 The attached patch completely reworks Parrot_process_args. The changes are extensive and I think they make the code much clearer. Rather than just check it in, I thought I'd try to get feedback here to