Internals of this step's runstep() were refactored into internal
subroutines, which were then unit-tested in additional test files. I
have narrowed the scope of the SKIP block in 113-auto_msvc-01.t to
simply the test of the runstep() method. Test coverage is high.
Resolving ticket.
On Friday 02 November 2007 18:29:23 James Keenan via RT wrote:
> c: Could I ask you to post the error messages you got when this test
> failed? Before submitting/committing patches, I ran this test file many
> times in its original version on both Darwin and Linux and it never
> failed for me.
Here's an additional problem I noticed with auto::msvc. During coverage
analysis, there were several lines of code that I was never able to
cover successfully (see:
http://thenceforward.net/parrot/coverage/configure-build/config-auto-msvc-pm.html).
unless ( defined $msvcref->{_MSC_VER} ) {
On Tue Oct 30 19:19:42 2007, [EMAIL PROTECTED] wrote:
> The refactored auto::msvc and associated tests were committed to trunk
> tonight as part of r22629. Resolving ticket.
Am reopening ticket. Subsequent to the above, chromatic patched one of
the 3 test files as follows:
-
The refactored auto::msvc and associated tests were committed to trunk
tonight as part of r22629. Resolving ticket.
The patch attached significantly improves the test coverage of
configuration step class auto::msvc. To make this class more testable,
the guts of its runstep() method have been refactored out into two
subroutines
The first is a subroutine, _probe_for_msvc(), which wraps around the
construction an
File holding framework for writing tests for this configuration step was
committed to trunk Oct 21 2007 in r22362. Tests do not yet provide high
coverage due to obstacles in testing runstep(). You are encouraged to
poke around and add tests.
# New Ticket Created by James Keenan
# Please include the string: [perl #43314]
# in the subject line of all future correspondence about this issue.
# http://rt.perl.org/rt3/Ticket/Display.html?id=43314 >
Write unit tests for config/auto/msvc.pm,
the module whose functionality executes Parro
