Re: [perl #44809] [PATCH] use Storable instead of Data::Dumper for PMC .dump files

2007-08-23 Thread James E Keenan
Mark Glines via RT wrote: I didn't hear back from kid51. Mark, I was satisfied with your response but didn't have time to comment further. My thoughts were 'qualms' rather than 'objections'. Practice will provide better evidence to evaluate the change. kid51

[perl #44809] [PATCH] use Storable instead of Data::Dumper for PMC .dump files

2007-08-23 Thread Mark Glines via RT
I didn't hear back from kid51. I believe data portability doesn't matter in this case; all that matters is that Storable at the current rev on the current platform is able to read it's own data for the next 10 seconds or so, which seems like a valid assumption. Pmichaud and chromatic seem to agre

Re: [perl #44809] [PATCH] use Storable instead of Data::Dumper for PMC .dump files

2007-08-22 Thread Mark Glines
Oops. I replied to this on the RT site, but it looks like I neglected to tell it to copy the list (or you). I'll cutpaste my response below. On Tue, 21 Aug 2007 21:02:39 -0400 James E Keenan <[EMAIL PROTECTED]> wrote: > I do have some qualms. > > (1) I know that there have been issues with inc

Re: [perl #44809] [PATCH] use Storable instead of Data::Dumper for PMC .dump files

2007-08-21 Thread James E Keenan
Mark Glines wrote: # New Ticket Created by Mark Glines # Please include the string: [perl #44809] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=44809 > [snip] Are there any drawbacks to this patch? The only thing I can t

Re: [perl #44809] [PATCH] use Storable instead of Data::Dumper for PMC .dump files

2007-08-21 Thread Mark Glines
On Tue, 21 Aug 2007 09:52:01 -0700 chromatic <[EMAIL PROTECTED]> wrote: > return unless -f $filename; > return retrieve($filename); > > My preference is the latter, for clarity and context reasons. Thanks, you're absolutely right. Here's an updated patch. Mark Index: lib/Parrot/Pmc

Re: [perl #44809] [PATCH] use Storable instead of Data::Dumper for PMC .dump files

2007-08-21 Thread chromatic
On Monday 20 August 2007 16:49:53 Mark Glines wrote: > With this patch, parrot rebuilds for me in 1 minute 41 seconds, plus or > minus a few seconds. That's almost 80 seconds faster; a 45% improvement > in build time. > > For reference, I also tried YAML::Syck, which built in 1 minute 55 > seconds

[perl #44809] [PATCH] use Storable instead of Data::Dumper for PMC .dump files

2007-08-21 Thread Will Coleda via RT
On Mon Aug 20 16:49:53 2007, [EMAIL PROTECTED] wrote: > With ccache, HEAD rebuilds for me in a little less than 3 minutes. > (2:57, on average.) > > With this patch, parrot rebuilds for me in 1 minute 41 seconds, plus or > minus a few seconds. That's almost 80 seconds faster; a 45% improvement > i

[perl #44809] [PATCH] use Storable instead of Data::Dumper for PMC .dump files

2007-08-21 Thread via RT
# New Ticket Created by Mark Glines # Please include the string: [perl #44809] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=44809 > With ccache, HEAD rebuilds for me in a little less than 3 minutes. (2:57, on average.) W