# New Ticket Created by "Paul Cochrane"
# Please include the string: [perl #40482]
# in the subject line of all future correspondence about this issue.
# http://rt.perl.org/rt3/Ticket/Display.html?id=40482 >
Hi,
This patch adds a new policy for the Parrot Perl::Critic tests, namely
to check
Patches applied as of revisions r15848, r15860, and r15871.
Thanks,
Paul
On Oct 9, 2006, at 5:51 AM, Paul Cochrane (via RT) wrote:
# New Ticket Created by "Paul Cochrane"
# Please include the string: [perl #40482]
# in the subject line of all future correspondence about this issue.
# http://rt.perl.org/rt3/Ticket/Display.html?id=40482 >
Hi,
This patch adds a ne
Will,
They're all coding standards. I say leave the Coda where it is, and
put this in the same grouping as 'use warnings' (i.e.
'TestingAndDebugging').
Ok, see attached patch.
Also, instead of checking for "/usr/local" and then reporting a
violation, switch it. Check for the *allowed* version
On Oct 9, 2006, at 4:51 AM, Paul Cochrane (via RT) wrote:
# New Ticket Created by "Paul Cochrane"
# Please include the string: [perl #40482]
# in the subject line of all future correspondence about this issue.
# http://rt.perl.org/rt3/Ticket/Display.html?id=40482 >
Hi,
This patch adds a new
On Oct 9, 2006, at 11:50 AM, Paul Cochrane wrote:
Will,
They're all coding standards. I say leave the Coda where it is, and
put this in the same grouping as 'use warnings' (i.e.
'TestingAndDebugging').
Ok, see attached patch.
This one is still a false negative on "#!perl -Tw" and is a false
Chris,
Thanks for your comments, I'm still trying to hone my perl abilities
and I really appreciate your feedback. I certainly need help
sometimes with my regular expressions...
A few comments:
* No, this shouldn't go into UseParrotCoda. Separately enabled
policies are more flexible.
Actua
Chris,
This one is still a false negative on "#!perl -Tw" and is a false positive
on "package main; #!!! my co-worker provided this non-Perl-licensed code to
Parrot!!!". Yes, that's a highly contrived example. :-) But the false
positive would be avoidable by checking the line and column numbe
On Oct 10, 2006, at 3:12 AM, Paul Cochrane wrote:
* This would be a nice addition to core Perl::Critic!
Do you want me to supply a patch for Perl::Critic too, or will the
file added to Parrot suffice?
That's completely up to you. You seem to have a knack for writing
policies, so we'd lov
Chris,
This one is still a false negative on "#!perl -Tw" and is a false positive
on "package main; #!!! my co-worker provided this non-Perl-licensed code to
Parrot!!!". Yes, that's a highly contrived example. :-) But the false
positive would be avoidable by checking the line and column numbe
Chris,
Attached are three new P::C policies for Parrot:
prohibit_shebang_warnings_arg.patch: checks for C
misplaced_shebang.patch:checks for shebang not on
first line of script
require_portable_shebang.patch:checks for non-portable shebang line
That's complete
On Oct 10, 2006, at 11:03 AM, Paul Cochrane wrote:
I've been playing around for a while with the shebang line tests, and
it struck me that the is_script() function will return true on your
contrived example.
Yeah, I saw that and fixed it in SVN yesterday. :-) It now checks
that column == 1
12 matches
Mail list logo
