Re: [PATCH] Re: Getting the grammar engine in (or a small task for the interested)

2004-11-20 Thread Patrick R. Michaud
On Sat, Nov 20, 2004 at 10:46:03AM -0500, Andy Dougherty wrote: > On Fri, 19 Nov 2004, Patrick R. Michaud wrote: > > > On Fri, Nov 19, 2004 at 04:30:06PM -0500, Andy Dougherty wrote: > > > > > > Ok, here's a first pass. Most of it is pretty straightforward > > One spot I may have goofed: I chan

Re: [PATCH] Re: Getting the grammar engine in (or a small task for the interested)

2004-11-20 Thread Andy Dougherty
On Fri, 19 Nov 2004, Patrick R. Michaud wrote: > On Fri, Nov 19, 2004 at 04:30:06PM -0500, Andy Dougherty wrote: > > > > Ok, here's a first pass. Most of it is pretty straightforward One spot I may have goofed: I changed some initializations from "" to NULL, which is, of course, rather a differ

Re: [PATCH] Re: Getting the grammar engine in (or a small task for the interested)

2004-11-20 Thread Patrick R. Michaud
On Sat, Nov 20, 2004 at 09:23:36AM +0100, Lars Balker Rasmussen wrote: > Andy Dougherty <[EMAIL PROTECTED]> writes: > > /* strcon(...) converts string values into PIR string constants */ > > static char* > > strcon(const char* s, int len) > > Haven't looked at the code yet, but I'll just observe

Re: [PATCH] Re: Getting the grammar engine in (or a small task for the interested)

2004-11-20 Thread Patrick R. Michaud
On Fri, Nov 19, 2004 at 04:30:06PM -0500, Andy Dougherty wrote: > > Ok, here's a first pass. Most of it is pretty straightforward, but one > thing is worth noting: > > The code uses both signed and unsigned chars, with and without the 'const' > qualifier. I gather this is a deliberate part of a

Re: [PATCH] Re: Getting the grammar engine in (or a small task for the interested)

2004-11-20 Thread Lars Balker Rasmussen
Andy Dougherty <[EMAIL PROTECTED]> writes: > --- parrot-orig/compilers/p6ge/p6ge_gen.c Fri Nov 19 08:53:40 2004 > +++ parrot-andy/compilers/p6ge/p6ge_gen.c Fri Nov 19 14:43:43 2004 > /* strcon(...) converts string values into PIR string constants */ > static char* > -strcon(const char* s,

[PATCH] Re: Getting the grammar engine in (or a small task for the interested)

2004-11-19 Thread Andy Dougherty
On Fri, 19 Nov 2004, Andy Dougherty wrote: > On Fri, 19 Nov 2004, Dan Sugalski wrote: > > > So, if someone'd like to take a shot at thumping the template > > makefile bits to add in compilers/p6ge to the basic build, that'd be > > great. Grovelling over the code in there to scrub out portability >

Re: Getting the grammar engine in (or a small task for the interested)

2004-11-19 Thread Dan Sugalski
At 10:58 AM -0500 11/19/04, Andy Dougherty wrote: On Fri, 19 Nov 2004, Dan Sugalski wrote: So, if someone'd like to take a shot at thumping the template makefile bits to add in compilers/p6ge to the basic build, that'd be great. Grovelling over the code in there to scrub out portability issues

Re: Getting the grammar engine in (or a small task for the interested)

2004-11-19 Thread Andy Dougherty
On Fri, 19 Nov 2004, Dan Sugalski wrote: > So, if someone'd like to take a shot at thumping the template > makefile bits to add in compilers/p6ge to the basic build, that'd be > great. Grovelling over the code in there to scrub out portability > issues would also be good. I'll take a look at this

Getting the grammar engine in (or a small task for the interested)

2004-11-19 Thread Dan Sugalski
Folks, Since the grammar engine that Patrick's working on is going to be part of the base parrot kit (given the number of languages that have perl 5 compatible regex implementations, we might as well make it so the *real* perl 5, and perl 6, regex engine's there to be used in their parrot incar