Re: [petsc-dev] DMCopyDMSNES

2017-07-20 Thread Barry Smith
I have moved it to petscsnes.h in the master branch > On Jul 20, 2017, at 6:42 PM, Jed Brown wrote: > > Barry Smith writes: > >> Ok, I think we should move it to the public headers unless Jed objects. > > If it is used externally, it should be in a

Re: [petsc-dev] DMCopyDMSNES

2017-07-20 Thread Barry Smith
Ok, I think we should move it to the public headers unless Jed objects. Barry BTW: I have hate DMSNES and friends but don't have a solution for the problem it solves so have to live with it. > On Jul 20, 2017, at 1:40 PM, Jose E. Roman wrote: > > It is used in

Re: [petsc-dev] DMCopyDMSNES

2017-07-20 Thread Jose E. Roman
It is used in SLEPc in code contributed by Fande Kong. https://bitbucket.org/slepc/slepc/pull-requests/14/example-34-work-with-the-monolithic-update/diff I have no problem in including the private header, but we in SLEPc always try to use public headers only. Jose > El 20 jul 2017, a las

Re: [petsc-dev] DMCopyDMSNES

2017-07-20 Thread Barry Smith
It is developer level, so might not belong in the public headers. Do you need it in the public headers? > On Jul 20, 2017, at 11:27 AM, Jose E. Roman wrote: > > DMCopyDMSNES() is documented >

[petsc-dev] DMCopyDMSNES

2017-07-20 Thread Jose E. Roman
DMCopyDMSNES() is documented http://www.mcs.anl.gov/petsc/petsc-current/docs/manualpages/SNES/DMCopyDMSNES.html but it is defined in the private header snesimpl.h. Shouldn't it be in the public header petscsnes.h? Jose