Re: [petsc-dev] PetscLayoutFindOwner and PetscLayoutFindOwnerIndex

2019-10-28 Thread Pierre Jolivet via petsc-dev
https://gitlab.com/petsc/petsc/merge_requests// > On 24 Oct 2019, at 4:47 PM, Smith, Barry F. wrote: > > > These routines should be fixed. > > >> On Oct 16, 2019, at 5:19 AM, Pierre Jolivet via petsc-dev >> wrote: >> >> Hello, >>

Re: [petsc-dev] PetscLayoutFindOwner and PetscLayoutFindOwnerIndex

2019-10-25 Thread Pierre Jolivet via petsc-dev
I can live with PetscInt instead of PetscMPIInt, this was more of a curiosity I noticed. But if no one fixes these, I’ll give it a go in the near future. Thanks, Pierre > On 24 Oct 2019, at 4:47 PM, Smith, Barry F. wrote: > > > These routines should be fixed. > > >> On Oct 16, 2019, at 5:

Re: [petsc-dev] PetscLayoutFindOwner and PetscLayoutFindOwnerIndex

2019-10-24 Thread Smith, Barry F. via petsc-dev
These routines should be fixed. > On Oct 16, 2019, at 5:19 AM, Pierre Jolivet via petsc-dev > wrote: > > Hello, > These two functions use a parameter “owner” of type PetscInt*. > Shouldn’t this be PetscMPIInt*? > This implies changes left and right, so I want to check I’m not pushing an >

Re: [petsc-dev] PetscLayoutFindOwner and PetscLayoutFindOwnerIndex

2019-10-16 Thread Jed Brown via petsc-dev
Pierre Jolivet via petsc-dev writes: >> On 16 Oct 2019, at 8:01 PM, Zhang, Junchao wrote: >> >> The value of "owner" should fit in PetscMPIInt. > > Are you implying that BuildSystem always promotes PetscInt to be able to > store a PetscMPIInt (what if you configure with 32 bit indices and a 64

Re: [petsc-dev] PetscLayoutFindOwner and PetscLayoutFindOwnerIndex

2019-10-16 Thread Pierre Jolivet via petsc-dev
> On 16 Oct 2019, at 8:01 PM, Zhang, Junchao wrote: > > The value of "owner" should fit in PetscMPIInt. Are you implying that BuildSystem always promotes PetscInt to be able to store a PetscMPIInt (what if you configure with 32 bit indices and a 64 bit MPI implementation)? Thanks, Pierre >

Re: [petsc-dev] PetscLayoutFindOwner and PetscLayoutFindOwnerIndex

2019-10-16 Thread Zhang, Junchao via petsc-dev
The value of "owner" should fit in PetscMPIInt. But if you change prototype of the two functions, you have to change all their uses. In petsc, values representing MPI ranks are not always of type PetscMPIInt. Only those closely tied to MPI routines are in PetscMPIInt. --Junchao Zhang On Wed, O

[petsc-dev] PetscLayoutFindOwner and PetscLayoutFindOwnerIndex

2019-10-16 Thread Pierre Jolivet via petsc-dev
Hello, These two functions use a parameter “owner” of type PetscInt*. Shouldn’t this be PetscMPIInt*? This implies changes left and right, so I want to check I’m not pushing an incorrect MR. Thanks, Pierre