Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Dave Page
> On 12 Jul 2017, at 02:56, Ashesh Vashi wrote: > >> On Tue, Jul 11, 2017 at 10:29 PM, Surinder Kumar >> wrote: >> Robert, >> >> I have attached two patches: >> >> 1. webpack_bundles.patch >> >> 2. unvendor_files.patch >> >> in this email chain. >> >> If you didn't received those patche

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Ashesh Vashi
On Tue, Jul 11, 2017 at 10:29 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Robert, > > I have attached two patches: > > 1. webpack_bundles.patch > > 2. unvendor_files.patch > > in this email chain. > > If you didn't received those patches possibly due to large size of patch, > le

Jenkins build is back to normal : pgadmin4-master-python26 #358

2017-07-11 Thread pgAdmin 4 Jenkins
See

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Surinder Kumar
Robert, I have attached two patches: 1. webpack_bundles.patch 2. unvendor_files.patch in this email chain. If you didn't received those patches possibly due to large size of patch, let me know i will send again. On Tue, Jul 11, 2017 at 10:24 PM, Robert Eckhardt wrote: > Surinder, > > Sorry

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Robert Eckhardt
Surinder, Sorry I'm missing the email can you tell me the name please. -- Rob On Tue, Jul 11, 2017 at 12:51 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Tue, Jul 11, 2017 at 10:18 PM, Robert Eckhardt > wrote: > >> The last email on this chain from Surinder says that it isn

Build failed in Jenkins: pgadmin4-master-python35 #237

2017-07-11 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix a compiler error with older compilers. -- [...truncated 569.72 KB...] ResourceGroupsGetTestCase (Get resource groups)

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Surinder Kumar
On Tue, Jul 11, 2017 at 10:18 PM, Robert Eckhardt wrote: > The last email on this chain from Surinder says that it isn't working on > IE and he will submit another patch. Are we missing that patch? Would you > like us to look at the previous patch? > ​Yes previous patch includes fix related to IE

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Robert Eckhardt
The last email on this chain from Surinder says that it isn't working on IE and he will submit another patch. Are we missing that patch? Would you like us to look at the previous patch? -- Rob On Jul 11, 2017 11:37 AM, "Dave Page" wrote: > Pivotal team; you guys are far more familiar with webp

Re: More RHEL 6 build issues

2017-07-11 Thread Devrim Gündüz
Hi Dave, On Tue, 2017-07-11 at 12:26 +0100, Dave Page wrote: > Anyway; the attached patch fixes the issue for me. I wonder if this is some > CentOS weirdness... Thanks, that fixed this issue. We have now another one: Exception occurred:   File "/usr/lib/python2.6/site-packages/pgadmin4-web/fla

Re: Windows testing required: Updated runtime

2017-07-11 Thread Ashesh Vashi
On Tue, Jul 11, 2017 at 9:44 PM, Dave Page wrote: > > > On Tue, Jul 11, 2017 at 4:56 PM, Mike Surcouf wrote: > >> >No - PostgreSQL builds on Windows dropped GSSAPI in favour of SSPI some >> years ago. That functionality is provided by the underlying libpq, not >> pgAdmin - though pgAdmin 1.6 doe

pgAdmin 4 commit: Fix a compiler error with older compilers.

2017-07-11 Thread Dave Page
Fix a compiler error with older compilers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de06e63334ba041df6de4ba5a91e1650a9d8f024 Author: Mammoth Power Modified Files -- runtime/splash.png | Bin 28131 -> 13559 bytes 1 file chang

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
On Tue, Jul 11, 2017 at 4:56 PM, Mike Surcouf wrote: > >No - PostgreSQL builds on Windows dropped GSSAPI in favour of SSPI some > years ago. That functionality is provided by the underlying libpq, not > pgAdmin - though pgAdmin 1.6 does allow you to specify the host address as > >well as hostname

RE: Windows testing required: Updated runtime

2017-07-11 Thread Mike Surcouf
>No - PostgreSQL builds on Windows dropped GSSAPI in favour of SSPI some years >ago. That functionality is provided by the underlying libpq, not pgAdmin - >though pgAdmin 1.6 does allow you to specify the host address as >well as >hostname/address which many people need with Kerberos for example

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
On Tue, Jul 11, 2017 at 4:14 PM, Mike Surcouf wrote: > > Try pressing Ctrl 0 (Control zero) > > > > Yes that did it. > > I also needed to reset layout for it to stick. > OK, good. > > > Start-up time still 25 secs to dash board so still slow for me (sorry but > it’s a fact). > > For comparison

RE: Windows testing required: Updated runtime

2017-07-11 Thread Mike Surcouf
> Try pressing Ctrl 0 (Control zero) Yes that did it. I also needed to reset layout for it to stick. Start-up time still 25 secs to dash board so still slow for me (sorry but it’s a fact). For comparison Server install start up is 5 seconds to dash board. 1. Does the desktop support GSSA

RE: Windows testing required: Updated runtime

2017-07-11 Thread McDonaldR
Yes! Installed quickly. Splash screen to gui window about 7 secs and then another few secs to usable. Much more responsive. Expanding elements in tree is snappy. I’ll test it some more tomorrow with connections to a production database. Ross From: Dave Page [mailto:dp...@pgadmin.org] Sent: 11 J

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
Nice! Thanks for the feedback. On Tue, Jul 11, 2017 at 3:35 PM, McDonaldR wrote: > Yes! > > > > Installed quickly. > > Splash screen to gui window about 7 secs and then another few secs to > usable. > > Much more responsive. > > Expanding elements in tree is snappy. > > > > I’ll test it some mor

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
Hi On Tue, Jul 11, 2017 at 2:47 PM, Mike Surcouf wrote: > Hi Dave > > > > v1.6 > > Show splash then backround of main window then hangs forever. pgadmin4.log > is 0 bytes > Try pressing Ctrl 0 (Control zero) to reset the zoom level. The experimental ActiveQt build used a different scaling facto

Re: [pgadmin-hackers][pgaweb][patch] Website patch to add SCSS

2017-07-11 Thread Dave Page
Hi On Mon, Jul 10, 2017 at 7:16 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > In this email you will be able to find the first patches to start the > migration of the Styleguide from http://pgadmin4-styleguide.cfapps.io/ to > the pgadmin.org webpage. > > The

RE: Windows testing required: Updated runtime

2017-07-11 Thread Mike Surcouf
Hi Dave v1.6 Show splash then backround of main window then hangs forever. pgadmin4.log is 0 bytes v1.3 Uninstalled then reinstalled 1.3 (which was the last version that worked).and all is ok again But I guess it works on your machine so it must be something wrong with my setup Thanks Mike

Build failed in Jenkins: pgadmin4-master-python26 #357

2017-07-11 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Straighten line -- [...truncated 572.38 KB...] SynonymGetTestCase (Fetch synonym Node URL) PackageDeleteT

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
Hi The candidate build can be found at https://developer.pgadmin.org/~dpage/1.6/. Note that as the timing is coupled with the PostgreSQL 10b2 release, we'll only rewrap now for showstopper issues, not anything minor. On Tue, Jul 11, 2017 at 1:14 PM, Mike Surcouf wrote: > Hi Dave > > > > Can I

pgAdmin 4 commit: Straighten line

2017-07-11 Thread Dave Page
Straighten line Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=68a6c496d9648df2c002f85ad42d34850f773b11 Modified Files -- web/pgadmin/dashboard/static/img/welcome_logo.png | Bin 22526 -> 22603 bytes 1 file changed, 0 insertions(+)

RE: Windows testing required: Updated runtime

2017-07-11 Thread Mike Surcouf
Hi Dave Can I suggest you send out another build before you go GA. I for one have outstanding issues that were not in 1.3 (see previous emails). I know you said you don’t have my issues on your install but that doesn’t mean they don’t exist. Happy to test Thanks Mike From: Dave Page [mailto:d

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
Hi On Tue, Jul 11, 2017 at 10:03 AM, McDonaldR wrote: > Hi Dave, > > > > I’m testing the latest build (10/7/2017) from your download page. > > > > I had a v1.5 build that fixed issues with the proxy server. It took ~30 > secs from start to usable. Before that I could only run the v1.3 release.

Re: [pgAdmin4][Patch] To fix the issue in privileges control

2017-07-11 Thread Murtuza Zabuawala
Hi, Please find updated patch. On Tue, Jul 11, 2017 at 4:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Please disregard previous patch, I'll send updated patch as I found one > issue. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > T

Re: More RHEL 6 build issues

2017-07-11 Thread Dave Page
On Tue, Jul 11, 2017 at 12:09 PM, Devrim Gündüz wrote: > > Hi, > > Sorry, I missed this part: > > On Tue, 2017-07-11 at 11:44 +0100, Dave Page wrote: > > It was fixed in the code: > > > > # HTMLMIN doesn't work with Python 2.6. > > if not config.DEBUG and sys.version_info >= (2,7): > >

Re: More RHEL 6 build issues

2017-07-11 Thread Dave Page
On Tue, Jul 11, 2017 at 12:07 PM, Devrim Gündüz wrote: > > Hi, > > On Tue, 2017-07-11 at 11:44 +0100, Dave Page wrote: > > Never modify config.py! You should be using config_distro.py. > > Err, this was what you asked me to do when we had similar issues before. I > apply these patches to RHEL 6:

Re: [pgAdmin4][Patch] To fix the issue in privileges control

2017-07-11 Thread Murtuza Zabuawala
Please disregard previous patch, I'll send updated patch as I found one issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 11, 2017 at 4:49 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA m

[pgAdmin4][Patch] To fix the issue in privileges control

2017-07-11 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue in privileges control, where privileges were not displaying in IE10/11 when user click on it to grant privileges for given role. RM#1166 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/

Re: More RHEL 6 build issues

2017-07-11 Thread Devrim Gündüz
Hi, Sorry, I missed this part: On Tue, 2017-07-11 at 11:44 +0100, Dave Page wrote: > It was fixed in the code: > > # HTMLMIN doesn't work with Python 2.6. >     if not config.DEBUG and sys.version_info >= (2,7): >     HTMLMIN(app) > > Though, we do have an unconditional import (both i

Re: More RHEL 6 build issues

2017-07-11 Thread Devrim Gündüz
Hi, On Tue, 2017-07-11 at 11:44 +0100, Dave Page wrote: > Never modify config.py! You should be using config_distro.py. Err, this was what you asked me to do when we had similar issues before. I apply these patches to RHEL 6: https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/m

pgAdmin 4 commit: Fix proxy support with Qt 5.9+

2017-07-11 Thread Dave Page
Fix proxy support with Qt 5.9+ Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=374bf79911c5da6cd46fbf1b959fdd7ce44bceca Modified Files -- runtime/pgAdmin4.cpp | 5 + 1 file changed, 5 insertions(+)

Re: More RHEL 6 build issues

2017-07-11 Thread Dave Page
On Tue, Jul 11, 2017 at 11:21 AM, Devrim Gündüz wrote: > > Hi, > > I thought we fixed it at some point, but I'm recently getting this again: > > in the web/config.py, I changed > MINIFY_PAGE = True > > to False. > Never modify config.py! You should be using config_distro.py. > > Still getting

More RHEL 6 build issues

2017-07-11 Thread Devrim Gündüz
Hi, I thought we fixed it at some point, but I'm recently getting this again: in the web/config.py, I changed MINIFY_PAGE = True to False. Still getting sphinx-1.0-build -b html -d _build/doctrees . _build/html Making output directory... Running Sphinx v1.0.8 Exception occurred: File

Re: pgAdmin 4 commit: Revert "Ensure dependencies are packaged in the tarba

2017-07-11 Thread Ashesh Vashi
On Tue, Jul 11, 2017 at 1:54 PM, Dave Page wrote: > Revert "Ensure dependencies are packaged in the tarball" > > This reverts commit 6ad4a623c47154a2e3938805af52776039c23601. > > ENOCOFFEE error > ;-) > > Branch > -- > master > > Details > --- > https://git.postgresql.org/gitweb?p=pgadmi

RE: Windows testing required: Updated runtime

2017-07-11 Thread McDonaldR
Hi Dave, I’m testing the latest build (10/7/2017) from your download page. I had a v1.5 build that fixed issues with the proxy server. It took ~30 secs from start to usable. Before that I could only run the v1.3 release. This new build starts in about 9 seconds showing the splash screen and th

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Neel Patel
Hi Dave, I have tested Surinder's patch in my local machine with Qt 5.9.1 Webkit on Windows and we are getting improvements with this patch. :) Below performance tested with Qt 5.9.1 with annulen webkit v 5.212.0 Alpha2. *Before Webpack patch:-* It took ~20 seconds. This 20 seconds includes whe

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-07-11 Thread Dave Page
On Mon, Jul 10, 2017 at 9:48 PM, Shirley Wang wrote: > I noticed that the default font, Menlo, was disabled in favor of > Monospace. Was there a specific reason why Monospace was used in favor of > Menlo? > > I find that Menlo is an easier font to read, especially for uppercase > letters. For web

pgAdmin 4 commit: Revert "Ensure dependencies are packaged in the tarba

2017-07-11 Thread Dave Page
Revert "Ensure dependencies are packaged in the tarball" This reverts commit 6ad4a623c47154a2e3938805af52776039c23601. ENOCOFFEE error Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dad6031bd633501069034d438cfc4157ed7c6478 Modified Files --

pgAdmin 4 commit: Fix a compiler error with older compilers.

2017-07-11 Thread Dave Page
Fix a compiler error with older compilers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c93aa3810d0f5bda61e736b900c3477f8d704782 Author: Neel Patel Modified Files -- runtime/TabWindow.cpp | 2 +- 1 file changed, 1 insertion(+),

pgAdmin 4 commit: Ensure dependencies are packaged in the tarball

2017-07-11 Thread Dave Page
Ensure dependencies are packaged in the tarball Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6ad4a623c47154a2e3938805af52776039c23601 Modified Files -- pkg/src/build.sh | 19 +-- 1 file changed, 9 insertions(+), 1

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Surinder Kumar
Hi I found this patch won't work on IE, so i have fixed it and will send updated patch. On Tue, Jul 11, 2017 at 1:25 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > > On Tue, Jul 11, 2017 at 1:22 PM, Dave Page wrote: > >> When you say "un-vendorising", do you mean removing them f

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Surinder Kumar
On Tue, Jul 11, 2017 at 1:22 PM, Dave Page wrote: > When you say "un-vendorising", do you mean removing them from the vendor > directory and adding them to packages.json so they're pulled in via > npm/yarn? (if so, good :-) ) > ​Yes.​ > > On Tue, Jul 11, 2017 at 7:34 AM, Surinder Kumar < > surin

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Dave Page
When you say "un-vendorising", do you mean removing them from the vendor directory and adding them to packages.json so they're pulled in via npm/yarn? (if so, good :-) ) On Tue, Jul 11, 2017 at 7:34 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Detailed changes:* > > ​1)