pgAdmin 4 commit: Allow queries to be cancelled from the dashboards. Fi

2017-07-24 Thread Dave Page
Allow queries to be cancelled from the dashboards. Fixes #1812 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=617e9dbb3a466507a7cfdd6ba144c0dca5955dec Author: Murtuza Zabuawala Modified Files

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Dave Page
not exclude specific column from certain rows if it >> renders in one row then it will render for every row in the grid, What we >> can do is, it will throw an error when user is not eligible to cancel the >> active running query. >> >>> - Perhaps this is a g

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Dave Page
> -- -- data text > -- --); > > --Index required on data for finding Wumpus' quickly . (not sure if there > should be spaces or not) > -- --CREATE INDEX foo_idx ON foo (data); > > Right - we lose the ability to uncomment multiple levels though, which may also be useful

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Dave Page
; elsewhere we discovered: >>>> >>>> jetbrains cmd+/ >>>> pycharmcmd+/ >>>> Sublime Ctrl+/ Toggle line comment >>>>Ctrl+Shift+/ Toggle block comment >>>> EclipseCTRL + / >&

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Dave Page
e were looking at this earlier to see what was being used >>>> elsewhere we discovered: >>>> >>>> jetbrains cmd+/ >>>> pycharmcmd+/ >>>> SublimeCtrl+/ Toggle line comment >>>>Ctrl+Shift+/ Toggle block comm

pgAdmin 4 commit: Fix test assertion.

2017-07-21 Thread Dave Page
Fix test assertion. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ebb40819534d79376a577a149a8a5db124b Author: Sarah McAlear Modified Files -- web/pgadmin/feature_tests/query_tool_journey_test.py | 2 +-

pgAdmin 4 commit: Fix typo that caused a layout issue with the Edit Gri

2017-06-30 Thread Dave Page
Fix typo that caused a layout issue with the Edit Grid. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7c09a8f8272e9d697ea9f8cfddf6f3a34a4d9fe9 Author: Khushboo Vashi Modified Files --

Re: UI issue

2017-06-30 Thread Dave Page
On Fri, Jun 30, 2017 at 12:29 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Fri, Jun 30, 2017 at 12:25 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Fri, Jun 30, 2017 at 12:23 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com&

Re: UI issue

2017-06-30 Thread Dave Page
Khushboo > > On Fri, Jun 30, 2017 at 5:06 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Fri, Jun 30, 2017 at 12:29 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> >>> >>> On Fri, Jun 30, 2017 at 12:25 PM, Dave

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-06-30 Thread Dave Page
gt;>> properly defined, the task to generate other module JS will become quite >>>> easy. >>>> >>> >>> We used imports-loader and exports-loader for tests (see >>> web/webpack.test.config.js) >>> >> ​Hmm. it is useful.​ but I am u

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-06-30 Thread Dave Page
> On 30 Jun 2017, at 18:00, Surinder Kumar > wrote: > > ​Hi, > > Review comments: > > 1) I see the font used for class .query-history .entry​ is monospace, > shouldn't it be Helvetica as per style guide ? the font for Messages > text > is also monospace.

Re: Tree view icon samples

2017-06-30 Thread Dave Page
>>>> ashesh.va...@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Jun 28, 2017 22:32, "Robert Eckhardt" <reckha...@pivotal.io> wrote: >>>>> >>>>> I like them as well. The only comme

pgAdmin 4 commit: Improve styling for alerts by highlighting the icon.

2017-07-04 Thread Dave Page
Improve styling for alerts by highlighting the icon. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b211eb199c78f480716e0c2be47a14f0f23a6f81 Author: Murtuza Zabuawala Modified Files --

Re: [RM1972][pgAdmin4] Improve query tool close workflow.

2017-07-04 Thread Dave Page
hal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-07-03 Thread Dave Page
ooks a little like the old-school "digital" font; the sort of thing they used in the movie War Games. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Patch for sqleditor js syntax issue

2017-07-03 Thread Dave Page
eer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix an issue where duplicate entry is made of success

2017-07-03 Thread Dave Page
Fix an issue where duplicate entry is made of successful executed query, one with status message and one without status message. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1e427890de93f83d2b1ffb0e25b1c6f6d8bd8389 Author: Murtuza

Re: [pgAdmin4][Patch] To fix the duplicate entry in History panel

2017-07-03 Thread Dave Page
and one without status >> message. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Tree view icon samples

2017-07-03 Thread Dave Page
old one is any better though. Chethana; do you have any alternative ideas? > > Just my two cents... > > On Fri, Jun 30, 2017 at 9:57 AM, Dave Page <dp...@pgadmin.org > <javascript:_e(%7B%7D,'cvml','dp...@pgadmin.org');>> wrote: > >> Hi >> >>

pgAdmin 4 commit: Fix a syntax error in the SQL Editor.

2017-07-03 Thread Dave Page
Fix a syntax error in the SQL Editor. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4e21cdb64bc68c20d195a63c17b2f926e75a Author: Harshal Dhumal Modified Files --

pgAdmin 4 commit: Fix clipboard handling with large datasets. Fixes #24

2017-07-03 Thread Dave Page
Fix clipboard handling with large datasets. Fixes #2489 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1977a5fcda44b78b00d6eaac2e6a99df355d5105 Author: Harshal Dhumal Modified Files --

Re: [pgAdmin4][Patch]: Fixed couple of minor issues

2017-07-03 Thread Dave Page
nd the attached patch for the same. (delete_row.patch) > > 2. The debugger can not be opened from the View trigger. > Please find the attached patch for the same. (view_debugger.patch) > > Thanks, > Khushboo > > > -- Dave Page Blog: http://pgsnake.blogs

Re: Tree view icon samples

2017-07-03 Thread Dave Page
pload.wikimedia.org/wikipedia/commons/3/33/B_tree_insertion_example.png. Leave out the numbers of course. For function, something with { } in there? And for Trigger Function, a mashup of function and trigger? > > Note: I have listed out the list of icons which will be used in pgAdmin 4 > and will be

pgAdmin 4 commit: Remove unnecessary whitespace from stored procedure S

2017-07-03 Thread Dave Page
Remove unnecessary whitespace from stored procedure SQL. Fixes #2146 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0aa763b70680707136036ed1b7d3f994e70161de Author: Murtuza Zabuawala Modified Files

pgAdmin 4 commit: Allow debugging of functions in packages. Fixes #1948

2017-07-03 Thread Dave Page
Allow debugging of functions in packages. Fixes #1948 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c7dcaba81c55846f5d9a85f1226abdee8cc1856 Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Improve the debugger's default page layout, and preve

2017-07-03 Thread Dave Page
Improve the debugger's default page layout, and prevent attempts to continue debugging after the user has stopped. Fixes #2512, Fixes #2511 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d5e55964ad811690ac1b52efdc632e8b485e943 Author:

Re: [pgAdmin4][Patch] To fix the issues in Debugger module

2017-07-03 Thread Dave Page
ws busy status > only), I think that is the reason why in pgAdmin3 we have disable all the > buttons and release the connection if user clicks on stop button, For time > being I have done the same in pgAdmin4 until we find the solution for this > issue. > OK - please log an RM for the db s

Re: [pgAdmin4][Patch]: Fixed the issue related to Domain Constraint module

2017-07-03 Thread Dave Page
backbone-min.js:1) at s [as constructor] (backbone-min.js:1) at new s (backbone-min.js:1) at s._prepareModel (backbone-min.js:1) at set (backbone-min.js:1) at s.add ( backbone-min.js:1) at s.insertRow (backgrid.min.js:8) at s.insertRow ( backgrid.min.js:8) at HTMLButtonElement. ( backfor

Re: Tree view icon samples

2017-07-03 Thread Dave Page
look clear in 16px measurement which is > happening with 'Conversions' icons'. > > We might have to rework on 'Conversions', what do you say ? > Hmm, we could use a square and triangle if it works better. > > > Regards, > Chethana kumar > > On Mon, Jul 3, 2017 at 6:35 PM, Dav

pgAdmin 4 commit: Fix deletion of table rows with the column definition

2017-07-03 Thread Dave Page
Fix deletion of table rows with the column definition having NOT NULL TRUE and HAS NO DEFAULT VALUE. Fixes #2527 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f6b879233c1c9f554a43094e1d82d3e16cff23fa Author: Khushboo Vashi

pgAdmin 4 commit: Fix alert layout when more than one are shown at once

2017-07-05 Thread Dave Page
Fix alert layout when more than one are shown at once. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2bb01e2d1a60df72d2b1569e2de87ba63c831a39 Author: Murtuza Zabuawala Modified Files --

Re: Tree view icon samples

2017-07-06 Thread Dave Page
rk on this project! > You're welcome. > > Anthony > > On July 3, 2017 at 10:40:50 AM, Dave Page (dp...@pgadmin.org) wrote: > > Hi > > On Mon, Jul 3, 2017 at 10:25 AM, Chethana Kumar < > chethana.ku...@enterprisedb.com> wrote: > >> Hi Dave, >

Re: [pgAdmin4][Patch] Fix the issue in save password checkbox in "Create - Server" dialog.

2017-07-06 Thread Dave Page
. > RM#2540 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Dave Page
ginning I think and it is inherited from pgAdmin3. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Jul 6, 2017 at 5:58 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On T

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Dave Page
. > RM#2537 > This still doesn't seem quite right - the Rows field seems to be always greyed out, so I cannot set it to test at all. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Remove unused minimisation code

2017-07-06 Thread Dave Page
Remove unused minimisation code Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1291841d988050d99804e0a0f30396bee20675cf Modified Files -- Makefile | 3 --- web/tools/minimise.py | 65

pgAdmin 4 commit: UI tweaks for the query history.

2017-07-06 Thread Dave Page
UI tweaks for the query history. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2cbaaef7124b41be91bf34d704f0d3f61cf7b0c Author: Matthew Kleiman Modified Files --

Re: make subnode rows the same height for rows without dropdowns

2017-07-06 Thread Dave Page
An > example place in the app is Create Table -> > Security tab -> add a row for each of Privileges and Security labels. > > Attached is a fix. > > Thanks, > Shirley and Shruti and George > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseD

pgAdmin 4 commit: In subnodes without dropdowns, the rows had smaller h

2017-07-06 Thread Dave Page
In subnodes without dropdowns, the rows had smaller height, making them appear unintentionally different than those with dropdowns. Make them the same. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5bedf088e880de8949d68f0b0564fff62f3d5a7

pgAdmin 4 commit: Ensure the save password option is enabled when creat

2017-07-06 Thread Dave Page
Ensure the save password option is enabled when creating a server. Fixes #2540 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca7fe9a520468b7452a1efa44e1575bb0bb8c22d Author: Murtuza Zabuawala Modified

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

2017-06-27 Thread Dave Page
) at (index):278 at Object.execCb (require.min.js:29) at Z.check (require.min.js:18) On Tue, Jun 27, 2017 at 9:21 AM, Dave Page <dp...@pgadmin.org> wrote: > Thanks, patch applied. > > On Tue, Jun 27, 2017 at 2:58 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrot

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-07-05 Thread Dave Page
yblue'; ^ File to import not found or unreadable: primaryblue. Parent style sheet: stdin in /Users/dpage/git/pgadmin4/web/pgadmin/static/scss/pgadmin.scss (line 4, column 1) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to delete Tab via Shift-Tab in query editor

2017-07-05 Thread Dave Page
; Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Update preferences docs.

2017-06-27 Thread Dave Page
Update preferences docs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0066d60066d3a2297bbec0fa1acbcd9d0d858f8 Author: Murtuza Zabuawala Modified Files --

Re: [pgAdmin4][Patch] To add preferences for brace matching and auto brace closing

2017-06-27 Thread Dave Page
PostgreSQL Company > > On Tue, Jun 27, 2017 at 7:43 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Sure Dave, I'll do the needful. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.co

Re: crypto.py bug on server add form (button save) with python 3.5 - Can't convert 'bytes' object to str implicitly

2017-06-28 Thread Dave Page
;> TypeError: Can't convert 'bytes' object to str implicitly >>>> 2017-06-27 13:21:53,031: INFO werkzeug: 127.0.0.1 - - [27/Jun/2017 >>>> 13:21:53] "POST /browser/server/obj/2/ HTTP/1.1" 410 - >>>> 2017-06-27 13:22:49,936: INFO werkzeug: * Detect

pgAdmin 4 commit: A number of minor cleanups to the recent changes to t

2017-06-28 Thread Dave Page
A number of minor cleanups to the recent changes to the query tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7389744ecff66cb070c118682992d9c5cb5b04ee Author: Harshal Dhumal Modified Files

pgAdmin 4 commit: Add stylesheet to override brace matching styles, mis

2017-06-27 Thread Dave Page
Add stylesheet to override brace matching styles, missed from the feature commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e413186d239150cc993ac100601c10ded1000400 Modified Files --

Re: Unified server/desktop config

2017-08-08 Thread Dave Page
of 1.x and 2.x), how would we resolve the Alembic issue you noted such that both versions could be run against the same DB? > Thanks, > Surinder > ​ > > On Mon, Aug 7, 2017 at 7:01 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Mon, Aug

Re: Unified server/desktop config

2017-08-08 Thread Dave Page
Please update the patch :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 9 Aug 2017, at 05:53, Surinder Kumar <surinder.ku...@enterprisedb.com> > wrote: > > Hi, >

Re: Unified server/desktop config

2017-08-08 Thread Dave Page
On Tue, Aug 8, 2017 at 11:27 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Tue, Aug 8, 2017 at 1:47 PM, Dave Page <dp...@pgadmin.org> wrote: > > >> >> On Tue, Aug 8, 2017 at 7:18 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com

Re: Unified server/desktop config

2017-08-07 Thread Dave Page
Anyone? On Thu, Jul 20, 2017 at 5:03 PM, Dave Page <dp...@pgadmin.org> wrote: > All, > > Attached is a patch that aims to allow us to have a standardised config > that will work out of the box for both web and desktop modes. It does this > by doing two things: > > 1) T

Re: Unified server/desktop config

2017-08-07 Thread Dave Page
> Thanks, > Surinder > ​ > > On Mon, Aug 7, 2017 at 4:33 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Mon, Aug 7, 2017 at 4:11 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Mon, Aug

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-07 Thread Dave Page
nd and the body background for more clarity > > Please feel free to provide your input on the same. > Much nicer in my opinion! Good work. Anyone else have any comments? > > Regards, > Chethana kumar > > > > On Fri, Jul 28, 2017 at 4:11 PM, Dave Page <

Re: Selecting tables from Browser

2017-08-23 Thread Dave Page
On Tue, Aug 22, 2017 at 5:04 PM, Shirley Wang <sw...@pivotal.io> wrote: > > > On Tue, Aug 22, 2017 at 8:27 AM Dave Page <dp...@pgadmin.org> wrote: > >> On Tue, Aug 22, 2017 at 12:17 AM, Shirley Wang <sw...@pivotal.io> wrote: >> >>> Hi Rob

Re: pgAdmin4: Random failure of FTS test cases due to improper random string creation

2017-08-18 Thread Dave Page
> Dave - thoughts? > Right - it only seems to be FTS and FDW related objects that suffer from this problem from what I can see, so I assume we're getting it right for everything else by removing objects in the tear-down. -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

2017-06-20 Thread Dave Page
created for it. This PR made SlickGrid Cell Decorator and Cell Selection > more configurable. > > With SlickGrid more configurable we can, by changing options, change the > border position when the user is drag selecting inside the query results. > > > Thanks > Joao --

pgAdmin 4 commit: Properly handle bytea[], and 'infinity'::real/real[].

2017-06-20 Thread Dave Page
Properly handle bytea[], and 'infinity'::real/real[]. Fixes #2498. Fixes #2502. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2ba57c1abfda02241d969c4caa1ce0bf24cfc09 Author: Murtuza Zabuawala Modified

Re: [pgAdmin4][PATCH] Fix handling of real type

2017-06-20 Thread Dave Page
pdated PG Data type feature test for the same. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][PATCH] Consolidating Selection Colors

2017-06-21 Thread Dave Page
ks, > Shirley and Shruti -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Consolidate selection colors in the drop down menu an

2017-06-21 Thread Dave Page
Consolidate selection colors in the drop down menu and browser tree to match the light blue agreed upon in the styleguide. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=281b67952a94bc1599536c2b6c469252f233aa69 Author: Shruti B Iyer

pgAdmin 4 commit: Vendorize React. This is required at this time becaus

2017-06-21 Thread Dave Page
Vendorize React. This is required at this time because we need to modify it to work with QtWebKit. The patch to do that has been submitted upstream; if accepted, we can un-vendorize again. Branch -- master Details ---

pgAdmin 4 commit: Fix preferences handling for utilities.

2017-06-22 Thread Dave Page
Fix preferences handling for utilities. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33e75d24f82828c6925b88fecf0eac35a8480bbd Author: Khushboo Vashi Modified Files --

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

2017-06-22 Thread Dave Page
The Enterprise PostgreSQL Company > > On Wed, Jun 21, 2017 at 9:40 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Thanks, patch applied! >> >> On Wed, Jun 21, 2017 at 12:44 PM, Khushboo Vashi >> <khushboo.va...@enterprisedb.com> wrote: >> &

pgAdmin 4 commit: Ensure default values are honoured when adding/editin

2017-06-22 Thread Dave Page
Ensure default values are honoured when adding/editing columns. Fixes #1860 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=137bae1b0494a7c763d302f5f5e652e5201abdea Author: Murtuza Zabuawala Modified Files

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

2017-06-22 Thread Dave Page
Thanks, patch applied. On Thu, Jun 22, 2017 at 11:06 AM, Khushboo Vashi <khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached fix for the same. > > Thanks, > Khushboo > > On Thu, Jun 22, 2017 at 2:18 PM, Dave Page <dp...@pgadmin.org&

Re: [pgAdmin4][PATCH] To fix the issue in column module

2017-06-22 Thread Dave Page
#1860 > > I have also fixed similar issue in foreign table module. > > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pg

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

2017-06-22 Thread Dave Page
a3d'); false Both of those are valid addresses. Note that I've only eye-balled the patch so far, as I was unable to apply it without manual work. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Handle missing/dropped synonyms gracefully. Fixes #25

2017-06-21 Thread Dave Page
Handle missing/dropped synonyms gracefully. Fixes #2503 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9736cbd74c723ce914fa3beaafe03fd284daf45 Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Update MatView and pgAgent modules to work with recen

2017-06-21 Thread Dave Page
Update MatView and pgAgent modules to work with recent integer/numeric changes. Fixes #2504 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9f6fb95456a540287ef7aca02ff885068b64cd5 Author: Murtuza Zabuawala

Re: [pgAdmin4][PATCH] To fix the issue in Materialized View

2017-06-21 Thread Dave Page
mpany >> >> On Wed, Jun 21, 2017 at 1:54 PM, Murtuza Zabuawala >> <murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>> Hi, >>> >>> PFA minor patch to fix the issue where create dialog opens blank due to >>> JS error. >>> R

pgAdmin 4 commit: Maintain a client-side cache of preference values, po

2017-06-21 Thread Dave Page
Maintain a client-side cache of preference values, populated using an async call. Fixes #2487 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=67fd119de834afd022f95c8c153a3b0c8c7b7fae Author: Khushboo Vashi

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-23 Thread Dave Page
Hi Harshal, When can we expect an updated version of this patch? I think it's important to get this into the next release. Thanks! On Fri, Jun 16, 2017 at 10:55 AM, Dave Page <dp...@pgadmin.org> wrote: > Hi, > > That's better - the failures are far less random now :-). I got the

Re: [pgAdmin4][Patch]: Fixed RM #1920 - [Web Based] Unexpected behaviour observed when connect server with save password option.

2017-06-26 Thread Dave Page
Thanks, patch applied. On Mon, Jun 26, 2017 at 5:24 AM, Khushboo Vashi <khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #1920 - [Web Based] Unexpected > behaviour observed when connect server with save password option. > > Thanks

pgAdmin 4 commit: Ensure saved passwords are effective immediately, not

2017-06-26 Thread Dave Page
Ensure saved passwords are effective immediately, not just following a restart when first saved. Fixes #1920 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=27bc5c803f1b92dd8e498e751e2e3bf17f558d62 Author: Khushboo Vashi

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-26 Thread Dave Page
; > On Fri, Jun 23, 2017 at 9:00 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi Harshal, >> >> When can we expect an updated version of this patch? I think it's >> important to get this into the next release. >> >> Thanks! >> >&g

pgAdmin 4 commit: Add support for the hostaddr connection parameter. Th

2017-06-26 Thread Dave Page
Add support for the hostaddr connection parameter. This helps us play nicely with Kerberos/SSPI and friends. Fixes #2191 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15cb9fc35b41736a331a452b9303a79e8f13ee36 Author: Atul Sharma

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

2017-06-26 Thread Dave Page
gt; Please find the attached patch for the feature #2506: Allow the dashboard > panel to be closed. > > Thanks, > Khushboo -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in Sqleditor module

2017-06-26 Thread Dave Page
ined) in browser for generated sqleditor.js, so declared those > variables before using them. > > Please find attached patch. > > Thanks, > Surinder Kumar -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module

2017-06-26 Thread Dave Page
; DatagridPanel wasn't working. This is fixed. > > Please find attached patch. > > Thanks, > Surinder Kumar -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Tidy up About box formatting, 'cos it's been annoying

2017-06-23 Thread Dave Page
Tidy up About box formatting, 'cos it's been annoying me for ages. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92b1b1365e9b82bcc7ff201f94496b94f1ae8759 Modified Files -- web/pgadmin/about/templates/about/index.html | 10

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-23 Thread Dave Page
Original patch by: Kit Yam Tse > (who reported the issue) > > I just re-based it against current code. Isn't that code required? We do need plugin_debugger to be present for global (indirect) debugging to work. I suppose it may not be required for direct debugging, but I haven't tes

pgAdmin 4 commit: Ensure the relevant Makefile targets install node mod

2017-06-23 Thread Dave Page
Ensure the relevant Makefile targets install node modules before running. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b98fcaa829aa71493af8419d6d97a5c8a3b74302 Author: Matthew Kleiman Modified Files --

pgAdmin 4 commit: Fix cell selection window alignment for the updated S

2017-06-23 Thread Dave Page
Fix cell selection window alignment for the updated SlickGrid. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9af29364c7414128d091d57b020750657946cc8c Author: Matthew Kleiman Modified Files --

Re: [pgAdmin4][Patch] To fix the issue in Column module

2017-06-23 Thread Dave Page
2155 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix removal of sizes from column definitions. Fixes #

2017-06-23 Thread Dave Page
Fix removal of sizes from column definitions. Fixes #2155 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a4945ff9e9a3cb7cf9dc0c4f042f5502d76464f Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Add access keys for top level menus.

2017-06-23 Thread Dave Page
Add access keys for top level menus. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6fabf4764b51c9978c896ce93733b474a3c3a8ff Modified Files -- web/pgadmin/browser/templates/browser/index.html | 12 ++-- 1 file changed, 6

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

2017-06-23 Thread Dave Page
are you seeing these changes? I can't spot them in the diff (though, I've only looked at changes to our code). > Thanks, > Surinder > > > On Fri, Jun 23, 2017 at 2:08 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Thanks - all applied! >> >> On Thu,

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

2017-06-23 Thread Dave Page
re, patches should be sent upstream. We don't want to modify (and thus have to vendorise) 3rd party code unless it's absolutely essential. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

2017-06-22 Thread Dave Page
Thanks, applied. On Thu, Jun 22, 2017 at 2:43 PM, Khushboo Vashi <khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > One more fix for this module. > > Thanks, > Khushboo > > On Thu, Jun 22, 2017 at 4:49 PM, Dave Page <dp...@pgadmin.org> wrote: >> >

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-21 Thread Dave Page
Gelashvili <ggelashv...@pivotal.io> wrote: > Hi > > We rebased this on top of latest master. > > Cheers, > Matt and George > > On Thu, Jun 15, 2017 at 10:43 AM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> We use Qt 5.8 at the moment, with

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-27 Thread Dave Page
>> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Mon, Jun 26, 2017 at 5:22 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> I'm sorry, it needs rebasing again. If you can do it quickly, I'll >&

Re: [pgAdmin4][Patch]: pgAdmin4 not displaying schema if it start with 'pg'

2017-09-15 Thread Dave Page
> display it under browser tree. > RM#2709 > > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > [image: https://community.postgresrocks.net/] > <https:/

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

2017-09-15 Thread Dave Page
...@enterprisedb.com> wrote: >> >>> Hi Atul, >>> >>> Please also check fonts in various the alertify dialogs. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> Th

pgAdmin 4 commit: Replace the "Roboto" font family with "Open Sans" for

2017-09-15 Thread Dave Page
Replace the "Roboto" font family with "Open Sans" for alertify dialogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3ea3b7bdfa684c84fb1a4e28fbfbb409b807470 Author: Atul Sharma Modified Files --

pgAdmin 4 commit: Fix filtering of system schemas so pg_* is hidden but

2017-09-15 Thread Dave Page
Fix filtering of system schemas so pg_* is hidden but pg* is not. Fixes #2709 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9cfb2f3cbed3e1710ad19df4ab4ab320817fc6f9 Author: Murtuza Zabuawala Modified

Re: Fonts for pgAdmin

2017-09-13 Thread Dave Page
b.com> wrote: > >> Sure. I will send a patch. >> >> On Tue, Sep 12, 2017 at 8:21 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> Thanks. Whoever picks up this task will need to include that info in the >>> libraries.txt file so we know exactly what

pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

2017-09-13 Thread Dave Page
Bundle fonts with pgAdmin so we have a standard set for all platforms. Research by Shirley at Pivotal. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=788f7f3a69500c37008dbba459d3ea00b0b1bff8 Author: Atul Sharma

Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons

2017-09-15 Thread Dave Page
On Fri, Sep 15, 2017 at 2:19 PM, Murtuza Zabuawala <murtuza.zabuawala@ enterprisedb.com> wrote: > Hi Dave, > > On Fri, Sep 15, 2017 at 6:26 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Fri, Sep 15, 2017 at 8:52 AM, Murtuza Zabuawala <

pgAdmin 4 commit: Fix menu left-hand margin.

2017-09-15 Thread Dave Page
Fix menu left-hand margin. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8150f93c06084a34dd94170a23df85ed8b82c735 Author: Murtuza Zabuawala Modified Files --

<    1   2   3   4   5   6   7   8   9   10   >