pgAdmin 4 commit: Add ALT tags to images for accessibility. Fixes #2902

Add ALT tags to images for accessibility. Fixes #2902 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aec86970f2620295a444d20958f53206fe1ec24d Author: Murtuza Zabuawala Modified Files --

Re: [pgAdmin4][Patch#2902] To add ALT tags for images in pgAdmin4

priseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 12:37 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > On Mon, Jan 8, 2018 at 5:15 PM, Dave Page <dp...@pgadmin.org> wrote: > >> HI >> >> On Mon, Jan 8, 2018 at 11:41 AM, Harshal Dhumal < >> harshal.dhu...@enterp

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

ult? > No - users probably won't find it then. I wonder if we should make the default poll interval a couple of seconds (or more) though. > > > On Mon, Jan 8, 2018 at 7:26 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Mon, Jan 8, 2018

Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

* the "close tab" and "move tabs left"/"move tabs right" buttons that may appear in tab bars * the add row button at the top of a subnode control (e.g. to add a column definition) * the delete and expand row buttons in subnode grid rows Sorry for not

pgAdmin 4 commit: Fix a minor UI issue on dashboard while displaying su

Fix a minor UI issue on dashboard while displaying subnode control in Backgrid. Fixes #3013 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ad46d61bd3a26d6d1cef3b7e764125382b186068 Author: Murtuza Zabuawala

Re: [pgAdmin4][Patch#3013] Fixed minor UI issue on Dashboard

za Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix typo in string.

Fix typo in string. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55c2ab0b241ba4b45366bc5d902c01321d974665 Modified Files -- web/pgadmin/static/js/sqleditor_utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Thanks, applied. On Mon, Jan 15, 2018 at 11:35 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Jan 15, 2018 at 2:57 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> Unfortunately there's variation in the s

pgAdmin 4 commit: Doc updates for connection status monitoring.

Doc updates for connection status monitoring. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03605bf9bed44585396541373e521619ddfb02bb Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Ensure clickable images/buttons have appropriate tool

Ensure clickable images/buttons have appropriate tooltips for screen readers. Fixes #2904 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca80cfa04a4b11718340196c381a1a1c85451b21 Author: Khushboo Vashi

Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

Thanks, patch applied. On Wed, Jan 17, 2018 at 6:55 AM, Khushboo Vashi <khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Jan 17, 2018 at 12:23 PM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: >> >> >> >> On Mon, Jan 15, 2018

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

which I always do when testing. This newer version of ESLint seems to be picking up more than the older one though. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Complain if the default web browser cannot be opened.

Complain if the default web browser cannot be opened. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9d0d1eb5fd092d501975c362947d7579daf57bd2 Modified Files -- runtime/TrayIcon.cpp | 8 +++- runtime/pgAdmin4.cpp | 8

Re: [pgadmin4] Explain plans

me. Consider that the user may have chosen to do EXPLAIN ANALYZE, which executes the actual query. I agree that 3 isn't really an option - and I also agree that factoring out functionality into smaller units is good. Option 2 doesn't preclude that though does it? It just doesn't require it. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Update ESLint requirement to support --fix-dry-run

Update ESLint requirement to support --fix-dry-run Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ee9f09bbde345160f7bb764ce3242e78b3c1293 Author: Surinder Kumar Modified Files --

Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

Tab/Shift-Tab > keys but once RM#2895 <https://redmine.postgresql.org/issues/2895> patch > gets committed it will start working automatically as it's inherited code > which will add tabindex tag automatically on each newly created wcDocker > panel. > > -- > Regard

pgAdmin 4 commit: Correctly display SQL of multiple objects on the SQL

Correctly display SQL of multiple objects on the SQL tab in GPDB. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=284adbbb901b1be30d130be0e40674cfde931e41 Author: Joao Pedro De Almeida Pereira Modified Files

pgAdmin 4 commit: Fix feature tests following button tooltip changes.

Fix feature tests following button tooltip changes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8df006343b951d92b0a8f9a0cee1d2204a9fdc1b Author: Khushboo Vashi Modified Files --

Re: [pgadmin4]{Patch] Display GreenPlum partitions and correct SQL on SQL Tab

Hi On Tue, Jan 23, 2018 at 9:14 AM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Mon, Jan 22, 2018 at 10:55 PM, Joao De Almeida Pereira > <jdealmeidapere...@pivotal.io> wrote: > > Hello Hackers, > > I merge the 2 commits into 1 and also co

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

s >>>>>> 'FunctionView' class to use it check line no. 120 >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira < >>>>>> jdealmeidapere...@pivotal.io> wrote: >>>>>> >>>>>>> Hello Hackers, >>>>>>> We had some requests from GreenPlum users to display the functions >>>>>>> node again. >>>>>>> This patch reintroduces functions as a node underneath the Schemas. >>>>>>> >>>>>>> >>>>>>> Unfortunately this patch is not final because I could not find the >>>>>>> place where the Data Type is populated from. (See next image)[image: >>>>>>> Inline image 1] >>>>>>> >>>>>>> Can anyone explain me how these types get populated? >>>>>>> >>>>>>> >>>>>>> >>>>>>> Thanks >>>>>>> Joao >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Display functions in Greenplum. Fixes #3044

Display functions in Greenplum. Fixes #3044 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=65337daeba442b635184f057c2014317cbcb9dbc Author: Joao Pedro De Almeida Pereira Modified Files --

Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

om > The Enterprise PostgreSQL Company > > > On Mon, Jan 22, 2018 at 4:02 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> This seems to be missing documentation updates. I would also expect to >> see some Jasmine unit tests for some/all of the

pgAdmin 4 commit: Support keyboard navigation in the debugger. Fixes #2

Support keyboard navigation in the debugger. Fixes #2897 In passing, fix injection of variable values. Fixes #2981 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0e41b3364b3de80381ae7c6ad052087ac0eae6a4 Author: Murtuza Zabuawala

pgAdmin 4 commit: Ignore tray icon moc file.

Ignore tray icon moc file. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a7d6d027aa43401b9285a1396546c43eebf8679 Modified Files -- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Mac build for new runtime.

Mac build for new runtime. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c194d73298819c7018fc5c9839fc89837b40b37d Modified Files -- Makefile | 3 --- pkg/mac/build.sh | 8 ++--

pgAdmin 4 commit: Make sure that the bundle cache is removed if necessa

Make sure that the bundle cache is removed if necessary Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=946b02b647505ce6a0f97125719ad11876a5a022 Modified Files -- pkg/docker/build.sh | 4 +++- 1 file changed, 3

pgAdmin 4 commit: Initial cut at Windows installer changes

Initial cut at Windows installer changes Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=23562b2f399d45f88dbffc8cdeee7431fd7fe6ea Modified Files -- Make-MinGW.bat | 20 --- Make.bat | 79

Re: [pgadmin][patch] Make Feature and Unit tests Green Again

ves all the problems above. > I notice that datatype_test.json adds a field for "datatypes_minimum_versions" (maybe should be datatype_minimum_versions?), whilst the code is checking the server version is greater than that value. Should the comparison be >=, or is the name misleading?

pgAdmin 4 commit: Include a hash of the executable path in the lock and

Include a hash of the executable path in the lock and address file names. This allows side-by-side running of different instances of the runtime. While we're at it, improve some comments and tidy up a little. Branch -- runtime-revamp Details ---

pgAdmin 4 commit: Add a log viewer. stderr is redirected to a per-insta

Add a log viewer. stderr is redirected to a per-installation logfile, and can be viewed with an internal viewer. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b41558a56682940d2a2454f9af74af96ade59b2 Modified Files --

Fwd: pgAdmin4 2.1 on apt.postgresql.org

adbach 12080, USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer pgp fingerprint: 5C48 FE61 57F4 9179 5970 87C6 4C5A 6BAB 12D2 A7AE -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake Enterpris

Re: [pgadmin][patch] Make Feature and Unit tests Green Again

n Fri, Jan 26, 2018 at 5:47 AM Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Thu, Jan 25, 2018 at 7:10 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Hackers, >>> >>> Attached you can find

Re: [pgAdmin4][RM#3062] Fix PEP-8 issues in Tools module

ole project but as of now > I have fixed only tools module, that's why I'm suggesting you to run it > against Tools module only :) > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dav

Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module

blank line at end of file 23 W503 line break before binary operator 1677 Thoughts? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Update the regression tests to fix issues with Python

Update the regression tests to fix issues with Python 3.5 and PG 9.2. Fixes #3057 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de1c767e8849bdd761c3425452babcae18402c12 Author: Joao Pedro De Almeida Pereira

pgAdmin 4 commit: Fix PEP8 issues in the Tools module. Fixes #3063

Fix PEP8 issues in the Tools module. Fixes #3063 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=393ce53d2da5c7fd686ebcc849d63d920c02fffe Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Support Properties on Greenplum databases. Fixes #301

Support Properties on Greenplum databases. Fixes #3015 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56e922f5abff35e6904d59c2173fd127ac336285 Author: Joao Pedro De Almeida Pereira Modified Files --

Re: [pgadmin4][Patch] Access Database properties

> was displayed. > > Also in the patch we made some correction to feature tests, and skipped > other test that were failing against GreenPlum > > Thanks > Joao > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

n Fri, Jan 12, 2018 at 8:08 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Sure, I'll do that. >> >> On Fri, Jan 12, 2018 at 8:05 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> Thanks - patch applied! >>> &g

pgAdmin 4 commit: Fix Python wheel dependencies. Fixes #3011

Fix Python wheel dependencies. Fixes #3011 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6f8066d2610c682594fa5233418f841acc210606 Modified Files -- pkg/pip/setup_pip.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

>> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Mon, Jan 8, 2018 at 7:39 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>

Re: [pgAdmin4][Patch] Statistics button not working for GreenPlum

Thanks, patch applied. On Thu, Jan 11, 2018 at 9:58 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > Find attached a patch that enables the retrieval of statistics for > databases and servers on GreenPlum databases. > > > Thanks > J

pgAdmin 4 commit: Support server and database statistics on Greenplum.

Support server and database statistics on Greenplum. Fixes #3004 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed3e374df6a2927cadba20cc3cebe7cee8c33c51 Author: Joao Pedro De Almeida Pereira Modified Files

pgAdmin 4 commit: Fix typo

Fix typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=601a7b1a5c417d37a167d77e0b32487c942394dc Author: Magnus Hagander Modified Files -- pkg/docker/README | 2 +- 1 file changed, 1 insertion(+), 1

Re: pgadmin4 container docs bug

Thanks, patch applied. On Fri, Jan 12, 2018 at 11:45 AM, Magnus Hagander <mag...@hagander.net> wrote: > Looks like a simple copy/paste bug. > > //Magnus > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The

pgAdmin 4 commit: Add keyboard navigation in Query tool module via Tab/

Add keyboard navigation in Query tool module via Tab/Shift-Tab key. Fixes #2896 Note: 1) Once the keyboard shortcut infrastructure is ready we will add generic shortcut to focus out from CodeMirror editor and set foucs to next element, Right now there is no way of doing this, For testing

Re: [pgAdmin4][Patch#2896] Add support for Tab/Shift Tab navigation in Query tool

dd tabindex tag automatically on each newly created wcDocker panel. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin4][patch] Correct Bug #3050

ue in Redmine and assign it to me, but I > cannot change the status of it. Do I need to have any special permission? > No, you shouldn't do. I can't see anything in the config that would prevent you changing the status. Is it just greyed out, or...? What about other tickets? -- Dave Page Blo

pgAdmin 4 commit: Add infrastructure for managing configurable keyboard

Add infrastructure for managing configurable keyboard shortcuts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=66341e6947b0999b66c46078bf31f89851597fd6 Author: Harshal Dhumal Modified Files --

Re: [pgAdmin4][Patch#3046] To display connection status in IE11 & Firefox properly

ww.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix connection status indicator on IE/FF. Fixes #3046

Fix connection status indicator on IE/FF. Fixes #3046 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=abcb8c36a3be2c2cd8d2854a2f22453888b59542 Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Support arbitrary browser commands.

Support arbitrary browser commands. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4015d74e6c61fc6b60eec48e8e9e5e645e1922ed Modified Files -- runtime/ConfigWindow.cpp | 10 +++ runtime/ConfigWindow.h | 3 +-

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

ecks to prevent unnecessary ​polling > added as suggested. > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Jan 11, 2018 at 2:33 PM, Dave Page <dp...@pgadmin.org

pgAdmin 4 commit: Monitor connection and transaction status in the quer

Monitor connection and transaction status in the query tool. Fixes #2475 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8520871bc612b25c8d8b193846c3cb34e5f2c6da Author: Murtuza Zabuawala Modified Files

pgAdmin 4 commit: Mask email addresses

Mask email addresses Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d8bd6ea885c365b7b1eed79e7cb002eb5acefa49 Modified Files -- docs/en_US/images/pgadmin_user.png | Bin 49561 -> 51359 bytes 1 file changed, 0 insertions(+), 0

pgAdmin 4 commit: Ensure we capture notices raised by queries. Fixes #3

Ensure we capture notices raised by queries. Fixes #3027 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=25647c16ba4170715243f70f194027460e1c3151 Author: Murtuza Zabuawala Modified Files --

Re: [pgAdmin4][Patch]: RM # 2895 - All the controls and display elements in the main window to be accessible using the tab key in an appropriate order

Thanks, patch applied. On Fri, Feb 2, 2018 at 8:23 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached updated patch. > > On Mon, Jan 29, 2018 at 3:52 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> &g

pgAdmin 4 commit: Add keyboard navigation options for the main browser

Add keyboard navigation options for the main browser windows. Fixes #2895 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=262d01bf01e3a38a01bc1b368ca601d3cc6a7960 Author: Khushboo Vashi Modified Files

Re: [pgAdmin4][RM#3016] Properly display notices in case of error

; reproduce the issue. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Don't quote variable values used by SET. It's usually

Don't quote variable values used by SET. It's usually going to be wrong. Fixes #3027 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d69764869bf9d1731d61d15a290388d5bd0f789 Modified Files --

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

Sorry - I think we broke it again. It looks simple to fix, but I'm about to board a flight so can you update again please? Thanks. On Wed, Jan 31, 2018 at 11:17 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Wed, Jan 31, 2018 at 3:47 PM, Dave Page <

pgAdmin 4 commit: PEP8 fixes for the utils module. Fixes #3076

PEP8 fixes for the utils module. Fixes #3076 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3ddb7df38eb6592372d82483ed3c0d4ec961061 Author: Murtuza Zabuawala Modified Files --

Re: [pgAdmin4][RM#3076] Fix PEP-8 issues in Utility module

to ../web directory and run following > pycodestyle --config=.pycodestyle ./pgadmin/utils/ > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitte

Revamped runtime vs. Version number

more quickly. - Cleaned up a bunch of redundant code. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix on-click handling of treeview nodes that wasn't r

Fix on-click handling of treeview nodes that wasn't refreshing SQL/Dependencies/Dependents in some circumstances. Fixes #3058 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6ad44cb51e33349aad46714e7cc12aff5e29ce94 Author: Murtuza Zabuawala

pgAdmin 4 commit: Don't include sizes on primitive datatypes that shoul

Don't include sizes on primitive datatypes that shouldn't have them when modifying columns. Fixes #3052 Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3424f420e738f7c2060d7b3ba79c6bbf80e570de Author: Harshal Dhumal

pgAdmin 4 commit: Significantly improve connection loss detection and h

Significantly improve connection loss detection and handling in the query tool. Fixes #2815 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e0da9c5a0cf75a3a6a2f04601caaf61d3343bfd9 Author: Harshal Dhumal

Re: Fix for RM3052: Alter column error

. > However we cannot change internal datatype lengths of some primitive > datatypes. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.bl

Re: [pgAdmin4][Patch]: RM # 2895 - All the controls and display elements in the main window to be accessible using the tab key in an appropriate order

t+Shift+B isn't configurable? - I think the description for Alt+Shift+B should be "Focus the browser tree". - I don't see any Jasmine tests for the new JS, or any feature tests. Whilst we needn't test every single option, I think we should at least test that changing a shortcut work

Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module

Hi On Sun, Jan 28, 2018 at 4:42 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Jan 26, 2018 at 10:33 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Fri, Jan 26, 2018 at 1:26 PM, Murtuza Zabuawala <

Re: Request for feedback: Alternate desktop runtime architecture

What browser are you using? > > Aside from that, I'm not seeing anything here of concern. Nice job. > > Anthony > > > On January 23, 2018 at 9:48:43 AM, Dave Page (dp...@pgadmin.org) wrote: > > All, > > As you may know, the most troublesome part of pgAdmin 4

Re: [pgAdmin4][RM#3054] F5 Keyboard shortcut doesn't work after cancelling query

ixed the similar issue when user press open/save dialog & clear > editor window options. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitt

pgAdmin 4 commit: Ensure the user can use keyboard shortcuts after usin

Ensure the user can use keyboard shortcuts after using button controls such as Cancel, Open and Save. Fixes #3054 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc836aa37421a13ecb00fda907f34f4356c23803 Author: Murtuza Zabuawala

Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module

updated patch. > > On Mon, Jan 29, 2018 at 3:23 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Sun, Jan 28, 2018 at 4:42 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>&

pgAdmin 4 commit: Add tools for checking PEP8 compliance. Fixes #3063

Add tools for checking PEP8 compliance. Fixes #3063 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=489349b4e9aacc59132cc32ed6f39530b1f1ef28 Author: Murtuza Zabuawala Modified Files -- Makefile

Re: Revamped runtime vs. Version number

On Thu, Feb 1, 2018 at 3:17 PM, Robert Eckhardt <reckha...@pivotal.io> wrote: > > > On Thu, Feb 1, 2018 at 9:45 AM, Dave Page <dp...@pgadmin.org> wrote: > >> So there's been nothing but positive feedback about the PoC revamped >> runtime I asked folks on the

pgAdmin 4 commit: Revert "Don't include sizes on primitive datatypes th

Revert "Don't include sizes on primitive datatypes that shouldn't have them when modifying columns. Fixes #3052" This reverts commit 3424f420e738f7c2060d7b3ba79c6bbf80e570de. Committed on the wrong branch :-( Branch -- runtime-revamp Details ---

Re: Revamped runtime vs. Version number

n (paolosau...@gmail.com) > wrote: > > As Melvin, I am too in favor of "version number to 3.0 for the next > release". > > Paolo > > 2018-02-01 16:00 GMT+01:00 Ashesh Vashi <ashesh.va...@enterprisedb.com>: > >> >> >> On Feb 1, 2018 8:15 PM, "Dave

Re: pgAdmin 4 commit: Don't quote variable values used by SET. It's usually

SQL Company > > http://www.linkedin.com/in/asheshvashi > >> On Fri, Feb 2, 2018 at 7:28 PM, Dave Page <dp...@pgadmin.org> wrote: >> Don't quote variable values used by SET. It's usually going to be wrong. >> Fixes #3027 >> >> Branch >> ---

Re: [pgAdmin4][RM#3082] Fix PEP-8 issues

in/feature_tests/keyboard_shortcut_test.py:90: [E501] line too long (86 > 79 characters) ./pgadmin/feature_tests/keyboard_shortcut_test.py:95: [W391] blank line at end of file 9 E501 line too long (95 > 79 characters) 1 W391 blank line at end of file 10 -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Rewrite the runtime as a tray-based server which can

Rewrite the runtime as a tray-based server which can launch a web browser. Fixes #3086 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7192a2b67502b2afbad9e88cd3fc4618e7e64da1 Modified Files -- .gitignore|

pgAdmin 4 commit: Bump the version to 3.0, per discussion on the mailin

Bump the version to 3.0, per discussion on the mailing lists Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2706d9cd8e6f98cf543e4e86afe881b8f4b571d3 Modified Files -- runtime/Info.plist | 4 ++-- web/config.py | 8 2

pgAdmin 4 commit: Prevent the filter dialog CodeMirror from overflowing

Prevent the filter dialog CodeMirror from overflowing onto the button bar of the dialog. Fixes #3067 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6e405ce72a1bc1d203c238b7fb2a09e4d7e4faf Author: Murtuza Zabuawala

Re: [pgAdmin4][RM#3067] To fix codemirror scroll alignment

seDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

ion was expired. > > > [image: Inline image 1] > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Jan 15, 2018 at 11:09 PM, Dave Page <dp...@pgadmin.org> wrote: > >

pgAdmin 4 commit: Quiet a warning in GCC

Quiet a warning in GCC Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c54a90f0874fee21bd311448f5c21f242245bf41 Modified Files -- runtime/LogWindow.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

pgAdmin 4 commit: Use shared memory for process locking instead of QLoc

Use shared memory for process locking instead of QLockFile which isn't available in QT4. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c8d88974894c09f0efda46a7ce17cee962a5f1aa Modified Files -- runtime/pgAdmin4.cpp | 49

pgAdmin 4 commit: Redirect stderr within the Python interpreter, which

Redirect stderr within the Python interpreter, which should work in win32. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46ab0f82b057ddb04a089d2edc10f1c73baf4361 Modified Files -- runtime/Server.cpp | 8 +++-

Re: pgAdmin 4 commit: Don't quote variable values used by SET. It's usually

On Mon, Feb 5, 2018 at 2:26 AM, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote: > On Mon, Feb 5, 2018 at 1:35 AM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On 4 Feb 2018, at 18:07, Ashesh Vashi <ashesh.va...@enterprisedb.com> >> wr

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

It’s in my queue, but I’ve been traveling. I hope to get to it later today or tomorrow. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 7 Feb 2018, at 22:32, Joao De Almeida Pere

Re: pgAdmin4: Patch for RM#3060

Thanks Harshal for help! > Unfortunately this doesn't apply. Can you rebase it please? Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: pgAdmin4: Patch for RM#3060

ing wherever needed. > > Thanks Harshal for help! > > -- > Regards, > navnath > > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix quoting of function names in RE-SQL. Fixes #3060

Fix quoting of function names in RE-SQL. Fixes #3060 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db92907fe9b98e1bcc5ec993a2c16ca0438ac283 Author: Navnath Gadakh Modified Files --

Re: Build failed in Jenkins: pgadmin4-master-python26 #602

gt; Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Fri, Feb 9, 2018 at 3:47 PM, pgAdmin 4 Jenkins <jenk...@pgadmin.org> > wrote: > >> See <https://jenkins.pgadmin.org/job/pgadmin4-master-python26/60

pgAdmin 4 commit: Fix tests for Python 3.x

Fix tests for Python 3.x Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c382e4d23aa66cf4ff18e25835c14a1c5fe3a9c Author: Joao Pedro De Almeida Pereira Modified Files --

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

Thanks, applied. On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > Attached you can find the fix for the current pronlem > > > On Fri, Feb 9, 2018 at 7:29 AM Dave Page <dp...@pgadmin.org> wrote: > >> Hi J

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

e Explain SQL from the front-end and now pass the Explain plan > parameters as a JSON object in the start query call. > Extract the compile_template_name into a function that can be used by > the different places that try to select the version of the template and the > server type >

pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

Support EXPLAIN on Greenplum. Fixes #3097 - Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them - Extract SQLEditor backend functions that start executing query to their own files and add tests around it - Move the Explain SQL from the front-end and

Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

s provided in this patch: > > Alt+Shift+Q Open the query tool > Alt+Shift+V View data > Alt+Shift+C Open the context menu > Alt+Shift+N Create an object > Alt+Shift+E Edit the object properties > Alt+Shift+D Delete the object > Alt+Shift+G Direct debugging > &

<    4   5   6   7   8   9   10   11   12   13   >