Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-12 Thread Dave Page
Hi On Wed, Apr 12, 2017 at 4:20 PM, Shirley Wang wrote: > Hello! > > Our team is starting to work on changes to the results table, including: > > 1. changing unselected columns and row colors to grey > I'd like to see the entire window to see if that seems to make things too flat, but no object

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-12 Thread Shirley Wang
Hello! Our team is starting to work on changes to the results table, including: 1. changing unselected columns and row colors to grey 2. changing selected columns and rows to blue 3. differentiating header text so that field name is bold and datatype is in brackets 4. text is white when columns a

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

2017-04-12 Thread Dave Page
Thanks, applied. On Wed, Apr 12, 2017 at 1:52 PM, Surinder Kumar wrote: > Hi Dave, > > Please find rebased patch. > > On Wed, Apr 12, 2017 at 5:44 PM, Dave Page wrote: >> >> Can you rebase this please? >> >> On Tue, Apr 11, 2017 at 1:23 PM, Surinder Kumar >> wrote: >> > Hi Dave, >> > >> > On Tu

[pgadmin-hackers] pgAdmin 4 commit: Remove some unused events.

2017-04-12 Thread Dave Page
Remove some unused events. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9bbc05051cc852e558ebcdf5a83644b97f09a82a Author: Surinder Kumar Modified Files -- .../server_groups/servers/templates/servers/servers.js | 13 +

Re: [pgadmin-hackers] [question]

2017-04-12 Thread Murtuza Zabuawala
is just to manage servers in groups in browser tree that the main purpose, is unique regardless of server-group id that's why you are getting proper response. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 12, 2017 at 7:21 P

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-12 Thread Sarah McAlear
Great, thank you so much! On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi wrote: > > On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear > wrote: > >> Hi Hackers! >> > Hi Sarah, > >> >> Is there an update on this? >> > We will look in to it end of this week. > I was not rushing to it, because - Dave w

Re: [pgadmin-hackers] [question]

2017-04-12 Thread Sarah McAlear
Hi Murtuza, Thanks for your response! There is just one little piece of this URL that we can't seem to figure out what it does. The doesn't seem to change the result of the request. Meaning that if we were to input browser/server/children/1/3 browser/server/children/684635135/3 browser/server/ch

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-12 Thread Ashesh Vashi
On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear wrote: > Hi Hackers! > Hi Sarah, > > Is there an update on this? > We will look in to it end of this week. I was not rushing to it, because - Dave was preparing for the 1.4 release. -- Thanks, Ashesh > > Thanks, > Sarah & Joao > > On Fri, Apr 7, 2

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-12 Thread Sarah McAlear
Hi Hackers! Is there an update on this? Thanks, Sarah & Joao On Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear wrote: > Hi Ashesh! > > Good catch. Looks like there was an override of the input function that > didn't get moved to the new file, causing the input with the @ to fail. We > also added

Re: [pgadmin-hackers] [question]

2017-04-12 Thread Murtuza Zabuawala
Hi Sarah, Each number represent mapping of id for the node. For example in your case, /browser//children// /browser/server/children/1/3 Here is the type of object (eg: server-group, server, database, table etc) and will be the column 'id' of server table(pgadmin4.db), I guess you have multipl

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

2017-04-12 Thread Surinder Kumar
Hi Dave, Please find rebased patch. On Wed, Apr 12, 2017 at 5:44 PM, Dave Page wrote: > Can you rebase this please? > > On Tue, Apr 11, 2017 at 1:23 PM, Surinder Kumar > wrote: > > Hi Dave, > > > > On Tue, Apr 11, 2017 at 4:28 PM, Dave Page wrote: > >> > >> On Tue, Apr 11, 2017 at 10:51 AM, S

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Dave Page
Thanks, committed. On Wed, Apr 12, 2017 at 1:26 PM, Murtuza Zabuawala wrote: > Hi Dave, > > Apologies for previous patch, please find updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Apr 12, 2017 at 5:

[pgadmin-hackers] pgAdmin 4 commit: Update inode info when refreshing treeview nodes. Fix

2017-04-12 Thread Dave Page
Update inode info when refreshing treeview nodes. Fixes #2336 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=019c1302cb863094eb3494391580a77dd02ad4dd Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/templates/browse

[pgadmin-hackers] pgAdmin 4 commit: Align labels with switches properly.

2017-04-12 Thread Dave Page
Align labels with switches properly. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbee76eac88cbeab47d245087be2abdb38ffcd08 Author: Akshay Joshi Modified Files -- web/pgadmin/static/css/pgadmin.css | 1 + 1 file changed, 1 inserti

Re: [pgadmin-hackers] [pgAdmin4][Patch] Align Switch control with the text

2017-04-12 Thread Dave Page
Thanks, applied. On Wed, Apr 12, 2017 at 7:30 AM, Akshay Joshi wrote: > Hi All > > Attached is the patch to fix the alignment of switch control with the > text. Currently it is not aligned properly. Please refer > 'Without-Alignment' and 'With-Alignment' screenshots for the difference. > > Pleas

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Murtuza Zabuawala
Hi Dave, Apologies for previous patch, please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 12, 2017 at 5:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Please disregard previous

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Murtuza Zabuawala
Please disregard previous patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 12, 2017 at 5:50 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA rebased patch. > > Thanks, > Murtuza > > O

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Murtuza Zabuawala
Hi Dave, PFA rebased patch. Thanks, Murtuza On Wed, Apr 12, 2017 at 5:45 PM, Dave Page wrote: > Can you rebase this please? > > On Tue, Apr 11, 2017 at 2:04 PM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA minor patch to fix the issue where we were not updating inode > > information on refr

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Dave Page
Can you rebase this please? On Tue, Apr 11, 2017 at 2:04 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue where we were not updating inode > information on refresh. > RM#2336 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

2017-04-12 Thread Dave Page
Can you rebase this please? On Tue, Apr 11, 2017 at 1:23 PM, Surinder Kumar wrote: > Hi Dave, > > On Tue, Apr 11, 2017 at 4:28 PM, Dave Page wrote: >> >> On Tue, Apr 11, 2017 at 10:51 AM, Surinder Kumar >> wrote: >> > Hi >> > >> > When a server is disconnected, listen to >> > 'pgadmin:server:di

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-12 Thread Dave Page
Thanks, patch applied. On Mon, Apr 10, 2017 at 2:22 PM, Navnath Gadakh wrote: > Hi Dave, > > Please find the revised patch. > > On Mon, Apr 10, 2017 at 1:43 PM, Dave Page > wrote: >> >> Hi >> >> On Fri, Apr 7, 2017 at 8:01 PM, Navnath Gadakh >> wrote: >>> >>> Hello Joao, >>> >>>

[pgadmin-hackers] pgAdmin 4 commit: Include passed test results in the JSON output from t

2017-04-12 Thread Dave Page
Include passed test results in the JSON output from the regression tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62716c4193c4434b002682126b634b29d70d1870 Author: Navnath Gadakh Modified Files -- .../sql/tests/test_foreign_

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Dave Page
Thanks, patch applied. On Mon, Apr 10, 2017 at 2:16 PM, Murtuza Zabuawala wrote: > Sure, https://redmine.postgresql.org/issues/2331 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Apr 10, 2017 at 6:43 PM, Dave Page

[pgadmin-hackers] pgAdmin 4 commit: Fix binary search algorithm so new treeview nodes are

2017-04-12 Thread Dave Page
Fix binary search algorithm so new treeview nodes are added in the correct position. Fixes #2331 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7dd9efd811c7845d9dc985b66f8d33497f2f4bfa Author: Murtuza Zabuawala Modified Files --