Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-14 Thread Surinder Kumar
Hi PFA patch which fixes the issue Harshal reported. Thanks, Surinder On Thu, Jun 15, 2017 at 3:52 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Surinder, > > I guess this broke the script options (Create, Delete, Select, Insert, > Update) > > > VM4124 datagrid.js:440 Uncaught

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-14 Thread Harshal Dhumal
Surinder, I guess this broke the script options (Create, Delete, Select, Insert, Update) VM4124 datagrid.js:440 Uncaught TypeError: self.get_panel_title is not a function at Object.success (VM4124 datagrid.js:440) at fire ( jquery-1.11.2.js:3143) at Object.fireWith [as resolveWith] ( jquery-1.11

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-14 Thread Sarah McAlear
Sounds good! We're looking into it. On Wed, Jun 14, 2017 at 12:15 PM, Robert Eckhardt wrote: > Absolutely makes sense. > > Matt, Sarah, > > Do we understand the issues Dave is mentioning well enough to look into it > and tackle it? > > -- Rob > > On Wed, Jun 14, 2017 at 8:12 AM, Dave Page wrote

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-14 Thread Robert Eckhardt
Absolutely makes sense. Matt, Sarah, Do we understand the issues Dave is mentioning well enough to look into it and tackle it? -- Rob On Wed, Jun 14, 2017 at 8:12 AM, Dave Page wrote: > Hi, > > Before I commit anything else for this patch, we need to fix the > existing changes so they work in

[pgadmin-hackers] Migrating this list to PGLister on Friday, June 16th, 1300 UTC

2017-06-14 Thread Stephen Frost
Greetings! The PostgreSQL Infrastructure team will be migrating the project's mailing lists from the existing system (an ancient and unmaintained piece of software called "majordomo2") to a newly developed mailing list system (known as "PGLister"), which better addresses the needs of the PostgreSQ

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-14 Thread Dave Page
Hi, Before I commit anything else for this patch, we need to fix the existing changes so they work in the desktop runtime (see the previous thread with the patches for the history pane changes). Have any of your team been able to look at that yet? On Wed, Jun 14, 2017 at 4:07 PM, Sarah McAlear w

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-14 Thread Harshal Dhumal
On Wed, Jun 14, 2017 at 6:21 PM, Ashesh Vashi wrote: > On Wed, Jun 14, 2017 at 6:19 PM, Dave Page wrote: > >> Hi, >> >> Sorry - it's drifted out again, I suspect because of the work Ashesh >> has been doing. Can you rebase please? Check with Ashesh first though, >> in case he's about ready to co

[pgadmin-hackers] Invitation to a Community Developer Forum

2017-06-14 Thread Matthew Kleiman
Hi Hackers! As a community of open-source developers, it is valuable to have a space to come together and discuss technical topics about the project. We would like to invite everyone in the community to a public developer forum on Thursday, June 29 from 8-9am EDT (Meeting time in different timezon

[pgadmin-hackers] pgAdmin 4 commit: Add some more Makefile targets for running different

2017-06-14 Thread Dave Page
Add some more Makefile targets for running different test suites. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6938fbafb538997e8a37a19827b03ad402572829 Modified Files -- Makefile | 11 ++- 1 file changed, 10 insertions(+)

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-14 Thread Ashesh Vashi
On Wed, Jun 14, 2017 at 6:19 PM, Dave Page wrote: > Hi, > > Sorry - it's drifted out again, I suspect because of the work Ashesh > has been doing. Can you rebase please? Check with Ashesh first though, > in case he's about ready to commit another big change. > I am not. :-) -- Thanks & Regards,

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-14 Thread Dave Page
Hi, Sorry - it's drifted out again, I suspect because of the work Ashesh has been doing. Can you rebase please? Check with Ashesh first though, in case he's about ready to commit another big change. Thanks. On Fri, Jun 9, 2017 at 10:08 AM, Harshal Dhumal wrote: > Hi, > > > Please find rebased p

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-14 Thread Dave Page
On Wed, Jun 14, 2017 at 1:06 PM, Ashesh Vashi wrote: > On Wed, Jun 14, 2017 at 1:59 PM, Dave Page wrote: > >> >> >> On Tue, Jun 13, 2017 at 2:59 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>> For further implementation following task needs to be work upon: >>>

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-14 Thread Ashesh Vashi
On Wed, Jun 14, 2017 at 1:59 PM, Dave Page wrote: > > > On Tue, Jun 13, 2017 at 2:59 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> For further implementation following task needs to be work upon: >> >>- How to parse and show partitions keys. For example user has

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-14 Thread Dave Page
Thanks, patch applied. On Tue, Jun 13, 2017 at 12:30 PM, Surinder Kumar wrote: > Hi > > On Tue, Jun 13, 2017 at 2:54 PM, Dave Page wrote: >> >> On Mon, Jun 12, 2017 at 5:55 PM, Shirley Wang wrote: >> >>> >> >>> >> >>> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar >> >>> wrote: >> >>> > Hi >>

[pgadmin-hackers] pgAdmin 4 commit: Ensure text editors render in an appropriate place on

2017-06-14 Thread Dave Page
Ensure text editors render in an appropriate place on the results grid. Fixes #2477 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fdc9eed51479e0057420f116f4b3b7425a12f377 Author: Surinder Kumar Modified Files -- web/pgadmin/fea

[pgadmin-hackers] pgAdmin 4 commit: Un-break the feature tests. Fixes from Surinder and m

2017-06-14 Thread Dave Page
Un-break the feature tests. Fixes from Surinder and myself. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b4a8ed89c9374fa9e0f9c0eb190662979d0bb6b Author: Surinder Kumar Modified Files -- web/pgadmin/feature_tests/copy_selected_

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-14 Thread Dave Page
Thanks Surinder. That, along with another fix seems to have got the tests working fully again. On Tue, Jun 13, 2017 at 6:37 PM, Surinder Kumar wrote: > Hi > > PFA patch. > > On Tue, Jun 13, 2017 at 9:54 PM, Dave Page wrote: >> >> Hmm, this seems to have broken the feature tests. Can you look at

[pgadmin-hackers] pgAdmin 4 commit: Fix the JS Bundler test to work when there are multip

2017-06-14 Thread Dave Page
Fix the JS Bundler test to work when there are multiple servers defined in a test run. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4b846ae4e04efee32156c4def44346a6878de6b0 Author: Joao Pedro De Almeida Pereira Modified Files

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

2017-06-14 Thread Dave Page
Thanks, that got it. Applied! On Tue, Jun 13, 2017 at 4:51 PM, Joao Pedro De Almeida Pereira wrote: > Hi Hackers, > > Good catch Dave. > > You can find attached the new diff with the correction of the problem above. > > Thanks > Shruti & Joao > > On Tue, Jun 13, 2017 at 10:35 AM, Dave Page wrote

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-14 Thread Dave Page
On Tue, Jun 13, 2017 at 2:59 PM, Akshay Joshi wrote: > Hi All > > For further implementation following task needs to be work upon: > >- How to parse and show partitions keys. For example user has created >below partitioned table > > CREATE TABLE public.sales > ( > country character va