[pgadmin-hackers] pgAdmin 4 commit: Using client-side implementation of 'url_for' in the

Using client-side implementation of 'url_for' in the settings module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=900ccebb50bdc448da5adad55fb513815b0a7b82 Modified Files -- web/pgadmin/settings/__init__.py | 3

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the use

Using client-side 'url_for' implementation in the user management module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c140b3f58980b6f1bba01e4ed8b7006fbd74af4 Modified Files -- web/pgadmin/tools/user_management/__init__.py

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the imp

Using client-side 'url_for' implementation in the import/export module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e65b605912194808a2530cc644367137240d1003 Modified Files -- web/pgadmin/tools/import_export/__init__.py

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the mai

Using client-side 'url_for' implementation in the maintenance module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07580b844466e55c825178ce0385c82c57dff149 Modified Files -- web/pgadmin/tools/maintenance/__init__.py | 1

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

t. :-) -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> > > Thanks. > > On Fri, Jun 9, 2017 at 10:08 AM, Harshal

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

On Wed, Jun 14, 2017 at 1:59 PM, Dave Page wrote: > > > On Tue, Jun 13, 2017 at 2:59 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> For further implementation following task needs to be work upon: >> >>- How to parse and show partitions keys. For example user has

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

-- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > On Tue, Jun 13, 2017

[pgadmin-hackers] pgAdmin 4 commit: Package 'mock' is required for testing, and for Pytho

Package 'mock' is required for testing, and for Python < 3.3 only. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=467825c2d19c1ce43e81ea34fa063ef04938c31a Modified Files -- requirements.txt| 1 - web/regression/requ

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

On Tue, Jun 13, 2017 at 3:57 PM, Dave Page wrote: > > > On Tue, Jun 13, 2017 at 11:25 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, Jun 13, 2017 at 3:52 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

On Tue, Jun 13, 2017 at 3:52 PM, Ashesh Vashi wrote: > Oops. > let me revert it back. > 'web/regressions/requirements.txt' needs to change as it is not require for Python >= 3.3. Will do the change. > > -- > > Thanks & Regards, > > Ashesh Vashi

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

Oops. let me revert it back. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Tue, Jun 13, 2017 at 3:50 PM, Dave Page w

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: > And then I find a problem. Sigh. > > When running in the desktop runtime, under QtWekKit (the forked, > updated version that is by far the best of the browser engines we've > used), we get the attached error at startup. I don't see this under >

[pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

Required mock package for python < 3.3. It was required for the commit: 1208206bc0eca2d135469258e8a209b983e668be Also, do not fetch the scenario-name, when it is not avaiable (but - use default vaule as the stringified test-case itself). Branch -- master Details --- https://git.postgresq

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the Gra

Using client-side 'url_for' implementation in the Grant-Wizard module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0243d886c3cd01d8ca4d2941edf063c39affd1e6 Modified Files -- web/pgadmin/tools/grant_wizard/__init__.py |

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the bac

Using client-side 'url_for' implementation in the backup module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a46f7b1eb7246f34f05b1bf2a2429c2cff7ea9e Modified Files -- web/pgadmin/tools/backup/__init__.py| 15 ++

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the res

Using client-side 'url_for' implementation in the restore module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f9a387822047f862b01fb62e879b071b1e3c3c00 Modified Files -- web/pgadmin/tools/restore/__init__.py |

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the mod

Using client-side 'url_for' implementation in the module - bgprocess (background-processes). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a7c9d5ca1e0d92c113b093aa5cf2c2a34092b59 Modified Files -- web/pgadmin/misc/bgprocess/__in

[pgadmin-hackers] pgAdmin 4 commit: Implementation of the client side 'url_for(...)' func

Implementation of the client side 'url_for(...)' function. Created a url_for function module to be used by different javascript modules to use the same functionality of flask at client side. A python module can expose the list of endpoints, used by its javascripts, by overriding the 'get_exposed_

[pgadmin-hackers] pgAdmin 4 commit: Using the client-side translation using the client-si

Using the client-side translation using the client-side 'gettext' implementation. This is the first step towards 'Avoid creating the javascript modules using Jinja templates'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae809766892e3cbca31

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

On Wed, May 17, 2017 at 8:35 PM, Dave Page wrote: > > > On Wed, May 17, 2017 at 11:41 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Joao, >> >> Yes, this patch is related to browser tree issue, In this patch we have >> fixed some issues with 'onUpdateTreeNode' function to handle some co

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Sure. I am reviewing it. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Fri, May 12, 2017 at 3:09 PM, Dave Page wrote: &

Re: [pgadmin-hackers] security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes

; >> >> On Wed, May 10, 2017 at 9:00 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Wed, May 10, 2017 at 1:29 PM, Dave Page wrote: >>> >>>> >>>> >>>> On Wed, May 10, 2017 at 8:56 AM, Ashesh Va

Re: [pgadmin-hackers] security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes

On Wed, May 10, 2017 at 1:29 PM, Dave Page wrote: > > > On Wed, May 10, 2017 at 8:56 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Thanks. >> Committed! >> > > I agree with the change from a preventative/safety perspective, though

Re: [pgadmin-hackers] security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes

Thanks. Committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> 2017-05-10 1:06 GMT+05:30 Andrei Antonov : > good da

[pgadmin-hackers] pgAdmin 4 commit: HTML escape the label, when setting the collection no

HTML escape the label, when setting the collection node count along with the label of the tree-nodes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbf2de6c27760669a7c7e48f6bfc47c6053309f8 Author: Andrei Antonov Modified Files -

Re: [pgadmin-hackers] Pains and thoughts about refactoring the Tree Menu using React

On Sat, Apr 22, 2017 at 12:17 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > After a conversation with Dave we believe that we need to provide more > context on our pains and what we propose as a first step for implementing > the Tree Menu using React. >

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

On Wed, Apr 26, 2017 at 9:56 PM, Dave Page wrote: > > > On Wed, Apr 26, 2017 at 4:45 PM, Shirley Wang wrote: > >> >> >> I think the addition of icons and some copy would help: >> [image: Screen Shot 2017-04-26 at 11.28.41 AM.png] >> > > A

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

nit__.py files in the template directories. NOTE: The headers in those files are not consistent with the other project files. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi*

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: > Ashesh, can you review/commit this please? Thanks. > > On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to fix the issue where node rename is not working >> properly after 7dd9efd8 >>

[pgadmin-hackers] pgAdmin 4 commit: Added dependency on Flask-Migrate added by previous c

Added dependency on Flask-Migrate added by previous commit: 6283ef7f5e4379d5e2202ca2919b9ea76caf57c7 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=139a10e8f9b483ede6e6578f451119bd698e1bca Modified Files -- requirements.txt | 1 +

Re: [pgadmin-hackers][patch] Move to Alembic migration system

adding the necessary changes. -- Thanks, Ashesh Vashi > > Thanks > Joao & Oliver > > On Fri, Apr 21, 2017 at 1:21 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Joao & Oliver, >> >> On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro

[pgadmin-hackers] pgAdmin 4 commit: [Configuration][Migration] Use 'alembic' for migratio

irectly in the code, and it will avoid the error prone version numbering. Patched by: Sarah McAlear Revisions: Joao Pedro De Almeida Pereira, George Gelashvili. Reviewed by: Ashesh Vashi, Murtuza Zabuawala Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=co

Re: [pgadmin-hackers] file permission on ssl key

Hi Jeroen, This is pgAdmin hackers list. Please send mail to pgsql-gene...@postgresql.org mailing list for your postgresql related queries. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linke

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Joao & Oliver, On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > @Ashesh thanks for the feedback > > Here is the reviewed patch with the suggestions of Ashesh. > > Disclaimer: We added a new patch file with the changes >

Re: [pgadmin-hackers][patch] Move to Alembic migration system

s, Ashesh > > Thanks > Joao & Oliver > > On Wed, Apr 12, 2017 at 9:52 AM, Sarah McAlear > wrote: > >> Great, thank you so much! >> >> On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> >

Re: [pgadmin-hackers][patch] Move to Alembic migration system

added headers to the files that were missing them. This new patch >> should work. >> >> Thanks! >> Joao & Sarah >> >> >> >> On Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>>

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

Murtuza - please fix it asap. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Fri, Apr 7, 2017 at 1:59 PM, Dave Page wrote:

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Thu, Apr 6, 2017 at 11:21 AM, Murtuza Zabuawala

[pgadmin-hackers] pgAdmin 4 commit: Fixes #2321 - [Browser Tree] Shows only the newly cre

Fixes #2321 - [Browser Tree] Shows only the newly created node (not, all other child node) of a parent node, when it has not been already loaded. In order to resolve the issue - we will open the parent, and select the created node, instead of adding it to parent node. Branch -- master Detail

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Error running restore/backup etc utilities in WSGI mode

On Mon, Apr 3, 2017 at 6:57 PM, Ashesh Vashi wrote: > On Mon, Apr 3, 2017 at 6:33 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Thanks - committed! >> > Committed a lot better solution. > User can set '$DIR' in the bin_path. > &

[pgadmin-hackers] pgAdmin 4 commit: Resolved a typo in the previous commit.

Resolved a typo in the previous commit. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d55e8abe8fbb90f69e4984f71150fbd04a60695 Modified Files -- web/pgadmin/browser/server_groups/servers/types.py | 2 +- 1 file changed, 1 insertion

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Error running restore/backup etc utilities in WSGI mode

On Mon, Apr 3, 2017 at 6:33 PM, Ashesh Vashi wrote: > Thanks - committed! > Committed a lot better solution. User can set '$DIR' in the bin_path. We needed to check existence of the '__file__' attribute in the '__main__' module, when running as a WSGI applica

[pgadmin-hackers] pgAdmin 4 commit: As per Murtuza, we will have the '__module__', when r

As per Murtuza, we will have the '__module__', when running as a WSGI application, but - it will not have the '__file__' attribute. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=02a3919b0627dc27c4deecc38b17f6e75acb0051 Modified Files

[pgadmin-hackers] pgAdmin 4 commit: When running pgAdmin as a WSGI application, we will n

When running pgAdmin as a WSGI application, we will not be able to find the '__main__' module under 'sys.modules'. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b756407c3cb3e4afd40591b65902c390eb2b723f Modified Files -- web/pgadmi

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Error running restore/backup etc utilities in WSGI mode

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Mon, Apr 3, 2017 at 6:23 PM, Murtuza Zabuawala

[pgadmin-hackers] pgAdmin 4 commit: Replace the '$DIR' only when found in the binary dire

Replace the '$DIR' only when found in the binary directory string. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=74655e60a04d1fcccfda1be03ab4e602428748b2 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/server_grou

Re: [pgadmin-hackers][patch] Move to Alembic migration system

On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi wrote: > Hi Jaoao, Sarah, > > I've tried to run on fresh machine, it failed with the below error: > And - I have noticed - the headers are missing in new files. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterpri

Re: [pgadmin-hackers][patch] Move to Alembic migration system

web/migrations/versions/fdc58d9bd449_.py", line 84, in upgrade* *email, password = user_info()* * File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/user_info.py", line 50, in user_info* *email = input("Email address: ")* * File "",

[pgadmin-hackers] pgAdmin 4 commit: Fixes #2304, #2145 - Resolve the issue for restoring

Fixes #2304, #2145 - Resolve the issue for restoring the table from the backup. Earlier - implementation was generating the backup code like as below: XXX/pg_restore.exe --host "x.x.x.x" --port "" --username "osboxes" --no-password --dbname "test" --data-only --verbose --table "tt.test2" "XX

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Joao & Sarah, I have asked Murtuza to review the patch today. He will update me by EOD. If all goes well, I will commit the patch. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/

Re: [pgadmin-hackers][patch] Raise InternalServerError while retrieving table DDL

if not status:* * 28 -return internal_server_error(errormsg=result)* * 29 +raise InternalServerError(result)* * 30 •* * 31 for fk in result['rows']:* * 32 •* In above code (and, similar), why do we need that change at all? -- Thanks, Ashesh > > Tir

Re: [pgadmin-hackers][patch] Raise InternalServerError while retrieving table DDL

On Fri, Mar 24, 2017 at 5:07 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > > On Thu, Mar 23, 2017 at 3:49 PM, Joao Pedro De Almeida Pereira > wrote: > > Hi Hackers, > > > > While doing the DDL patch we found out that the code was not working > > properly when errors happene

Re: [pgadmin-hackers] Re-vamping the history tab

On Thu, Mar 23, 2017 at 8:23 PM, Dave Page wrote: > On Thu, Mar 23, 2017 at 1:51 PM, Atira Odhner wrote: > > > > We will use jquery to make ajax calls that fetch the history data, but > > actually rendering that data and managing the data once it has been > fetched > > will be handled with React

Re: [pgadmin-hackers] Feature test regression failures

change all the 'i' to 'item', 'd' to > data', etc. Until then, I think it is worthwhile to sacrifice consistency > in exchange for adding meaning and clarity to the code that is being > updated. > To be honest, not in that case. As the current ch

Re: [pgadmin-hackers] Feature test regression failures

-- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Tue, Mar 21, 2017 at 9:20 PM, Atira Odhner wrote: > Here is a new pa

[pgadmin-hackers] pgAdmin 4 commit: [Extendible][Dashboard] Allow to create a server clic

[Extendible][Dashboard] Allow to create a server clicking the 'Add New Server' button on the dashboard, even when the first node is of not type of 'server-group' in the browser tree. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=90a369b7deb96a

[pgadmin-hackers] pgAdmin 4 commit: Resolved a typo - show a '?' after the 'Show timing'

Resolved a typo - show a '?' after the 'Show timing' preference. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4eafdbeff6b6c2c05c6934108b8880567798a001 Modified Files -- web/pgadmin/tools/sqleditor/__init__.py | 2 +- 1 file change

[pgadmin-hackers] pgAdmin 4 commit: [Extendible][Dashboard] Allow to show the dashboard o

[Extendible][Dashboard] Allow to show the dashboard of their choice for the selected node in the browser tree. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=72128df75c9d1f298f7a22738f8f81f11b1ed410 Modified Files -- .../dashboard/

Re: [pgadmin-hackers] Feature test regression failures

lots of alternatives. >> >> That said, I took a peek at the code and noticed that it was using a >> global variable ('d') inside the loop where it calculated the tree >> hierarchy. I suspect that is not the only issue, but here is a patch for it. >> >&g

Re: [pgadmin-hackers] Feature test regression failures

hu, Mar 16, 2017, 6:49 AM Dave Page wrote: > On Thu, Mar 16, 2017 at 10:39 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > > On Thu, Mar 16, 2017 at 3:55 PM, Dave Page wrote: > > Hi Ashesh, > > A common theme is emerging from some of the feature test r

Re: [pgadmin-hackers] Feature test regression failures

hat might be causing it? > This can happen, when the module is not yet loaded for the respective node, and it is being expanded. Just thinking - shall we load all the javascript in the beginning? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://w

[pgadmin-hackers] pgAdmin 4 commit: Resolved an issue finding the python interpreter on *

Resolved an issue finding the python interpreter on *nix systems, and Windows 2008 R2 (32 bit), while running the pgAdmin 4 as runtime for the PostgreSQL one click installers. - Found a typo in runtime code, we were appending the path using ';' on *nix systems too. We should have used ':', and t

Re: [pgadmin-hackers] [PATCH] Allow to skip the feature tests

Thanks. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Wed, Mar 8, 2017 at 2:54 PM, Dave Page wrote: > Thanks, applied

[pgadmin-hackers] [PATCH] Allow to skip the feature tests

chine. i.e. *python runtests.py --exclude feature_tests* -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> skip_feature_test.patc

[pgadmin-hackers] pgAdmin 4 commit: Adding the directory containing 'config.py' in to the

Adding the directory containing 'config.py' in to the sys.path variable, so that - when config.py refered from outside the pgAdmin itself (i.e. during building the pip). Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=41e0a73ea6e361e772323a5d913

[pgadmin-hackers] pgAdmin 4 commit: Import config only when needed, it was causing cyclic

Import config only when needed, it was causing cyclic dependency when running the regression suite. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6cc1fbe73976fd5b3dcb2c4597f3699f8e1c56aa Modified Files -- web/pgadmin/utils/paths.p

[pgadmin-hackers] pgAdmin 4 commit: Resolved quite a few file-system encoding/decoding re

Resolved quite a few file-system encoding/decoding related cases. In order to resolve the non-ascii characters in path (in user directory, storage path, etc) on windows, we have converted the path into the short-path, so that - we don't need to deal with the encoding issues (specially with Python

[pgadmin-hackers] pgAdmin 4 commit: Better handling the non-ascii characters for differen

Better handling the non-ascii characters for different database objects. Using 'psycopg2.extensions.UNICODE' (for Python < 3) in the psycopg2 driver for proper conversation of unicode characters. Also - adjusted the string typecaster to take care of different character types (char, character, text

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

On Wed, Mar 1, 2017 at 10:27 PM, Dave Page wrote: > You're going to deal with the final review/commit right Ashesh? > Yes - I am planning to. > > On Wed, Mar 1, 2017 at 11:41 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > Patch looks good to me, Tested with Python3.5(manually) attached > screen

[pgadmin-hackers] PATCH: Javascript addons/modules specific to pgAdmin 4

Hi Dave, We've added few add-ons for CodeMirror, and slickgrid to be used by pgAdmin 4. Moved them back to 'static/js' directory from 'vendor' directory. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb

Re: [pgadmin-hackers] Feature test issues

gt; Are we working on moving to 3.x and just haven't gotten fully there yet? > There is no plan to move to Python 3 only. We do support Python 2.6 too, so that - it works on system like Cento OS 6+ out of box. We (at EnterpriseDB) test pgAdmin 4 with Python 2.6, 2.7, 3.3, 3.4, 3.5 & 3

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

Hi Dave, Please find the patch with fix for the 2144. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Fri, Feb 3, 2017 at

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

Can you please create a separate RM for the same, and assign it to me? And, please attach the pgadmin logs (only the relevant logs). -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshva

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

x27;ve added logging functionality in the process executor permanently. Working as expected with the latest patch on my systems (OSX, and Window 10). -- Thanks & Regards, Ashesh Vashi > > Kind Regards, > > On Thu, Feb 2, 2017 at 11:22 AM, Fahar Abbas > wrote: > >> Sure

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

Hi Fahar, Can you please test the updated patch? I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterpris

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

Murtuza, FYI - http://www.diveintopython3.net/porting-code-to-python-3-with-2to3.html#itertools -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/i

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

e "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/processes.py", > line 390, in update_process_info > if data['end_time']: > KeyError: u'end_time' > > The status file contains: > > {"start_time": "2017-01-11 06:27:20.939703

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

e, and point out the correct reference point. Please find the updated patch with the latest changes. I have also attached a patch to make the restore, and backup routes more REST API compatible. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://ww

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

Hi Dave, On Mon, Dec 12, 2016 at 4:01 PM, Dave Page wrote: > Hi, > > On Fri, Dec 9, 2016 at 9:16 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the patch to resolve the issue reported in RM #1679 >>

[pgadmin-hackers] PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

listen the signal like SIGINT, SIGTERM, so that - the child does not kill, or hangup (It used to happen. NOTE: This patch does not take care of the unicode errors in the path. I will send a separate patch for the same. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreS

Re: [pgadmin-hackers] pgadmin4. utf8 bug report

Hi, What is the operating system user name? On Dec 3, 2016 06:40, "Андрей Брюхов" wrote: > I'm using binary: > >- pgAdmin4: 1.1 >- python: 2.7.12 (v2.7.12:d33e0cf91556, Jun 27 2016, 15:19:22) [MSC >v.1500 32 bit (Intel)] >- Flask Version: 0.11. > > > I have a table: > > CREATE D

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

On Thu, Oct 20, 2016 at 4:26 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Sat, Oct 15, 2016 at 11:52 AM, Dave Page wrote: > >> >> >> On Friday, October 14, 2016, Ashesh Vashi >> wrote: >> >>> On Sat, Oct 15, 20

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

th old schema. - 'git checkout master' to go to the latest code. - Make sure - you've latest code. 'git pull'. - Now - rerun 'python setup.py/pgAdmin4.py'. It should work. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company &l

[pgadmin-hackers] pgAdmin 4 commit: Ensure the auto-generated CSRF_SESSION_KEY, SECRET_KE

Ensure the auto-generated CSRF_SESSION_KEY, SECRET_KEY, SECURITY_PASSWORD_SALT keys are decoded as string for python 3 compatibility. Fixes #1871 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4c439d64ae9ba638cb7698a7dd8340b9a0a5857 Modified

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

he sqlite configuration table. And, the next exception, you're describing, is result of that. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

Hi Fahar, Please log the case on redmine. Please find the attached patch, please apply it locally, and test it. And, please update the case, and this mail chain accordingly. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterpris

[pgadmin-hackers] pgAdmin 4 commit: Resolved - Integer type of preferences are not update

Resolved - Integer type of preferences are not updated Reason: IntegerControl assumes the model, passed to it, would always has errorModel variable set properly. In order to resolve it, now using pgBrowser.DataModel instead of Backbone.Model, which initialize the errorModel by default. Fixes #

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

Hi Dave, On Sat, Oct 15, 2016 at 8:02 AM, Dave Page wrote: > Hi > > > On Friday, October 14, 2016, Dave Page wrote: > >> Hi >> >> On Thursday, October 13, 2016, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Dav

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

This doesn't seem right, because we might want to use the RESTful APIs for > another purpose in the future, which would mean needing to re-implement > quoting if something else uses an affected API. > As I explained above, it wont affect the RESTful API. -- Thanks & Regards, Ashesh Vashi > > Thanks. > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > >

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

7; mode. I was thinking - we can store the existing security configurations in the database during upgrade process in 'web' mode. I was not able to spend much time on it due to some other priorities. -- Thanks & Regards, Ashesh Vashi > The purpose is to auto-generate the various securi

Re: [pgadmin-hackers] Connection to the server has been lost

d show an message like "Connection to the server has >> been lost." >> > Hi Ralph, Looks like - pgAdmin 4 (indirectly the psycopg2 driver) is using very old version of libpq. Can you please upgrade the libpq on the system? I will be able to suggest "how to

[pgadmin-hackers] pgAdmin 4 commit: Fixes# 1808 - Invalid date-time format was used in th

Fixes# 1808 - Invalid date-time format was used in the Start/End time for Job Schedule. Thanks Susan for the report. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e52aeecd20324135fd4ace15187cb3250359e995 Modified Files -- .../sch

Re: [pgadmin-hackers] Fwd: Bug Report, pgAdmin 4 RC1, Windows 10.1607

Hi Erez, Please avoid sending personal mail, and keep the pgadmin-hackers list in CC (preferably - 'Reply All'). This would also solve the user's having same issue in future. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Error while expanding server group node.

ers/__init__.py", line 86, in get_nodes > in_recovery = result['rows'][0]['inrecovery']; > TypeError: string indices must be integers > > Not a proper scenario to reproduce it. > > *Solution:* > Add proper check to fix it. > Thanks - committed!

[pgadmin-hackers] pgAdmin 4 commit: Do not try to set in_recovery, is_replay_paused prope

Do not try to set in_recovery, is_replay_paused properties in the server object, when data is not available. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ae719dae00324c49ea777d8194ca2860f4af471 Author: Surinder Kumar Modified Files ---

[pgadmin-hackers] pgAdmin 4 commit: Fixes#1737 - Setting the schedma-id as the pid (paren

Fixes#1737 - Setting the schedma-id as the pid (parent-id) for the sequences node instead of the server-id. Due to this - during updating the sequence node, it was not able to find out the correct parent node, and it was updating the existing node, but - later it (considering the old node) was rem

Re: [pgadmin-hackers] PATCH: RM#1735

Hi Team, On Sat, Sep 24, 2016 at 3:23 AM, Ashesh Vashi wrote: > Hi Dave/Team, > > I've fixed the issue "No default schema when creating some schema objects". > > For package, allowing to change the schema at the create time only, as the > logic required to cha

[pgadmin-hackers] PATCH: RM#1733

the above issue. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> RM1733.patch Description: Binary data -- Sent via pgadmin-hacker

[pgadmin-hackers] PATCH: RM#1736

Hi Dave/Team, Please find the patch for the "Cannot create a view". When we do not select the schema name, this error comes at backend-side. The client-side issue has been taken care by the patch for RM#1735. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise Post

[pgadmin-hackers] PATCH: RM#1735

is phase of the project. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> RM1735.patch Description: Binary data -- Sent v

  1   2   3   4   5   6   7   8   9   10   >